agentic-loop 1.0.0

package/ralph/verify/review.sh

@@ -0,0 +1,152 @@
+#!/usr/bin/env bash
+# shellcheck shell=bash
+# review.sh - Code review verification module for ralph
+
+# Run code review on changes
+run_code_review() {
+  local story="$1"
+
+  # Check if code review is enabled in config
+  local review_enabled
+  review_enabled=$(get_config '.verification.codeReviewEnabled' "true")
+  if [[ "$review_enabled" == "false" ]]; then
+    echo "    (code review disabled in config, skipping)"
+    return 0
+  fi
+
+  # Check if git is available
+  if ! command -v git &>/dev/null || [[ ! -d ".git" ]]; then
+    echo "    (no git repository, skipping)"
+    return 0
+  fi
+
+  # Get the diff of uncommitted changes (limit size to prevent memory issues)
+  local diff
+  local max_diff_lines=2000
+  diff=$(git diff HEAD 2>/dev/null | head -n "$max_diff_lines")
+
+  if [[ -z "$diff" ]]; then
+    # No uncommitted changes, check staged
+    diff=$(git diff --cached 2>/dev/null | head -n "$max_diff_lines")
+  fi
+
+  if [[ -z "$diff" ]]; then
+    echo "    (no changes to review)"
+    return 0
+  fi
+
+  # Check if diff was truncated
+  local full_diff_lines
+  full_diff_lines=$(git diff HEAD 2>/dev/null | wc -l)
+  if [[ "$full_diff_lines" -gt "$max_diff_lines" ]]; then
+    echo "    (diff truncated from $full_diff_lines to $max_diff_lines lines)"
+  fi
+
+  # Get story context for the review
+  local story_json
+  story_json=$(jq --arg id "$story" '.stories[] | select(.id==$id)' "$RALPH_DIR/prd.json" 2>/dev/null)
+
+  # Build the code review prompt
+  local prompt
+  prompt=$(cat <<EOF
+You are a senior code reviewer. Review this diff for a story implementation.
+
+## Story Context
+\`\`\`json
+$story_json
+\`\`\`
+
+## Code Diff
+\`\`\`diff
+$diff
+\`\`\`
+
+## Review Checklist
+
+Check for these issues:
+
+1. **Security** - SQL injection, XSS, command injection, hardcoded secrets, OWASP top 10
+2. **Error handling** - Missing try/catch, unhandled promise rejections, silent failures
+3. **Edge cases** - Null/undefined checks, empty arrays, boundary conditions
+4. **Code quality** - Unused variables, dead code, overly complex logic
+5. **Performance** - N+1 queries, unnecessary re-renders, memory leaks
+6. **Scalability** - Unbounded queries? Missing pagination? Missing indexes? No caching strategy?
+7. **Accessibility** - Missing ARIA labels, keyboard navigation, color contrast (if frontend)
+8. **Story compliance** - Does the code actually implement what the story requires?
+9. **Architecture** - Files in correct directories? Reusing existing components? File size < 300 lines?
+10. **No duplication** - Creating something that already exists? Reinventing utilities?
+
+## Response Format
+
+IMPORTANT: Output ONLY raw JSON, no markdown formatting, no code blocks, no explanation.
+
+{"pass": true/false, "issues": [{"severity": "critical|warning|info", "category": "security|error-handling|edge-case|quality|performance|scalability|a11y|architecture|compliance", "file": "path/to/file", "line": 123, "message": "Description", "suggestion": "Fix"}], "summary": "Brief assessment"}
+
+Only fail (pass: false) for critical or multiple warning-level issues.
+EOF
+)
+
+  echo "    Reviewing changes..."
+
+  local result
+  # Timeout for code review (defined in utils.sh)
+  result=$(echo "$prompt" | run_with_timeout "$CODE_REVIEW_TIMEOUT_SECONDS" claude -p --dangerously-skip-permissions 2>/dev/null) || {
+    print_warning "    Code review skipped (Claude unavailable or timed out)"
+    return 0
+  }
+
+  # Save review result
+  mkdir -p "$RALPH_DIR/reviews"
+  echo "$result" > "$RALPH_DIR/reviews/${story}-review.json"
+
+  # Extract JSON from markdown code blocks if present
+  local json_result
+  if echo "$result" | grep -q '```json'; then
+    json_result=$(echo "$result" | sed -n '/```json/,/```/p' | sed '1d;$d')
+  elif echo "$result" | grep -q '```'; then
+    json_result=$(echo "$result" | sed -n '/```/,/```/p' | sed '1d;$d')
+  else
+    json_result="$result"
+  fi
+
+  # Check if result is valid JSON
+  if ! echo "$json_result" | jq -e . >/dev/null 2>&1; then
+    print_warning "    Code review returned invalid response, skipping"
+    return 0
+  fi
+
+  local passed
+  passed=$(echo "$json_result" | jq -r '.pass // true' 2>/dev/null)
+
+  # Handle empty/null result
+  if [[ -z "$passed" || "$passed" == "null" ]]; then
+    print_warning "    Code review inconclusive, continuing"
+    return 0
+  fi
+
+  if [[ "$passed" == "true" ]]; then
+    print_success "passed"
+
+    # Show any warnings/info even on pass
+    local warnings
+    warnings=$(echo "$json_result" | jq -r '.issues[] | select(.severity != "critical") | "      [\(.severity)] \(.message)"' 2>/dev/null)
+    if [[ -n "$warnings" ]]; then
+      echo "    Notes:"
+      echo "$warnings"
+    fi
+    return 0
+  else
+    print_error "failed"
+    echo ""
+
+    # Show all issues
+    echo "    Issues found:"
+    echo "$json_result" | jq -r '.issues[] | "      [\(.severity)] \(.category): \(.message)"' 2>/dev/null
+    echo ""
+    echo "    Summary: $(echo "$json_result" | jq -r '.summary // "Review failed"' 2>/dev/null)"
+
+    # Save for failure context
+    echo "$json_result" > "$RALPH_DIR/last_review_failure.json"
+    return 1
+  fi
+}

package/ralph/verify/tests.sh

@@ -0,0 +1,81 @@
+#!/usr/bin/env bash
+# shellcheck shell=bash
+# tests.sh - Test verification module for ralph
+
+# Run unit tests
+run_unit_tests() {
+  local log_file
+  log_file=$(create_temp_file ".log") || return 1
+
+  # Try common test commands
+  local test_cmd
+  test_cmd=$(get_config '.checks.test' "")
+
+  if [[ -z "$test_cmd" ]]; then
+    # Auto-detect test command
+    if [[ -f "package.json" ]] && grep -q '"test"' package.json; then
+      test_cmd="npm test"
+    elif [[ -f "pytest.ini" ]] || [[ -f "pyproject.toml" ]]; then
+      test_cmd="pytest"
+    elif [[ -f "Cargo.toml" ]]; then
+      test_cmd="cargo test"
+    elif [[ -f "go.mod" ]]; then
+      test_cmd="go test ./..."
+    else
+      echo "    (no test command found, skipping)"
+      return 0
+    fi
+  fi
+
+  echo -n "    Running: $test_cmd... "
+
+  if safe_exec "$test_cmd" "$log_file"; then
+    print_success "passed"
+    rm -f "$log_file"
+    return 0
+  else
+    print_error "failed"
+    echo ""
+    echo "    Output (last $MAX_LOG_LINES lines):"
+    tail -"$MAX_LOG_LINES" "$log_file" | sed 's/^/      /'
+    cp "$log_file" "$RALPH_DIR/last_test_failure.log"
+    rm -f "$log_file"
+    return 1
+  fi
+}
+
+# Verify PRD acceptance criteria / test steps
+verify_prd_criteria() {
+  local story="$1"
+
+  local test_steps
+  test_steps=$(jq -r --arg id "$story" '.stories[] | select(.id==$id) | .testSteps[]?' "$RALPH_DIR/prd.json" 2>/dev/null)
+
+  if [[ -z "$test_steps" ]]; then
+    echo "    (no testSteps defined)"
+    return 0
+  fi
+
+  local failed=0
+  local log_file
+  log_file=$(create_temp_file ".log") || return 1
+
+  while IFS= read -r step; do
+    [[ -z "$step" ]] && continue
+
+    echo -n "    $step... "
+
+    if safe_exec "$step" "$log_file"; then
+      print_success "passed"
+    else
+      print_error "failed"
+      echo ""
+      echo "    Output:"
+      tail -"$MAX_OUTPUT_PREVIEW_LINES" "$log_file" | sed 's/^/      /'
+      failed=1
+    fi
+  done <<< "$test_steps"
+
+  rm -f "$log_file"
+  return $failed
+}

package/ralph/verify.sh

@@ -0,0 +1,268 @@
+#!/usr/bin/env bash
+# shellcheck shell=bash
+# verify.sh - Full UAT verification pipeline for ralph
+#
+# This file orchestrates the verification pipeline by sourcing modular components:
+#   - verify/review.sh  - Code review logic
+#   - verify/lint.sh    - Auto-fix + lint checks
+#   - verify/tests.sh   - Unit tests + PRD criteria
+#   - verify/browser.sh - Browser validation
+
+# Validate required source files exist before sourcing
+if [[ ! -f "$RALPH_LIB/playwright.sh" ]]; then
+  echo "Error: Missing $RALPH_LIB/playwright.sh" >&2
+  exit 1
+fi
+if [[ ! -f "$RALPH_LIB/api.sh" ]]; then
+  echo "Error: Missing $RALPH_LIB/api.sh" >&2
+  exit 1
+fi
+
+# Source verification modules
+source "$RALPH_LIB/playwright.sh"
+source "$RALPH_LIB/api.sh"
+
+# Determine the directory where this script lives
+VERIFY_DIR="${RALPH_LIB:-$(dirname "${BASH_SOURCE[0]}")}"
+
+# Source modular verification components
+source "$VERIFY_DIR/verify/review.sh"
+source "$VERIFY_DIR/verify/lint.sh"
+source "$VERIFY_DIR/verify/tests.sh"
+source "$VERIFY_DIR/verify/browser.sh"
+
+run_verification() {
+  local story="$1"
+
+  echo ""
+  print_info "=== Verification: $story ==="
+  echo ""
+
+  # Clear old failure logs (so smart-skip logic uses fresh state)
+  rm -f "$RALPH_DIR/last_precommit_failure.log" \
+        "$RALPH_DIR/last_test_failure.log" \
+        "$RALPH_DIR/last_review_failure.json" 2>/dev/null
+
+  # Check for fast mode
+  local fast_mode="${RALPH_FAST_MODE:-false}"
+  if [[ "$fast_mode" == "true" ]]; then
+    echo "  (fast mode - skipping code review)"
+  fi
+
+  # Determine story type (single jq call for all story info)
+  local story_json
+  story_json=$(jq --arg id "$story" '.stories[] | select(.id==$id)' "$RALPH_DIR/prd.json" 2>/dev/null)
+
+  local story_type has_test_url has_api_endpoints
+  story_type=$(echo "$story_json" | jq -r '.type // "frontend"')
+  has_test_url=$(echo "$story_json" | jq -r '.testUrl // empty')
+  has_api_endpoints=$(echo "$story_json" | jq -r '.apiEndpoints[0] // empty')
+
+  # Auto-detect type if not specified
+  if [[ -n "$has_api_endpoints" && -z "$has_test_url" ]]; then
+    story_type="backend"
+  fi
+
+  local failed=0
+  local lint_failed=0
+  local test_failed=0
+
+  # ========================================
+  # STEP 1: Code review (skip in fast mode or if last failure was lint/test)
+  # ========================================
+  local skip_review=false
+  if [[ "$fast_mode" == "true" ]]; then
+    skip_review=true
+  elif [[ -f "$RALPH_DIR/last_precommit_failure.log" ]] || [[ -f "$RALPH_DIR/last_test_failure.log" ]]; then
+    # Skip review if last failure was lint/test - review won't help
+    skip_review=true
+    echo "  [1/5] Skipping code review (last failure was lint/test)"
+  fi
+
+  if [[ "$skip_review" == "false" ]]; then
+    echo "  [1/5] Running code review..."
+    if ! run_code_review "$story"; then
+      failed=1
+    fi
+  fi
+
+  # ========================================
+  # STEP 2+3: Run lint and tests IN PARALLEL
+  # ========================================
+  if [[ $failed -eq 0 ]]; then
+    echo ""
+    echo "  [2/5] Running lint + tests (parallel)..."
+
+    # Create temp files for results
+    local lint_log test_log
+    lint_log=$(mktemp)
+    test_log=$(mktemp)
+
+    # Run lint in background
+    (run_configured_checks > "$lint_log" 2>&1; echo $? > "${lint_log}.exit") &
+    local lint_pid=$!
+
+    # Run tests in background
+    (run_unit_tests > "$test_log" 2>&1; echo $? > "${test_log}.exit") &
+    local test_pid=$!
+
+    # Wait for both
+    wait $lint_pid 2>/dev/null
+    wait $test_pid 2>/dev/null
+
+    # Check results
+    lint_failed=$(cat "${lint_log}.exit" 2>/dev/null || echo "1")
+    test_failed=$(cat "${test_log}.exit" 2>/dev/null || echo "1")
+
+    # Show lint output
+    echo "    Lint:"
+    cat "$lint_log" | sed 's/^/      /'
+
+    # Show test output
+    echo "    Tests:"
+    cat "$test_log" | sed 's/^/      /'
+
+    # Cleanup
+    rm -f "$lint_log" "${lint_log}.exit" "$test_log" "${test_log}.exit"
+
+    if [[ "$lint_failed" != "0" ]] || [[ "$test_failed" != "0" ]]; then
+      failed=1
+    fi
+  fi
+
+  # ========================================
+  # STEP 3: Run Playwright tests (frontend) or API tests (backend)
+  # ========================================
+  if [[ $failed -eq 0 ]]; then
+    echo ""
+    if [[ "$story_type" == "backend" ]]; then
+      echo "  [3/5] Running API tests..."
+      if ! run_api_validation "$story"; then
+        failed=1
+      elif ! run_api_error_tests "$story"; then
+        failed=1
+      fi
+    else
+      echo "  [3/5] Running Playwright tests..."
+      if ! run_playwright_tests "$story"; then
+        failed=1
+      fi
+    fi
+  fi
+
+  # ========================================
+  # STEP 4: Run browser validation (frontend) or API validation (backend)
+  # ========================================
+  if [[ $failed -eq 0 ]]; then
+    echo ""
+    if [[ "$story_type" == "backend" ]]; then
+      echo "  [4/5] Running API validation..."
+      if ! run_api_tests "$story"; then
+        failed=1
+      fi
+    else
+      echo "  [4/5] Running browser validation..."
+      if ! run_browser_validation "$story"; then
+        failed=1
+      fi
+    fi
+  fi
+
+  # ========================================
+  # STEP 5: Run PRD test steps
+  # ========================================
+  if [[ $failed -eq 0 ]]; then
+    echo ""
+    echo "  [5/5] Running PRD test steps..."
+    if ! verify_prd_criteria "$story"; then
+      failed=1
+    fi
+  fi
+
+  # ========================================
+  # Final result
+  # ========================================
+  echo ""
+  if [[ $failed -eq 0 ]]; then
+    print_success "=== All verification passed ==="
+    return 0
+  else
+    print_error "=== Verification failed ==="
+    # Save failure context for next iteration
+    save_failure_context "$story"
+    return 1
+  fi
+}
+
+# Save failure context for next iteration
+save_failure_context() {
+  local story="$1"
+
+  local context_file="$RALPH_DIR/last_failure.txt"
+
+  {
+    echo "=== Failure Context for $story ==="
+    echo "Timestamp: $(date -Iseconds 2>/dev/null || date)"
+    echo ""
+
+    if [[ -f "$RALPH_DIR/last_migration_failure.log" ]]; then
+      echo "--- Migration Failure ---"
+      echo "Database migrations failed. Fix the migration or the code causing it:"
+      tail -50 "$RALPH_DIR/last_migration_failure.log"
+      echo ""
+    fi
+
+    if [[ -f "$RALPH_DIR/last_review_failure.json" ]]; then
+      echo "--- Code Review Failure ---"
+      echo "Issues found by code review:"
+      jq -r '.issues[] | "- [\(.severity)] \(.category): \(.message)\n  File: \(.file // "unknown"):\(.line // "?")\n  Fix: \(.suggestion // "See above")"' "$RALPH_DIR/last_review_failure.json" 2>/dev/null
+      echo ""
+    fi
+
+    if [[ -f "$RALPH_DIR/last_test_failure.log" ]]; then
+      echo "--- Test Failure ---"
+      tail -50 "$RALPH_DIR/last_test_failure.log"
+      echo ""
+    fi
+
+    if [[ -f "$RALPH_DIR/last_playwright_failure.log" ]]; then
+      echo "--- Playwright Failure ---"
+      tail -50 "$RALPH_DIR/last_playwright_failure.log"
+      echo ""
+    fi
+
+    if [[ -f "$RALPH_DIR/last_browser_failure.json" ]]; then
+      echo "--- Browser Validation Failure ---"
+      jq -r '"Errors: " + (.errors | join(", "))' "$RALPH_DIR/last_browser_failure.json" 2>/dev/null
+      jq -r '"Console errors: " + (.consoleErrors | join(", "))' "$RALPH_DIR/last_browser_failure.json" 2>/dev/null
+      jq -r '"Missing elements: " + (.elementsMissing | join(", "))' "$RALPH_DIR/last_browser_failure.json" 2>/dev/null
+      echo ""
+    fi
+
+    if [[ -f "$RALPH_DIR/last_precommit_failure.log" ]]; then
+      echo "--- Pre-commit / Lint Failure ---"
+      echo "Fix these errors before the story can be completed:"
+      echo ""
+      # Extract actual error lines (not warnings-only or file modification messages)
+      grep -E "^error:|: error:|Error:|SyntaxError|✖ [0-9]+ problems|^[^:]+:[0-9]+:[0-9]+: [EF][0-9]+" "$RALPH_DIR/last_precommit_failure.log" | head -30
+      # If no errors shown, show the full log tail
+      if ! grep -qE "^error:|: error:|Error:|SyntaxError|✖ [0-9]+ problems" "$RALPH_DIR/last_precommit_failure.log"; then
+        echo "(Full output):"
+        tail -40 "$RALPH_DIR/last_precommit_failure.log"
+      fi
+      echo ""
+    fi
+
+    if [[ -f "$RALPH_DIR/last_fastapi_response_check.log" ]]; then
+      echo "--- FastAPI Response Model Failure ---"
+      echo "Add Pydantic response_model to these endpoints for proper Swagger docs:"
+      echo ""
+      cat "$RALPH_DIR/last_fastapi_response_check.log"
+      echo ""
+      echo "Fix by adding response_model parameter or return type annotation:"
+      echo '  @router.get("/items", response_model=list[ItemSchema])'
+      echo "  async def get_items() -> list[ItemSchema]:"
+      echo ""
+    fi
+  } > "$context_file"
+}