agentgui 1.0.988 → 1.0.990

package/lib/agent-discovery.js

@@ -66,57 +66,6 @@ export function findCommand(cmd, rootDir) {
   return null;
 }
 
-export async function queryACPServerAgents(baseUrl) {
-  const endpoint = baseUrl.endsWith('/') ? baseUrl + 'agents/search' : baseUrl + '/agents/search';
-  try {
-    const response = await fetch(endpoint, {
-      method: 'POST',
-      headers: { 'Content-Type': 'application/json', 'Accept': 'application/json' },
-      body: JSON.stringify({}),
-      signal: AbortSignal.timeout(5000)
-    });
-    if (!response.ok) {
-      console.error(`Failed to query ACP agents from ${baseUrl}: ${response.status}`);
-      return [];
-    }
-    const data = await response.json();
-    if (!data?.agents || !Array.isArray(data.agents)) {
-      console.error(`Invalid agents response from ${baseUrl}`);
-      return [];
-    }
-    return data.agents.map(agent => ({
-      id: agent.agent_id || agent.id,
-      name: agent.metadata?.ref?.name || agent.name || 'Unknown Agent',
-      metadata: {
-        ref: {
-          name: agent.metadata?.ref?.name,
-          version: agent.metadata?.ref?.version,
-          url: agent.metadata?.ref?.url,
-          tags: agent.metadata?.ref?.tags
-        },
-        description: agent.metadata?.description,
-        author: agent.metadata?.author,
-        license: agent.metadata?.license
-      },
-      specs: agent.specs ? {
-        capabilities: agent.specs.capabilities,
-        input_schema: agent.specs.input_schema || agent.specs.input,
-        output_schema: agent.specs.output_schema || agent.specs.output,
-        thread_state_schema: agent.specs.thread_state_schema || agent.specs.thread_state,
-        config_schema: agent.specs.config_schema || agent.specs.config,
-        custom_streaming_update_schema: agent.specs.custom_streaming_update_schema || agent.specs.custom_streaming_update
-      } : null,
-      custom_data: agent.custom_data,
-      icon: agent.metadata?.ref?.name?.charAt(0) || 'A',
-      protocol: 'acp',
-      path: baseUrl
-    }));
-  } catch (error) {
-    console.error(`ACP agents query failed for ${baseUrl}: ${error.message}`);
-    return [];
-  }
-}
-
 export function discoverAgents(rootDir) {
   const agents = [];
   for (const bin of BINARIES) {
@@ -145,17 +94,6 @@ export function discoverAgents(rootDir) {
   return filtered;
 }
 
-export async function discoverExternalACPServers(discoveredAgents) {
-  const externalAgents = [];
-  for (const agent of discoveredAgents.filter(a => a.protocol === 'acp' && a.acpPort)) {
-    try {
-      const agents = await queryACPServerAgents(`http://localhost:${agent.acpPort}`);
-      externalAgents.push(...agents);
-    } catch (_) {}
-  }
-  return externalAgents;
-}
-
 export async function initializeAgentDiscovery(discoveredAgents, rootDir, logError) {
   try {
     const agents = discoverAgents(rootDir);

package/lib/server-startup.js

@@ -41,7 +41,6 @@ export function createOnServerReady({ queries, broadcastSync, warmAssetCache, st
       console.log('[ACP] On-demand startup enabled (ACP tools start when first used)');
       setTimeout(() => {
         const acpStatus = getACPStatus();
-        for (const s of acpStatus) { if (s.healthy) { const agent = discoveredAgents.find(a => a.id === s.id); if (agent) agent.acpPort = s.port; } }
         if (acpStatus.length > 0) console.log(`[ACP] Tools ready: ${acpStatus.filter(s => s.healthy).map(s => s.id + ':' + s.port).join(', ') || 'none healthy yet'}`);
       }, 6000);
     }).catch(err => console.error('[ACP] Startup error:', err.message));

package/lib/server-utils.js

@@ -45,7 +45,12 @@ export function makeGetModelsForAgent(deps) {
         { id: 'opus', label: 'Opus' }
       ];
     } else {
-      const agent = discoveredAgents.find(a => a.id === agentId);
+      // The client sends canonical registry ids ('opencode', 'kilo', 'codex'),
+      // but discoverAgents() replaces each found ACP agent with its cli-wrapper
+      // entry whose own id is prefixed ('cli-opencode') and whose acpId carries
+      // the original id. Match on acpId too so model discovery resolves the
+      // wrapper instead of finding nothing and silently returning [] models.
+      const agent = discoveredAgents.find(a => a.id === agentId || a.acpId === agentId);
       if (agent?.protocol === 'acp') {
         await ensureRunning(agentId);
         try { models = await queryACPModels(agentId); } catch (_) {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.988",
+  "version": "1.0.990",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/server.js

@@ -9,7 +9,7 @@ import { createHistoryRouter } from 'ccsniff';
 import { queries } from './database.js';
 import { runClaudeWithStreaming } from './lib/claude-runner-run.js';
 import { initializeDescriptors, getAgentDescriptor } from './lib/agent-descriptors.js';
-import { discoverExternalACPServers, initializeAgentDiscovery } from './lib/agent-discovery.js';
+import { initializeAgentDiscovery } from './lib/agent-discovery.js';
 import { register as registerWsHandlers } from './lib/ws-handlers-util.js';
 import { BROADCAST_TYPES } from './lib/broadcast.js';
 import { WSOptimizer } from './lib/ws-optimizer.js';

package/test.js

@@ -340,6 +340,25 @@ await ok('cross-tab-storage: "updated in another tab" banner on stale load', ()
   }
 });
 
+await ok('agents.models: resolves cli-wrapper by acpId (registry id, not wrapper id)', async () => {
+  // The client picker sends canonical registry ids ('opencode'), but
+  // discoverAgents() stores only the cli-wrapper entry ('cli-opencode',
+  // acpId:'opencode'). getModelsForAgent must resolve via acpId, else model
+  // discovery silently returns [] for every ACP agent (witnessed regression).
+  const { makeGetModelsForAgent } = await import('./lib/server-utils.js');
+  const discoveredAgents = [{ id: 'cli-opencode', protocol: 'cli-wrapper', acpId: 'opencode' }];
+  const calls = [];
+  const getModels = makeGetModelsForAgent({
+    modelCache: new Map(),
+    discoveredAgents,
+    ensureRunning: async (id) => { calls.push(['ensure', id]); return 18100; },
+    queryACPModels: async (id) => { calls.push(['query', id]); return [{ id: 'm1', label: 'M1' }]; },
+  });
+  const models = await getModels('opencode');
+  assert.deepEqual(calls, [['ensure', 'opencode'], ['query', 'opencode']], 'should ensureRunning + query with acpId');
+  assert.equal(models.length, 1, 'should return the ACP-provided models, not an empty list');
+});
+
 console.log(`\n${passed} passed, ${failed} failed, ${skipped} skipped`);
 process.exit(failed === 0 ? 0 : 1);
 }; run();