agentgui 1.0.988 → 1.0.989

package/lib/server-utils.js

@@ -45,7 +45,12 @@ export function makeGetModelsForAgent(deps) {
         { id: 'opus', label: 'Opus' }
       ];
     } else {
-      const agent = discoveredAgents.find(a => a.id === agentId);
+      // The client sends canonical registry ids ('opencode', 'kilo', 'codex'),
+      // but discoverAgents() replaces each found ACP agent with its cli-wrapper
+      // entry whose own id is prefixed ('cli-opencode') and whose acpId carries
+      // the original id. Match on acpId too so model discovery resolves the
+      // wrapper instead of finding nothing and silently returning [] models.
+      const agent = discoveredAgents.find(a => a.id === agentId || a.acpId === agentId);
       if (agent?.protocol === 'acp') {
         await ensureRunning(agentId);
         try { models = await queryACPModels(agentId); } catch (_) {}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.988",
+  "version": "1.0.989",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/test.js

@@ -340,6 +340,25 @@ await ok('cross-tab-storage: "updated in another tab" banner on stale load', ()
   }
 });
 
+await ok('agents.models: resolves cli-wrapper by acpId (registry id, not wrapper id)', async () => {
+  // The client picker sends canonical registry ids ('opencode'), but
+  // discoverAgents() stores only the cli-wrapper entry ('cli-opencode',
+  // acpId:'opencode'). getModelsForAgent must resolve via acpId, else model
+  // discovery silently returns [] for every ACP agent (witnessed regression).
+  const { makeGetModelsForAgent } = await import('./lib/server-utils.js');
+  const discoveredAgents = [{ id: 'cli-opencode', protocol: 'cli-wrapper', acpId: 'opencode' }];
+  const calls = [];
+  const getModels = makeGetModelsForAgent({
+    modelCache: new Map(),
+    discoveredAgents,
+    ensureRunning: async (id) => { calls.push(['ensure', id]); return 18100; },
+    queryACPModels: async (id) => { calls.push(['query', id]); return [{ id: 'm1', label: 'M1' }]; },
+  });
+  const models = await getModels('opencode');
+  assert.deepEqual(calls, [['ensure', 'opencode'], ['query', 'opencode']], 'should ensureRunning + query with acpId');
+  assert.equal(models.length, 1, 'should return the ACP-provided models, not an empty list');
+});
+
 console.log(`\n${passed} passed, ${failed} failed, ${skipped} skipped`);
 process.exit(failed === 0 ? 0 : 1);
 }; run();