agentgui 1.0.963 → 1.0.965

package/lib/http-handler.js

@@ -471,6 +471,48 @@ export function createHttpHandler({ BASE_URL, expressApp, queries, sendJSON, ser
         return;
       }
 
+      // POST /api/move {path, destDir, overwrite?} -> {ok, path}. Moves an
+      // entry into another directory; BOTH endpoints re-confine via realpath.
+      // Refuses: a root as the source, a directory moved into itself or its
+      // own subtree, and an existing target unless overwrite:true (and never
+      // overwrites a directory).
+      if (routePath.split('?')[0] === '/api/move' && req.method === 'POST') {
+        let body;
+        try { body = JSON.parse((await readBody(req, 64 * 1024)).toString('utf8') || '{}'); }
+        catch (e) { sendJSON(req, res, e.code === 'TOO_LARGE' ? 413 : 400, { error: 'bad request body' }); return; }
+        const allowRoots = fsAllowRoots();
+        const conf = confineToRoots(String(body.path || ''), allowRoots);
+        if (!conf.ok) { sendJSON(req, res, conf.reason === 'not found' ? 404 : 403, { error: 'forbidden: ' + conf.reason }); return; }
+        if (isAllowRoot(conf.realPath, allowRoots)) { sendJSON(req, res, 403, { error: 'forbidden: cannot move an allowed root' }); return; }
+        const dConf = confineToRoots(String(body.destDir || ''), allowRoots);
+        if (!dConf.ok) { sendJSON(req, res, dConf.reason === 'not found' ? 404 : 403, { error: 'forbidden: ' + dConf.reason }); return; }
+        let destIsDir = false;
+        try { destIsDir = fs.statSync(dConf.realPath).isDirectory(); } catch {}
+        if (!destIsDir) { sendJSON(req, res, 400, { error: 'destination is not a directory' }); return; }
+        const name = sanitizeEntryName(path.basename(conf.realPath));
+        if (!name) { sendJSON(req, res, 400, { error: 'invalid name' }); return; }
+        // A directory must never move into itself or its own subtree.
+        const srcPrefix = conf.realPath + path.sep;
+        if (dConf.realPath === conf.realPath || dConf.realPath.startsWith(srcPrefix)) {
+          sendJSON(req, res, 400, { error: 'cannot move a folder into itself' }); return;
+        }
+        const target = path.join(dConf.realPath, name);
+        if (target === conf.realPath) { sendJSON(req, res, 200, { ok: true, path: target }); return; }
+        if (fs.existsSync(target)) {
+          let targetIsDir = false;
+          try { targetIsDir = fs.lstatSync(target).isDirectory(); } catch {}
+          if (targetIsDir || body.overwrite !== true) {
+            sendJSON(req, res, 409, { error: 'a file with that name already exists' }); return;
+          }
+        }
+        try { fs.renameSync(conf.realPath, target); sendJSON(req, res, 200, { ok: true, path: target }); }
+        catch (err) {
+          const code = err.code === 'EACCES' || err.code === 'EPERM' ? 403 : 400;
+          sendJSON(req, res, code, { error: err.code === 'EXDEV' ? 'cannot move across drives' : err.message });
+        }
+        return;
+      }
+
       // POST /api/delete {path, recursive?} -> {ok}. Deleting a non-empty dir
       // requires recursive:true (the client confirms first).
       if (routePath.split('?')[0] === '/api/delete' && req.method === 'POST') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.963",
+  "version": "1.0.965",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/scripts/validate-mutations.mjs

@@ -44,6 +44,17 @@ const up2 = await fetch(BASE + '/api/upload-file?dir=' + encodeURIComponent(join
 results.push({ name: 'upload-conflict-409', expected: 409, got: up2.status, ok: up2.status === 409 });
 await check('rename-ok', 200, await post('/api/rename', { path: join(ROOT, '_wtest', 'up.txt'), newName: 'up2.txt' }));
 await check('rename-conflict-409', 409, await post('/api/rename', { path: join(ROOT, '_wtest', 'up2.txt'), newName: 'up2.txt' }));
+// move: security cases + round trip (subdir -> back), then self-nesting refusal
+await check('move-traversal-src-403', 403, await post('/api/move', { path: TRAVERSAL, destDir: ROOT }));
+await check('move-outside-dest-403', 403, await post('/api/move', { path: join(ROOT, '_wtest', 'up2.txt'), destDir: OUTSIDE_DIR }));
+await check('move-root-refused-403', 403, await post('/api/move', { path: ROOT, destDir: join(ROOT, '_wtest') }));
+await check('mkdir-move-sub-ok', 200, await post('/api/mkdir', { dir: join(ROOT, '_wtest'), name: 'sub' }));
+await check('move-ok', 200, await post('/api/move', { path: join(ROOT, '_wtest', 'up2.txt'), destDir: join(ROOT, '_wtest', 'sub') }));
+const up3 = await fetch(BASE + '/api/upload-file?dir=' + encodeURIComponent(join(ROOT, '_wtest')) + '&name=up2.txt', { method: 'PUT', headers: AUTH, body: 'collide' });
+results.push({ name: 'upload-for-move-conflict', expected: 200, got: up3.status, ok: up3.status === 200 });
+await check('move-conflict-409', 409, await post('/api/move', { path: join(ROOT, '_wtest', 'sub', 'up2.txt'), destDir: join(ROOT, '_wtest') }));
+await check('move-overwrite-ok', 200, await post('/api/move', { path: join(ROOT, '_wtest', 'sub', 'up2.txt'), destDir: join(ROOT, '_wtest'), overwrite: true }));
+await check('move-dir-into-itself-400', 400, await post('/api/move', { path: join(ROOT, '_wtest', 'sub'), destDir: join(ROOT, '_wtest', 'sub') }));
 await check('delete-nonempty-no-recursive-409', 409, await post('/api/delete', { path: join(ROOT, '_wtest') }));
 await check('delete-recursive-ok', 200, await post('/api/delete', { path: join(ROOT, '_wtest'), recursive: true }));
 const st = await fetch(BASE + '/api/stat/' + encodeURIComponent(ROOT), { headers: AUTH });

package/site/app/index.html

@@ -16,6 +16,13 @@
   <script type="importmap">
     { "imports": { "anentrypoint-design": "./vendor/anentrypoint-design/247420.js" } }
   </script>
+  <!-- Preload the whole module graph so the 300KB kit fetch starts in parallel
+       with app.js instead of after its parse; preconnect warms the jsdelivr
+       DNS+TLS the markdown stack needs on first chat render. -->
+  <link rel="modulepreload" href="./vendor/anentrypoint-design/247420.js">
+  <link rel="modulepreload" href="./js/backend.js">
+  <link rel="modulepreload" href="./js/codec.js">
+  <link rel="preconnect" href="https://cdn.jsdelivr.net" crossorigin>
   <style>
     :root {
       --agentgui-bg: #16161a;
@@ -114,12 +121,15 @@
     }
     .pill:focus-visible { outline: 2px solid var(--accent, var(--agentgui-accent)); outline-offset: 2px; }
 
-    /* subagent toggle */
-    .subagent-toggle { display: flex; gap: .5em; align-items: center; padding: .4em 0; cursor: pointer; min-height: 32px; }
-    .subagent-toggle input { width: 16px; height: 16px; cursor: pointer; }
+    /* subagent toggle (the control itself is the kit Checkbox) */
+    .subagent-toggle { padding: .4em 0; min-height: 32px; }
 
     .field-error { color: var(--warn, var(--agentgui-warn)); }
 
+    /* Boot splash: static text painted with the HTML, replaced by the first
+       mount render - the cold module waterfall no longer reads as a blank page. */
+    .boot-splash { height: 100%; min-height: 60vh; display: flex; align-items: center; justify-content: center; color: var(--agentgui-muted); font-size: .9rem; }
+
     /* chat control cluster in the crumb bar: model picker, +new, status.
        Allowed to wrap so it never overflows the crumb on tablet widths. */
     .chat-controls { display: flex; align-items: center; gap: .6em; flex-wrap: wrap; }
@@ -255,7 +265,7 @@
   </style>
 </head>
 <body>
-  <div id="app"></div>
+  <div id="app"><div class="boot-splash" role="status">loading agentgui…</div></div>
   <script type="module" src="./js/app.js"></script>
 </body>
 </html>