agentgui 1.0.913 → 1.0.915

package/AGENTS.md

@@ -11,3 +11,23 @@ Fix: `bun run scripts/capture-screenshots.mjs` (not `node ...`).
 Why it works: `process.execPath` becomes bun, so the spawned child server also runs under bun and loads `bun:sqlite` natively — no compiled binding needed.
 
 Rule: any CI step that spawns the agentgui server (directly or via a script that inherits `process.execPath`) must invoke it with `bun`.
+
+## Plugin Dependencies
+
+**`lib/plugins/stream-plugin.js` must not import packages missing from package.json.**
+
+The plugin loader runs at startup and logs failures silently if a plugin import fails. If stream plugin fails to load due to missing dependency (e.g., `uuid`), the error cascades: `agents` and `websocket` plugins both declare `stream` as a dependency and fail with "Plugin stream not found in registry", cascading to boot failure.
+
+Fix for uuid: replaced `import { v4 as uuidv4 } from 'uuid'` with `import { randomUUID as uuidv4 } from 'crypto'` (Node.js built-in, zero deps).
+
+Pattern: all imports in lib/plugins/* must be either built-in (crypto, fs, path, etc.) or already in package.json. No new npm packages should be added to plugins without adding them to dependencies.
+
+## Plugin Tool Provisioning on Windows
+
+**`lib/tool-spawner.js` must iterate bun → npx fallback and match cross-platform command-not-found errors.**
+
+On Windows hosts without bun installed, the auto-provisioner on startup and 6h periodic update checker failed silently when spawnBunxProc tried `bun.cmd` directly. The missing command error came via process stderr+close, not the 'error' event, so simple ENOENT detection was insufficient. Additionally, the error message format differs by OS: Windows shows "'bun.cmd' is not recognized as an internal or external command", Linux/Mac show "command not found" or "cannot find".
+
+Fix: `BUNX_RUNNERS` array iterates `['bun', 'npx']` and tries each in sequence. Error detection regex `isMissingCmdError` matches `/not recognized|ENOENT|command not found|cannot find/i` on both `error.message` and captured stdout+stderr. Only falls through to next runner when the `missing` flag is set.
+
+Pattern: When a binary might not exist on all platforms, use a runner fallback strategy. Always capture and check both error.message and process output streams. Cross-platform error detection requires regex alternation on common message patterns.

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.0.908] - manual audit fixes: server retry idempotency, cli-version detection, cleanup FK ordering, refresh-all path
+
+- server.js: `onServerListenStart` one-shot guard prevents `onServerReady` + `loadPluginExtensions` from re-firing when EADDRINUSE retry succeeds — previously every retry re-ran autoProvision/installGMAgentConfigs/setIntervals causing 100+ duplicate provision passes and stacked timers
+- lib/tool-version-check.js: bumped `getCliVersion` execSync timeout from 1000ms to 15000ms; bumped `checkCliInstalled` `where` timeout from 3000ms to 10000ms — Windows cmd.exe + node CLI cold-start regularly exceeds 1s/3s, leaving opencode/gemini/kilo/agent-browser with `installedVersion: null` despite being installed
+- lib/db-queries-cleanup.js: reordered cleanup transaction — child rows (chunks, stream_updates) now deleted before their parent sessions; was causing FOREIGN KEY constraint failed on every `[cleanup] Initial DB cleanup complete` invocation and on the 6h periodic cleanup, silently aborting the whole transaction
+- lib/routes-tools.js: `POST /api/tools/refresh-all` now calls `toolManager.refreshAllToolsAsync()` (which clears statusCache) instead of `getAllTools()` which returned stale cached values — refresh button was a no-op
+
 ## [Unreleased] - implement 247420 brand-bible chrome on main shell
 
 - index.html: header brand line reads `247420 / agentgui / <leaf>`; sidebar brand line reads `247420 / agentgui` — mono slash `/` in muted color, matches canonical app-topbar pattern from c:/dev/design

package/lib/db-queries-cleanup.js

@@ -6,15 +6,16 @@ export function addCleanupQueries(q, db, prep, generateId) {
 
     const cleanupStmt = db.transaction(() => {
       prep('DELETE FROM events WHERE created_at < ?').run(thirtyDaysAgo);
-      prep('DELETE FROM sessions WHERE completed_at IS NOT NULL AND completed_at < ?').run(thirtyDaysAgo);
       prep('DELETE FROM idempotencyKeys WHERE (created_at + ttl) < ?').run(now);
 
-      prep('DELETE FROM chunks WHERE sessionId IN (SELECT id FROM sessions WHERE completed_at IS NOT NULL AND completed_at < ?)').run(sevenDaysAgo);
-      prep('DELETE FROM stream_updates WHERE sessionId IN (SELECT id FROM sessions WHERE completed_at IS NOT NULL AND completed_at < ?)').run(sevenDaysAgo);
+      prep('DELETE FROM chunks WHERE sessionId IN (SELECT id FROM sessions WHERE completed_at IS NOT NULL AND completed_at < ?)').run(thirtyDaysAgo);
+      prep('DELETE FROM stream_updates WHERE sessionId IN (SELECT id FROM sessions WHERE completed_at IS NOT NULL AND completed_at < ?)').run(thirtyDaysAgo);
 
       prep('DELETE FROM chunks WHERE created_at < ? AND sessionId NOT IN (SELECT id FROM sessions WHERE completed_at IS NULL AND started_at >= ?)').run(sevenDaysAgo, sevenDaysAgo);
       prep('DELETE FROM stream_updates WHERE created_at < ? AND sessionId NOT IN (SELECT id FROM sessions WHERE completed_at IS NULL AND started_at >= ?)').run(sevenDaysAgo, sevenDaysAgo);
 
+      prep('DELETE FROM sessions WHERE completed_at IS NOT NULL AND completed_at < ?').run(thirtyDaysAgo);
+
       prep('DELETE FROM voice_cache WHERE expires_at <= ?').run(now);
 
       const deletedConvIds = prep("SELECT id FROM conversations WHERE status = 'deleted' AND updated_at < ?").all(sevenDaysAgo).map(r => r.id);

package/lib/routes-tools.js

@@ -67,12 +67,11 @@ export function register(deps) {
     sendJSON(req, res, 200, { refreshing: true, toolCount: 4 });
     broadcastSync({ type: 'tools_refresh_started' });
     setImmediate(async () => {
-      const tools = toolManager.getAllTools();
+      const tools = await toolManager.refreshAllToolsAsync();
       for (const tool of tools) {
         queries.updateToolStatus(tool.id, { status: tool.installed ? 'installed' : 'not_installed', version: tool.installedVersion, last_check_at: Date.now() });
-        if (tool.installed) {
-          const status = await toolManager.checkToolStatusAsync(tool.id);
-          if (status?.upgradeNeeded) queries.updateToolStatus(tool.id, { update_available: 1, latest_version: status.publishedVersion });
+        if (tool.installed && tool.upgradeNeeded) {
+          queries.updateToolStatus(tool.id, { update_available: 1, latest_version: tool.publishedVersion });
         }
       }
       broadcastSync({ type: 'tools_refresh_complete', data: tools });

package/lib/tool-version-check.js

@@ -141,7 +141,7 @@ export function checkCliInstalled(pkg) {
     const cmd = isWindows ? 'where' : 'which';
     const bin = BIN_MAP[pkg];
     if (bin) {
-      execSync(`${cmd} ${bin}`, { stdio: 'pipe', timeout: 3000, windowsHide: true });
+      execSync(`${cmd} ${bin}`, { stdio: 'pipe', timeout: 10000, windowsHide: true });
       return true;
     }
   } catch (_) {}
@@ -154,7 +154,7 @@ export function getCliVersion(pkg) {
     if (!bin) return null;
     try {
       const versionFlag = pkg === 'agent-browser' ? '-V' : '--version';
-      const out = execSync(`${bin} ${versionFlag}`, { stdio: 'pipe', timeout: 1000, encoding: 'utf8', windowsHide: true });
+      const out = execSync(`${bin} ${versionFlag}`, { stdio: 'pipe', timeout: 15000, encoding: 'utf8', windowsHide: true });
       const match = out.match(/(\d+\.\d+\.\d+)/);
       if (match) {
         console.log(`[tool-manager] CLI ${pkg} (${bin}) version: ${match[1]}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.913",
+  "version": "1.0.915",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/server.js

@@ -169,11 +169,19 @@ process.on('SIGINT', () => {
   process.exit(0);
 });
 
+let _serverReadyFired = false;
+const onServerListenStart = () => {
+  if (_serverReadyFired) return;
+  _serverReadyFired = true;
+  onServerReady();
+  loadPluginExtensions();
+};
+
 server.on('error', (err) => {
   if (err.code === 'EADDRINUSE') {
     console.error(`Port ${PORT} already in use. Waiting 3 seconds before retry...`);
     setTimeout(() => {
-      server.listen(PORT, onServerReady);
+      server.listen(PORT, onServerListenStart);
     }, 3000);
   } else {
     console.error('[SERVER] Error (contained):', err.message);
@@ -194,7 +202,4 @@ const { onServerReady, getJsonlWatcher } = createOnServerReady({
   performAgentHealthCheck, pm2Manager, pm2Subscribers, recoverStaleSessions
 });
 
-server.listen(PORT, () => {
-  onServerReady();
-  loadPluginExtensions();
-});
+server.listen(PORT, onServerListenStart);