agentgui 1.0.912 → 1.0.914

package/AGENTS.md

@@ -11,3 +11,23 @@ Fix: `bun run scripts/capture-screenshots.mjs` (not `node ...`).
 Why it works: `process.execPath` becomes bun, so the spawned child server also runs under bun and loads `bun:sqlite` natively — no compiled binding needed.
 
 Rule: any CI step that spawns the agentgui server (directly or via a script that inherits `process.execPath`) must invoke it with `bun`.
+
+## Plugin Dependencies
+
+**`lib/plugins/stream-plugin.js` must not import packages missing from package.json.**
+
+The plugin loader runs at startup and logs failures silently if a plugin import fails. If stream plugin fails to load due to missing dependency (e.g., `uuid`), the error cascades: `agents` and `websocket` plugins both declare `stream` as a dependency and fail with "Plugin stream not found in registry", cascading to boot failure.
+
+Fix for uuid: replaced `import { v4 as uuidv4 } from 'uuid'` with `import { randomUUID as uuidv4 } from 'crypto'` (Node.js built-in, zero deps).
+
+Pattern: all imports in lib/plugins/* must be either built-in (crypto, fs, path, etc.) or already in package.json. No new npm packages should be added to plugins without adding them to dependencies.
+
+## Plugin Tool Provisioning on Windows
+
+**`lib/tool-spawner.js` must iterate bun → npx fallback and match cross-platform command-not-found errors.**
+
+On Windows hosts without bun installed, the auto-provisioner on startup and 6h periodic update checker failed silently when spawnBunxProc tried `bun.cmd` directly. The missing command error came via process stderr+close, not the 'error' event, so simple ENOENT detection was insufficient. Additionally, the error message format differs by OS: Windows shows "'bun.cmd' is not recognized as an internal or external command", Linux/Mac show "command not found" or "cannot find".
+
+Fix: `BUNX_RUNNERS` array iterates `['bun', 'npx']` and tries each in sequence. Error detection regex `isMissingCmdError` matches `/not recognized|ENOENT|command not found|cannot find/i` on both `error.message` and captured stdout+stderr. Only falls through to next runner when the `missing` flag is set.
+
+Pattern: When a binary might not exist on all platforms, use a runner fallback strategy. Always capture and check both error.message and process output streams. Cross-platform error detection requires regex alternation on common message patterns.

package/lib/plugins/stream-plugin.js

@@ -1,6 +1,6 @@
 // Stream plugin - session management, streaming execution, rate limiting
 
-import { v4 as uuidv4 } from 'uuid';
+import { randomUUID as uuidv4 } from 'crypto';
 
 export default {
   name: 'stream',

package/lib/tool-spawner.js

@@ -29,17 +29,24 @@ const spawnNpmInstall = (pkg, onProgress) => new Promise((resolve) => {
   proc.on('error', (err) => { clearTimeout(timer); if (!completed) { completed = true; resolve({ success: false, error: err.message }); } });
 });
 
-const spawnBunxProc = (pkg, onProgress) => new Promise((resolve) => {
-  const cmd = isWindows ? 'bun.cmd' : 'bun';
+const BUNX_RUNNERS = [
+  { cmd: isWindows ? 'bun.cmd' : 'bun', args: (pkg) => ['x', pkg] },
+  { cmd: isWindows ? 'npx.cmd' : 'npx', args: (pkg) => ['-y', pkg] },
+];
+
+const isMissingCmdError = (s) => /not recognized|ENOENT|command not found|cannot find/i.test(s || '');
+
+const spawnBunxOnce = (runner, pkg, onProgress) => new Promise((resolve) => {
+  const cmd = runner.cmd;
   let completed = false, stderr = '', stdout = '';
   let lastDataTime = Date.now();
   let proc;
   try {
-    proc = spawn(cmd, ['x', pkg], { stdio: ['pipe', 'pipe', 'pipe'], timeout: 300000, shell: isWindows, windowsHide: true });
+    proc = spawn(cmd, runner.args(pkg), { stdio: ['pipe', 'pipe', 'pipe'], timeout: 300000, shell: isWindows, windowsHide: true });
   } catch (err) {
-    return resolve({ success: false, error: `Failed to spawn bun x: ${err.message}` });
+    return resolve({ success: false, error: `Failed to spawn ${cmd}: ${err.message}`, missing: isMissingCmdError(err.message) });
   }
-  if (!proc) return resolve({ success: false, error: 'Failed to spawn bun x process' });
+  if (!proc) return resolve({ success: false, error: `Failed to spawn ${cmd} process`, missing: true });
 
   const timer = setTimeout(() => {
     if (!completed) { completed = true; try { proc.kill('SIGKILL'); } catch (_) {} resolve({ success: false, error: 'Timeout (5min)' }); }
@@ -48,7 +55,7 @@ const spawnBunxProc = (pkg, onProgress) => new Promise((resolve) => {
   const heartbeatTimer = setInterval(() => {
     if (completed) { clearInterval(heartbeatTimer); return; }
     const elapsed = Date.now() - lastDataTime;
-    if (elapsed > 30000) console.warn(`[tool-manager] No output from bun x ${pkg} for ${elapsed}ms - process may be hung`);
+    if (elapsed > 30000) console.warn(`[tool-manager] No output from ${cmd} ${pkg} for ${elapsed}ms - process may be hung`);
   }, 30000);
 
   const onData = (d) => { lastDataTime = Date.now(); if (onProgress) onProgress({ type: 'progress', data: d.toString() }); };
@@ -64,16 +71,27 @@ const spawnBunxProc = (pkg, onProgress) => new Promise((resolve) => {
     const ok = [code === 0, output.includes('upgraded'), output.includes('registered'),
       output.includes('Hooks registered'), output.includes('successfully'),
       output.includes('Done'), code === 0 && !output.includes('error')].some(Boolean);
-    resolve(ok ? { success: true, error: null, pkg } : { success: false, error: output.substring(0, 1000) || 'Failed' });
+    resolve(ok ? { success: true, error: null, pkg } : { success: false, error: output.substring(0, 1000) || 'Failed', missing: isMissingCmdError(output) });
   });
 
   proc.on('error', (err) => {
     clearTimeout(timer);
     clearInterval(heartbeatTimer);
-    if (!completed) { completed = true; resolve({ success: false, error: `Process error: ${err.message}` }); }
+    if (!completed) { completed = true; resolve({ success: false, error: `Process error: ${err.message}`, missing: isMissingCmdError(err.message) }); }
   });
 });
 
+const spawnBunxProc = async (pkg, onProgress) => {
+  let lastResult = null;
+  for (const runner of BUNX_RUNNERS) {
+    const result = await spawnBunxOnce(runner, pkg, onProgress);
+    if (result.success) return result;
+    lastResult = result;
+    if (!result.missing) return result;
+  }
+  return lastResult || { success: false, error: 'No runner available' };
+};
+
 function spawnForTool(tool, onProgress) {
   const pkg = tool.installPkg || tool.pkg;
   return tool.category === 'cli' ? spawnNpmInstall(pkg, onProgress) : spawnBunxProc(pkg, onProgress);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.912",
+  "version": "1.0.914",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",