agentgui 1.0.904 → 1.0.906

package/CLAUDE.md

@@ -373,7 +373,7 @@ The README.md uses shields.io badges with a consistent pattern:
 
 **Codebase Insight Stale:** `.codeinsight` snapshot is outdated (v1.0.811 claimed server.js=3407L, db-queries.js=1412L, but actual as of 2026-04-17: server.js=201L, db-queries.js=94L). Heavy refactoring already done. Before acting on insight "issues" (SQL injection claims, hardcoded secrets, large files), always verify with grep/read against current state. Most reported issues are false positives or stale.
 
-**Test Harness Pattern:** Use better-sqlite3 in-memory Database, call `initSchema()` → `migrateConversationColumns()` → `migrateACPSchema()` in order (conversations table needs agentType column from second migration). `createQueries` signature: `(db, prep, generateId)` where `prep=(sql)=>db.prepare(sql)`. Silence console during schema init to keep test output clean. Node ships with better-sqlite3 available (optional dep resolved).
+**Test Harness Pattern:** test.js prefers `bun:sqlite`, falls back to `better-sqlite3` via createRequire (so it runs under both `bun test.js` and `node test.js` provided `bun install` / `npm install` ran). Call `initSchema()` → `migrateConversationColumns()` → `migrateACPSchema()` in order (conversations table needs agentType column from second migration). `createQueries` signature: `(db, prep, generateId)` where `prep=(sql)=>db.prepare(sql)`. Silence console during schema init to keep test output clean. CI runs `bun test.js` via `.github/workflows/test.yml` on every push/PR to main.
 
 **CI Auto-Rewrites History:** Every push to main triggers Auto-Declaudeify workflow that filters Claude coauthor commits and force-pushes filtered history. After a push, `git fetch origin` is needed — local SHA drifts from origin SHA.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.904",
+  "version": "1.0.906",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/site/theme.mjs

@@ -26,17 +26,17 @@ function Hero() {
   if (!home || !home.hero) return null;
   return C.Panel({
     style: 'margin:8px',
-    children: [
+    children: h('div', { style: 'padding:24px 22px' },
       C.Heading({ level: 1, style: 'margin:0 0 8px 0', children: home.hero.heading || site.title }),
       home.hero.subheading ? C.Lede({ children: home.hero.subheading }) : null,
       home.hero.body ? h('p', { style: 'margin:8px 0 16px 0;color:var(--panel-text-2);max-width:64ch' }, home.hero.body) : null,
-      (home.hero.badges && home.hero.badges.length) ? h('div', { style: 'display:flex;gap:6px;flex-wrap:wrap;margin-bottom:12px' },
+      (home.hero.badges && home.hero.badges.length) ? h('div', { style: 'display:flex;gap:6px;flex-wrap:wrap;margin:0 0 12px 0' },
         ...home.hero.badges.map((b, i) => C.Chip({ key: 'b'+i, children: b.label }))
       ) : null,
       (home.hero.ctas && home.hero.ctas.length) ? h('div', { style: 'display:flex;gap:8px;flex-wrap:wrap' },
         ...home.hero.ctas.map((c, i) => C.Btn({ key: 'c'+i, href: c.href, primary: c.primary, children: c.label }))
       ) : null
-    ]
+    )
   });
 }
 
@@ -60,13 +60,102 @@ function Features() {
 function Quickstart() {
   if (!home || !home.quickstart || !home.quickstart.lines || !home.quickstart.lines.length) return null;
   const lineNodes = home.quickstart.lines.map((l, i) => h('div', { key: 'q'+i, class: 'cli' },
-    h('span', { class: 'prompt' }, (l.kind === 'cmt' ? '#' : '$')),
+    h('span', { class: 'prompt' }, (l.kind === 'cmt' ? '#' : '
+
+function Examples() {
+  if (!home || !home.examples || !home.examples.items || !home.examples.items.length) return null;
+  const rows = home.examples.items.map((it, i) => C.RowLink({
+    key: 'e'+i,
+    title: it.name,
+    sub: it.desc || '',
+    meta: it.cta || 'open',
+    href: it.href || '#'
+  }));
+  return C.Panel({
+    title: home.examples.heading || 'examples',
+    style: 'margin:8px',
+    children: rows
+  });
+}
+
+function Footer() {
+  return h('footer', { class: 'app-status' },
+    h('span', { class: 'item' }, 'styled with '),
+    h('a', { class: 'item', href: 'https://anentrypoint.github.io/design/' }, 'anentrypoint-design'),
+    h('span', { class: 'item' }, '·'),
+    h('a', { class: 'item', href: 'https://247420.xyz' }, '247420.xyz'),
+    h('span', { class: 'spread' }),
+    site.repo ? h('a', { class: 'item', href: site.repo }, 'source ↗') : null
+  );
+}
+
+const navItems = (nav && nav.links ? nav.links : []).map(l => [String(l.label || ''), l.href]);
+
+const App = C.AppShell({
+  topbar: C.Topbar({
+    brand: '247420',
+    leaf: site.title || '',
+    items: navItems
+  }),
+  crumb: C.Crumb({
+    trail: ['247420'],
+    leaf: site.title || ''
+  }),
+  main: h('div', {},
+    Hero(),
+    Features(),
+    Quickstart(),
+    Examples()
+  ),
+  status: Footer()
+});
+
+applyDiff(document.getElementById('app'), [App]);
+`;
+
+const html = ({ site, nav, home }) => `<!DOCTYPE html>
+<html lang="en" class="ds-247420">
+<head>
+  <meta charset="UTF-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+  <title>${escapeHtml(site.title)}${site.tagline ? ' — ' + escapeHtml(site.tagline) : ''}</title>
+  <meta name="description" content="${escapeHtml(site.description || site.tagline || site.title)}" />
+  <meta property="og:title" content="${escapeHtml(site.title)}" />
+  <meta property="og:description" content="${escapeHtml(site.description || site.tagline || '')}" />
+  <meta property="og:url" content="${escapeHtml(site.url || '')}" />
+  <link rel="canonical" href="${escapeHtml(site.url || '')}" />
+  <link rel="icon" href="data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 32 32'%3E%3Ctext y='26' font-size='26'%3E${encodeURIComponent(site.glyph || '◆')}%3C/text%3E%3C/svg%3E" />
+  <script type="importmap">{"imports":{"anentrypoint-design":"${SDK_URL}"}}</script>
+  <style>html,body{margin:0;padding:0}body{background:var(--app-bg,#FBF6EB);color:var(--ink,#1F1B16);font-family:var(--ff-ui,'Nunito',system-ui,sans-serif)}</style>
+</head>
+<body>
+  <div id="app"></div>
+  <script type="application/json" id="__site__">${escapeJson({ site, nav, home })}</script>
+  <script type="module">${clientScript}</script>
+</body>
+</html>
+`;
+
+export default {
+  render: async (ctx) => {
+    const site = ctx.readGlobal('site') || {};
+    const nav = ctx.readGlobal('navigation') || { links: [] };
+    const homeDoc = ctx.read('pages').docs.find(p => p.id === 'home');
+    if (!homeDoc) throw new Error('config/pages/home.yaml missing or has no id: home');
+
+    return [{
+      path: 'index.html',
+      html: html({ site, nav, home: homeDoc })
+    }];
+  }
+};
+)),
     h('span', { class: 'cmd' }, l.text)
   ));
   return C.Panel({
     title: home.quickstart.heading || 'quick start',
     style: 'margin:8px',
-    children: lineNodes
+    children: h('div', { style: 'padding:16px 22px' }, ...lineNodes)
   });
 }
 

package/test.js

@@ -1,184 +1,118 @@
 import assert from 'assert';
-import Database from 'better-sqlite3';
+import { createRequire } from 'module';
 import { initSchema } from './database-schema.js';
 import { migrateConversationColumns } from './database-migrations.js';
 import { migrateACPSchema } from './database-migrations-acp.js';
 import { createQueries } from './lib/db-queries.js';
 import { encode, decode } from './lib/codec.js';
 import { WsRouter } from './lib/ws-protocol.js';
-import * as toolInstallMachine from './lib/tool-install-machine.js';
-import * as execMachine from './lib/execution-machine.js';
-import * as acpServerMachine from './lib/acp-server-machine.js';
+import { WSOptimizer } from './lib/ws-optimizer.js';
+import * as tim from './lib/tool-install-machine.js';
+import * as exm from './lib/execution-machine.js';
+import * as asm from './lib/acp-server-machine.js';
+import { maskKey, buildSystemPrompt } from './lib/provider-config.js';
+import { buildBaseUrl, isRemoteRequest, encodeOAuthState, decodeOAuthState } from './lib/oauth-common.js';
+import { compareVersions } from './lib/tool-version-check.js';
+import { initializeDescriptors, getAgentDescriptor } from './lib/agent-descriptors.js';
+const require = createRequire(import.meta.url);
+let Database;
+try { Database = (await import('bun:sqlite')).default; } catch { Database = require('better-sqlite3'); }
 
 let passed = 0, failed = 0;
-const section = (name, fn) => {
-  try { fn(); console.log(`ok — ${name}`); passed++; }
-  catch (err) { console.error(`FAIL — ${name}: ${err.message}`); failed++; }
-};
-
+const ok = (name, fn) => Promise.resolve().then(fn).then(
+  () => { console.log(`ok — ${name}`); passed++; },
+  (err) => { console.error(`FAIL — ${name}: ${err.message}`); failed++; });
 function inMemDb() {
   const db = new Database(':memory:');
-  db.pragma('foreign_keys = ON');
+  if (db.pragma) db.pragma('foreign_keys = ON'); else db.run('PRAGMA foreign_keys = ON');
   const origLog = console.log, origWarn = console.warn;
   console.log = () => {}; console.warn = () => {};
-  try {
-    initSchema(db);
-    migrateConversationColumns(db);
-    migrateACPSchema(db);
-  } finally { console.log = origLog; console.warn = origWarn; }
-  const prep = (sql) => db.prepare(sql);
+  try { initSchema(db); migrateConversationColumns(db); migrateACPSchema(db); }
+  finally { console.log = origLog; console.warn = origWarn; }
   const gid = (p) => `${p}-${Date.now()}-${Math.random().toString(36).slice(2, 11)}`;
-  return { db, prep, gid };
+  return { db, prep: (sql) => db.prepare(sql), gid };
 }
-
-section('codec: roundtrip primitives', () => {
+const run = async () => {
+await ok('codec: roundtrip + binary', () => {
   const obj = { a: 1, b: 'str', c: [1, 2, 3], d: { nested: true } };
   assert.deepEqual(decode(encode(obj)), obj);
-});
-
-section('codec: binary payload', () => {
-  const buf = Buffer.from([1, 2, 3, 4]);
-  const round = decode(encode({ bin: buf }));
+  const round = decode(encode({ bin: Buffer.from([1, 2, 3, 4]) }));
   assert.deepEqual(Array.from(round.bin), [1, 2, 3, 4]);
 });
 
-section('db: init schema creates conversations table', () => {
+await ok('db: init schema creates conversations table', () => {
   const { db } = inMemDb();
-  const t = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name='conversations'").get();
-  assert.ok(t, 'conversations table exists');
+  assert.ok(db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name='conversations'").get());
 });
 
-section('db-queries: createConversation round-trip', () => {
+await ok('db-queries: createConversation round-trip', () => {
   const { db, prep, gid } = inMemDb();
   const q = createQueries(db, prep, gid);
   const c = q.createConversation('claude-code', 'Test', '/tmp', 'sonnet', null);
-  assert.equal(c.title, 'Test');
-  const fetched = q.getConversation(c.id);
-  assert.equal(fetched.title, 'Test');
-  assert.equal(fetched.status, 'active');
-});
-
-section('db-queries: archive + restore', () => {
-  const { db, prep, gid } = inMemDb();
-  const q = createQueries(db, prep, gid);
-  const c = q.createConversation('claude-code', 'A');
-  q.archiveConversation(c.id);
-  assert.equal(q.getConversation(c.id).status, 'archived');
-  q.restoreConversation(c.id);
+  assert.equal(q.getConversation(c.id).title, 'Test');
   assert.equal(q.getConversation(c.id).status, 'active');
 });
 
-section('db-queries: streaming flag', () => {
+await ok('db-queries: archive + restore + streaming flag', () => {
   const { db, prep, gid } = inMemDb();
   const q = createQueries(db, prep, gid);
-  const c = q.createConversation('claude-code', 'S');
-  q.setIsStreaming(c.id, true);
-  assert.equal(q.getIsStreaming(c.id), true);
-  q.setIsStreaming(c.id, false);
-  assert.equal(q.getIsStreaming(c.id), false);
+  const c = q.createConversation('claude-code', 'A');
+  q.archiveConversation(c.id); assert.equal(q.getConversation(c.id).status, 'archived');
+  q.restoreConversation(c.id); assert.equal(q.getConversation(c.id).status, 'active');
+  q.setIsStreaming(c.id, true); assert.equal(q.getIsStreaming(c.id), true);
+  q.setIsStreaming(c.id, false); assert.equal(q.getIsStreaming(c.id), false);
 });
 
-section('acp-queries: createThread + getThread + patchThread', () => {
+await ok('acp-queries: thread crud + search', () => {
   const { db, prep, gid } = inMemDb();
   const q = createQueries(db, prep, gid);
   const t = q.createThread({ foo: 'bar' });
-  assert.ok(t.thread_id);
-  const got = q.getThread(t.thread_id);
-  assert.deepEqual(got.metadata, { foo: 'bar' });
-  const patched = q.patchThread(t.thread_id, { metadata: { foo: 'baz' }, status: 'active' });
-  assert.equal(patched.status, 'active');
+  assert.deepEqual(q.getThread(t.thread_id).metadata, { foo: 'bar' });
+  q.patchThread(t.thread_id, { metadata: { foo: 'baz' }, status: 'active' });
   assert.deepEqual(q.getThread(t.thread_id).metadata, { foo: 'baz' });
-});
-
-section('acp-queries: searchThreads parameterized', () => {
-  const { db, prep, gid } = inMemDb();
-  const q = createQueries(db, prep, gid);
-  q.createThread({ kind: 'a' });
   q.createThread({ kind: 'b' });
-  const r = q.searchThreads({});
-  assert.equal(r.total, 2);
-  assert.equal(r.threads.length, 2);
+  assert.equal(q.searchThreads({}).total, 2);
 });
 
-section('WsRouter: dispatch registered method', async () => {
+await ok('WsRouter: dispatch + 404 + error + legacy', async () => {
   const router = new WsRouter();
   router.handle('ping', async (p) => ({ pong: p.n }));
+  router.handle('boom', async () => { throw Object.assign(new Error('kaboom'), { code: 422 }); });
+  let legacy = null;
+  router.onLegacy((m) => { legacy = m; });
   const replies = [];
-  const ws = { readyState: 1, send: (buf) => replies.push(decode(buf)), clientId: 'c1' };
+  const ws = { readyState: 1, send: (b) => replies.push(decode(b)), clientId: 'c' };
   await router.onMessage(ws, encode({ r: 1, m: 'ping', p: { n: 7 } }));
-  assert.deepEqual(replies[0], { r: 1, d: { pong: 7 } });
-});
-
-section('WsRouter: unknown method replies 404', async () => {
-  const router = new WsRouter();
-  const replies = [];
-  const ws = { readyState: 1, send: (buf) => replies.push(decode(buf)), clientId: 'c' };
   await router.onMessage(ws, encode({ r: 2, m: 'nope', p: {} }));
-  assert.equal(replies[0].r, 2);
-  assert.equal(replies[0].e.c, 404);
-});
-
-section('WsRouter: handler exception becomes error reply', async () => {
-  const router = new WsRouter();
-  router.handle('boom', async () => { throw Object.assign(new Error('kaboom'), { code: 422 }); });
-  const replies = [];
-  const ws = { readyState: 1, send: (buf) => replies.push(decode(buf)), clientId: 'c' };
   await router.onMessage(ws, encode({ r: 3, m: 'boom', p: {} }));
-  assert.equal(replies[0].e.c, 422);
-  assert.equal(replies[0].e.m, 'kaboom');
-});
-
-section('WsRouter: legacy handler called for non-RPC messages', async () => {
-  const router = new WsRouter();
-  let seen = null;
-  router.onLegacy((msg) => { seen = msg; });
-  const ws = { readyState: 1, send: () => {}, clientId: 'c' };
   await router.onMessage(ws, encode({ type: 'subscribe', id: 'x' }));
-  assert.equal(seen.type, 'subscribe');
-});
-
-section('tool-install-machine: actors map exposed', () => {
-  const actors = toolInstallMachine.getMachineActors();
-  assert.ok(actors instanceof Map);
-});
-
-section('execution-machine: snapshot returns null for unknown id', () => {
-  assert.equal(execMachine.snapshot('nonexistent-conv-id'), null);
-});
-
-section('acp-server-machine: lifecycle transitions', () => {
-  const actor = acpServerMachine.getOrCreate('test-tool');
-  assert.equal(actor.getSnapshot().value, 'stopped');
-  acpServerMachine.send('test-tool', { type: 'START', pid: 123 });
-  assert.equal(acpServerMachine.get('test-tool').getSnapshot().value, 'starting');
-  acpServerMachine.send('test-tool', { type: 'HEALTHY', providerInfo: { ok: true } });
-  assert.equal(acpServerMachine.isHealthy('test-tool'), true);
-  acpServerMachine.stopAll();
+  assert.deepEqual(replies[0], { r: 1, d: { pong: 7 } });
+  assert.equal(replies[1].e.c, 404);
+  assert.equal(replies[2].e.c, 422);
+  assert.equal(legacy.type, 'subscribe');
 });
 
-section('acp-server-machine: getMachineActors returns Map', () => {
-  const actors = acpServerMachine.getMachineActors();
-  assert.ok(actors instanceof Map);
+await ok('machines: tool-install + execution + acp-server lifecycle', () => {
+  assert.ok(tim.getMachineActors() instanceof Map);
+  assert.equal(exm.snapshot('nonexistent-conv-id'), null);
+  assert.equal(asm.getOrCreate('test-tool').getSnapshot().value, 'stopped');
+  asm.send('test-tool', { type: 'START', pid: 123 });
+  assert.equal(asm.get('test-tool').getSnapshot().value, 'starting');
+  asm.send('test-tool', { type: 'HEALTHY', providerInfo: { ok: true } });
+  assert.equal(asm.isHealthy('test-tool'), true);
+  asm.stopAll();
 });
 
-section('workflow-plugin: deps only list active plugins', async () => {
+await ok('workflow-plugin + agent-registry hermes', async () => {
   const wp = await import('./lib/plugins/workflow-plugin.js');
   assert.deepEqual(wp.default.dependencies, ['database']);
-  assert.equal(typeof wp.default.init, 'function');
-});
-
-section('agent-registry: hermes registered as stdio ACP', async () => {
   const { registry } = await import('./lib/claude-runner-agents.js');
-  assert.ok(registry.has('hermes'));
   const h = registry.get('hermes');
-  assert.equal(h.name, 'Hermes Agent');
-  assert.equal(h.command, 'hermes');
   assert.equal(h.protocol, 'acp');
   assert.deepEqual(h.buildArgs(), ['acp']);
-  assert.ok(h.supportedFeatures.includes('acp-protocol'));
 });
 
-section('delete-all: soft-deletes conv rows + wipes related data', () => {
+await ok('delete-all: soft-deletes + wipes related', () => {
   const { db, prep, gid } = inMemDb();
   const q = createQueries(db, prep, gid);
   const c1 = q.createConversation('claude-code', 'A');
@@ -190,9 +124,77 @@ section('delete-all: soft-deletes conv rows + wipes related data', () => {
   const rows = db.prepare('SELECT status, count(*) as c FROM conversations GROUP BY status').all();
   assert.deepEqual(rows, [{ status: 'deleted', c: 2 }]);
   assert.equal(db.prepare('SELECT count(*) as c FROM messages').get().c, 0);
-  assert.equal(db.prepare('SELECT count(*) as c FROM sessions').get().c, 0);
   assert.equal(q.getConversationsList().length, 0);
 });
 
+await ok('provider-config: maskKey + buildSystemPrompt', () => {
+  assert.equal(maskKey(''), '****');
+  assert.equal(maskKey('short'), '****');
+  assert.equal(maskKey('sk-abcd1234efgh'), '****efgh');
+  assert.equal(buildSystemPrompt('claude-code'), '');
+  assert.equal(buildSystemPrompt('opencode', 'sonnet'), 'Use opencode subagent for all tasks. Model: sonnet.');
+  assert.equal(buildSystemPrompt('foo-·-bar', null, 'sub'), 'Use foo subagent for all tasks. Subagent: sub.');
+});
+
+await ok('oauth-common: state codec + url helpers', () => {
+  const enc = encodeOAuthState('csrf-tok', 'https://relay.test/cb');
+  const dec = decodeOAuthState(enc);
+  assert.equal(dec.csrfToken, 'csrf-tok');
+  assert.equal(dec.relayUrl, 'https://relay.test/cb');
+  const fallback = decodeOAuthState('not-base64-json');
+  assert.equal(fallback.csrfToken, 'not-base64-json');
+  assert.equal(fallback.relayUrl, null);
+  const reqRemote = { headers: { 'x-forwarded-host': 'a.com', 'x-forwarded-proto': 'https' }, socket: {} };
+  assert.equal(buildBaseUrl(reqRemote, 3000), 'https://a.com');
+  assert.equal(isRemoteRequest(reqRemote), true);
+  assert.equal(buildBaseUrl({ headers: {}, socket: {} }, 3000), 'http://127.0.0.1:3000');
+  assert.equal(isRemoteRequest({ headers: {} }), false);
+});
+
+await ok('tool-version-check: compareVersions', () => {
+  assert.equal(compareVersions('1.0.0', '1.0.1'), true);
+  assert.equal(compareVersions('1.0.1', '1.0.0'), false);
+  assert.equal(compareVersions('1.0.0', '1.0.0'), false);
+  assert.equal(compareVersions('1.2', '1.2.1'), true);
+  assert.equal(compareVersions('2.0.0', '1.99.99'), false);
+  assert.equal(compareVersions(null, '1.0.0'), false);
+  assert.equal(compareVersions('1.0.0', null), false);
+});
+
+await ok('agent-descriptors: initialize + cache', () => {
+  const n = initializeDescriptors([{ id: 'claude-code', name: 'Claude Code', path: '/x' }]);
+  assert.equal(n, 1);
+  const d = getAgentDescriptor('claude-code');
+  assert.equal(d.metadata.ref.name, 'Claude Code');
+  assert.ok(d.specs.input.properties.model);
+  assert.ok(d.specs.thread_state.properties.sessionId);
+  assert.equal(getAgentDescriptor('nope'), null);
+});
+
+await ok('ws-optimizer: high-priority flushes immediately', () => {
+  const opt = new WSOptimizer();
+  const sent = [];
+  const ws = { readyState: 1, clientId: 'c1', send: (b) => sent.push(decode(b)) };
+  opt.sendToClient(ws, { type: 'streaming_start', id: 1 });
+  assert.equal(sent.length, 1);
+  assert.equal(sent[0].type, 'streaming_start');
+  opt.removeClient(ws);
+  assert.equal(opt.getStats().clients, 0);
+});
+
+await ok('ws-optimizer: low-priority batches via timer', async () => {
+  const opt = new WSOptimizer();
+  const sent = [];
+  const ws = { readyState: 1, clientId: 'c2', latencyTier: 'excellent', send: (b) => sent.push(decode(b)) };
+  opt.sendToClient(ws, { type: 'tts_audio', n: 1 });
+  opt.sendToClient(ws, { type: 'tts_audio', n: 2 });
+  assert.equal(sent.length, 0);
+  await new Promise(r => setTimeout(r, 40));
+  assert.equal(sent.length, 1);
+  assert.equal(sent[0].length, 2);
+  opt.removeClient(ws);
+});
+
 console.log(`\n${passed} passed, ${failed} failed`);
 process.exit(failed === 0 ? 0 : 1);
+}; run();