agentgui 1.0.880 → 1.0.882

package/CHANGELOG.md

@@ -1,3 +1,14 @@
+## [Unreleased] - Clear All now soft-deletes conv rows to suppress auto-import
+
+- `deleteAllConversations` was hard-deleting rows from the conversations table. Auto-import's skip check relies on `existingConv.status === 'deleted'` — after hard delete, existingConv is null, so the JSONL scanner re-imports everything the next poll. Visible symptom: Clear All appears to work, then the same conversations reappear.
+- Fix: use `UPDATE conversations SET status='deleted'` (match individual `deleteConversation` behavior). Related data (chunks/events/sessions/messages/voice_cache/stream_updates) is still hard-deleted, and the JSONL project files are still wiped from `~/.claude/projects/`.
+- Verified both paths end-to-end: HTTP `DELETE /api/conversations/:id` and WS `conv.del.all`. Added regression case in test.js.
+
+## [Unreleased] - fix stuck "live" indicators on conversations sidebar
+
+- Symptom: conversations show streaming dot in sidebar even when no agent is running. Root cause: `routes-conversations.js GET /api/conversations` reconcile required BOTH `!activeExecutions.has(conv.id)` AND `!activeSessionConvIds.has(conv.id)` to clear `isStreaming`. If a session crashed hard (server killed mid-stream, agent process killed without finally running), the session row stayed at `status='active'` forever, keeping the sidebar live indicator on indefinitely until next server restart triggered `recoverStaleSessions`.
+- Fix: trust `activeExecutions` map as ground truth. If `isStreaming=1` but no in-memory execution, set `isStreaming=0` AND mark any orphan 'active'/'pending' session for that conv as 'interrupted'. Self-heals on every list fetch — no restart needed.
+
 ## [Unreleased] - surface stream chunk persistence errors
 
 - lib/stream-event-handler.js: `queries.createChunk` failures were swallowed silently in the ACP streaming path. User would see live broadcast events but reload would lose all chunks. Now logs error with conv id, seq, block type for observability.

package/lib/db-queries-del.js

@@ -110,7 +110,7 @@ export function addDeleteQueries(q, db, prep, generateId) {
         prep('DELETE FROM voice_cache').run();
         prep('DELETE FROM sessions').run();
         prep('DELETE FROM messages').run();
-        prep('DELETE FROM conversations').run();
+        prep("UPDATE conversations SET status = 'deleted', updated_at = ? WHERE status != 'deleted'").run(Date.now());
       });
 
       deleteAllStmt();

package/lib/routes-conversations.js

@@ -9,9 +9,18 @@ export function register(deps) {
 
   routes['GET /api/conversations'] = async (req, res) => {
     const conversations = queries.getConversationsList();
-    const activeSessionConvIds = new Set(queries.getActiveSessionConversationIds());
     for (const conv of conversations) {
-      if (conv.isStreaming && !activeExecutions.has(conv.id) && !activeSessionConvIds.has(conv.id)) conv.isStreaming = 0;
+      if (conv.isStreaming && !activeExecutions.has(conv.id)) {
+        conv.isStreaming = 0;
+        try {
+          queries.setIsStreaming(conv.id, false);
+          for (const s of queries.getSessionsByConversation(conv.id, 5)) {
+            if (s.status === 'active' || s.status === 'pending') {
+              queries.updateSession(s.id, { status: 'interrupted', error: 'Reconciled: no active execution', completed_at: Date.now() });
+            }
+          }
+        } catch (err) { console.error(`[conv-list-reconcile] ${conv.id}:`, err.message); }
+      }
     }
     sendJSON(req, res, 200, { conversations });
   };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.880",
+  "version": "1.0.882",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/test.js

@@ -178,5 +178,21 @@ section('agent-registry: hermes registered as stdio ACP', async () => {
   assert.ok(h.supportedFeatures.includes('acp-protocol'));
 });
 
+section('delete-all: soft-deletes conv rows + wipes related data', () => {
+  const { db, prep, gid } = inMemDb();
+  const q = createQueries(db, prep, gid);
+  const c1 = q.createConversation('claude-code', 'A');
+  q.createConversation('claude-code', 'B');
+  q.createSession(c1.id);
+  q.createMessage(c1.id, 'user', 'hello');
+  const origLog = console.log; console.log = () => {};
+  try { q.deleteAllConversations(); } finally { console.log = origLog; }
+  const rows = db.prepare('SELECT status, count(*) as c FROM conversations GROUP BY status').all();
+  assert.deepEqual(rows, [{ status: 'deleted', c: 2 }]);
+  assert.equal(db.prepare('SELECT count(*) as c FROM messages').get().c, 0);
+  assert.equal(db.prepare('SELECT count(*) as c FROM sessions').get().c, 0);
+  assert.equal(q.getConversationsList().length, 0);
+});
+
 console.log(`\n${passed} passed, ${failed} failed`);
 process.exit(failed === 0 ? 0 : 1);