agentgui 1.0.868 → 1.0.870

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [Unreleased] - GUI observability + workflow-plugin fix
+
+- Fix regression from prior commit: workflow-plugin.js declared `dependencies: ['git','database']` but git plugin was deleted; plugin init failed with "Plugin git not found in registry". Removed unused git dep and stale binding.
+- Consolidate client debug registry: `window.__debug` now exposes structured sub-keys (`machines.{conv,toolInstall,voice,convList,prompt,recording,terminal,ws}`, `ws`, `auth`, `perf`, `config`, `renderer`, `conv`) via live getters that snapshot scattered `window.__*` machines into a single queryable tree. Existing `getState`/`getSyncState`/`getMessageState` methods preserved.
+- Null-safe snapshot helpers: uninitialized machines return `'uninitialized'` instead of crashing.
+- test.js: add regression case for workflow-plugin deps (17/17 pass).
+
 ## [Unreleased] - observability + dead-code sweep + root test suite
 
 - Expose acp-server-machine snapshots in /api/debug/machines (previously only tool-install + execution machines)

package/CLAUDE.md

@@ -368,3 +368,15 @@ The README.md uses shields.io badges with a consistent pattern:
 - **`JsonlWatcher._read(fp)` override:** Captures `this._currentFp` before calling `super._read(fp)`, making the file path available to `_line()` callbacks for project-directory decoding in `_conv()`. JSONL project dirs are encoded (e.g., `-config-workspace-agentgui`) — decoded via `'/' + dirName.slice(1).replace(/-/g, '/')`.
 - **`createHttpHandler` uses `getWss: () => wss` (lazy getter):** Passing `wss` directly would crash with TDZ since `wss` is declared after `createHttpHandler` is called. The function form defers access until request time when `wss` is initialized.
 - **`_promptPushIfWeOwnRemote` fires after every `streaming_complete`:** `client-streaming4.js` calls `git.check` on the server after each agent turn. If `ownsRemote && (hasChanges || hasUnpushed)`, it auto-sends "Push the changes to the remote repository." to the current conversation. `ownsRemote` is true for non-github remotes, and for github.com remotes only when `GITHUB_USER` env var is set and appears in the URL. Without `GITHUB_USER`, github.com remotes return `ownsRemote=false` (safe default).
+
+## Critical Knowledge for Future Sessions
+
+**Codebase Insight Stale:** `.codeinsight` snapshot is outdated (v1.0.811 claimed server.js=3407L, db-queries.js=1412L, but actual as of 2026-04-17: server.js=201L, db-queries.js=94L). Heavy refactoring already done. Before acting on insight "issues" (SQL injection claims, hardcoded secrets, large files), always verify with grep/read against current state. Most reported issues are false positives or stale.
+
+**Test Harness Pattern:** Use better-sqlite3 in-memory Database, call `initSchema()` → `migrateConversationColumns()` → `migrateACPSchema()` in order (conversations table needs agentType column from second migration). `createQueries` signature: `(db, prep, generateId)` where `prep=(sql)=>db.prepare(sql)`. Silence console during schema init to keep test output clean. Node ships with better-sqlite3 available (optional dep resolved).
+
+**CI Auto-Rewrites History:** Every push to main triggers Auto-Declaudeify workflow that filters Claude coauthor commits and force-pushes filtered history. After a push, `git fetch origin` is needed — local SHA drifts from origin SHA.
+
+**Debug Endpoints Scattered:** Routes at `/api/debug`, `/api/debug/machines`, `/api/debug/state`, `/api/ws-stats`, `/api/debug/ws-stats` (alias). `routes-debug.js` wires all five + backup/restore. DEBUG API in browser: `window.__debug.getSyncState()`.
+
+**Plugin Files NOT Orphans:** lib/plugins/* are dynamically loaded via `lib/plugin-loader.js` (import with file:// URL + cache-busting `?v=` timestamp). Only truly dead plugin was `lib/plugins/git-plugin.js`. Static scan showing orphans is misleading.

package/lib/plugins/workflow-plugin.js

@@ -1,18 +1,14 @@
-// Workflow plugin - git push detection, workflow execution, status polling
-
 import fs from 'fs';
 import path from 'path';
 
 export default {
   name: 'workflow',
   version: '1.0.0',
-  dependencies: ['git', 'database'],
+  dependencies: ['database'],
 
   async init(config, plugins) {
-    const git = plugins.get('git');
-    const db = plugins.get('database');
+    plugins.get('database');
     const workflowPolls = new Map();
-    const runCache = new Map();
 
     const getWorkflows = () => {
       const repoRoot = process.cwd();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.868",
+  "version": "1.0.870",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/static/js/client-helpers.js

@@ -112,36 +112,71 @@ Object.assign(AgentGUIClient.prototype, {
   _setupDebugHooks() {
     if (typeof window === 'undefined') return;
     const self = this;
-    window.__debug = {
+    const snap = (actor) => (actor && actor.getSnapshot) ? actor.getSnapshot().value : 'uninitialized';
+    const mapSnap = (m) => m ? Object.fromEntries([...m].map(([k, a]) => [k, snap(a)])) : {};
+    const registry = {
       getState: () => ({
         latencyEma: self.wsManager?._latencyEma || null,
         serverProcessingEstimate: self._serverProcessingEstimate,
         latencyTrend: self.wsManager?.latency?.trend || null
       }),
-
       getSyncState: () => ({
         currentConversation: self.state.currentConversation,
         isStreaming: self._convIsStreaming(self.state.currentConversation?.id),
         streamingConversations: Array.from(self.state.streamingConversations),
-        convMachineStates: typeof convMachineAPI !== 'undefined' ? Object.fromEntries([...window.__convMachines].map(([k, a]) => [k, a.getSnapshot().value])) : {},
-        toolInstallMachineStates: typeof window.__toolInstallMachines !== 'undefined' ? Object.fromEntries([...window.__toolInstallMachines].map(([k, a]) => [k, a.getSnapshot().value])) : {},
-        voiceMachineState: typeof window.__voiceMachine !== 'undefined' ? window.__voiceMachine.getSnapshot().value : 'unknown',
-        convListMachineState: typeof window.__convListMachine !== 'undefined' ? window.__convListMachine.getSnapshot().value : 'unknown',
-        promptMachineState: typeof window.__promptMachine !== 'undefined' ? window.__promptMachine.getSnapshot().value : 'unknown',
-        wsConnectionState: self.wsManager?._wsActor?.getSnapshot().value || 'unknown',
+        convMachineStates: mapSnap(window.__convMachines),
+        toolInstallMachineStates: mapSnap(window.__toolInstallMachines),
+        voiceMachineState: snap(window.__voiceMachine),
+        convListMachineState: snap(window.__convListMachine),
+        promptMachineState: snap(window.__promptMachine),
+        wsConnectionState: snap(self.wsManager?._wsActor),
         rendererEventQueueLength: self.renderer?.eventQueue?.length || 0,
         rendererEventHistoryLength: self.renderer?.eventHistory?.length || 0,
       }),
-
       getMessageState: () => {
         const output = document.querySelector('.conversation-messages');
         if (!output) return { error: 'No conversation output found' };
-        const messageCount = output.querySelectorAll('.message').length;
-        const queueItems = output.querySelectorAll('.queue-item').length;
-        const pendingMessages = output.querySelectorAll('.message-sending').length;
-        return { messageCount, queueItems, pendingMessages };
+        return {
+          messageCount: output.querySelectorAll('.message').length,
+          queueItems: output.querySelectorAll('.queue-item').length,
+          pendingMessages: output.querySelectorAll('.message-sending').length,
+        };
       }
     };
+    const subkeys = {
+      machines: () => ({
+        conv: mapSnap(window.__convMachines),
+        toolInstall: mapSnap(window.__toolInstallMachines),
+        voice: snap(window.__voiceMachine),
+        convList: snap(window.__convListMachine),
+        prompt: snap(window.__promptMachine),
+        recording: snap(window.__recordingMachine),
+        terminal: snap(window.__terminalMachine),
+        ws: snap(self.wsManager?._wsActor),
+      }),
+      ws: () => ({
+        state: snap(self.wsManager?._wsActor),
+        latencyEma: self.wsManager?._latencyEma || null,
+        latencyTrend: self.wsManager?.latency?.trend || null,
+        url: window.__WS || null,
+      }),
+      auth: () => ({
+        state: window.__agentAuthState || null,
+        oauth: window.__agentAuthOAuth || null,
+      }),
+      perf: () => window.__convPerfMetrics || null,
+      config: () => ({ base: window.__BASE || null, server: window.__SERVER || null }),
+      renderer: () => ({
+        eventQueueLength: self.renderer?.eventQueue?.length || 0,
+        eventHistoryLength: self.renderer?.eventHistory?.length || 0,
+      }),
+      conv: () => ({
+        current: self.state.currentConversation,
+        streaming: Array.from(self.state.streamingConversations),
+      }),
+    };
+    for (const [k, fn] of Object.entries(subkeys)) Object.defineProperty(registry, k, { get: fn, enumerable: true });
+    window.__debug = registry;
   },
 
 

package/test.js

@@ -161,5 +161,11 @@ section('acp-server-machine: getMachineActors returns Map', () => {
   assert.ok(actors instanceof Map);
 });
 
+section('workflow-plugin: deps only list active plugins', async () => {
+  const wp = await import('./lib/plugins/workflow-plugin.js');
+  assert.deepEqual(wp.default.dependencies, ['database']);
+  assert.equal(typeof wp.default.init, 'function');
+});
+
 console.log(`\n${passed} passed, ${failed} failed`);
 process.exit(failed === 0 ? 0 : 1);