agentgui 1.0.1126 → 1.0.1127

package/lib/ws-handlers/git.js

@@ -1,159 +0,0 @@
-import os from 'os';
-import fs from 'fs';
-import path from 'path';
-import { execSync, execFileSync } from 'child_process';
-import { err, execFileP, resolveGitCwd, assertSafeRelPath, assertSafeBranch } from './shared.js';
-
-export function register(router, deps) {
-  const { STARTUP_CWD } = deps;
-
-  router.handle('clone', (p) => {
-    const repo = (p.repo || '').trim();
-    if (!repo || !/^[a-zA-Z0-9_.-]+\/[a-zA-Z0-9_.-]+$/.test(repo)) {
-      err(400, 'Invalid repo format. Use org/repo or user/repo');
-    }
-    const cloneDir = STARTUP_CWD || os.homedir();
-    const repoName = repo.split('/')[1];
-    const targetPath = path.join(cloneDir, repoName);
-    if (fs.existsSync(targetPath)) err(409, `Directory already exists: ${repoName}`);
-    try {
-      execFileSync('git', ['clone', 'https://github.com/' + repo + '.git'], {
-        cwd: cloneDir, encoding: 'utf-8', timeout: 120000,
-        stdio: ['pipe', 'pipe', 'pipe'],
-        env: { ...process.env, GIT_TERMINAL_PROMPT: '0' },
-      });
-      return { ok: true, repo, path: targetPath, name: repoName };
-    } catch (e) { err(500, (e.stderr || e.message || 'Clone failed').trim()); }
-  });
-
-  router.handle('git.check', () => {
-    try {
-      const isWindows = os.platform() === 'win32';
-      const devnull = isWindows ? '' : ' 2>/dev/null';
-      const remoteUrl = execSync('git remote get-url origin' + devnull, { encoding: 'utf-8', cwd: STARTUP_CWD, shell: isWindows }).trim();
-      const statusResult = execSync('git status --porcelain' + devnull, { encoding: 'utf-8', cwd: STARTUP_CWD, shell: isWindows });
-      const hasChanges = statusResult.trim().length > 0;
-      const unpushedResult = execSync('git rev-list --count --not --remotes' + devnull, { encoding: 'utf-8', cwd: STARTUP_CWD, shell: isWindows });
-      const hasUnpushed = parseInt(unpushedResult.trim() || '0', 10) > 0;
-      const githubUser = process.env.GITHUB_USER;
-      const ownsRemote = !remoteUrl.includes('github.com/') || (!!githubUser && remoteUrl.includes(githubUser));
-      return { ownsRemote, hasChanges, hasUnpushed, remoteUrl };
-    } catch {
-      return { ownsRemote: false, hasChanges: false, hasUnpushed: false, remoteUrl: '' };
-    }
-  });
-
-  router.handle('git.push', (p) => {
-    if (!p?.confirm) err(400, 'confirm required: git.push commits and pushes the entire working tree');
-    try {
-      const isWindows = os.platform() === 'win32';
-      const cmd = isWindows
-        ? 'git add -A & git commit -m "Auto-commit" & git push'
-        : 'git add -A && git commit -m "Auto-commit" && git push';
-      execSync(cmd, { encoding: 'utf-8', cwd: STARTUP_CWD, shell: isWindows });
-      return { success: true };
-    } catch (e) { err(500, e.message); }
-  });
-
-  // --- git.status: changed-file list (staged/unstaged/untracked) for
-  // GitStatusPanel. Porcelain=v1 line format "XY PATH" (rename: "XY OLD -> NEW"),
-  // X = index state, Y = worktree state, '?'/' ' = untouched/untracked.
-  router.handle('git.status', async (p) => {
-    const cwd = resolveGitCwd(p, STARTUP_CWD);
-    try {
-      const { stdout } = await execFileP('git', ['status', '--porcelain=v1'], { cwd });
-      const files = [];
-      for (const line of stdout.split('\n')) {
-        if (!line) continue;
-        const x = line[0], y = line[1];
-        const filePath = line.slice(3);
-        if (x === '?' && y === '?') { files.push({ path: filePath, status: '?' }); continue; }
-        if (x !== ' ' && x !== '?') files.push({ path: filePath, status: x, staged: true });
-        else if (y !== ' ' && y !== '?') files.push({ path: filePath, status: y, staged: false });
-      }
-      return { files };
-    } catch (e) { err(500, (e.stderr || e.message || 'git status failed').trim()); }
-  });
-
-  // --- git.diff: unified diff for a single file or the whole working tree.
-  // p.cwd (optional) is confined via confineToRoots/fsAllowRoots, same as
-  // chat.sendMessage; p.file (optional) is validated to reject flags/shell
-  // metacharacters. execFile array-args form only, never a shell string.
-  router.handle('git.diff', async (p) => {
-    const cwd = resolveGitCwd(p, STARTUP_CWD);
-    const args = ['diff', '--no-color'];
-    if (p?.staged) args.push('--staged');
-    if (p?.file) args.push('--', assertSafeRelPath(p.file, 'file'));
-    try {
-      const { stdout } = await execFileP('git', args, { cwd });
-      // git prints "Binary files a/x and b/x differ" for binary paths instead
-      // of a unified diff - an empty `diff` string then reads to the client as
-      // "no diff to show" with no explanation. Detect it so the UI can say why.
-      const binary = /^Binary files .* differ$/m.test(stdout);
-      return { diff: stdout, binary, file: p?.file || null, staged: !!p?.staged };
-    } catch (e) { err(500, (e.stderr || e.message || 'git diff failed').trim()); }
-  });
-
-  // --- git.log: recent commit list, limit param (default 20, capped 200).
-  router.handle('git.log', async (p) => {
-    const cwd = resolveGitCwd(p, STARTUP_CWD);
-    const limit = Math.max(1, Math.min(200, parseInt(p?.limit, 10) || 20));
-    const FIELD_SEP = '\x1f';
-    const REC_SEP = '\x1e';
-    const args = ['log', `-n${limit}`, `--pretty=format:%H${FIELD_SEP}%an${FIELD_SEP}%ad${FIELD_SEP}%s${REC_SEP}`, '--date=iso-strict'];
-    try {
-      const { stdout } = await execFileP('git', args, { cwd });
-      const commits = stdout.split(REC_SEP).map(s => s.trim()).filter(Boolean).map(rec => {
-        const [hash, author, date, ...rest] = rec.split(FIELD_SEP);
-        return { hash, author, date, subject: rest.join(FIELD_SEP) };
-      });
-      return { commits };
-    } catch (e) { err(500, (e.stderr || e.message || 'git log failed').trim()); }
-  });
-
-  // --- worktree.list / create / remove ---
-  router.handle('worktree.list', async (p) => {
-    const cwd = resolveGitCwd(p, STARTUP_CWD);
-    try {
-      const { stdout } = await execFileP('git', ['worktree', 'list', '--porcelain'], { cwd });
-      // Parse the porcelain block format: records separated by blank lines,
-      // each line "key value" or a bare flag ("bare", "detached", "locked").
-      const worktrees = [];
-      let cur = null;
-      for (const line of stdout.split('\n')) {
-        if (!line.trim()) { if (cur) { worktrees.push(cur); cur = null; } continue; }
-        if (!cur) cur = {};
-        const sp = line.indexOf(' ');
-        if (sp === -1) { cur[line] = true; continue; }
-        cur[line.slice(0, sp)] = line.slice(sp + 1);
-      }
-      if (cur) worktrees.push(cur);
-      return { worktrees: worktrees.map(w => ({ path: w.worktree || null, head: w.HEAD || null, branch: w.branch || null, bare: !!w.bare, detached: !!w.detached, locked: !!w.locked })) };
-    } catch (e) { err(500, (e.stderr || e.message || 'git worktree list failed').trim()); }
-  });
-
-  router.handle('worktree.create', async (p) => {
-    const cwd = resolveGitCwd(p, STARTUP_CWD);
-    const wtPath = assertSafeRelPath(p?.path, 'path');
-    const args = ['worktree', 'add'];
-    if (p?.newBranch) { args.push('-b', assertSafeBranch(p.newBranch, 'newBranch')); }
-    args.push(wtPath);
-    if (p?.branch) args.push(assertSafeBranch(p.branch, 'branch'));
-    try {
-      const { stdout, stderr } = await execFileP('git', args, { cwd });
-      return { ok: true, output: (stdout || stderr || '').trim(), path: wtPath };
-    } catch (e) { err(500, (e.stderr || e.message || 'git worktree add failed').trim()); }
-  });
-
-  router.handle('worktree.remove', async (p) => {
-    const cwd = resolveGitCwd(p, STARTUP_CWD);
-    const wtPath = assertSafeRelPath(p?.path, 'path');
-    const args = ['worktree', 'remove'];
-    if (p?.force) args.push('--force');
-    args.push(wtPath);
-    try {
-      const { stdout, stderr } = await execFileP('git', args, { cwd });
-      return { ok: true, output: (stdout || stderr || '').trim() };
-    } catch (e) { err(500, (e.stderr || e.message || 'git worktree remove failed').trim()); }
-  });
-}

package/lib/ws-handlers/misc.js

@@ -1,36 +0,0 @@
-import fs from 'fs';
-import os from 'os';
-import path from 'path';
-import { err } from './shared.js';
-
-export function register(router, deps) {
-  const { queries, wsOptimizer, getProviderConfigs, saveProviderConfig, STARTUP_CWD } = deps;
-
-  router.handle('home', () => ({ home: os.homedir(), cwd: STARTUP_CWD }));
-
-  router.handle('folders', (p) => {
-    const folderPath = p.path || STARTUP_CWD;
-    try {
-      const raw = folderPath.startsWith('~') ? folderPath.replace('~', os.homedir()) : folderPath;
-      const entries = fs.readdirSync(path.resolve(raw), { withFileTypes: true });
-      return { folders: entries.filter(e => e.isDirectory() && !e.name.startsWith('.')).map(e => ({ name: e.name })).sort((a, b) => a.name.localeCompare(b.name)) };
-    } catch (e) { err(400, e.message); }
-  });
-
-  router.handle('auth.configs', () => getProviderConfigs());
-
-  router.handle('auth.save', (p) => {
-    const { providerId, apiKey, defaultModel } = p;
-    if (typeof providerId !== 'string' || !providerId.length || providerId.length > 100) err(400, 'Invalid providerId');
-    if (typeof apiKey !== 'string' || !apiKey.length || apiKey.length > 10000) err(400, 'Invalid apiKey');
-    if (defaultModel !== undefined && (typeof defaultModel !== 'string' || defaultModel.length > 200)) err(400, 'Invalid defaultModel');
-    const configPath = saveProviderConfig(providerId, apiKey, defaultModel || '');
-    return { success: true, path: configPath };
-  });
-
-  router.handle('import.claude', () => ({ imported: queries.importClaudeCodeConversations() }));
-
-  router.handle('discover.claude', () => ({ discovered: queries.discoverClaudeCodeConversations() }));
-
-  router.handle('ws.stats', () => wsOptimizer.getStats());
-}

package/lib/ws-handlers/shared.js

@@ -1,47 +0,0 @@
-import { execFile } from 'child_process';
-import { confineToRoots, fsAllowRoots } from '../http-handler.js';
-
-export function err(code, message) { const e = new Error(message); e.code = code; throw e; }
-
-// Promisified execFile — array-args form only, never a shell string, so a
-// crafted branch/path/file value cannot be interpreted as a shell command.
-export function execFileP(cmd, args, opts) {
-  return new Promise((resolve, reject) => {
-    execFile(cmd, args, { encoding: 'utf-8', timeout: 30000, maxBuffer: 20 * 1024 * 1024, ...opts }, (e, stdout, stderr) => {
-      if (e) { e.stdout = stdout; e.stderr = stderr; reject(e); return; }
-      resolve({ stdout, stderr });
-    });
-  });
-}
-
-// Resolve + confine a client-supplied cwd to the same allowlist the file
-// explorer / chat.sendMessage use (fsAllowRoots via confineToRoots). Falls
-// back to STARTUP_CWD (itself an allowed root) when no cwd is given.
-export function resolveGitCwd(p, STARTUP_CWD) {
-  if (!p?.cwd) return STARTUP_CWD;
-  const conf = confineToRoots(p.cwd, fsAllowRoots());
-  if (!conf.ok) err(conf.reason === 'not found' ? 400 : 403, `cwd outside allowed roots: ${p.cwd}`);
-  return conf.realPath;
-}
-
-// A relative in-repo file path: no leading '-' (flag injection), no shell
-// metacharacters, no absolute path (git resolves it relative to cwd already).
-const SAFE_REL_PATH_RE = /^[^\0]{1,4096}$/;
-export function assertSafeRelPath(v, label) {
-  if (typeof v !== 'string' || !v.length) err(400, `${label} required`);
-  if (v.startsWith('-')) err(400, `${label} must not start with '-'`);
-  if (/[\0]/.test(v)) err(400, `${label} contains invalid characters`);
-  if (!SAFE_REL_PATH_RE.test(v)) err(400, `${label} invalid`);
-  return v;
-}
-
-// A git branch/ref name — conservative allowlist (git's own ref-format is
-// more permissive, but this blocks every shell-metacharacter and flag-
-// injection vector while still covering normal branch names).
-const SAFE_BRANCH_RE = /^[A-Za-z0-9][A-Za-z0-9_.\/-]{0,199}$/;
-export function assertSafeBranch(v, label) {
-  if (typeof v !== 'string' || !v.length) err(400, `${label} required`);
-  if (v.startsWith('-') || v.includes('..') || v.includes('//')) err(400, `${label} invalid`);
-  if (!SAFE_BRANCH_RE.test(v)) err(400, `${label} invalid`);
-  return v;
-}

package/lib/ws-handlers/terminal-state.js

@@ -1,16 +0,0 @@
-// Short-lived per-session terminal-event buffer (finding 35): a turn that
-// completes/errors/cancels while a client ws is down would otherwise be a
-// fire-and-forget broadcast the client never sees, hanging it busy forever.
-// A re-subscribing client gets the buffered terminal frame replayed.
-const TERMINAL_TTL_MS = 60000;
-const terminalEvents = new Map(); // sessionId -> terminal event
-
-export function recordTerminal(sessionId, event) {
-  terminalEvents.set(sessionId, event);
-  const t = setTimeout(() => {
-    if (terminalEvents.get(sessionId) === event) terminalEvents.delete(sessionId);
-  }, TERMINAL_TTL_MS);
-  if (typeof t.unref === 'function') t.unref();
-}
-
-export function getTerminal(sessionId) { return terminalEvents.get(sessionId); }

package/site/app/js/chat-persistence.js

@@ -1,123 +0,0 @@
-export const CHAT_KEY = 'agentgui.chat';
-// Cap the persisted footprint: the last 100 messages, with any tool args/result
-// payload over 4KB truncated in the SAVED copy only (in-memory state keeps the
-// full payload). A quota failure is surfaced once instead of silently dropping
-// persistence forever.
-const PERSIST_MSG_CAP = 100;
-const PERSIST_PART_CAP = 4096;
-
-// An assistant turn with no content AND no parts is an empty shell (an aborted
-// turn that produced nothing). The view already renders it as nothing; drop it
-// from persisted/in-memory state so a restored chat never carries blank bubbles.
-function isEmptyTurn(m) {
-  return m.role === 'assistant' && !m.content && !(Array.isArray(m.parts) && m.parts.length);
-}
-
-function trimPartForStorage(p) {
-  if (!p || typeof p !== 'object') return p;
-  let out = p;
-  for (const k of ['result', 'args']) {
-    const v = out[k];
-    if (v == null) continue;
-    let s;
-    if (typeof v === 'string') s = v;
-    else { try { s = JSON.stringify(v); } catch { s = String(v); } }
-    if (s.length > PERSIST_PART_CAP) {
-      if (out === p) out = { ...p };
-      out[k] = s.slice(0, PERSIST_PART_CAP);
-      out.truncatedForStorage = true;
-    }
-  }
-  return out;
-}
-
-function computeTotalCost(state) {
-  return (state.chat.messages || []).reduce((s, m) => s + (typeof m.costUsd === 'number' ? m.costUsd : 0), 0);
-}
-
-// Factory: app.js calls this once at module load, passing the live `state`
-// object (mutated by reference, same as every other app.js concern) and the
-// shared helpers (announce/scheduleRender/lsGet/lsSet/lsRemove/debounce)
-// already defined there. Returns the same function set app.js previously
-// defined inline, wired to app.js's own state/render/announce.
-export function createChatPersistence(state, { announce, scheduleRender, lsGet, lsRemove, debounce }) {
-  let _persistFailedOnce = false;
-  let _lastPersistTs = 0;
-
-  function persistChat() {
-    try {
-      const eligible = state.chat.messages.filter(m => !isEmptyTurn(m));
-      // On-screen transcript can exceed the cap; a reload only restores the last
-      // PERSIST_MSG_CAP turns - surface that once so it's not a silent surprise,
-      // same Alert pattern as the sibling quota-failure banner below.
-      const wasCapped = eligible.length > PERSIST_MSG_CAP;
-      if (wasCapped !== !!state.chat.persistTruncated) {
-        state.chat.persistTruncated = wasCapped;
-        scheduleRender();
-      }
-      const msgs = eligible
-        .slice(-PERSIST_MSG_CAP)
-        .map(m => ({ id: m.id, role: m.role, content: m.content, time: m.time, costUsd: m.costUsd, stopped: m.stopped || undefined, parts: Array.isArray(m.parts) ? m.parts.map(trimPartForStorage) : m.parts }));
-      const draft = (state.chat.draft || '').trim() ? state.chat.draft : '';
-      // Persist when there is a transcript OR a non-empty draft (a typed-but-not-
-      // sent message must survive a reload too).
-      if (!msgs.length && !draft) { lsRemove(CHAT_KEY); return; }
-      _lastPersistTs = Date.now();
-      localStorage.setItem(CHAT_KEY, JSON.stringify({ ts: _lastPersistTs, messages: msgs, draft, resumeSid: state.chat.resumeSid, totalCost: state.chat.totalCost || 0, agent: state.selectedAgent, model: state.selectedModel }));
-    } catch {
-      if (!_persistFailedOnce) {
-        _persistFailedOnce = true;
-        state.chat.persistError = true;
-        announce('chat too large to save locally - export it from settings');
-        scheduleRender();
-      }
-    }
-  }
-
-  const debouncedPersistDraft = debounce(persistChat, 500);
-
-  // Another GUI tab rewrote the shared chat key: never silently diverge - surface
-  // a banner offering to reload the newer copy (last-writer-wins with a ts guard).
-  window.addEventListener('storage', (e) => {
-    if (e.key !== CHAT_KEY || !e.newValue) return;
-    try {
-      const remote = JSON.parse(e.newValue);
-      if (remote && remote.ts && remote.ts > _lastPersistTs) {
-        state.chat.externalUpdate = true;
-        scheduleRender();
-      }
-    } catch {}
-  });
-
-  function restoreChat() {
-    try {
-      const raw = lsGet(CHAT_KEY);
-      if (!raw) return;
-      const saved = JSON.parse(raw);
-      if (typeof saved.draft === 'string' && saved.draft.trim()) {
-        state.chat.draft = saved.draft;
-        // A restored draft is set programmatically, so Ctrl+Z has nothing in the
-        // browser's native undo history to act on - a one-time note explains why
-        // undo appears to do nothing right after a reload.
-        announce('draft restored - note: undo history does not carry over a reload');
-      }
-      if (typeof saved.totalCost === 'number') state.chat.totalCost = saved.totalCost;
-      if (Array.isArray(saved.messages) && saved.messages.length) {
-        state.chat.messages = saved.messages
-          .filter(m => !isEmptyTurn(m))
-          .map(m => ({ ...m, parts: Array.isArray(m.parts) ? m.parts : [] }));
-        // Prefer the per-message cost sum when present (it self-corrects after
-        // edit/retry truncation); the scalar is only the legacy fallback.
-        const derived = computeTotalCost(state);
-        if (derived) state.chat.totalCost = derived;
-        state.chat.resumeSid = saved.resumeSid || null;
-        // Restore the agent/model the transcript belongs to, so a restored chat
-        // isn't silently shown under whatever agent the picker defaulted to.
-        state.chat.restoredAgent = saved.agent || null;
-        state.chat.restoredModel = saved.model || null;
-      }
-    } catch {}
-  }
-
-  return { persistChat, restoreChat, debouncedPersistDraft, isEmptyTurn, computeTotalCost: () => computeTotalCost(state) };
-}

package/site/app/js/hash-routing.js

@@ -1,62 +0,0 @@
-// Hash-based deep-link state, extracted from app.js (vertical slice per
-// AGENTS.md SOLID/Clean-Architecture preferences). Full hash routing state is
-// HASH_KEYS; popstate diffs the full set, and navTo(tab,{writeHash:false})
-// navigates without pushing a new hash entry (navTo itself stays in app.js -
-// it orchestrates tab-switch side effects like reloading history/files/live
-// data, not just the hash string, so it is a broader concern than routing).
-export const HASH_KEYS = ['tab', 'sid', 'dir', 'file', 'q', 'project', 'section', 'filter', 'lsort', 'lfilter', 'lerr', 'ets'];
-
-export function readHash() {
-  const hash = location.hash || '';
-  const out = {};
-  for (const k of HASH_KEYS) {
-    const m = hash.match(new RegExp('(?:^#|&)' + k + '=([^&]*)'));
-    out[k] = m ? decodeURIComponent(m[1]) : null;
-  }
-  return out;
-}
-
-export function buildHash(state) {
-  const parts = [];
-  const tab = state.tab || 'chat';
-  // tab is omitted for the default chat tab, EXCEPT when a session id rides
-  // along - a bare #sid= historically meant history, so chat+sid must name its
-  // tab explicitly or the deep-link restores the wrong surface.
-  if (tab !== 'chat') parts.push('tab=' + encodeURIComponent(tab));
-  else if (state.selectedSid) parts.push('tab=chat');
-  // Keep sid whenever set (regardless of tab) so Back restores the selection.
-  if (state.selectedSid) parts.push('sid=' + encodeURIComponent(state.selectedSid));
-  if (tab === 'files' && state.files) {
-    if (state.files.path) parts.push('dir=' + encodeURIComponent(state.files.path));
-    if (state.files.preview && state.files.preview.path) parts.push('file=' + encodeURIComponent(state.files.preview.path));
-    if (state.files.filter) parts.push('filter=' + encodeURIComponent(state.files.filter));
-  }
-  if (tab === 'history') {
-    const q = (state.searchQ || '').trim();
-    if (q.length >= 2) parts.push('q=' + encodeURIComponent(q));
-    if (state.projectFilter) parts.push('project=' + encodeURIComponent(state.projectFilter));
-    // A session opened from a search hit carries the matched event's
-    // timestamp so reload/Back reproduces the same scrolled+flashed position
-    // a live click gives - without this, the anchor only existed in memory
-    // and a search-hit URL degraded to just the bare session on reload.
-    if (state._focusEventTs != null) parts.push('ets=' + encodeURIComponent(state._focusEventTs));
-  }
-  if (tab === 'settings' && state.settingsSection) parts.push('section=' + encodeURIComponent(state.settingsSection));
-  if (tab === 'live') {
-    const lv = state.live || {};
-    if (lv.sort && lv.sort !== 'status') parts.push('lsort=' + encodeURIComponent(lv.sort));
-    if (lv.filter) parts.push('lfilter=' + encodeURIComponent(lv.filter));
-    if (lv.errorsOnly) parts.push('lerr=1');
-  }
-  return parts.length ? '#' + parts.join('&') : '';
-}
-
-export function writeHash(state, { push = false } = {}) {
-  const h = buildHash(state);
-  const url = location.pathname + location.search + h;
-  if (location.hash === h || (!location.hash && !h)) return;
-  // pushState for user navigation steps (tab visits, session selection,
-  // directory walks, preview opens) so Back retraces them; replaceState for
-  // passive state sync (search text, filter resets).
-  (push ? history.pushState : history.replaceState).call(history, null, '', url);
-}