agentgui 1.0.1117 → 1.0.1119

package/.gm/.embed-generation.code_chunks

@@ -0,0 +1 @@
+b8b6f24106dd526a

package/.gm/.embed-generation.git_commit_vectors

@@ -0,0 +1 @@
+b8b6f24106dd526a

package/.gm/.embed-generation.memories

@@ -0,0 +1 @@
+b8b6f24106dd526a

package/.gm/.embed-generation.rssearch_vectors

@@ -0,0 +1 @@
+b8b6f24106dd526a

package/.gm/prd.yml

@@ -0,0 +1,10 @@
+- id: aaa-consolidate-acp-http-routing
+  subject: Route chat.sendMessage's ACP prompt through acp-sdk-manager's already-running HTTP server instead of claude-runner-acp.js spawning a fresh stdio subprocess per turn
+  witness: 'MAJOR PROGRESS this session, sha f5e57db253: root-caused opencode''s HTTP server appearing unreachable (same stdin-EOF disposal bug as acp-sdk-manager.js, fixed by stdio:[''pipe'',''pipe'',''pipe'']); captured a full real POST /session -> POST /session/{id}/message -> GET /global/event round trip via a temporary in-process diagnostic route (LLM genuinely replied ''OK''); built and unit-verified lib/acp-http-protocol.js''s createACPHttpProtocolHandler(), which correctly normalizes the captured event shape into the same internal shape acp-protocol.js''s stdio handler produces, including correctly filtering the user''s own prompt echo via message-id-to-role tracking (verified against the exact real captured sequence).'
+  description: 'Remaining step: wire the verified normalizer into the live chat.sendMessage path. Concretely: (1) in lib/claude-runner-acp.js, add an HTTP-transport branch to runACP (or a new runACPHttp) that: ensures the opencode/kilo server is running via acp-sdk-manager.ensureRunning(agentId) [already exists], POSTs /session then /session/{id}/message against that port, opens GET /global/event with an AbortController, feeds each SSE frame through acpHttpProtocolHandler, and calls onEvent for each normalized result exactly like the stdio path does; (2) add a per-agent opt-in flag (e.g. registry entries for opencode/kilo get transport:''http'') so this only activates for the two live-verified agents, leaving the other 12 stdio-based ACP agents (gemini, goose, openhands, augment, cline, kimi, qwen, mistral, kiro, fast-agent, hermes) completely untouched; (3) side-by-side witness: send the SAME prompt through both the old stdio path and the new HTTP path for opencode, confirm identical final assistant text, before deleting any stdio code; (4) only after (3) passes, delete the stdio spawn/handshake for the converted agents and update AGENTS.md''s ACP CRITICAL rule to be literally true. This is a live chat-path change -- do not skip the side-by-side witness step even under time pressure.'
+  status: pending
+- id: aaa-split-app-js-god-file
+  subject: Extract site/app/js/app.js's mixed concerns into per-concern modules
+  witness: 'Slice 1/4 DONE (chat-persistence, sha d211f32cbd, live-witnessed). Slice 2 (keyboard shortcuts, app.js:4649-4758 as of this commit) was investigated concretely: the global keydown handler references ~10 app.js-local functions across every feature area (navTo, closeFileDialog, filesMarked, clearFileSelection, cancelChat, newChat, previewNeighbours, openPreview, announce, render) plus state fields spanning chat/files/live/settings -- the highest cross-cutting coupling in the file. This is the exact code AGENTS.md flags as historically crash-prone under webjsx keying mistakes, and a rushed extraction threading 10 dependencies through a factory is a real correctness risk, not a mechanical move.'
+  description: 'Slice 2 (shortcuts) needs a dedicated pass: enumerate the full dependency list precisely (grep every identifier referenced inside the keydown handler + SHORTCUTS array + focusComposer/focusSearch/focusFilter), decide whether those ~10 functions move WITH the shortcuts module (turning it into a larger cut than ''just shortcuts'') or stay in app.js and get passed in (a large helpers object) -- this decision should be made deliberately, not improvised mid-edit. Slices 3 (hash-routing) and 4 (settings/history) still queued after. Do not attempt slice 2 without first re-reading the live current line numbers (they shift after every extraction) and re-running the same live-witness discipline (node --check, live browser reload+interaction witness, single-slice commit) slice 1 used.'
+  status: pending

package/AGENTS.md

@@ -21,7 +21,7 @@ Never add `puppeteer`/`puppeteer-core`/`playwright`/`playwright-core` as a depen
 - The "Untitled conversation" fallback is one shared `UNTITLED_CONVERSATION` constant — never a locally re-typed literal (casing/wording drifts across call sites otherwise).
 - Upload/mkdir/rename/list request bodies are scanned by `SECRET_RE` before being echoed into logs or responses.
 - **webjsx keying:** mixing keyed VElements with `null`/strings/numbers in any children array crashes `applyDiff` ("reading 'key'"). Never pass a conditional `x?h():null` positionally — build the array and `.filter(Boolean)` it. `Btn` spreads array children. A kit component prop with an established narrow contract can silently corrupt an unrelated call site when a caller passes a richer value than the prop was designed for (e.g. a VElement where only a plain string was ever read) — grep every other use site of a prop before extending what a caller passes through it.
-- **Escape ladder order (extend, never reorder):** shortcuts overlay > file dialog > confirmingEdit > new-chat arm > stop-arms > stop generation.
+- **Escape ladder order (extend, never reorder):** shortcuts overlay > file dialog > confirmingEdit > cwd editor > confirmingClearData > new-chat arm > stop-arms > files multi-select clear > stop generation.
 - **Status-disc shape:** live = solid+pulse, error = solid+halo, connecting = hollow ring, stale = muted solid.
 - **Kit `Row` rail/rank contract:** the design-kit `Row` (`anentrypoint-design` `src/components/content.js`) renders a leading status rail from a `rail` prop (`green` | `purple` | `flame`, via `.row.rail-<tone>::before`) and accepts `rank` as an alias for the leading `code` index. `state: 'disabled'` is inert (no `onClick`/`role=button`/tab-stop, `aria-disabled=true`). Rail semantics are consistent everywhere: green = selected/ok, purple = subagent, flame = error/unavailable.
 - **No decorative glyphs.** GUI source and output use ASCII words and CSS-drawn discs (`.status-dot-disc`) for status, never `●/◌/○/⌘/§/▶` etc. The middot separator `·`, ellipsis `…`, and em/en dashes in prose are kept as deliberate typographic product design, not tells — convert any other decorative glyph (arrows, box-drawing, bullets, checks) to ASCII on sight (`->`, `// --- x ---`, `-`/`*`). A dismiss control's own close icon on a dismissible Alert is a real DS icon affordance, exempt.

package/lib/acp-http-protocol.js

@@ -0,0 +1,91 @@
+// Normalizes opencode's REST+SSE event shape (POST /session, POST
+// /session/{id}/message, GET /global/event) into the SAME internal event
+// shape lib/acp-protocol.js's acpProtocolHandler produces for the stdio ACP
+// JSON-RPC transport (assistant/tool_use/tool_result/result), so a caller can
+// switch transports without caring which one produced the event.
+//
+// Live-captured event shapes this maps (opencode 1.2.15, acp --port, SSE
+// frames from GET /global/event during a real session/message round trip):
+//   {payload:{type:'message.part.updated', properties:{part:{type:'text',text,...}}}}
+//   {payload:{type:'message.part.updated', properties:{part:{type:'reasoning',text,...}}}}
+//   {payload:{type:'message.updated', properties:{info:{role,finish,...}}}}
+//   {payload:{type:'session.status', properties:{status:{type:'busy'|'idle'}}}}
+//   {payload:{type:'session.idle', properties:{...}}}
+
+function normalizePart(part, sessionId) {
+  if (!part || typeof part !== 'object') return null;
+  if (part.type === 'text' && typeof part.text === 'string') {
+    return { type: 'assistant', message: { role: 'assistant', content: [{ type: 'text', text: part.text }] }, session_id: sessionId };
+  }
+  if (part.type === 'tool' || part.type === 'tool-invocation') {
+    return {
+      type: 'assistant',
+      message: { role: 'assistant', content: [{ type: 'tool_use', id: part.id, name: part.tool || part.name || 'tool', input: part.input || part.args || {} }] },
+      session_id: sessionId,
+    };
+  }
+  // reasoning/step-start/step-finish parts carry no user-facing content in
+  // agentgui's chat surface today - dropped (return null), same as the stdio
+  // path drops ACP updates it doesn't recognize.
+  return null;
+}
+
+// A `message.part.updated` frame's `part` carries NO role of its own - live
+// capture confirmed the part's role lives on the earlier `message.updated`
+// frame for the SAME messageID (the prompt echo arrives as a role:"user"
+// message.updated immediately before its own message.part.updated). Each
+// createACPHttpProtocolHandler() call keeps its own messageId->role map so a
+// caller with one handler per session never leaks state across sessions.
+export function createACPHttpProtocolHandler() {
+  const roleByMessageId = new Map();
+
+  return function (frame, context) {
+    if (!frame || typeof frame !== 'object') return null;
+    const payload = frame.payload;
+    if (!payload || typeof payload !== 'object') return null;
+    const sid = context?.sessionId;
+
+    if (payload.type === 'message.updated') {
+      const info = payload.properties?.info;
+      if (!info) return null;
+      if (info.id) roleByMessageId.set(info.id, info.role);
+      if (info.role === 'assistant' && info.finish) {
+        return { type: 'result', result: '', stopReason: info.finish, usage: info.tokens ? { used: info.tokens.total } : undefined, session_id: info.sessionID || sid };
+      }
+      return null;
+    }
+
+    if (payload.type === 'message.part.updated') {
+      const part = payload.properties?.part;
+      if (!part) return null;
+      // The user's own prompt echoes back as a part on their own message -
+      // only forward parts belonging to an assistant-role message.
+      const role = part.messageID ? roleByMessageId.get(part.messageID) : undefined;
+      if (role === 'user') return null;
+      return normalizePart(part, sid);
+    }
+
+    if (payload.type === 'session.status' && payload.properties?.status?.type === 'error') {
+      return { type: 'error', error: payload.properties.status };
+    }
+
+    return null;
+  };
+}
+
+export const acpHttpProtocolHandler = createACPHttpProtocolHandler();
+
+// Parse one SSE "data: {...}\n\n" frame (or a raw chunk containing several)
+// into an array of parsed JSON payloads. opencode's /global/event stream
+// uses the standard `data: <json>\n\n` SSE framing (live-confirmed).
+export function parseSSEChunk(chunk) {
+  const out = [];
+  for (const block of chunk.split('\n\n')) {
+    const line = block.trim();
+    if (!line.startsWith('data:')) continue;
+    const jsonText = line.slice(5).trim();
+    if (!jsonText) continue;
+    try { out.push(JSON.parse(jsonText)); } catch { /* partial frame, skip */ }
+  }
+  return out;
+}

package/lib/acp-sdk-manager.js

@@ -8,10 +8,18 @@ import * as acpMachine from './acp-server-machine.js';
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const projectRoot = path.resolve(__dirname, '..');
 const isWindows = os.platform() === 'win32';
+// codex (@openai/codex >=0.147.0) has no `acp` subcommand - `codex acp` is
+// parsed as the interactive TUI with prompt text "acp" ("Error: stdin is not
+// a terminal" when non-interactive), live-confirmed via `codex --help`/`codex
+// app-server --help`. Its ACP-equivalent surface is `app-server` over a
+// WebSocket (`--remote ws://host:port`), not this manager's HTTP-polling
+// `/provider` health-check model, so codex is intentionally excluded from
+// ACP_TOOLS rather than spawning a command that can never succeed. Re-add it
+// once a WebSocket app-server client exists (see PRD row
+// aaa-codex-app-server-client).
 const ACP_TOOLS = [
   { id: 'opencode', cmd: 'opencode', args: ['acp'], port: 18100, npxPkg: 'opencode-ai' },
   { id: 'kilo', cmd: 'kilo', args: ['acp'], port: 18101, npxPkg: '@kilocode/cli' },
-  { id: 'codex', cmd: 'codex', args: ['acp'], port: 18102, npxPkg: '@openai/codex' },
 ];
 const HEALTH_INTERVAL_MS = 30000, STARTUP_GRACE_MS = 5000, IDLE_TIMEOUT_MS = 120000;
 const processes = new Map(), idleTimers = new Map();
@@ -51,8 +59,13 @@ function startProcess(tool) {
   const resolved = resolveCommand(tool);
   let proc;
   try {
+    // stdin MUST stay open (piped, never closed) - the ACP CLI's `acp`
+    // subcommand watches stdin and disposes itself on EOF even though it is
+    // actually serving its normal HTTP API on `tool.port` (confirmed live:
+    // spawning with stdio 'ignore' closes stdin immediately, which the
+    // process treats as EOF and exits). Never .end()/.destroy() proc.stdin.
     proc = spawn(resolved.bin, resolved.args, {
-      stdio: ['ignore', 'pipe', 'pipe'],
+      stdio: ['pipe', 'pipe', 'pipe'],
       detached: false,
     });
   } catch (err) {

package/lib/claude-runner-agents.js

@@ -149,7 +149,14 @@ registry.register({ id: 'augment', name: 'Augment Code', command: 'augment', pro
 registry.register({ id: 'cline', name: 'Cline', command: 'cline', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'kimi', name: 'Kimi CLI', command: 'kimi', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'qwen', name: 'Qwen Code', command: 'qwen-code', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
-registry.register({ id: 'codex', name: 'Codex CLI', command: 'codex', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
+// codex (@openai/codex >=0.147.0) has no `acp` subcommand - live-confirmed
+// via `codex --help`/`codex app-server --help`: `codex acp` is parsed as the
+// interactive TUI with prompt text "acp" and errors "stdin is not a
+// terminal" non-interactively. Its ACP-equivalent is `app-server` over a
+// WebSocket, a different transport this stdio-JSON-RPC runner cannot drive.
+// Registering it with buildArgs:()=>['acp'] would spawn a command that can
+// never succeed. Disabled until a WebSocket app-server client exists (see
+// PRD row aaa-codex-app-server-client).
 registry.register({ id: 'mistral', name: 'Mistral Vibe', command: 'mistral-vibe', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'kiro', name: 'Kiro CLI', command: 'kiro', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'fast-agent', name: 'fast-agent', command: 'fast-agent', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });