agentgui 1.0.1116 → 1.0.1118

package/AGENTS.md

@@ -21,7 +21,7 @@ Never add `puppeteer`/`puppeteer-core`/`playwright`/`playwright-core` as a depen
 - The "Untitled conversation" fallback is one shared `UNTITLED_CONVERSATION` constant — never a locally re-typed literal (casing/wording drifts across call sites otherwise).
 - Upload/mkdir/rename/list request bodies are scanned by `SECRET_RE` before being echoed into logs or responses.
 - **webjsx keying:** mixing keyed VElements with `null`/strings/numbers in any children array crashes `applyDiff` ("reading 'key'"). Never pass a conditional `x?h():null` positionally — build the array and `.filter(Boolean)` it. `Btn` spreads array children. A kit component prop with an established narrow contract can silently corrupt an unrelated call site when a caller passes a richer value than the prop was designed for (e.g. a VElement where only a plain string was ever read) — grep every other use site of a prop before extending what a caller passes through it.
-- **Escape ladder order (extend, never reorder):** shortcuts overlay > file dialog > confirmingEdit > new-chat arm > stop-arms > stop generation.
+- **Escape ladder order (extend, never reorder):** shortcuts overlay > file dialog > confirmingEdit > cwd editor > confirmingClearData > new-chat arm > stop-arms > files multi-select clear > stop generation.
 - **Status-disc shape:** live = solid+pulse, error = solid+halo, connecting = hollow ring, stale = muted solid.
 - **Kit `Row` rail/rank contract:** the design-kit `Row` (`anentrypoint-design` `src/components/content.js`) renders a leading status rail from a `rail` prop (`green` | `purple` | `flame`, via `.row.rail-<tone>::before`) and accepts `rank` as an alias for the leading `code` index. `state: 'disabled'` is inert (no `onClick`/`role=button`/tab-stop, `aria-disabled=true`). Rail semantics are consistent everywhere: green = selected/ok, purple = subagent, flame = error/unavailable.
 - **No decorative glyphs.** GUI source and output use ASCII words and CSS-drawn discs (`.status-dot-disc`) for status, never `●/◌/○/⌘/§/▶` etc. The middot separator `·`, ellipsis `…`, and em/en dashes in prose are kept as deliberate typographic product design, not tells — convert any other decorative glyph (arrows, box-drawing, bullets, checks) to ASCII on sight (`->`, `// --- x ---`, `-`/`*`). A dismiss control's own close icon on a dismissible Alert is a real DS icon affordance, exempt.

package/lib/acp-sdk-manager.js

@@ -8,10 +8,18 @@ import * as acpMachine from './acp-server-machine.js';
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const projectRoot = path.resolve(__dirname, '..');
 const isWindows = os.platform() === 'win32';
+// codex (@openai/codex >=0.147.0) has no `acp` subcommand - `codex acp` is
+// parsed as the interactive TUI with prompt text "acp" ("Error: stdin is not
+// a terminal" when non-interactive), live-confirmed via `codex --help`/`codex
+// app-server --help`. Its ACP-equivalent surface is `app-server` over a
+// WebSocket (`--remote ws://host:port`), not this manager's HTTP-polling
+// `/provider` health-check model, so codex is intentionally excluded from
+// ACP_TOOLS rather than spawning a command that can never succeed. Re-add it
+// once a WebSocket app-server client exists (see PRD row
+// aaa-codex-app-server-client).
 const ACP_TOOLS = [
   { id: 'opencode', cmd: 'opencode', args: ['acp'], port: 18100, npxPkg: 'opencode-ai' },
   { id: 'kilo', cmd: 'kilo', args: ['acp'], port: 18101, npxPkg: '@kilocode/cli' },
-  { id: 'codex', cmd: 'codex', args: ['acp'], port: 18102, npxPkg: '@openai/codex' },
 ];
 const HEALTH_INTERVAL_MS = 30000, STARTUP_GRACE_MS = 5000, IDLE_TIMEOUT_MS = 120000;
 const processes = new Map(), idleTimers = new Map();
@@ -51,8 +59,13 @@ function startProcess(tool) {
   const resolved = resolveCommand(tool);
   let proc;
   try {
+    // stdin MUST stay open (piped, never closed) - the ACP CLI's `acp`
+    // subcommand watches stdin and disposes itself on EOF even though it is
+    // actually serving its normal HTTP API on `tool.port` (confirmed live:
+    // spawning with stdio 'ignore' closes stdin immediately, which the
+    // process treats as EOF and exits). Never .end()/.destroy() proc.stdin.
     proc = spawn(resolved.bin, resolved.args, {
-      stdio: ['ignore', 'pipe', 'pipe'],
+      stdio: ['pipe', 'pipe', 'pipe'],
       detached: false,
     });
   } catch (err) {

package/lib/claude-runner-agents.js

@@ -149,7 +149,14 @@ registry.register({ id: 'augment', name: 'Augment Code', command: 'augment', pro
 registry.register({ id: 'cline', name: 'Cline', command: 'cline', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'kimi', name: 'Kimi CLI', command: 'kimi', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'qwen', name: 'Qwen Code', command: 'qwen-code', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
-registry.register({ id: 'codex', name: 'Codex CLI', command: 'codex', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
+// codex (@openai/codex >=0.147.0) has no `acp` subcommand - live-confirmed
+// via `codex --help`/`codex app-server --help`: `codex acp` is parsed as the
+// interactive TUI with prompt text "acp" and errors "stdin is not a
+// terminal" non-interactively. Its ACP-equivalent is `app-server` over a
+// WebSocket, a different transport this stdio-JSON-RPC runner cannot drive.
+// Registering it with buildArgs:()=>['acp'] would spawn a command that can
+// never succeed. Disabled until a WebSocket app-server client exists (see
+// PRD row aaa-codex-app-server-client).
 registry.register({ id: 'mistral', name: 'Mistral Vibe', command: 'mistral-vibe', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'kiro', name: 'Kiro CLI', command: 'kiro', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });
 registry.register({ id: 'fast-agent', name: 'fast-agent', command: 'fast-agent', protocol: 'acp', supportsStdin: false, supportedFeatures: ['streaming', 'resume', 'acp-protocol'], buildArgs: () => ['acp'], protocolHandler: acpProtocolHandler });