agentgui 1.0.1115 → 1.0.1116

package/AGENTS.md

@@ -8,6 +8,10 @@ ACP lifecycle lives in `lib/acp-sdk-manager.js` alone; no other module spawns or
 
 Same-origin app auth must never use the `Authorization` header when an upstream proxy may own Basic auth — a `Bearer` header overwrites the browser's cached `Authorization: Basic` credentials, and nginx `auth_basic` only accepts `Basic`, so the request is rejected at the proxy before it ever reaches agentgui. Use the **`?token=` query param** (`withToken()`, exactly like the WS / EventSource / image / download URLs) instead — it coexists with upstream Basic auth, and agentgui accepts `?token=` on every HTTP route, plus the `agentgui_token` cookie.
 
+## CRITICAL — no Chrome/Puppeteer/Playwright dependency anywhere in this repo
+
+Never add `puppeteer`/`puppeteer-core`/`playwright`/`playwright-core` as a dependency, and never hand-roll a raw headless-Chrome launch in a script. Live browser verification for this project is done via the gm skill's `browser` verb (direct CDP, no relay), not by this repo owning its own browser-automation dependency. `scripts/capture-screenshots.mjs` (puppeteer-core-driven, dead code — not wired into any CI workflow) was removed for this reason.
+
 ## Standing engineering rules
 
 - **All GUI/design decisions live in the kit (`../design`), none in agentgui.** New surface styling is a kit CSS rule, never an inline `<style>` or `style=` prop in agentgui. A new kit component must be re-exported through `src/components.js`'s barrel to be consumable — adding it to a component file alone leaves it invisible to the built bundle even with 0 lint errors; grep the built dist for the export name before wiring the app against it. New CSS class tokens in the kit must carry a registered family prefix (`ds-`, `app-`, `ws-`, `chat-`, etc. — see `scripts/lint-classes.mjs`'s `PREFIXES`/`FROZEN` lists) or the build's lint-classes check fails; a legacy bare name like `chip` being grandfathered on the FROZEN list does not cover new sub-tokens off it (e.g. a new `chip-remove` class still needs a `ds-` prefix).
@@ -79,7 +83,7 @@ Two runner protocols exist. **Direct** (`lib/claude-runner-direct.js`): claude-c
 
 ## CI / GitHub Actions
 
-**capture-screenshots must run under bun, not node** (gh-pages.yml `--ignore-scripts` leaves `better-sqlite3` uncompiled, so `bun:sqlite`'s fallback also fails under Node — detail in rs-learn). Rule: any CI step that spawns the agentgui server must invoke it with `bun`.
+Any CI step that spawns the agentgui server must invoke it with `bun`, not `node` (`--ignore-scripts` npm installs leave `better-sqlite3` uncompiled, so `bun:sqlite`'s fallback also fails under Node).
 
 ## GM Plugin Autonomy Blocker
 

package/lib/ws-handlers-util.js

@@ -87,6 +87,9 @@ export function register(router, deps) {
       features: a.supportedFeatures || [],
       available: registry.isAvailable(a.id),
       npxInstallable: !!a.npxPackage,
+      // The CLI binary name a manual (non-npx) install would need - lets the
+      // settings panel say what to install instead of just "not installed".
+      cmd: a.command || null,
     }));
     return { agents };
   });
@@ -355,7 +358,11 @@ export function register(router, deps) {
     if (p?.file) args.push('--', assertSafeRelPath(p.file, 'file'));
     try {
       const { stdout } = await execFileP('git', args, { cwd });
-      return { diff: stdout, file: p?.file || null, staged: !!p?.staged };
+      // git prints "Binary files a/x and b/x differ" for binary paths instead
+      // of a unified diff - an empty `diff` string then reads to the client as
+      // "no diff to show" with no explanation. Detect it so the UI can say why.
+      const binary = /^Binary files .* differ$/m.test(stdout);
+      return { diff: stdout, binary, file: p?.file || null, staged: !!p?.staged };
     } catch (e) { err(500, (e.stderr || e.message || 'git diff failed').trim()); }
   });
 
@@ -456,67 +463,4 @@ export function register(router, deps) {
     }
     return { subAgents: SUB_AGENT_MAP[p.id] || [] };
   });
-
-  // --- models.availability: composes agentgui's REAL model surface into the
-  // ModelsConfig component's shape (design SDK's ModelsConfig.js). agentgui
-  // has no freddie-style probed-availability matrix (no /v1/models round-trip
-  // per mode) - what it actually has is: discovered agent CLIs (registry,
-  // same data agents.list already exposes), each agent's model choices
-  // (agents.models' getModelsForAgent), and per-provider API-key presence
-  // (auth.configs' getProviderConfigs). This handler is a read-only
-  // composition of those three real sources, not a new probe and not fake
-  // data - "usable_in_any_mode" is derived from registry.isAvailable(agentId)
-  // (the CLI binary was actually found on this server), and "key_present"
-  // comes straight from getProviderConfigs' filesystem check.
-  router.handle('models.availability', async () => {
-    const agents = registry.list();
-    const providerConfigs = typeof getProviderConfigs === 'function' ? getProviderConfigs() : {};
-    const providers = [];
-    for (const a of agents) {
-      const available = registry.isAvailable(a.id);
-      let models = [];
-      if (a.id === 'claude-code') {
-        models = [
-          { id: 'sonnet', name: 'Claude Sonnet (latest)' },
-          { id: 'opus', name: 'Claude Opus (latest)' },
-          { id: 'haiku', name: 'Claude Haiku (latest)' },
-        ];
-      } else if (typeof getModelsForAgent === 'function') {
-        try {
-          const raw = await getModelsForAgent(a.id);
-          const list = Array.isArray(raw) ? raw : (raw?.models || []);
-          models = list.map((m) => ({ id: m.id, name: m.name || m.label || m.id }));
-        } catch { models = []; }
-      }
-      // Map onto agentgui's one real signal per model: is the agent CLI itself
-      // available on this server (registry.isAvailable). agentgui does not
-      // probe individual (model, mode) cells the way freddie's matrix does,
-      // so every model under an available agent reports the same single
-      // 'cli' mode rather than fabricating per-mode probe results.
-      providers.push({
-        id: a.id,
-        key_present: !!(providerConfigs[a.id] && providerConfigs[a.id].hasKey) || available,
-        discovery_error: available ? null : ((a.name || a.id) + ' CLI not found on this server'),
-        models: models.map((m) => ({
-          id: m.id,
-          name: m.name,
-          discovered_via: a.protocol || 'cli',
-          modes: { cli: { ok: !!available, skipped: !available, reason: available ? undefined : 'agent_not_installed' } },
-          usable_in_any_mode: !!available,
-        })),
-      });
-    }
-    const totalModels = providers.reduce((n, p) => n + p.models.length, 0);
-    const usableModels = providers.reduce((n, p) => n + p.models.filter((m) => m.usable_in_any_mode).length, 0);
-    return {
-      timestamp: new Date().toISOString(),
-      providers,
-      sampler: [],
-      summary: {
-        total_providers: providers.length,
-        total_models: totalModels,
-        usable_in_any_mode: usableModels,
-      },
-    };
-  });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.1115",
+  "version": "1.0.1116",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",
@@ -34,13 +34,11 @@
     "fsbrowse": "latest",
     "lru-cache": "^11.2.7",
     "opencode-ai": "^1.2.15",
-    "puppeteer-core": "^24.37.5",
     "webjsx": "^0.0.73",
     "ws": "^8.14.2",
     "xstate": "^5.32.0"
   },
   "devDependencies": {
-    "electron": "^35.0.0",
-    "playwright": "^1.59.1"
+    "electron": "^35.0.0"
   }
 }