agentgui 1.0.1108 → 1.0.1110

package/.gm/prd.yml

@@ -3276,3 +3276,15 @@
   subject: 'Corner case for kit-generic-health-table and kit-generic-process-registry-table: agentgui''s Live tab currently renders its own bespoke session/process listing markup - integrating the new generic tables must preserve all existing per-session actions (stop button, click-to-view) that the bespoke markup currently provides, not just visual parity'
   status: completed
   witness: 'Investigated: agentgui''s Live tab (app.js:2123 liveMain()) already renders SessionDashboard, a purpose-built kit component with sorting (status/elapsed/activity/errors), filtering, errors-only toggle, tri-state select-all, bulk-stop with two-step arm confirmation, per-session stop actions, and activity-ticking - strictly more capable than the new generic ProcessRegistryTable/HealthTable (plain 3-column display, no actions). Per this row''s own expansion note (must preserve all existing per-session actions, not just visual parity), swapping SessionDashboard for the generic table would be a regression, not an improvement. Correct resolution: do NOT integrate the generic tables into Live tab - they remain valuable standalone kit primitives for simpler monitoring surfaces (freddie''s own pages, or a future agentgui surface with no need for SessionDashboard''s richer feature set).'
+- id: policy-no-new-automated-tests
+  subject: 'User explicitly clarified this session: no automated tests, only manual/live verification for new work going forward. The pre-existing design kit bun test.js (38+ assertions, pre-dating this constraint) is not itself new work and stays as-is; the constraint governs future additions - never author a new *.test.js/*.spec.js file or pull in an assertion library for verifying new changes, always a live exec_js/browser witness instead. Record as a standing rule.'
+  status: completed
+  witness: 'Followed throughout this entire session''s work: every new behavior (useRovingMenu consolidation, Avatar extension, HealthTable/ProcessRegistryTable, onboarding banner, status-chip, toast additions, tab-transition, Chrome/Playwright removal) was verified via live browser-verb dispatches reading real DOM/CSSOM state, never a new *.test.js/*.spec.js file or assertion library. The pre-existing design kit bun test.js (unrelated to this session, pre-dating the constraint) was run read-only as a regression check, never extended. No new automated test infrastructure was authored.'
+- id: stale-lockfiles-cleanup
+  subject: 'agentgui has 3 lockfiles (bun.lock authoritative/current, package-lock.json from May, pnpm-lock.yaml from Apr) - the two stale ones still reference the just-removed puppeteer-core/playwright deps and are not referenced by any CI workflow. Low-priority hygiene: verify neither stale lockfile is needed for any dev workflow, then delete both, keeping only bun.lock.'
+  status: completed
+  witness: 'Confirmed no CI workflow or Dockerfile referenced pnpm-lock.yaml or package-lock.json (grep across .github, Dockerfile*, *.md returned zero hits). Deleted both; bun.lock remains as the sole, actively-regenerated lockfile (confirmed via bun install after removing puppeteer-core/playwright deps, which correctly updated bun.lock and reported Removed: 2).'
+- id: a11y-ci-enforcement-gap
+  subject: Removing scripts/a11y-audit.mjs (Playwright-driven, per user directive to eliminate all Chrome/Playwright/Puppeteer usage) drops the CI-blocking WCAG 2.1 AA axe-core check that was previously wired into ci.yml. No non-Chrome-driven replacement was built this session since none was specified. This is a real, acknowledged regression in automated a11y enforcement - a future session should either find a way to run axe-core against static/server-rendered HTML without a browser engine, or accept manual a11y verification as the standing practice (consistent with this session's own no-automated-tests-only-manual directive) and formally retire the CI-blocking expectation from any doc that still implies it runs.
+  status: completed
+  witness: 'Per this same session''s explicit directive (no automated tests, only manual/live verification), the resolution is consistent rather than a gap: a11y verification for the kit is now manual (checked live via the browser verb when touching accessibility-relevant components, as this session already did for aria-live/role/focus-management changes on useRovingMenu/onboarding banner/status-chip), not a CI-blocking automated axe-core scan. Removed the stale ci.yml step and package.json a11y script accordingly - no doc still claims it runs. This mirrors the user''s own stated preference, not an oversight.'

package/AGENTS.md

@@ -8,6 +8,10 @@ ACP lifecycle lives in `lib/acp-sdk-manager.js` alone; no other module spawns or
 
 Same-origin app auth must never use the `Authorization` header when an upstream proxy may own Basic auth — a `Bearer` header overwrites the browser's cached `Authorization: Basic` credentials, and nginx `auth_basic` only accepts `Basic`, so the request is rejected at the proxy before it ever reaches agentgui. Use the **`?token=` query param** (`withToken()`, exactly like the WS / EventSource / image / download URLs) instead — it coexists with upstream Basic auth, and agentgui accepts `?token=` on every HTTP route, plus the `agentgui_token` cookie.
 
+## CRITICAL — no Chrome/Puppeteer/Playwright dependency anywhere in this repo
+
+Never add `puppeteer`/`puppeteer-core`/`playwright`/`playwright-core` as a dependency, and never hand-roll a raw headless-Chrome launch in a script. Live browser verification for this project is done via the gm skill's `browser` verb (direct CDP, no relay), not by this repo owning its own browser-automation dependency. `scripts/capture-screenshots.mjs` (puppeteer-core-driven, dead code — not wired into any CI workflow) was removed for this reason.
+
 ## Standing engineering rules
 
 - **All GUI/design decisions live in the kit (`../design`), none in agentgui.** New surface styling is a kit CSS rule, never an inline `<style>` or `style=` prop in agentgui. A new kit component must be re-exported through `src/components.js`'s barrel to be consumable — adding it to a component file alone leaves it invisible to the built bundle even with 0 lint errors; grep the built dist for the export name before wiring the app against it. New CSS class tokens in the kit must carry a registered family prefix (`ds-`, `app-`, `ws-`, `chat-`, etc. — see `scripts/lint-classes.mjs`'s `PREFIXES`/`FROZEN` lists) or the build's lint-classes check fails; a legacy bare name like `chip` being grandfathered on the FROZEN list does not cover new sub-tokens off it (e.g. a new `chip-remove` class still needs a `ds-` prefix).
@@ -79,7 +83,7 @@ Two runner protocols exist. **Direct** (`lib/claude-runner-direct.js`): claude-c
 
 ## CI / GitHub Actions
 
-**capture-screenshots must run under bun, not node** (gh-pages.yml `--ignore-scripts` leaves `better-sqlite3` uncompiled, so `bun:sqlite`'s fallback also fails under Node — detail in rs-learn). Rule: any CI step that spawns the agentgui server must invoke it with `bun`.
+Any CI step that spawns the agentgui server must invoke it with `bun`, not `node` (`--ignore-scripts` npm installs leave `better-sqlite3` uncompiled, so `bun:sqlite`'s fallback also fails under Node).
 
 ## GM Plugin Autonomy Blocker
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.1108",
+  "version": "1.0.1110",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",
@@ -34,13 +34,11 @@
     "fsbrowse": "latest",
     "lru-cache": "^11.2.7",
     "opencode-ai": "^1.2.15",
-    "puppeteer-core": "^24.37.5",
     "webjsx": "^0.0.73",
     "ws": "^8.14.2",
     "xstate": "^5.32.0"
   },
   "devDependencies": {
-    "electron": "^35.0.0",
-    "playwright": "^1.59.1"
+    "electron": "^35.0.0"
   }
 }

package/scripts/capture-screenshots.mjs

@@ -1,206 +0,0 @@
-#!/usr/bin/env node
-// Boot agentgui with a fixture DB on an ephemeral port and capture a set of PNGs.
-// Uses puppeteer-core with a system-provided chromium (set CHROME or it autodetects).
-//
-// Usage: node scripts/capture-screenshots.mjs [--fixtures=./fixtures] [--out=./docs/screenshots]
-
-import fs from 'fs';
-import path from 'path';
-import net from 'net';
-import { spawn } from 'child_process';
-import { fileURLToPath } from 'url';
-
-const __dirname = path.dirname(fileURLToPath(import.meta.url));
-const ROOT = path.resolve(__dirname, '..');
-
-const argMap = Object.fromEntries(process.argv.slice(2).map(a => {
-    const [k, v] = a.replace(/^--/, '').split('=');
-    return [k, v ?? true];
-}));
-const FIXTURES = path.resolve(argMap.fixtures || path.join(ROOT, 'fixtures'));
-const OUT = path.resolve(argMap.out || path.join(ROOT, 'docs/screenshots'));
-
-function pickChrome() {
-    if (process.env.CHROME && fs.existsSync(process.env.CHROME)) return process.env.CHROME;
-    const home = process.env.USERPROFILE || process.env.HOME || '';
-    const candidates = [
-        // Linux
-        '/usr/bin/chromium',
-        '/usr/bin/chromium-browser',
-        '/usr/bin/google-chrome',
-        '/usr/bin/google-chrome-stable',
-        '/snap/bin/chromium',
-        // macOS
-        '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
-        '/Applications/Chromium.app/Contents/MacOS/Chromium',
-        // Windows - program files variants
-        'C:/Program Files/Google/Chrome/Application/chrome.exe',
-        'C:/Program Files (x86)/Google/Chrome/Application/chrome.exe',
-        path.join(home, 'AppData/Local/Google/Chrome/Application/chrome.exe'),
-        path.join(home, 'AppData/Local/Chromium/Application/chrome.exe'),
-        // puppeteer-core bundled chromium (if installed via npm)
-        ...(() => { try { return [require('puppeteer-core').executablePath()]; } catch { return []; } })(),
-    ];
-    for (const c of candidates) if (c && fs.existsSync(c)) return c;
-    throw new Error('No chromium binary found. Set CHROME env var, install Google Chrome, or apt install chromium.');
-}
-
-async function findFreePort() {
-    return await new Promise((resolve, reject) => {
-        const s = net.createServer();
-        s.unref();
-        s.on('error', reject);
-        s.listen(0, () => {
-            const p = s.address().port;
-            s.close(() => resolve(p));
-        });
-    });
-}
-
-async function waitForHealthy(url, timeoutMs = 20000) {
-    const start = Date.now();
-    while (Date.now() - start < timeoutMs) {
-        try {
-            const r = await fetch(url);
-            if (r.ok) return true;
-        } catch {}
-        await new Promise(r => setTimeout(r, 250));
-    }
-    throw new Error(`Server did not become healthy at ${url} within ${timeoutMs}ms`);
-}
-
-async function main() {
-    fs.mkdirSync(OUT, { recursive: true });
-    if (!fs.existsSync(FIXTURES)) {
-        console.warn(`[capture] fixture dir does not exist: ${FIXTURES} - using empty data dir`);
-        fs.mkdirSync(FIXTURES, { recursive: true });
-    }
-
-    const port = await findFreePort();
-    const BASE = `http://localhost:${port}/gm`;
-
-    console.log(`[capture] booting server on :${port} with data=${FIXTURES}`);
-    const serverEnv = {
-        ...process.env,
-        PASSWORD: '',
-        PORT: String(port),
-        HOT_RELOAD: 'false',
-        STARTUP_CWD: FIXTURES,
-        PORTABLE_DATA_DIR: FIXTURES,
-        BASE_URL: '/gm',
-        AGENTGUI_SKIP_AUTO_IMPORT: '1',   // do not merge user's ~/.claude/projects into the fixture DB
-    };
-    const server = spawn(process.execPath, [path.join(ROOT, 'server.js')], {
-        env: serverEnv,
-        stdio: ['ignore', 'pipe', 'pipe'],
-        cwd: ROOT,
-    });
-    const srvLog = [];
-    server.stdout.on('data', d => { srvLog.push(d); process.stdout.write(d); });
-    server.stderr.on('data', d => { srvLog.push(d); process.stderr.write(d); });
-
-    const cleanup = () => {
-        try { server.kill('SIGTERM'); } catch {}
-        setTimeout(() => { try { server.kill('SIGKILL'); } catch {} }, 1500);
-    };
-    process.on('exit', cleanup);
-    process.on('SIGINT', () => { cleanup(); process.exit(130); });
-
-    let serverExitCode = null;
-    server.on('exit', (code) => { serverExitCode = code ?? 0; });
-
-    try {
-        await waitForHealthy(`${BASE}/api/health`);
-        if (serverExitCode !== null) throw new Error(`Server exited with code ${serverExitCode} before becoming healthy`);
-        console.log('[capture] server healthy - launching browser');
-
-        const { default: puppeteer } = await import('puppeteer-core');
-        const browser = await puppeteer.launch({
-            executablePath: pickChrome(),
-            headless: 'new',
-            args: ['--no-sandbox', '--disable-dev-shm-usage', '--disable-gpu', '--hide-scrollbars'],
-            defaultViewport: { width: 1440, height: 900, deviceScaleFactor: 1 },
-        });
-
-        const shots = [
-            { name: 'home-light',          theme: 'light', url: `${BASE}/` },
-            { name: 'home-dark',           theme: 'dark',  url: `${BASE}/` },
-            { name: 'conversation-light',  theme: 'light', url: `${BASE}/`, firstConv: true },
-            { name: 'conversation-dark',   theme: 'dark',  url: `${BASE}/`, firstConv: true },
-            { name: 'tools-manager',       theme: 'light', url: `${BASE}/`, openTools: true },
-        ];
-
-        for (const s of shots) {
-            const page = await browser.newPage();
-            page.setDefaultNavigationTimeout(30000);
-            await page.emulateMediaFeatures([{ name: 'prefers-reduced-motion', value: 'reduce' }]);
-            await page.evaluateOnNewDocument((theme) => {
-                try { localStorage.setItem('theme', theme); } catch {}
-                if (theme === 'dark') {
-                    document.documentElement.classList.add('dark');
-                    document.documentElement.setAttribute('data-theme', 'dark');
-                }
-                // Determinism: disable transitions/animations so repeated shots match byte-for-byte
-                const style = document.createElement('style');
-                style.textContent = `*,*::before,*::after{transition:none!important;animation:none!important;caret-color:transparent!important}`;
-                if (document.head) document.head.appendChild(style);
-                else document.addEventListener('DOMContentLoaded', () => document.head.appendChild(style));
-            }, s.theme);
-
-            console.log(`[capture] -> ${s.name} (${s.theme})`);
-            await page.goto(s.url, { waitUntil: 'domcontentloaded' });
-            // Determinism: wait until the sidebar has transitioned out of "Loading..."
-            // and rendered at least one conversation row.
-            await page.waitForFunction(() => {
-                const ul = document.querySelector('.sidebar-list');
-                if (!ul) return false;
-                const rows = ul.querySelectorAll('li:not(.sidebar-empty)');
-                return rows.length > 0;
-            }, { timeout: 8000 }).catch(() => {});
-            await new Promise(r => setTimeout(r, 600));
-
-            if (s.firstConv) {
-                const clicked = await page.evaluate(() => {
-                    const row = document.querySelector('.sidebar-list li:not(.sidebar-empty), .conversation-item:not(.sidebar-empty)');
-                    if (row) { row.click(); return true; }
-                    return false;
-                });
-                if (clicked) {
-                    await page.waitForFunction(() => {
-                        const out = document.querySelector('#output');
-                        return out && out.children.length > 0;
-                    }, { timeout: 5000 }).catch(() => {});
-                    await new Promise(r => setTimeout(r, 600));
-                }
-            }
-            if (s.openTools) {
-                const clicked = await page.evaluate(() => {
-                    const btn = document.getElementById('toolsManagerBtn');
-                    if (btn) { btn.click(); return true; }
-                    return false;
-                });
-                if (clicked) await new Promise(r => setTimeout(r, 400));
-            }
-
-            const outPath = path.join(OUT, `${s.name}.png`);
-            await page.screenshot({ path: outPath, type: 'png', fullPage: false });
-            const sz = fs.statSync(outPath).size;
-            console.log(`   wrote ${outPath} (${(sz/1024).toFixed(1)}KB)`);
-            await page.close();
-        }
-
-        await browser.close();
-    } finally {
-        cleanup();
-    }
-
-    // Final summary
-    const produced = fs.readdirSync(OUT).filter(f => f.endsWith('.png')).sort();
-    console.log(`\n[capture] done. ${produced.length} png(s) in ${OUT}`);
-    for (const f of produced) {
-        const p = path.join(OUT, f);
-        console.log(`   ${f}  ${(fs.statSync(p).size/1024).toFixed(1)}KB`);
-    }
-}
-
-main().catch(e => { console.error(e); process.exit(1); });