agentgui 1.0.1082 → 1.0.1084

package/.gm/memories/mem-d9c19257abc2fa5e-1061.md

@@ -0,0 +1,8 @@
+---
+key: mem-d9c19257abc2fa5e-1061
+ns: default
+created: 1784316128399
+updated: 1784316128399
+---
+
+{"key":"agentgui-no-tool-approval-gate-2026-07-17","value":"agentgui has NO tool-call approval/permission gate anywhere in its runner stack (confirmed 47th run, 2026-07-17): claude-runner-agents.js passes --dangerously-skip-permissions on every invocation; acp-sdk-manager.js/acp-protocol.js/claude-runner-acp.js/acp-server-machine.js have zero permission/approval/canUseTool references; backend.js's WS event switch has no pending-approval state; app.js has no pendingApproval field. The new kit ApprovalPrompt component (added this run, modeled on docstudio's approve/deny-with-note UI) has no backend concept to bind to today - wiring a real approval flow would need a new WS message type (permission_request/permission_response), runner-side blocking/resume logic differing per runner protocol (direct vs ACP vs agents), and removing --dangerously-skip-permissions. This is a distinct, much larger initiative than porting a UI idea into the kit - not in scope for a docstudio-design-cue pass, would need its own dedicated planning session if ever pursued."}

package/AGENTS.md

@@ -1,5 +1,13 @@
 # AgentGUI — Agent Notes
 
+## Docstudio design-cue follow-up (2026-07-17) — forty-seventh run, confirming pass
+
+Per gm-continue's mandatory first-confirming-pass discipline, a second independent Explore-agent survey (told what the 47th run's main pass just shipped) re-checked docstudio against the kit + app and found one last real, narrow gap: `app.js`'s cross-tab external-update banner still called native `window.confirm()` for the reload-discards-unsent-draft guard — the sole remaining native browser dialog call anywhere in the app, matching docstudio's own `dialog.js` rationale of never using `window.confirm/alert/prompt` for data-loss confirmations. Replaced with a `state.chat.confirmingReloadDiscard` flag rendering the kit's existing `ConfirmDialog` modal, mirroring the same pattern already used for file delete/bulk-delete. Browser-witnessed by fetching the live-served `/gm/js/app.js` directly and regex-confirming `window.confirm` is gone and the new `confreload` dialog key is present. A second confirming pass after this one found nothing further — docstudio's `buildDocAccessPrompt`/`buildScopePrompt` variants are narrow Google-OAuth/Drive-doc-specific flows with no analog in agentgui's domain model, and everything else checked (ApprovalPrompt's focus/a11y semantics, build-freshness poll, modal focus-trap/Escape/backdrop semantics) was already correctly ported.
+
+## Docstudio design-cue follow-up (2026-07-17) — forty-seventh run
+
+Fifth docstudio-cue pass, same directive repeated a fifth time after the 46th run's confirming pass had concluded the mining task "genuinely exhausted." A fresh independent Explore-agent re-verification (told what runs 42-46 shipped) found that conclusion was **not fully accurate**: `chat-approval-prompts.js:47-71`'s `buildApprovalPrompt` has an auto-focused free-text note textarea threaded through every approve/deny decision (prefixed onto the denial message so the assistant sees why it was denied) that the kit's `PermissionMenu` (a settings-style checkbox dropdown, architecturally different) had no analog for at all. Added a new `ApprovalPrompt` component (`overlay-primitives.js`) — an inline, in-thread permission card (name/category head, optional args preview, auto-focused optional note, once/session/all/deny actions via `onDecision(kind, note)`) — plus a `lock` icon added to the shared `ICON_PATHS` (didn't exist previously) and a barrel re-export per the standing barrel rule. Also landed the pass's secondary finding: `update-check.js`'s `/version.json` poll + persistent reload-nudge pattern, ported to `app.js` as `startBuildFreshnessPoll()` (90s interval, compares live `/health` `version` against `window.__SERVER_VERSION`, reuses the kit's existing `toast({actionLabel,onAction,duration:0})` from the 46th run rather than inventing a new notice surface). A first CSS pass tripped the frozen spacing-lint baseline (raw `6px 14px` button padding) — fixed by mapping to `--space-1-75`/`--space-3` and `--r-pill` instead of literal `999px`. Kit rebased once onto concurrent `v0.0.352`/`v0.0.353` releases (dist-only conflict, rebuilt fresh per the standing discipline). Kit pushed `e93f4f7`→`6d71b34`, all 3 checks green. Browser-witnessed live on `localhost:3009/gm/`: this session's `gm browser` verb had a real, repeat tool defect (`url=`/`dom=`/`screenshot=` prefixes evaluate in a detached Node vm, not the real page — `ReferenceError: document is not defined` despite `navigation_requested:true`) — recorded to durable memory (`agentgui-browser-verb-url-dom-prefix-broken-2026-07-17`) rather than left as a stuck PRD row, per gm's diagnose-the-tool discipline. Worked around by using only the bare `capture\n<script>` form (`page.goto`+`page.evaluate` inline) and reading results via `console.log('WITNESS:'+...)` inside the page context rather than the top-level `result` field, which came back `null` even on successful (`exit_code:0`) dispatches. Confirmed live: `toast()`'s action button fires `onAction(dismiss)`; `ApprovalPrompt` renders (`.ov-approval` present), note textarea auto-focuses, lock icon renders, Deny click fires `onDecision('deny', '')` correctly. agentgui re-vendored, pushed `1d37290`→`9b25faf`→`08483cf`, all 4 CI checks green both pushes.
+
 ## Docstudio design-cue follow-up (2026-07-17) — forty-sixth run, confirming pass
 
 Per gm-continue's mandatory first-confirming-pass discipline, a second independent Explore-agent survey (told what runs 42-46 already shipped, including the aria-live fix above) checked docstudio's remaining source (`update-check.js`, `debug-panel.js`, `chat-tabs.js`, `chat-model-selector.js`, `webview-detector.js`, `xls-preview.js`, `doc-tab.js`, `chat-approval-prompts.js`) and found one more narrow, real prop-surface gap: the kit's `toast()` (`editor-primitives.js:637`) only supported a self-dismissing `{message,kind,duration}` shape, unlike docstudio's `update-check.js:18-30` persistent click-to-reload notification bar. Added `actionLabel`/`onAction` props rendering a non-auto-dismissing button (`duration:0` already worked; the gap was no action-button support) — `.ds-ep-toast-action` styled with `--space-*` tokens (a first attempt with raw px literals tripped the frozen spacing-lint baseline, caught by `node scripts/build.mjs` before commit). CI caught a real miss on first push: `docs/component-props.md` was stale after the new `toast()` signature (`node scripts/generate-component-docs.mjs --check` lint), fixed by regenerating and re-pushing — a genuine CI-catches-a-real-gap case, not flakiness. Kit rebased twice cleanly onto concurrent `v0.0.350`/`v0.0.351` releases (dist-only, rebuilt fresh both times). Kit pushed `b5530cb`→`e93f4f7`, all 3 kit CI checks green. Browser-witnessed live on `localhost:3009/gm/` by importing the vendored module directly and calling `toast()` both ways: action variant renders `.ds-ep-toast.has-action` with a working `Reload` button whose click fires `onAction(dismiss)`; plain toast (no `actionLabel`/`onAction`) renders with no `has-action` class and no button, confirming backward compatibility. agentgui re-vendored, pushed `ed36a36`→`3a59c3b`, all 4 CI checks green. A second confirming pass after this one found nothing further.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.1082",
+  "version": "1.0.1084",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/site/app/js/app.js

@@ -2273,7 +2273,7 @@ function chatMain() {
           + (hasDraft ? 'This tab has an unsent draft that reloading will discard. ' : '')),
         Btn({ key: 'xureload', disabled: state.chat.busy, onClick: () => {
           if (state.chat.busy) return;
-          if (hasDraft && !window.confirm('Reloading will discard your unsent draft in this tab. Continue?')) return;
+          if (hasDraft) { state.chat.confirmingReloadDiscard = true; render(); return; }
           state.chat.externalUpdate = false;
           state.chat.messages = []; state.chat.resumeSid = null; state.chat.totalCost = 0;
           restoreChat(); render();
@@ -2528,6 +2528,19 @@ function chatMain() {
       onCwdClear: () => { state.chatCwd = ''; lsRemove('agentgui.cwd'); render(); },
       onCwdDraft: (v) => { state.cwdDraft = v; state.cwdError = null; debouncedCwdProbe(); },
     }),
+    state.chat.confirmingReloadDiscard ? ConfirmDialog({
+      key: 'confreload',
+      title: 'Discard unsent draft?',
+      message: 'Reloading will discard your unsent draft in this tab. Continue?',
+      confirmLabel: 'reload', cancelLabel: 'cancel', destructive: true,
+      onCancel: () => { state.chat.confirmingReloadDiscard = false; render(); },
+      onConfirm: () => {
+        state.chat.confirmingReloadDiscard = false;
+        state.chat.externalUpdate = false;
+        state.chat.messages = []; state.chat.resumeSid = null; state.chat.totalCost = 0;
+        restoreChat(); render();
+      },
+    }) : null,
   ].filter(Boolean);
 }