agentgui 1.0.1001 → 1.0.1003

package/AGENTS.md

@@ -1,8 +1,18 @@
 # AgentGUI — Agent Notes
 
-## CRITICAL — ACP is managed ONLY by `lib/acp-sdk-manager.js` (2026-06-20) — twentieth run
+## GUI cohesion sweep (2026-07-02) — twenty-first run
 
-A destructive quality run found a second, redundant ACP path: `lib/plugins/acp-plugin.js` eager-spawned all four ACP tools at boot on **conflicting/mismatched ports** (it mapped gemini=18101 / kilo=18102 / codex=18103, but the canonical `acp-sdk-manager.js` uses opencode=18100 / kilo=18101 / codex=18102), implemented no restart/health logic despite a `/api/acp/status` route that promised `restarts`, and **crashed server boot** with `[FATAL] Uncaught exception: Executable not found in $PATH: "codex"` whenever an ACP binary was missing. Its route was consumed by nobody (the client `acpStatusFor` reads `state.health.acp` from `getACPStatus()` → `acp-sdk-manager.js`); no plugin declared an `acp` dependency. **Deleted the file.** Rule: ACP lifecycle (on-demand start, health via `/provider`, restart-backoff, status) lives in `lib/acp-sdk-manager.js` alone — never add a second eager-spawn ACP manager. Also: `spawn()` for a missing binary surfaces ENOENT as an **async `'error'` event** under Bun (it escapes a synchronous try/catch), so every `spawn()` callsite needs a `proc.on('error', …)` handler. `acp-sdk-manager.js startProcess` was the only remaining callsite missing it (every other — terminal.js, claude-runner-direct.js, gm-agent-configs.js, claude-runner-acp.js — already had one); added `proc.on('error')` routing into the CRASHED + `scheduleRestart` backoff path. Witnessed: clean boot (0 FATAL), `[PLUGINS] Loaded extensions` no longer lists `acp`, `/api/acp/status` → 404, tests 46/46, browser localhost:3009/gm/ 0 console errors. Pushed this run.
+`gui-cohesion` workflow wf_6b9f1890-320 (25 agents, 12 confirmed). Kit (`../design`): `WorkspaceRail` items gain an optional `rail` attention-dot tone (a background surface, e.g. an errored Live session, can flag its nav item even while the user is elsewhere) — new `.ws-rail-item-flag` CSS. `WorkspaceShell` extends the pane-track `stableFrame` treatment to the sessions column (`keepSessionsTrack`, mirrors `keepPaneTrack`) so navigating chat/history/files/live/settings no longer reflows the 4-column grid to 3 and back. Mobile `ws-sessions`/`ws-pane` drawers now trap Tab/Shift+Tab focus (exported `trapTab` from `overlay-primitives.js`, reused in `shell.js`'s `toggleWsDrawer`) — previously Tab could walk focus out into the scrim. `ConversationList` rows accept a richer optional `status` ('error'|'stale'|'running'|'stopping') mirroring `SessionCard`'s `STATUS_DISC`, so a session pinned to the rail's "Running" group shows stuck-vs-busy. `ContextPane` gains a `recentFiles`/`onOpenFile` "recent files" panel. Also picked up inherited uncommitted 19th/20th-run work sitting dirty in the kit tree (agent-chat/chat/files-modals/files a11y+dropzone fixes) — commit and push before starting new work if `git status --porcelain` is non-empty at PLAN entry.
+
+App (`site/app/js/app.js`): new `computeLiveSessions()` is the single source of truth for the live session set (owned `chat.active` rows + external SSE-observed sessions) — shared by the `WorkspaceRail` Live badge count/error-flame tone AND `liveMain()`'s dashboard, closing a prior gap where the nav badge undercounted external sessions the dashboard showed. Sessions rail now renders on the Live tab too (previously only chat/history), so the "jump between conversations" rail and "all sessions at once" oversight view coexist. Follow-up chip "Open X in files" relabeled "Explain X" — it only ever called `sendChat`, never navigated, so the label lied about its behavior. `recentSessionFiles()` scans Edit/Write/MultiEdit/Read/NotebookEdit tool-call args for `file_path`/`path`/`notebook_path`, deduped, most-recent-first, feeding `ContextPane`. "disconnected" -> "offline" in two remaining spots (live-stream reconnect banner, ACP agent status) to match the connected/connecting/offline vocabulary used everywhere else. `refreshActive()` now skips its network poll while `document.hidden` (resumes immediately on `visibilitychange`) instead of polling every ~3.3s from backgrounded tabs.
+
+Server (`lib/http-handler.js`): `/health` now reports `corsWildcardOpen` (true when `CORS_ORIGIN=*` and no `PASSWORD`); the settings panel renders a persistent error `Alert` from it instead of relying on the console-only boot warning an operator not tailing logs would never see.
+
+Witnessed: kit build (`node scripts/build.mjs`) — lint-tokens/lint-glyphs/lint-null-children/lint-classes all OK; `test.js` 28/28; browser localhost:3010/gm/ chat/live/settings tabs, 0 console errors, sessions column confirmed present on Live tab post-fix. Kit pushed `anentrypoint-design` `6cfd115` (rebased onto concurrent-writer `fe50db5`, dist regenerated rather than hand-merging the conflicting minified bundle). agentgui pushed `3410178`. Both repos' CI (Test/Publish/Deploy GH Pages) green.
+
+## CRITICAL — ACP is managed ONLY by `lib/acp-sdk-manager.js`
+
+Twentieth run deleted a redundant eager-spawn `lib/plugins/acp-plugin.js` (conflicting ports, no restart logic, crashed boot on a missing binary). Rule: ACP lifecycle lives in `lib/acp-sdk-manager.js` alone; every `spawn()` callsite needs a `proc.on('error', …)` handler (ENOENT surfaces async under Bun). Full detail in rs-learn (recall "agentgui 20th run ACP redundant manager").
 
 ## GUI quality sweep (2026-06-19) — nineteenth run
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgui",
-  "version": "1.0.1001",
+  "version": "1.0.1003",
   "description": "Multi-agent ACP client with real-time communication",
   "type": "module",
   "main": "electron/main.js",

package/site/app/index.html

@@ -13,6 +13,20 @@
        `node scripts/build.mjs`, copy dist/247420.{js,css} here, then publish the
        kit so unpkg stays in sync. -->
   <link rel="stylesheet" href="./vendor/anentrypoint-design/247420.css">
+  <!-- Resolve the saved theme BEFORE first paint, synchronously (not type=module,
+       which would defer until the kit's module graph loads) - otherwise a user
+       with a stored 'paper'/light preference sees the hardcoded data-theme="dark"
+       shell flash before the kit's theme.js applies their real choice. Mirrors
+       theme.js's own KEY/VALID set; keep in sync if that module changes. -->
+  <script>
+    (function () {
+      try {
+        var v = window.localStorage.getItem('247420:theme');
+        var valid = { auto: 1, paper: 1, ink: 1, thebird: 1 };
+        document.documentElement.setAttribute('data-theme', valid[v] ? v : 'auto');
+      } catch (e) {}
+    })();
+  </script>
   <script type="importmap">
     { "imports": { "anentrypoint-design": "./vendor/anentrypoint-design/247420.js" } }
   </script>

package/site/app/js/app.js

@@ -738,7 +738,7 @@ function sessionsColumn() {
     const hits = (state.searchHits.results || []).slice(0, state.sessionsLimit);
     const items = hits.map((r, i) => ({
       sid: r.sid,
-      title: r.snippet || r.title || r.sid,
+      title: r.snippet || r.title || ('session ' + String(r.sid).slice(0, 8) + '…'),
       project: projectLabel(r.project) || '',
       time: r.ts ? fmtRelTime(r.ts) : '',
       running: false,
@@ -1902,13 +1902,13 @@ function chatMain() {
       children: [
         h('span', { key: 'cntxt' }, 'This cannot be undone. '),
         Btn({ key: 'cnno', onClick: () => { clearTimeout(_newChatArmTimer); state.confirmingNewChat = false; render(); }, children: 'cancel' }),
-        Btn({ key: 'cnyes', danger: true, onClick: confirmNewChat, children: 'yes, clear chat' })] }));
+        Btn({ key: 'cnyes', danger: true, onClick: confirmNewChat, children: 'yes, clear history' })] }));
   }
   if (state.cwdError) {
     banners.push(Alert({ key: 'cwderr', kind: 'warn', title: 'Invalid working directory', children: state.cwdError }));
   }
   if (state.chat.externalUpdate) {
-    banners.push(Alert({ key: 'xupd', kind: 'info', title: 'This conversation was updated in another tab',
+    banners.push(Alert({ key: 'xupd', kind: 'info', title: 'This chat was updated in another tab',
       children: [
         h('span', { key: 'xutxt' }, 'Reload it to see the latest turns, or dismiss to keep this tab\'s view. '),
         Btn({ key: 'xureload', disabled: state.chat.busy, onClick: () => {
@@ -3139,9 +3139,9 @@ function preferencesPanel() {
         'local data: ' + fmtBytes(lsBytes) + ' across ' + lsKeys + ' key' + (lsKeys === 1 ? '' : 's')),
       h('div', { key: 'expchatrow', class: 'agentgui-field-my' },
         Btn({ key: 'expchat', disabled: !savedChat,
-          title: savedChat ? 'Download the saved chat transcript as JSON' : 'no saved chat',
+          title: savedChat ? 'Download the saved chat transcript as JSON' : 'no saved chat yet',
           onClick: savedChat ? () => downloadBlob(savedChat, 'agentgui-chat-' + dateStamp() + '.json', 'application/json') : undefined,
-          children: savedChat ? 'export chat' : 'no saved chat' })),
+          children: 'export chat' })),
       h('div', { key: 'cwdnote', class: 'lede agentgui-field-my' },
         'working directory: set per-chat in the chat composer\'s cwd bar' + (state.chatCwd ? ' (current: ' + state.chatCwd + ')' : ' (currently: server default)')),
       state.confirmingClearData
@@ -3179,10 +3179,10 @@ function agentsPanel() {
           const avail = a.available !== false;
           const usable = avail || a.npxInstallable;     // selectable from this row
           const bits = [PROTOCOL_WORDS[a.protocol] || 'agent'];
-          if (!avail) bits.push(a.npxInstallable ? 'runs via npx' : 'not installed');
+          if (!avail) bits.push(a.npxInstallable ? 'installs automatically when used' : 'not installed');
           if (acp) bits.push(acp.healthy ? 'connected' : (acp.running ? 'connecting' : 'offline'));
           if (acp && acp.restartCount >= 1) bits.push('restarted ' + acp.restartCount + (acp.restartCount === 1 ? ' time' : ' times'));
-          if (acp && !acp.healthy && acp.providerInfo?.error) bits.push(acp.providerInfo.error);
+          if (acp && !acp.healthy && acp.providerInfo?.error) bits.push('provider error: ' + String(acp.providerInfo.error).slice(0, 80));
           if (acp && acp.idleMs > 3_600_000) bits.push(fmtDuration(acp.idleMs) + ' idle');
           return Row({
             key: 'ag' + a.id,

package/site/app/vendor/anentrypoint-design/247420.css

@@ -1129,7 +1129,7 @@
 .ds-247420 .row.rail-green::before,
 .ds-247420 .row.rail-purple::before,
 .ds-247420 .row.rail-flame::before { height: 56%; opacity: 1; }
-.ds-247420 .row.rail-green::before  { background: var(--accent); }
+.ds-247420 .row.rail-green::before  { background: var(--accent-ink); }
 .ds-247420 .row.rail-purple::before { background: var(--purple-2); }
 .ds-247420 .row.rail-flame::before  { background: var(--flame); }
 /* Differentiate the rail by SHAPE, not hue alone (color-blind safety): error
@@ -3849,7 +3849,7 @@
 /* Crumb band is the top chrome of the content column: a stable height so the
    top edge aligns with the rail head, and a left gutter matching .ws-main so
    the trail text is not flush against the rail border. */
-.ds-247420 .ws-crumb { flex: 0 0 auto; min-height: 48px; padding: 0 var(--space-5); display: flex; align-items: center; gap: var(--space-1); border-bottom: var(--bw-hair) solid var(--bg-3); }
+.ds-247420 .ws-crumb { flex: 0 0 auto; min-height: calc(var(--app-crumb-h) + var(--space-3)); padding: 0 var(--space-5); display: flex; align-items: center; gap: var(--space-1); border-bottom: var(--bw-hair) solid var(--bg-3); }
 .ds-247420 .ws-crumb-main { flex: 1 1 auto; min-width: 0; }
 /* Content column gutter. Claude-Code-class calm: file grid / dashboard / event
    list / history get a generous, consistent inner gutter instead of butting
@@ -4044,6 +4044,7 @@
 /* Disabled file actions (read-only row / in-flight mutation) stay visible but inert. */
 .ds-247420 .ds-file-act:disabled { opacity: .45; cursor: default; }
 .ds-247420 .ds-file-act:disabled:hover { background: transparent; color: var(--fg-3); }
+.ds-247420 .ds-file-act:focus-visible { outline: 2px solid var(--accent); outline-offset: 1px; }
 
 /* ============================================================
    Print — linearize WorkspaceShell so main content prints in full.
@@ -5939,7 +5940,7 @@
 /* Live: a persistent faint concentric ring (resting shape channel, independent
    of motion) with the pulse layered on top — so even at the pulse trough the
    disc reads as solid-fill + ring, never a bare solid that aliases stale. */
-.ds-247420 .status-dot-disc.status-dot-live { background: var(--accent); box-shadow: 0 0 0 2px color-mix(in oklab, var(--accent) 30%, transparent); animation: status-disc-pulse 1.8s ease-in-out infinite; }
+.ds-247420 .status-dot-disc.status-dot-live { background: var(--accent-ink); box-shadow: 0 0 0 2px color-mix(in oklab, var(--accent-ink) 30%, transparent); animation: status-disc-pulse 1.8s ease-in-out infinite; }
 .ds-247420 .status-dot-disc.status-dot-error { background: var(--flame); box-shadow: 0 0 0 1.5px color-mix(in oklab, var(--flame) 38%, transparent); }
 .ds-247420 .status-dot-disc.status-dot-connecting { background: transparent; box-shadow: inset 0 0 0 2px var(--amber); }
 /* Stale: a muted ring with a hollow centre — silhouette distinct from live's
@@ -5977,7 +5978,7 @@
 .ds-247420 .ds-session-new:hover { background: var(--bg-2); color: var(--fg); }
 /* Rail filter uses the shared .ds-search-input primitive (provides bg/border/
    radius/focus-ring); only the rail layout + touch floor live here. */
-.ds-247420 .ds-session-head .ds-search-input { order: 1; flex: 1 1 auto; min-width: 0; }
+.ds-247420 .ds-session-head .ds-search-input { order: 1; flex: 1 1 auto; min-width: 0; min-height: 36px; padding: 0 10px; }
 .ds-247420 .ds-session-new:focus-visible { outline: 2px solid var(--accent); outline-offset: 2px; }
 /* Touch floor (must FOLLOW the base rules - same specificity, order decides). */
 @media (pointer: coarse) {
@@ -5989,7 +5990,7 @@
    label sticks to the top of the scroll area for Claude-Desktop-style headers. */
 .ds-247420 .ds-session-group { display: flex; flex-direction: column; }
 .ds-247420 .ds-session-group-rows { display: flex; flex-direction: column; gap: 2px; }
-.ds-247420 .ds-session-group-label { position: sticky; top: 0; z-index: 1; background: var(--bg-1, var(--bg)); font-size: var(--fs-tiny); font-weight: 600; color: var(--fg-3); text-transform: uppercase; letter-spacing: var(--tr-caps); padding: var(--space-2) var(--space-2) var(--space-1); }
+.ds-247420 .ds-session-group-label { position: sticky; top: 0; z-index: 1; background: var(--bg-1, var(--bg)); font-size: var(--fs-xs); font-weight: 600; color: var(--fg-3); text-transform: uppercase; letter-spacing: var(--tr-caps); padding: var(--space-2) var(--space-2) var(--space-1); }
 .ds-247420 .ds-session-row {
   position: relative; display: flex; align-items: center; gap: var(--space-2);
   width: 100%; padding: var(--space-2); min-height: 52px; margin-bottom: 2px;
@@ -6004,7 +6005,7 @@
 }
 /* Rail tones MUST match .row.rail-* in app-shell.css so the same semantic state
    reads as one colour across the conversation list and content rows. */
-.ds-247420 .ds-session-row.rail-green::before { background: var(--accent); }
+.ds-247420 .ds-session-row.rail-green::before { background: var(--accent-ink); }
 .ds-247420 .ds-session-row.rail-purple::before { background: var(--purple-2); }
 .ds-247420 .ds-session-row.rail-flame::before { background: var(--flame); }
 .ds-247420 .ds-session-main { flex: 1; min-width: 0; display: flex; flex-direction: column; gap: 2px; }
@@ -6067,8 +6068,8 @@
 ---------------------------------------------------------------------------- */
 .ds-247420 .ds-context { display: flex; flex-direction: column; gap: var(--space-3); padding: var(--space-3); }
 .ds-247420 .ds-context .panel { background: var(--bg-2); border: var(--bw-hair) solid var(--bg-3); border-radius: var(--r-2); }
-.ds-247420 .ds-context .row .meta { font-family: var(--ff-mono); font-size: var(--fs-tiny); color: var(--fg-2); }
-.ds-247420 .ds-context .row .sub { font-family: var(--ff-mono); font-size: var(--fs-tiny); color: var(--fg-3); white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
+.ds-247420 .ds-context .row .meta { font-family: var(--ff-mono); font-size: var(--fs-xs); color: var(--fg-2); }
+.ds-247420 .ds-context .row .sub { font-size: var(--fs-xs); color: var(--fg-3); white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
 .ds-247420 .ds-context-actions { display: flex; gap: var(--space-2); }
 
 /* ============================================================================
@@ -6090,7 +6091,7 @@
   opacity: 0; transition: opacity var(--dur-snap, .12s) var(--ease, ease);
 }
 .ds-247420 .chat-code-block:hover .chat-code-copy, .ds-247420 .chat-code-block:focus-within .chat-code-copy { opacity: 1; }
-.ds-247420 .chat-code-copy.is-copied { color: var(--accent); border-color: var(--accent); }
+.ds-247420 .chat-code-copy.is-copied { color: var(--accent-ink); border-color: var(--accent); }
 .ds-247420 .chat-code-copy:focus-visible { outline: 2px solid var(--accent); outline-offset: 1px; opacity: 1; }
 /* Head-placed copy (structured CodeNode + FilePreviewCode) is always visible. */
 .ds-247420 .chat-code-head .spread { flex: 1; }
@@ -6137,7 +6138,7 @@
 
 /* --- C1: stale/idle dashboard status (static, NOT pulsing). --- */
 .ds-247420 .ds-dash-status.is-stale { color: var(--stale); }
-.ds-247420 .ds-dash-status.is-running { color: var(--accent); }
+.ds-247420 .ds-dash-status.is-running { color: var(--accent-ink); }
 
 /* --- C2: dashboard sort/filter toolbar + stream-state line. --- */
 /* The toolbar is part of the ONE header row (count | heartbeat ... filter,
@@ -6153,7 +6154,7 @@
   width: auto; border-radius: var(--r-1);
 }
 .ds-247420 .ds-dash-stream { font-size: var(--fs-tiny); color: var(--fg-3); }
-.ds-247420 .ds-dash-stream.is-connected { color: var(--accent); }
+.ds-247420 .ds-dash-stream.is-connected { color: var(--accent-ink); }
 .ds-247420 .ds-dash-stream.is-lost { color: var(--flame); }
 .ds-247420 .ds-dash-stream.is-connecting { color: var(--amber); }
 .ds-247420 .ds-dash-header .spread { flex: 1; }
@@ -6172,7 +6173,7 @@
   border: none; background: none; color: var(--fg-3);
   font-family: var(--ff-mono); font-size: var(--fs-sm);
 }
-.ds-247420 .ds-dash-select[aria-checked="true"] { color: var(--accent); }
+.ds-247420 .ds-dash-select[aria-checked="true"] { color: var(--accent-ink); }
 .ds-247420 .ds-dash-select:focus-visible { outline: 2px solid var(--accent); outline-offset: 1px; }
 
 /* --- C5: active dashboard card (current conversation). --- */
@@ -6336,7 +6337,7 @@
 
 /* Dashboard: shared session title heading (same string as the rails). */
 .ds-247420 .ds-dash-title {
-  font-size: var(--fs-body); font-weight: 600; color: var(--fg);
+  font-size: var(--fs-sm); font-weight: 600; color: var(--fg);
   white-space: nowrap; overflow: hidden; text-overflow: ellipsis;
 }
 
@@ -6370,7 +6371,7 @@
 .ds-247420 .chat-msg-flat .chat-stack { max-width: var(--measure); width: 100%; margin: 0; align-items: stretch; }
 .ds-247420 .chat-msg-flat.you .chat-stack { align-items: stretch; }
 .ds-247420 .chat-role { font-size: var(--fs-tiny); font-weight: 600; text-transform: uppercase; letter-spacing: var(--tr-caps); color: var(--fg-3); margin-bottom: var(--space-1); }
-.ds-247420 .chat-msg-flat.you .chat-role { color: var(--accent); }
+.ds-247420 .chat-msg-flat.you .chat-role { color: var(--accent-ink); }
 .ds-247420 .chat-msg-flat .chat-bubble { background: none; border: none; border-radius: 0; padding: 0; max-width: 100%; box-shadow: none; transform: none; }
 .ds-247420 .chat-msg-flat.you .chat-bubble { background: none; color: inherit; }
 /* Flat user turns reset their bubble to transparent, but the messenger rule
@@ -6443,7 +6444,7 @@
   padding: 2px var(--space-2); border-radius: var(--r-pill);
   background: color-mix(in oklab, var(--fg) 6%, transparent);
 }
-.ds-247420 .chat-msg .chat-tool.tool-running .chat-tool-status { color: var(--accent); background: color-mix(in oklab, var(--accent) 12%, transparent); }
+.ds-247420 .chat-msg .chat-tool.tool-running .chat-tool-status { color: var(--accent-ink); background: color-mix(in oklab, var(--accent) 12%, transparent); }
 .ds-247420 .chat-msg .chat-tool.tool-error .chat-tool-status { color: var(--flame); background: color-mix(in oklab, var(--flame) 12%, transparent); }
 /* Completed tool: a positive (success) tone so done reads distinctly from the
    neutral pill and from the accent-toned running pill (--success = green-2). */
@@ -6508,7 +6509,7 @@
    shape, not hue alone. CSS-drawn discs, not glyphs (glyph policy clean). */
 .ds-247420 .ds-dash-breakdown .seg { display: inline-flex; align-items: center; gap: var(--space-1); font-weight: 600; }
 .ds-247420 .ds-dash-breakdown .seg::before { content: ''; width: 7px; height: 7px; border-radius: 50%; flex: none; }
-.ds-247420 .ds-dash-breakdown .seg.is-running { color: var(--accent); }
+.ds-247420 .ds-dash-breakdown .seg.is-running { color: var(--accent-ink); }
 .ds-247420 .ds-dash-breakdown .seg.is-running::before { background: var(--accent); box-shadow: 0 0 0 1.5px color-mix(in oklab, var(--accent) 30%, transparent); }
 .ds-247420 .ds-dash-breakdown .seg.is-error { color: var(--flame); }
 .ds-247420 .ds-dash-breakdown .seg.is-error::before { background: var(--flame); box-shadow: 0 0 0 1.5px color-mix(in oklab, var(--flame) 38%, transparent); }