agentgate 0.3.0 → 0.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agentgate",
-  "version": "0.3.0",
+  "version": "0.3.2",
   "type": "module",
   "description": "API gateway for AI agents with human-in-the-loop write approval",
   "main": "src/index.js",

package/src/lib/queueExecutor.js

@@ -1,5 +1,5 @@
 import { getAccountCredentials, setAccountCredentials, updateQueueStatus, getQueueEntry } from './db.js';
-import { notifyClawdbot } from './notifier.js';
+import { notifyAgentQueueStatus } from './agentNotifier.js';
 
 // Service base URLs
 const SERVICE_URLS = {
@@ -277,8 +277,8 @@ function finalizeEntry(entryId, status, results) {
 
   // Send notification to Clawdbot (async, don't block)
   const updatedEntry = getQueueEntry(entryId);
-  notifyClawdbot(updatedEntry).catch(err => {
-    console.error('[notifier] Failed to notify Clawdbot:', err.message);
+  notifyAgentQueueStatus(updatedEntry).catch(err => {
+    console.error('[agentNotifier] Failed to notify agent:', err.message);
   });
 }
 
@@ -327,7 +327,7 @@ export async function executeQueueEntry(entry) {
         headers
       };
 
-      if (req.body && ['POST', 'PUT', 'PATCH'].includes(req.method.toUpperCase())) {
+      if (req.body && ['POST', 'PUT', 'PATCH', 'DELETE'].includes(req.method.toUpperCase())) {
         if (req.binaryBase64) {
           // Binary data encoded as base64 (for blob uploads)
           fetchOptions.body = Buffer.from(req.body, 'base64');

package/src/routes/bluesky.js

@@ -16,6 +16,15 @@ export const serviceInfo = {
     'GET /api/bluesky/{accountName}/app.bsky.feed.getTimeline',
     'GET /api/bluesky/{accountName}/app.bsky.feed.getAuthorFeed?actor={handle}',
     'GET /api/bluesky/{accountName}/app.bsky.actor.getProfile?actor={handle}'
+  ],
+  writeGuidelines: [
+    'Posts require FACETS for clickable links, mentions, and hashtags - they are NOT auto-detected',
+    'Facet positions use UTF-8 BYTE offsets, not character positions (emoji=4 bytes, em-dash=3 bytes)',
+    'Link facet: { index: { byteStart, byteEnd }, features: [{ $type: "app.bsky.richtext.facet#link", uri: "https://..." }] }',
+    'Mention facet requires DID (resolve via com.atproto.identity.resolveHandle), not handle',
+    'Hashtag facet: tag value should NOT include the # symbol',
+    'Always include "langs" array (e.g. ["en"]) and "createdAt" ISO timestamp',
+    'Use TextEncoder to calculate byte offsets: encoder.encode(text.slice(0, start)).length'
   ]
 };
 

package/src/routes/ui.js

@@ -4,14 +4,12 @@ import {
   setAdminPassword, verifyAdminPassword, hasAdminPassword,
   listQueueEntries, getQueueEntry, updateQueueStatus, clearQueueByStatus, deleteQueueEntry, getPendingQueueCount, getQueueCounts,
   listApiKeys, createApiKey, deleteApiKey, updateAgentWebhook, getApiKeyById,
-  listUnnotifiedEntries,
   getMessagingMode, setMessagingMode, listPendingMessages, listAgentMessages,
   approveAgentMessage, rejectAgentMessage, deleteAgentMessage, clearAgentMessagesByStatus, getMessageCounts, getAgentMessage
 } from '../lib/db.js';
 import { connectHsync, disconnectHsync, getHsyncUrl, isHsyncConnected } from '../lib/hsyncManager.js';
 import { executeQueueEntry } from '../lib/queueExecutor.js';
-import { notifyClawdbot, retryNotification } from '../lib/notifier.js';
-import { notifyAgentMessage, notifyMessageRejected } from '../lib/agentNotifier.js';
+import { notifyAgentMessage, notifyMessageRejected, notifyAgentQueueStatus } from '../lib/agentNotifier.js';
 import { registerAllRoutes, renderAllCards } from './ui/index.js';
 
 const router = Router();
@@ -126,11 +124,10 @@ router.get('/', (req, res) => {
   const hsyncUrl = getHsyncUrl();
   const hsyncConnected = isHsyncConnected();
   const pendingQueueCount = getPendingQueueCount();
-  const notificationsConfig = getSetting('notifications');
   const messagingMode = getMessagingMode();
   const pendingMessagesCount = listPendingMessages().length;
 
-  res.send(renderPage(accounts, { hsyncConfig, hsyncUrl, hsyncConnected, pendingQueueCount, notificationsConfig, messagingMode, pendingMessagesCount }));
+  res.send(renderPage(accounts, { hsyncConfig, hsyncUrl, hsyncConnected, pendingQueueCount, messagingMode, pendingMessagesCount }));
 });
 
 // Register all service routes (github, bluesky, reddit, etc.)
@@ -157,78 +154,9 @@ router.post('/hsync/delete', async (req, res) => {
   res.redirect('/ui');
 });
 
-// Notification settings
-router.post('/notifications/setup', (req, res) => {
-  const { url, token, events } = req.body;
-  if (!url) {
-    return res.status(400).send('Webhook URL required');
-  }
-
-  // Parse events - could be comma-separated string or array
-  let eventList = ['completed', 'failed'];
-  if (events) {
-    eventList = Array.isArray(events) ? events : events.split(',').map(e => e.trim());
-  }
-
-  setSetting('notifications', {
-    clawdbot: {
-      enabled: true,
-      url: url.replace(/\/$/, ''),
-      token: token || '',
-      events: eventList,
-      retryAttempts: 3,
-      retryDelayMs: 5000
-    }
-  });
-  res.redirect('/ui');
-});
-
-router.post('/notifications/delete', (req, res) => {
-  deleteSetting('notifications');
-  res.redirect('/ui');
-});
-
-router.post('/notifications/test', async (req, res) => {
-  const wantsJson = req.headers.accept?.includes('application/json');
-  const config = getSetting('notifications');
+// Notification settings removed - using agent-specific webhooks
 
-  if (!config?.clawdbot?.enabled || !config.clawdbot.url || !config.clawdbot.token) {
-    const error = 'Notifications not configured';
-    return wantsJson
-      ? res.status(400).json({ success: false, error })
-      : res.status(400).send(error);
-  }
 
-  try {
-    const response = await fetch(config.clawdbot.url, {
-      method: 'POST',
-      headers: {
-        'Authorization': `Bearer ${config.clawdbot.token}`,
-        'Content-Type': 'application/json'
-      },
-      body: JSON.stringify({
-        text: '🧪 [agentgate] Test notification - webhook is working!',
-        mode: 'now'
-      })
-    });
-
-    if (response.ok) {
-      return wantsJson
-        ? res.json({ success: true })
-        : res.redirect('/ui?notification_test=success');
-    } else {
-      const text = await response.text().catch(() => '');
-      const error = `HTTP ${response.status}: ${text.substring(0, 100)}`;
-      return wantsJson
-        ? res.status(400).json({ success: false, error })
-        : res.redirect('/ui?notification_test=failed');
-    }
-  } catch (err) {
-    return wantsJson
-      ? res.status(500).json({ success: false, error: err.message })
-      : res.redirect('/ui?notification_test=failed');
-  }
-});
 
 // Agent Messaging settings
 router.post('/messaging/mode', (req, res) => {
@@ -354,8 +282,7 @@ router.get('/queue', (req, res) => {
     entries = listQueueEntries(filter);
   }
   const counts = getQueueCounts();
-  const unnotified = listUnnotifiedEntries();
-  res.send(renderQueuePage(entries, filter, counts, unnotified.length));
+  res.send(renderQueuePage(entries, filter, counts));
 });
 
 router.post('/queue/:id/approve', async (req, res) => {
@@ -412,10 +339,10 @@ router.post('/queue/:id/reject', async (req, res) => {
 
   updateQueueStatus(id, 'rejected', { rejection_reason: reason || 'No reason provided' });
 
-  // Send notification to Clawdbot
+  // Send notification to submitting agent and global Clawdbot webhook
   const updated = getQueueEntry(id);
-  notifyClawdbot(updated).catch(err => {
-    console.error('[notifier] Failed to notify Clawdbot:', err.message);
+  notifyAgentQueueStatus(updated).catch(err => {
+    console.error('[agentNotifier] Failed to notify agent:', err.message);
   });
 
   const counts = getQueueCounts();
@@ -472,35 +399,15 @@ router.post('/queue/:id/notify', async (req, res) => {
   const { id } = req.params;
   const wantsJson = req.headers.accept?.includes('application/json');
 
-  const result = await retryNotification(id, getQueueEntry);
   const updated = getQueueEntry(id);
 
   if (wantsJson) {
-    return res.json({ success: result.success, error: result.error, entry: updated });
+    return res.json({ success: true, entry: updated });
   }
   res.redirect('/ui/queue');
 });
 
-// Retry all failed notifications
-router.post('/queue/notify-all', async (req, res) => {
-  const wantsJson = req.headers.accept?.includes('application/json');
-  const unnotified = listUnnotifiedEntries();
 
-  if (unnotified.length === 0) {
-    return wantsJson
-      ? res.json({ success: true, count: 0 })
-      : res.redirect('/ui/queue');
-  }
-
-  // Batch into single notification
-  const { notifyClawdbotBatch } = await import('../lib/notifier.js');
-  const result = await notifyClawdbotBatch(unnotified);
-
-  if (wantsJson) {
-    return res.json({ success: result.success, error: result.error, count: unnotified.length });
-  }
-  res.redirect('/ui/queue');
-});
 
 // API Keys Management
 router.get('/keys', (req, res) => {
@@ -577,8 +484,7 @@ router.delete('/keys/:id', (req, res) => {
 
 // HTML Templates
 
-function renderPage(accounts, { hsyncConfig, hsyncUrl, hsyncConnected, pendingQueueCount, notificationsConfig, messagingMode, pendingMessagesCount }) {
-  const clawdbotConfig = notificationsConfig?.clawdbot;
+function renderPage(accounts, { hsyncConfig, hsyncUrl, hsyncConnected, pendingQueueCount, messagingMode, pendingMessagesCount }) {
   return `<!DOCTYPE html>
 <html>
 <head>
@@ -695,61 +601,6 @@ curl -X POST http://localhost:${PORT}/api/queue/github/personal/submit \\
   </div>
 
   <div class="card">
-    <details ${clawdbotConfig?.enabled ? 'open' : ''}>
-      <summary>Clawdbot Notifications ${clawdbotConfig?.enabled ? '<span class="status configured">Configured</span>' : ''}</summary>
-      <div style="margin-top: 16px;">
-        <div id="notification-feedback"></div>
-        ${clawdbotConfig?.enabled ? `
-          <p>Webhook URL: <strong>${clawdbotConfig.url}</strong></p>
-          <p>Events: <code>${(clawdbotConfig.events || ['completed', 'failed']).join(', ')}</code></p>
-          <div style="display: flex; gap: 8px; margin-top: 12px;">
-            <button type="button" class="btn-primary btn-sm" id="test-notification-btn" onclick="testNotification()">Send Test</button>
-            <form method="POST" action="/ui/notifications/delete" style="margin: 0;">
-              <button type="submit" class="btn-danger btn-sm">Disable</button>
-            </form>
-          </div>
-          <script>
-            async function testNotification() {
-              const btn = document.getElementById('test-notification-btn');
-              const feedback = document.getElementById('notification-feedback');
-              btn.disabled = true;
-              btn.textContent = 'Sending...';
-              feedback.innerHTML = '';
-              
-              try {
-                const res = await fetch('/ui/notifications/test', {
-                  method: 'POST',
-                  headers: { 'Accept': 'application/json' }
-                });
-                const data = await res.json();
-                
-                if (data.success) {
-                  feedback.innerHTML = '<div class="success-message" style="margin-bottom: 16px;">✓ Test notification sent!</div>';
-                } else {
-                  feedback.innerHTML = '<div class="error-message" style="margin-bottom: 16px;">✗ ' + (data.error || 'Failed to send') + '</div>';
-                }
-              } catch (err) {
-                feedback.innerHTML = '<div class="error-message" style="margin-bottom: 16px;">✗ ' + err.message + '</div>';
-              }
-              
-              btn.disabled = false;
-              btn.textContent = 'Send Test';
-            }
-          </script>
-        ` : `
-          <p class="help">Send notifications to <a href="https://docs.clawd.bot" target="_blank">Clawdbot</a> when queue items are completed, failed, or rejected.</p>
-          <form method="POST" action="/ui/notifications/setup">
-            <label>Webhook URL</label>
-            <input type="text" name="url" placeholder="https://your-gateway.example.com/hooks/wake" required>
-            <label>Token</label>
-            <input type="password" name="token" placeholder="Clawdbot hooks token" required>
-            <label>Events (comma-separated)</label>
-            <input type="text" name="events" placeholder="completed, failed, rejected" value="completed, failed, rejected">
-            <button type="submit" class="btn-primary">Enable Notifications</button>
-          </form>
-        `}
-      </div>
-    </details>
   </div>
 </body>
 </html>`;
@@ -804,7 +655,7 @@ function renderSetupPasswordPage(error = '') {
 </html>`;
 }
 
-function renderQueuePage(entries, filter, counts, unnotifiedCount = 0) {
+function renderQueuePage(entries, filter, counts = 0) {
   const escapeHtml = (str) => {
     if (typeof str !== 'string') str = JSON.stringify(str, null, 2);
     return str.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
@@ -1126,7 +977,7 @@ function renderQueuePage(entries, filter, counts, unnotifiedCount = 0) {
   <div class="filter-bar" id="filter-bar">
     ${filterLinks}
     <div class="clear-section">
-      ${unnotifiedCount > 0 ? `<button type="button" class="btn-sm btn-primary" onclick="retryAllNotifications()" id="retry-all-btn">Retry ${unnotifiedCount} Notification${unnotifiedCount > 1 ? 's' : ''}</button>` : ''}
+      
       ${filter === 'completed' && counts.completed > 0 ? '<button type="button" class="btn-sm btn-danger" onclick="clearByStatus(\'completed\')">Clear Completed</button>' : ''}
       ${filter === 'failed' && counts.failed > 0 ? '<button type="button" class="btn-sm btn-danger" onclick="clearByStatus(\'failed\')">Clear Failed</button>' : ''}
       ${filter === 'rejected' && counts.rejected > 0 ? '<button type="button" class="btn-sm btn-danger" onclick="clearByStatus(\'rejected\')">Clear Rejected</button>' : ''}

package/src/lib/notifier.js

@@ -1,286 +0,0 @@
-import { getSetting, updateQueueNotification } from './db.js';
-
-/**
- * Send a notification to Clawdbot webhook when queue items complete/fail
- */
-
-const DEFAULT_RETRY_ATTEMPTS = 3;
-const DEFAULT_RETRY_DELAY_MS = 5000;
-
-/**
- * Find the most relevant result to display (usually last one with a URL, or first failure)
- */
-function findRelevantResult(results, forError = false) {
-  if (!results?.length) return null;
-  
-  if (forError) {
-    // For errors, find the first non-ok result
-    return results.find(r => !r.ok) || results[results.length - 1];
-  }
-  
-  // For success, find the last result with a useful URL (PR, issue, etc.)
-  // Search backwards to get the most relevant one (e.g., PR URL, not branch ref)
-  for (let i = results.length - 1; i >= 0; i--) {
-    const r = results[i];
-    if (r.body?.html_url || r.body?.url) {
-      return r;
-    }
-  }
-  
-  // Fallback to last result
-  return results[results.length - 1];
-}
-
-/**
- * Format the notification text for a queue entry
- */
-function formatNotification(entry) {
-  const emoji = entry.status === 'completed' ? '✅' :
-    entry.status === 'failed' ? '❌' : '🚫';
-
-  let text = `${emoji} [agentgate] Queue #${entry.id} ${entry.status}`;
-  text += `\n→ ${entry.service}/${entry.account_name}`;
-
-  // Include key result info (e.g., PR URL, issue URL)
-  if (entry.status === 'completed' && entry.results?.length) {
-    const relevantResult = findRelevantResult(entry.results, false);
-    if (relevantResult?.body) {
-      // GitHub PR/Issue
-      if (relevantResult.body.html_url) {
-        text += `\n→ ${relevantResult.body.html_url}`;
-      }
-      // Other useful fields
-      else if (relevantResult.body.url) {
-        text += `\n→ ${relevantResult.body.url}`;
-      }
-    }
-  }
-
-  // Include error info for failures
-  if (entry.status === 'failed' && entry.results?.length) {
-    const failingResult = findRelevantResult(entry.results, true);
-    if (failingResult.error) {
-      text += `\n→ Error: ${failingResult.error}`;
-    } else if (failingResult.body?.message) {
-      text += `\n→ Error: ${failingResult.body.message}`;
-    } else if (!failingResult.ok && failingResult.status) {
-      text += `\n→ Error: HTTP ${failingResult.status}`;
-    }
-  }
-
-  // Include rejection reason
-  if (entry.status === 'rejected' && entry.rejection_reason) {
-    text += `\n→ Reason: ${entry.rejection_reason}`;
-  }
-
-  // Original comment/intent
-  if (entry.comment) {
-    // Truncate long comments
-    const comment = entry.comment.length > 100
-      ? entry.comment.substring(0, 100) + '...'
-      : entry.comment;
-    text += `\nOriginal: "${comment}"`;
-  }
-
-  return text;
-}
-
-/**
- * Sleep helper
- */
-function sleep(ms) {
-  return new Promise(resolve => setTimeout(resolve, ms));
-}
-
-/**
- * Send notification to Clawdbot
- * @param {object} entry - The queue entry to notify about
- * @returns {Promise<{success: boolean, error?: string}>}
- */
-export async function notifyClawdbot(entry) {
-  const config = getSetting('notifications');
-
-  if (!config?.clawdbot?.enabled) {
-    return { success: true, skipped: true };
-  }
-
-  const { url, token, events, retryAttempts, retryDelayMs } = config.clawdbot;
-
-  // Check if this event type should be notified
-  const allowedEvents = events || ['completed', 'failed'];
-  if (!allowedEvents.includes(entry.status)) {
-    return { success: true, skipped: true };
-  }
-
-  if (!url || !token) {
-    const error = 'Clawdbot notification config incomplete (missing url or token)';
-    updateQueueNotification(entry.id, false, error);
-    return { success: false, error };
-  }
-
-  const payload = {
-    text: formatNotification(entry),
-    mode: 'now'
-  };
-
-  const maxAttempts = retryAttempts || DEFAULT_RETRY_ATTEMPTS;
-  const delay = retryDelayMs || DEFAULT_RETRY_DELAY_MS;
-  let lastError = null;
-
-  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
-    try {
-      const response = await fetch(url, {
-        method: 'POST',
-        headers: {
-          'Authorization': `Bearer ${token}`,
-          'Content-Type': 'application/json'
-        },
-        body: JSON.stringify(payload)
-      });
-
-      if (response.ok) {
-        // Success
-        updateQueueNotification(entry.id, true, null);
-        return { success: true };
-      }
-
-      // Non-OK response
-      const text = await response.text().catch(() => '');
-      lastError = `HTTP ${response.status}: ${text.substring(0, 100)}`;
-
-    } catch (err) {
-      lastError = err.message;
-    }
-
-    // Retry after delay (unless last attempt)
-    if (attempt < maxAttempts) {
-      await sleep(delay);
-    }
-  }
-
-  // All retries failed
-  updateQueueNotification(entry.id, false, lastError);
-  return { success: false, error: lastError };
-}
-
-/**
- * Retry notification for a specific queue entry
- */
-export async function retryNotification(entryId, getQueueEntry) {
-  const entry = getQueueEntry(entryId);
-  if (!entry) {
-    return { success: false, error: 'Queue entry not found' };
-  }
-
-  // Only retry for completed/failed/rejected entries
-  if (!['completed', 'failed', 'rejected'].includes(entry.status)) {
-    return { success: false, error: 'Can only notify for completed/failed/rejected entries' };
-  }
-
-  return notifyClawdbot(entry);
-}
-
-/**
- * Format a short summary line for batch notifications
- */
-function formatBatchLine(entry) {
-  const emoji = entry.status === 'completed' ? '✅' :
-    entry.status === 'failed' ? '❌' : '🚫';
-
-  let line = `${emoji} #${entry.id.substring(0, 8)} - ${entry.service}/${entry.account_name}`;
-
-  // Add brief result info
-  if (entry.status === 'completed') {
-    const relevantResult = findRelevantResult(entry.results, false);
-    if (relevantResult?.body?.html_url) {
-      line += ` - ${relevantResult.body.html_url}`;
-    }
-  } else if (entry.status === 'failed') {
-    const failingResult = findRelevantResult(entry.results, true);
-    const err = failingResult?.error || failingResult?.body?.message || (failingResult && !failingResult.ok ? `HTTP ${failingResult.status || '?'}` : 'Unknown error');
-    line += ` - ${err.substring(0, 50)}`;
-  } else if (entry.status === 'rejected') {
-    line += ` - ${(entry.rejection_reason || 'rejected').substring(0, 50)}`;
-  }
-
-  return line;
-}
-
-/**
- * Send a single batched notification for multiple queue entries
- * @param {object[]} entries - Array of queue entries to notify about
- * @returns {Promise<{success: boolean, error?: string}>}
- */
-export async function notifyClawdbotBatch(entries) {
-  const config = getSetting('notifications');
-
-  if (!config?.clawdbot?.enabled) {
-    return { success: true, skipped: true };
-  }
-
-  const { url, token, retryAttempts, retryDelayMs } = config.clawdbot;
-
-  if (!url || !token) {
-    const error = 'Clawdbot notification config incomplete (missing url or token)';
-    for (const entry of entries) {
-      updateQueueNotification(entry.id, false, error);
-    }
-    return { success: false, error };
-  }
-
-  // Build batched message
-  const completed = entries.filter(e => e.status === 'completed').length;
-  const failed = entries.filter(e => e.status === 'failed').length;
-  const rejected = entries.filter(e => e.status === 'rejected').length;
-
-  const counts = [];
-  if (completed) counts.push(`${completed} completed`);
-  if (failed) counts.push(`${failed} failed`);
-  if (rejected) counts.push(`${rejected} rejected`);
-
-  let text = `📬 [agentgate] Catch-up: ${entries.length} item${entries.length > 1 ? 's' : ''} (${counts.join(', ')})\n\n`;
-  text += entries.map(formatBatchLine).join('\n');
-
-  const payload = { text, mode: 'now' };
-
-  const maxAttempts = retryAttempts || DEFAULT_RETRY_ATTEMPTS;
-  const delay = retryDelayMs || DEFAULT_RETRY_DELAY_MS;
-  let lastError = null;
-
-  for (let attempt = 1; attempt <= maxAttempts; attempt++) {
-    try {
-      const response = await fetch(url, {
-        method: 'POST',
-        headers: {
-          'Authorization': `Bearer ${token}`,
-          'Content-Type': 'application/json'
-        },
-        body: JSON.stringify(payload)
-      });
-
-      if (response.ok) {
-        // Success - mark all as notified
-        for (const entry of entries) {
-          updateQueueNotification(entry.id, true, null);
-        }
-        return { success: true };
-      }
-
-      const respText = await response.text().catch(() => '');
-      lastError = `HTTP ${response.status}: ${respText.substring(0, 100)}`;
-
-    } catch (err) {
-      lastError = err.message;
-    }
-
-    if (attempt < maxAttempts) {
-      await sleep(delay);
-    }
-  }
-
-  // All retries failed
-  for (const entry of entries) {
-    updateQueueNotification(entry.id, false, lastError);
-  }
-  return { success: false, error: lastError };
-}