agentbox-app 0.1.6 → 0.1.11

package/main/instruction-settings.mjs

@@ -1,16 +1,14 @@
 // A fixed allowlist exposes the instruction files, never arbitrary paths.
 // Defaults are shipped separately so an edited live file can always be reset.
 //
-// THERE ARE THREE OF THEM NOW, NOT FOUR (w-3dc46f3a67, 2026-09-22). Hers, on
-// being shown the five prompts a person could edit: "Those five layers of
-// prompts that the user can adjust might be overkill. Maybe we decide not to
-// expose some of them, or maybe we would best aggregate others."
+// THERE ARE THREE OF THEM NOW, NOT FOUR (w-3dc46f3a67). Five editable layers of
+// prompts was too many for a person to manage, so some were merged.
 //
 // A person opening that page is answering two questions, what should agents do
 // and how should they talk to me, so the writing rules and the finishing rules
-// became ONE document: `message-rules.md`, "How agents write to you". The
-// evidence they were one thing all along is her own rules file, where three of
-// four paragraphs are about how agents write to her rather than what they do.
+// became ONE document: `message-rules.md`, "How agents write to you". In
+// practice a rules file is mostly about how agents write to the person rather
+// than what they do, which is why the two were one thing all along.
 // `joinMessageRules` below carries the two old files into the new one.
 import fs from 'node:fs';
 import path from 'node:path';
@@ -19,12 +17,11 @@ import {fileURLToPath} from 'node:url';
 // one place that holds it. Typing it here is what left three dead names in the
 // code through two renames (tests/the-app-is-named-in-one-place).
 import {nameSlug} from '../shared/product-name.mjs';
-// ADHD MODE IS A FOURTH FILE, NOT A PARAGRAPH INSIDE THE THIRD (w-5737fe67cf,
-// 2026-09-25). Hers: "it should really just append that text to your content if
-// you have ADHD mode on, and then remove it when you turn it off... Maybe it
-// opens a new section with additional instructions that get applied." Kept in
-// its own file so her edits to it never mix with her own rules, and survive
-// while the mode is off. Whether it is on lives in her config (`adhdMode`).
+// ADHD MODE IS A FOURTH FILE, NOT A PARAGRAPH INSIDE THE THIRD (w-5737fe67cf).
+// Its text is appended to the instructions while the mode is on and removed when
+// it is off. Kept in its own file so edits to it never mix with the user's own
+// rules, and survive while the mode is off. Whether it is on lives in the
+// config (`adhdMode`).
 const files = {rules:'founder.md',messages:'message-rules.md',adhd:'adhd-mode.md',system:'worker.md'};
 // The two names the joined document replaced, read only by the migration.
 const WAS_MESSAGES = ['writing-rules.md','finishing.md'];
@@ -33,35 +30,38 @@ function fileFor(id) {
  if (!Object.hasOwn(files,id)) throw new Error('Unknown instruction section');
  return files[id];
 }
+// WHAT THE BOX OPENS ON when the user has written nothing. The message rules
+// box starts empty like the general one (w-3ec9f07978): the app's own message
+// rules are not the user's to edit, because the inbox reads every message by
+// them, so they ride on every run from the checkout and never sit in the box.
+const boxDefault=(id)=>(id==='rules'||id==='messages') ? '' : defaults[id];
 export function readInstruction(appDir,id,shippedDir=appDir) {
  const file=fileFor(id);
- const defaultText=id==='rules' ? '' : defaults[id];
+ const defaultText=boxDefault(id);
  let text=defaultText;
  try {text=fs.readFileSync(path.join(appDir,'briefs',file),'utf8');} catch(e) {if(e.code!=='ENOENT') throw e; if(id==='system') text=readSystemTemplate(shippedDir,appDir);}
  return {text,defaultText};
 }
 /**
  * RESTORE POINTS, BECAUSE A SAVE USED TO BE THE END OF THE OLD TEXT
- * (w-94b3af4e70, 2026-09-28).
+ * (w-94b3af4e70).
  *
- * Hers, on why the page needs this at all: "a user might change the agent
- * instructions and lose some critical information to the point where maybe the
- * app doesn't work the way they want it or they think, 'It worked better
- * before. I want to restore it.'"
+ * Why the page needs this at all: a user can edit the agent instructions, lose
+ * something that mattered, and want an earlier version back.
  *
- * Until this, the only thing the page could hand back was our shipped text, and
- * on her Mac that means deleting about 21,000 characters of her own writing to
- * recover 5,654 of ours. The box saves 400ms after a keystroke, straight over
+ * Until this, the only thing the page could hand back was our shipped text, so
+ * recovering meant throwing away everything the user had written to get the
+ * default. The box saves 400ms after a keystroke, straight over
  * the file, so a paragraph deleted at noon was gone at noon.
  *
  * WHAT COUNTS AS A VERSION: the text that was in the file before a save, kept
  * under the time that text was itself saved, so the list reads as the versions
- * she wrote rather than as a log of keystrokes. A burst of typing is one
+ * the user wrote rather than as a log of keystrokes. A burst of typing is one
  * version and not two hundred, because text that has been sitting untouched for
  * less than QUIET_MS is still being written and is not a place to come back to.
  *
  * It never throws into a save. Losing a restore point is a small thing and
- * failing to write what she just typed is not.
+ * failing to write what the user just typed is not.
  */
 const HISTORY='instruction-history';
 const KEEP=20;
@@ -84,13 +84,13 @@ export function readVersion(appDir,id,ts) {
  if(!Number.isFinite(at)) throw new Error('Unknown version');
  return {text:fs.readFileSync(path.join(historyDir(appDir,id),`${at}.md`),'utf8')};
 }
-function keepVersion(appDir,id,now=Date.now()) {
+function keepVersion(appDir,id,now=Date.now(),always=false) {
  try {
   const live=path.join(appDir,'briefs',fileFor(id));
   let stat,text;
   try {stat=fs.statSync(live); text=fs.readFileSync(live,'utf8');}
   catch(e) {if(e.code!=='ENOENT') throw e; return;}
-  if(now-stat.mtimeMs<QUIET_MS) return;
+  if(!always&&now-stat.mtimeMs<QUIET_MS) return;
   const ts=Math.floor(stat.mtimeMs);
   const have=listVersions(appDir,id);
   if(have.some(v=>v.ts===ts)) return;
@@ -123,21 +123,20 @@ export function readSystemTemplate(appDir,dataDir=appDir) {
 }
 
 /**
- * HER OWN WRITING, CARRIED OUT OF THE CHECKOUT ONCE (w-3dc46f3a67, 2026-09-21).
+ * THE USER'S OWN WRITING, CARRIED OUT OF THE CHECKOUT ONCE (w-3dc46f3a67).
  *
  * Until this ran, the four boxes in Settings read and wrote `dataDir/briefs`,
  * and running from source `dataDir` is the git checkout the whole fleet works
- * in. Measured on her repo that day: briefs/founder.md had four commits, all of
- * them an agent's, and the working copy matched the newest exactly. Her rules
- * were being kept in the one folder every worker is allowed to `git checkout`.
+ * in. So the user's rules were being kept in the one folder every worker is
+ * allowed to `git checkout`, and agents had been committing to them.
  *
- * WHAT MOVES IS ONLY WHAT SHE WROTE, and the test for that is the shipped
+ * WHAT MOVES IS ONLY WHAT THE USER WROTE, and the test for that is the shipped
  * default. A file whose text IS the default is our file sitting where we put
- * it, and copying it into her folder would freeze it there: the next release's
- * worker brief would never reach her, because her "edit" would shadow it
- * forever. So a file is carried across only when it differs from the default,
- * which on her Mac is founder.md and writing-rules.md and neither of the two we
- * ship. Those two are the same pair package.json keeps out of the download.
+ * it, and copying it into the user's folder would freeze it there: the next
+ * release's worker brief would never reach them, because the "edit" would
+ * shadow it forever. So a file is carried across only when it differs from the
+ * default, which is typically founder.md and writing-rules.md and neither of the
+ * two we ship. Those two are the same pair package.json keeps out of the download.
  *
  * It is a COPY, not a move, and it never overwrites. The checkout keeps its
  * copy so that merging this cannot lose a word, and a second run finds the
@@ -165,24 +164,33 @@ export function carryHerBriefsAcross(fromDir,toDir) {
 }
 
 /**
- * THE TWO OLD MESSAGE FILES, JOINED INTO ONE, ONCE (w-3dc46f3a67, 2026-09-22).
+ * THE TWO OLD MESSAGE FILES, JOINED INTO ONE, ONCE (w-3dc46f3a67).
  *
- * `writing-rules.md` said how an agent writes to her during a task and
+ * `writing-rules.md` said how an agent writes to the user during a task and
  * `finishing.md` said how it writes the last message. They are one box now, so
  * they have to become one document, and this is where that happens: on the
  * first boot after the change, before anything reads the new name.
  *
- * WHAT IT DOES WITH THE HALF SHE NEVER WROTE. The writing rules ship empty, so
- * anything in that file is hers. The finishing rules ship with 5,794 characters
- * of text, so most people have never touched them. When she has the one and not
- * the other, the joined document takes the shipped finishing text as its second
- * half rather than leaving it out: her copy shadows the default from here on,
- * and dropping it would quietly stop every task ending the way it does today.
+ * WHAT IT DOES WITH THE HALF THE USER NEVER WROTE. The writing rules ship
+ * empty, so anything in that file is the user's. The finishing rules ship with
+ * 5,794 characters of text, so most people have never touched them. When the
+ * user has the one and not the other, the joined document takes the shipped
+ * finishing text as its second half rather than leaving it out: the user's copy
+ * shadows the default from here on, and dropping it would quietly stop every
+ * task ending the way it does today.
  *
- * AND WHEN SHE WROTE NEITHER, IT WRITES NOTHING AT ALL. That is the fresh
- * install, and leaving her with no file of her own is what keeps a later
- * release's default reaching her. Same rule as `carryHerBriefsAcross` above:
- * never freeze our own text into her folder.
+ * AND WHEN THE USER WROTE NEITHER, IT WRITES NOTHING AT ALL. That is the fresh
+ * install, and leaving them with no file of their own is what keeps a later
+ * release's default reaching them. Same rule as `carryHerBriefsAcross` above:
+ * never freeze our own text into the user's folder.
+ *
+ * IT READS ONLY THE USER'S FOLDER, AND ADDS NOTHING OF OURS (w-3ec9f07978).
+ * It used to fall back to the checkout's copies and to put the shipped ending
+ * under whatever it found. In this repository `writing-rules.md` ships 16,000
+ * characters long, so every fresh copy run from source joined our two files
+ * and saved them as the user's, and the box showed nothing but our machinery.
+ * The shipped ending rides on every run anyway now (`messageRules` in the
+ * supervisor), so there is nothing of ours left to carry.
  *
  * Never throws, never overwrites. Returns what it joined, or null.
  */
@@ -190,16 +198,46 @@ export function joinMessageRules(shippedDir,toDir) {
  try {
   const target=path.join(toDir,'briefs',files.messages);
   if(fs.existsSync(target)) return null;
-  const read=(dir,name)=>{try {return fs.readFileSync(path.join(dir,'briefs',name),'utf8');} catch {return null;}};
-  const either=(name)=>read(toDir,name) ?? read(shippedDir,name);
-  const [writing,finishing]=WAS_MESSAGES.map((name)=>(either(name) ?? '').trim());
+  const read=(name)=>{try {return fs.readFileSync(path.join(toDir,'briefs',name),'utf8');} catch {return null;}};
+  const [writing,finishing]=WAS_MESSAGES.map((name)=>(read(name) ?? '').trim());
   if(!writing && !finishing) return null;
-  const ending=finishing || defaults.messages.trim();
-  const joined=[writing,ending].filter(Boolean).join('\n\n');
+  const joined=[writing,finishing].filter(Boolean).join('\n\n');
   writeInstruction(toDir,'messages',`${joined}\n`);
-  return {writing:writing.length,ending:ending.length,total:joined.length+1};
+  return {writing:writing.length,ending:finishing.length,total:joined.length+1};
  } catch(e) {
   console.warn(`${nameSlug}: could not join the message rules: ${e.message}`);
   return null;
  }
 }
+
+/**
+ * A MESSAGE BOX THAT HOLDS ONLY OUR TEXT IS NOT THE USER'S, ONCE (w-3ec9f07978).
+ *
+ * The old join above wrote the checkout's writing rules and ending rules into
+ * the user's folder as if they had typed them, so their box opened on 21,743
+ * characters of the app's own rules. A file whose text is EXACTLY one of the
+ * things we ship, alone or joined the way the old join joined them, is set
+ * aside: kept as a restore point and removed, so the box opens empty and our
+ * rules reach the run from the checkout as they should.
+ *
+ * Exact only. One line of the user's own makes the whole file theirs, and
+ * nothing here tries to cut it apart. Never throws. Returns whether it acted.
+ */
+export function setAsideShippedMessageRules(shippedDir,toDir) {
+ try {
+  const target=path.join(toDir,'briefs',files.messages);
+  if(path.resolve(shippedDir)===path.resolve(toDir)||!fs.existsSync(target)) return false;
+  const read=(name)=>{try {return fs.readFileSync(path.join(shippedDir,'briefs',name),'utf8').trim();} catch {return '';}};
+  const writing=read(WAS_MESSAGES[0]);
+  const endings=[...new Set([read(files.messages),defaults.messages.trim()])].filter(Boolean);
+  const ours=new Set([...endings,...endings.map((e)=>[writing,e].filter(Boolean).join('\n\n'))]);
+  const text=fs.readFileSync(target,'utf8').trim();
+  if(!text||!ours.has(text)) return false;
+  keepVersion(toDir,'messages',Date.now(),true);
+  fs.rmSync(target,{force:true});
+  return true;
+ } catch(e) {
+  console.warn(`${nameSlug}: could not set aside the shipped message rules: ${e.message}`);
+  return false;
+ }
+}