agent-window 1.4.1 → 1.4.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-window",
-  "version": "1.4.1",
+  "version": "1.4.3",
   "description": "A window to interact with AI agents through chat interfaces. Simplified interaction, powerful backend capabilities.",
   "type": "module",
   "main": "src/bot.js",
@@ -11,6 +11,8 @@
     "ui": "node bin/cli.js ui",
     "ui:dev": "cd web && npm run dev",
     "ui:build": "cd web && npm run build",
+    "cleanup-pm2": "bash scripts/cleanup-pm2.sh",
+    "check-node": "node -e \"const v=process.version; const n=parseInt(v.slice(1)); if(n>=23){console.error('⚠️  Node.js',v,'not supported. Use v18 or v20 LTS.'); process.exit(1);}else{console.log('✓ Node.js',v,'is supported');}\"",
     "pm2:start": "pm2 start ecosystem.config.cjs",
     "pm2:stop": "pm2 stop bot-corp",
     "pm2:restart": "pm2 restart bot-corp",
@@ -26,7 +28,8 @@
   "author": "",
   "license": "MIT",
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.0.0 <23.0.0",
+    "npm": ">=9.0.0"
   },
   "dependencies": {
     "@fastify/static": "^6.0.0",

package/scripts/cleanup-pm2.sh

@@ -0,0 +1,130 @@
+#!/bin/bash
+# PM2 Deep Cleanup Script
+# AgentWindow Multi-Instance Bug Recovery Tool
+#
+# This script cleans up:
+# - Multiple PM2 God Daemon processes (200+ leaked instances)
+# - Orphaned bot processes
+# - Stale PM2 dump files
+# - Duplicate instances
+
+set -e
+
+echo "🧹 PM2 Deep Cleanup Script"
+echo "======================================"
+echo ""
+
+# Color codes for output
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m' # No Color
+
+# Step 1: Check PM2 processes before cleanup
+echo "[1/7] Analyzing current state..."
+echo "-----------------------------------"
+
+PM2_COUNT=$(pgrep -f "PM2.*God Daemon" | wc -l | tr -d ' ' || echo "0")
+BOT_COUNT=$(ps aux | grep "node.*bot.js" | grep -v grep | wc -l | tr -d ' ' || echo "0")
+
+echo -e "PM2 God Daemons: ${YELLOW}${PM2_COUNT}${NC}"
+echo -e "Bot processes: ${YELLOW}${BOT_COUNT}${NC}"
+echo ""
+
+if [ "$PM2_COUNT" -lt 5 ] && [ "$BOT_COUNT" -lt 3 ]; then
+    echo -e "${GREEN}✓ System appears clean (no major issues detected)${NC}"
+    echo ""
+    read -p "Continue cleanup anyway? (y/N): " -n 1 -r
+    echo
+    if [[ ! $REPLY =~ ^[Yy]$ ]]; then
+        echo "Cleanup cancelled."
+        exit 0
+    fi
+fi
+
+# Step 2: Stop all PM2 apps
+echo "[2/7] Stopping all PM2 apps..."
+echo "-----------------------------------"
+if command -v pm2 &> /dev/null; then
+    pm2 stop all 2>/dev/null || echo "  No apps to stop"
+    pm2 delete all 2>/dev/null || echo "  No apps to delete"
+    echo -e "${GREEN}✓ PM2 apps stopped${NC}"
+else
+    echo -e "${YELLOW}⚠ PM2 not found, skipping...${NC}"
+fi
+echo ""
+
+# Step 3: Kill PM2 daemon
+echo "[3/7] Killing PM2 daemon..."
+echo "-----------------------------------"
+if command -v pm2 &> /dev/null; then
+    pm2 kill 2>/dev/null || echo "  Daemon already stopped"
+    echo -e "${GREEN}✓ PM2 daemon killed${NC}"
+else
+    echo -e "${YELLOW}⚠ PM2 not found, skipping...${NC}"
+fi
+echo ""
+
+# Step 4: Kill remaining PM2 God processes
+echo "[4/7] Cleaning up PM2 God processes..."
+echo "-----------------------------------"
+PM2_PIDS=$(pgrep -f "PM2.*God Daemon" || true)
+if [ -n "$PM2_PIDS" ]; then
+    echo "$PM2_PIDS" | xargs -I {} kill -9 {} 2>/dev/null || true
+    echo -e "${GREEN}✓ Killed PM2 God processes${NC}"
+else
+    echo -e "${GREEN}✓ No PM2 God processes found${NC}"
+fi
+echo ""
+
+# Step 5: Remove dump file
+echo "[5/7] Removing PM2 dump file..."
+echo "-----------------------------------"
+DUMP_FILE="$HOME/.pm2/dump.pm2"
+if [ -f "$DUMP_FILE" ]; then
+    rm -f "$DUMP_FILE"
+    echo -e "${GREEN}✓ Removed dump file${NC}"
+else
+    echo -e "${GREEN}✓ No dump file found${NC}"
+fi
+echo ""
+
+# Step 6: Kill orphaned bot processes
+echo "[6/7] Cleaning up orphaned bot processes..."
+echo "-----------------------------------"
+BOT_PIDS=$(ps aux | grep "node.*bot.js" | grep -v grep | awk '{print $2}' || true)
+if [ -n "$BOT_PIDS" ]; then
+    echo "$BOT_PIDS" | xargs -I {} kill -9 {} 2>/dev/null || true
+    echo -e "${GREEN}✓ Killed orphaned bot processes${NC}"
+else
+    echo -e "${GREEN}✓ No orphaned bot processes found${NC}"
+fi
+echo ""
+
+# Step 7: Verification
+echo "[7/7] Verification..."
+echo "-----------------------------------"
+sleep 1
+
+FINAL_PM2_COUNT=$(pgrep -f "PM2.*God Daemon" | wc -l | tr -d ' ' || echo "0")
+FINAL_BOT_COUNT=$(ps aux | grep "node.*bot.js" | grep -v grep | wc -l | tr -d ' ' || echo "0")
+
+echo -e "PM2 God Daemons: ${GREEN}${FINAL_PM2_COUNT}${NC} (was ${PM2_COUNT})"
+echo -e "Bot processes: ${GREEN}${FINAL_BOT_COUNT}${NC} (was ${BOT_COUNT})"
+echo ""
+
+if [ "$FINAL_PM2_COUNT" -eq 0 ] && [ "$FINAL_BOT_COUNT" -eq 0 ]; then
+    echo -e "${GREEN}✅ Cleanup complete! System is clean.${NC}"
+    echo ""
+    echo "Next steps:"
+    echo "  1. Start your bot: pm2 start ecosystem.config.cjs"
+    echo "  2. Verify: pm2 list"
+    echo "  3. Check logs: pm2 logs --lines 20"
+else
+    echo -e "${YELLOW}⚠️  Some processes still running. You may need to:${NC}"
+    echo "  - Check manually: ps aux | grep bot.js"
+    echo "  - Kill manually: kill -9 <PID>"
+    echo "  - Restart terminal/daemon"
+fi
+echo ""
+echo "======================================"

package/src/bot.js

@@ -24,8 +24,6 @@ import { spawn, execSync } from 'child_process';
 import { readFileSync, writeFileSync, existsSync, readdirSync, unlinkSync, mkdirSync, chmodSync } from 'fs';
 import { join } from 'path';
 import { homedir } from 'os';
-import { https } from 'https';
-import { http } from 'http';
 import { createWriteStream } from 'fs';
 
 // Import performance monitoring utilities (local)
@@ -41,6 +39,50 @@ import {
 // Import centralized configuration (local, project-specific)
 import config from './core/config.js';
 
+// ============================================================================
+// CRITICAL: Check Node.js version compatibility
+// ============================================================================
+const NODE_VERSION = process.version;
+const NODE_MAJOR = parseInt(NODE_VERSION.slice(1).split('.')[0]);
+
+if (ENFORCE_NODE_VERSION && NODE_MAJOR >= 23) {
+  console.error('\n' + '='.repeat(70));
+  console.error('⚠️  CRITICAL: Node.js v23+ is not compatible with AgentWindow!');
+  console.error('='.repeat(70));
+  console.error(`Current version: ${NODE_VERSION}`);
+  console.error('Supported versions: Node.js v18 LTS or v20 LTS');
+  console.error('\n❌ Issues with Node.js v23:');
+  console.error('  - ES module import syntax incompatibility');
+  console.error('  - Potential runtime errors with Discord.js');
+  console.error('  - Breaking changes in core modules');
+  console.error('\n✅ Recommended actions:');
+  console.error('  1. Install Node.js v20 LTS (recommended)');
+  console.error('     Using nvm: nvm install 20 && nvm use 20');
+  console.error('     Using Homebrew: brew install node@20');
+  console.error('  2. Reinstall global packages: npm install -g agent-window');
+  console.error('  3. Restart your bots');
+  console.error('\n📖 To disable this check, add to your config.json:');
+  console.error('  { "workspace": { "enforceNodeVersion": false } }');
+  console.error('\n📖 See: https://nodejs.org/en/download/releases');
+  console.error('='.repeat(70) + '\n');
+  process.exit(1);
+} else if (NODE_MAJOR >= 23) {
+  // Warning only (if check is disabled)
+  console.warn('\n' + '='.repeat(70));
+  console.warn('⚠️  WARNING: Node.js v23 detected!');
+  console.warn('='.repeat(70));
+  console.warn(`Current version: ${NODE_VERSION}`);
+  console.warn('Recommended versions: Node.js v18 LTS or v20 LTS');
+  console.warn('');
+  console.warn('⚠️  Node.js v23 may cause compatibility issues.');
+  console.warn('✅ Version check is disabled in config (enforceNodeVersion: false)');
+  console.warn('   Bot will continue, but issues may occur.');
+  console.warn('');
+  console.warn('To enable strict checking, remove "enforceNodeVersion: false" from config');
+  console.warn('Or install Node.js v20 LTS for best stability.');
+  console.warn('='.repeat(70) + '\n');
+}
+
 // Extract commonly used config values for convenience
 const BOT_TOKEN = config.discord.token;
 const PROJECT_DIR = config.workspace.projectDir;
@@ -50,6 +92,7 @@ const CHANNEL_SESSIONS_FILE = config.paths.sessions;
 const PENDING_DIR = config.paths.pending;
 const HOOK_DIR = config.paths.hooks;
 const USE_DOCKER = config.workspace.useDocker; // Whether to use Docker or run locally
+const ENFORCE_NODE_VERSION = config.workspace.enforceNodeVersion; // Whether to enforce Node.js version check
 const CONTAINER_NAME = config.workspace.containerName;
 const DOCKER_IMAGE = config.workspace.dockerImage;
 
@@ -1850,11 +1893,52 @@ client.on(Events.MessageCreate, async (message) => {
 
 // Ready event
 client.on(Events.ClientReady, async () => {
+  // ========================================================================
+  // CRITICAL: Check for duplicate bot instances
+  // ========================================================================
+  try {
+    const { execSync } = await import('child_process');
+    const psCommand = process.platform === 'win32'
+      ? 'tasklist | findstr node.exe'
+      : 'ps aux | grep "node.*bot.js" | grep -v grep';
+
+    const result = execSync(psCommand, { encoding: 'utf-8', timeout: 5000 });
+    const botProcesses = result.split('\n').filter(line => line.trim() && line.includes('bot.js'));
+
+    if (botProcesses.length > 1) {
+      console.error('\n' + '='.repeat(70));
+      console.error('⚠️  CRITICAL WARNING: Multiple bot instances detected!');
+      console.error('='.repeat(70));
+      console.error(`Found ${botProcesses.length} bot instances running concurrently.`);
+      console.error('This will cause duplicate responses to every message!');
+      console.error('\n🔍 Running instances:');
+      botProcesses.forEach((proc, i) => {
+        console.error(`  ${i + 1}. ${proc.trim()}`);
+      });
+      console.error('\n🔧 To fix this issue:');
+      console.error('  1. Check running PM2 processes: pm2 list');
+      console.error('  2. Stop all bots: pm2 stop all && pm2 delete all');
+      console.error('  3. Kill PM2 daemon: pm2 kill');
+      console.error('  4. Kill all bot processes: pkill -9 -f "node.*bot.js"');
+      console.error('  5. Clean dump file: rm -f ~/.pm2/dump.pm2');
+      console.error('  6. Restart single instance: pm2 start ecosystem.config.cjs');
+      console.error('\n📖 Or use the cleanup script: npm run cleanup-pm2');
+      console.error('='.repeat(70) + '\n');
+    } else {
+      console.log('✓ Instance check: Single bot instance (good)');
+    }
+  } catch (e) {
+    // Command failed (likely no other instances or platform not supported)
+    console.log('✓ Instance check: Passed');
+  }
+
   console.log(`AgentBridge logged in as ${client.user.tag}`);
   console.log(`Bot User ID: ${client.user.id}`);
   console.log(`Project: ${PROJECT_DIR}`);
-  console.log(`Mode: Docker Sandbox + Hooks Permission`);
-  console.log(`Container: ${CONTAINER_NAME}`);
+  console.log(`Mode: ${USE_DOCKER ? 'Docker Sandbox' : 'Local Host'} + Hooks Permission`);
+  if (USE_DOCKER) {
+    console.log(`Container: ${CONTAINER_NAME}`);
+  }
   console.log(`OAuth: ${OAUTH_TOKEN ? 'configured' : 'not set'}`);
 
   // Update PM2 and Discord health status

package/src/core/config.js

@@ -82,6 +82,7 @@ function loadConfig() {
     workspace: {
       projectDir: expandPath(fileConfig.PROJECT_DIR) || process.cwd(),
       useDocker: fileConfig.workspace?.useDocker !== false, // Default to true for backward compatibility
+      enforceNodeVersion: fileConfig.workspace?.enforceNodeVersion !== false, // Default to true for safety
       containerName: fileConfig.workspace?.containerName || 'claude-discord-bot',
       dockerImage: fileConfig.workspace?.dockerImage || 'claude-sandbox',
       portMappings: fileConfig.workspace?.portMappings || [],