agent-tower 0.7.3 → 0.7.4-beta.0

package/dist/routes/tasks.js

@@ -1,10 +1,13 @@
 import { z, ZodError } from 'zod';
 import { TaskService } from '../services/task.service.js';
 import { TaskStatus } from '../types/index.js';
-import { TaskPriority } from '@agent-tower/shared';
+import { TaskPriority, TASK_HANDOFF_MAX_LENGTH } from '@agent-tower/shared';
+import { TaskHandoffService } from '../services/task-handoff.service.js';
+import { requireTranslationOwner } from './translations.js';
 import { ServiceError } from '../errors.js';
 import { getEventBus, getSessionManager, getTaskCleanupService, getWorkspaceBackgroundService, } from '../core/container.js';
 const createTaskSchema = z.object({
+    parentTaskId: z.string().uuid().optional(),
     title: z.string().min(1, 'title is required').refine((value) => value.trim().length > 0, 'title is required'),
     description: z.string().optional(),
     baseBranch: z.string().trim().min(1).nullable().optional(),
@@ -15,6 +18,18 @@ const updateTaskSchema = z.object({
     description: z.string().optional(),
     priority: z.nativeEnum(TaskPriority).optional(),
 });
+const updateHandoffSchema = z.object({
+    oldString: z.string().max(TASK_HANDOFF_MAX_LENGTH),
+    newString: z.string().max(TASK_HANDOFF_MAX_LENGTH),
+}).strict();
+async function handoffCaller(request) {
+    if (request.agentTowerAuthKind === 'agent' && request.agentTowerAgentIdentity) {
+        return { kind: 'agent', ...request.agentTowerAgentIdentity };
+    }
+    // The shared owner guard also handles password-disabled browsers and CSRF.
+    await requireTranslationOwner(request);
+    return { kind: request.agentTowerAuthKind === 'internal' ? 'internal' : 'browser' };
+}
 const updateStatusSchema = z.object({
     status: z.nativeEnum(TaskStatus, {
         errorMap: () => ({
@@ -57,6 +72,7 @@ function handleError(error, reply) {
     return { error: 'Internal server error', code: 'INTERNAL_ERROR' };
 }
 export async function taskRoutes(app) {
+    const handoffService = new TaskHandoffService(getEventBus());
     const taskService = new TaskService(getEventBus(), getSessionManager(), getTaskCleanupService(), getWorkspaceBackgroundService());
     app.get('/task-board', async (request, reply) => {
         try {
@@ -115,6 +131,46 @@ export async function taskRoutes(app) {
             return handleError(error, reply);
         }
     });
+    app.get('/tasks/:id/handoff', async (request, reply) => {
+        try {
+            return await handoffService.get(request.params.id, await handoffCaller(request));
+        }
+        catch (error) {
+            return handleError(error, reply);
+        }
+    });
+    app.patch('/tasks/:id/handoff', async (request, reply) => {
+        try {
+            return await handoffService.update(request.params.id, updateHandoffSchema.parse(request.body), await handoffCaller(request));
+        }
+        catch (error) {
+            return handleError(error, reply);
+        }
+    });
+    app.get('/tasks/:id/subtasks', async (request, reply) => {
+        try {
+            return await taskService.findSubtasks(request.params.id, taskListQuerySchema.parse(request.query));
+        }
+        catch (error) {
+            return handleError(error, reply);
+        }
+    });
+    app.get('/tasks/:id/cleanup', async (request, reply) => {
+        try {
+            return await taskService.getCleanupStatus(request.params.id);
+        }
+        catch (error) {
+            return handleError(error, reply);
+        }
+    });
+    app.post('/tasks/:id/cleanup/retry', async (request, reply) => {
+        try {
+            return await taskService.retryCleanup(request.params.id);
+        }
+        catch (error) {
+            return handleError(error, reply);
+        }
+    });
     // 更新任务
     app.put('/tasks/:id', async (request, reply) => {
         try {
@@ -148,7 +204,8 @@ export async function taskRoutes(app) {
     // 删除任务
     app.delete('/tasks/:id', async (request, reply) => {
         try {
-            await taskService.delete(request.params.id);
+            const query = z.object({ expectedSubtaskCount: z.coerce.number().int().min(0).optional() }).parse(request.query);
+            await taskService.delete(request.params.id, query.expectedSubtaskCount);
             reply.code(204);
             return;
         }

package/dist/routes/tasks.js.map

@@ -1 +1 @@
-{"version":3,"file":"tasks.js","sourceRoot":"","sources":["../../src/routes/tasks.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,CAAC,EAAE,QAAQ,EAAE,MAAM,KAAK,CAAC;AAClC,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAC/C,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AACnD,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EACL,WAAW,EACX,iBAAiB,EACjB,qBAAqB,EACrB,6BAA6B,GAC9B,MAAM,sBAAsB,CAAC;AAE9B,MAAM,gBAAgB,GAAG,CAAC,CAAC,MAAM,CAAC;IAChC,KAAK,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,mBAAmB,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,mBAAmB,CAAC;IAC7G,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IAClC,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC,QAAQ,EAAE;IAC1D,QAAQ,EAAE,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC;CAClE,CAAC,CAAC;AAEH,MAAM,gBAAgB,GAAG,CAAC,CAAC,MAAM,CAAC;IAChC,KAAK,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,uBAAuB,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,uBAAuB,CAAC,CAAC,QAAQ,EAAE;IAChI,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IAClC,QAAQ,EAAE,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,QAAQ,EAAE;CAChD,CAAC,CAAC;AAEH,MAAM,kBAAkB,GAAG,CAAC,CAAC,MAAM,CAAC;IAClC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,UAAU,EAAE;QAC/B,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC;YACf,OAAO,EAAE,0BAA0B,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;SAC1E,CAAC;KACH,CAAC;CACH,CAAC,CAAC;AAEH,MAAM,oBAAoB,GAAG,CAAC,CAAC,MAAM,CAAC;IACpC,QAAQ,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,+BAA+B,CAAC;IAClE,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,QAAQ,EAAE;CAC5C,CAAC,CAAC;AAEH,MAAM,mBAAmB,GAAG,CAAC,CAAC,MAAM,CAAC;IACnC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,QAAQ,EAAE;IAC3C,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC;IAC/C,KAAK,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC;CAC7D,CAAC,CAAC;AAEH,MAAM,oBAAoB,GAAG,mBAAmB,CAAC,MAAM,CAAC;IACtD,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC,QAAQ,EAAE;CACxC,CAAC,CAAC,MAAM,CAAC;IACR,KAAK,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC;CAC9D,CAAC,CAAC;AAEH;;GAEG;AACH,SAAS,WAAW,CAAC,KAAc,EAAE,KAAU;IAC7C,IAAI,KAAK,YAAY,QAAQ,EAAE,CAAC;QAC9B,MAAM,WAAW,GAAG,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC3C,KAAK,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;YACvB,OAAO,EAAE,CAAC,CAAC,OAAO;SACnB,CAAC,CAAC,CAAC;QACJ,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAChB,OAAO,EAAE,KAAK,EAAE,mBAAmB,EAAE,IAAI,EAAE,kBAAkB,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC;IACxF,CAAC;IAED,IAAI,KAAK,YAAY,YAAY,EAAE,CAAC;QAClC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;QAC7B,OAAO,EAAE,KAAK,EAAE,KAAK,CAAC,OAAO,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,CAAC;IACpD,CAAC;IAED,OAAO,CAAC,KAAK,CAAC,0BAA0B,EAAE,KAAK,CAAC,CAAC;IACjD,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAChB,OAAO,EAAE,KAAK,EAAE,uBAAuB,EAAE,IAAI,EAAE,gBAAgB,EAAE,CAAC;AACpE,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,GAAoB;IACnD,MAAM,WAAW,GAAG,IAAI,WAAW,CACjC,WAAW,EAAE,EACb,iBAAiB,EAAE,EACnB,qBAAqB,EAAE,EACvB,6BAA6B,EAAE,CAChC,CAAC;IAEF,GAAG,CAAC,GAAG,CAAC,aAAa,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QAC9C,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,oBAAoB,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;YACxD,OAAO,MAAM,WAAW,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;QAC5C,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,uBAAuB;IACvB,GAAG,CAAC,GAAG,CACL,4BAA4B,EAC5B,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,mBAAmB,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;YACvD,OAAO,MAAM,WAAW,CAAC,eAAe,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;QAC5E,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,OAAO;IACP,GAAG,CAAC,IAAI,CACN,4BAA4B,EAC5B,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YAClD,MAAM,IAAI,GAAG,MAAM,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;YACtE,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAChB,OAAO,IAAI,CAAC;QACd,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,YAAY;IACZ,GAAG,CAAC,GAAG,CACL,kCAAkC,EAClC,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,mBAAmB,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QACzE,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,SAAS;IACT,GAAG,CAAC,GAAG,CAA6B,YAAY,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACzE,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACvD,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,GAAG,CAA6B,iBAAiB,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QAC9E,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3D,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,OAAO;IACP,GAAG,CAAC,GAAG,CAA6B,YAAY,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACzE,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YAClD,OAAO,MAAM,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,IAAI,CAAC,CAAC;QAC3D,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,kBAAkB;IAClB,GAAG,CAAC,KAAK,CACP,mBAAmB,EACnB,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,kBAAkB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YACpD,OAAO,MAAM,WAAW,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,IAAI,CAAC,MAAM,CAAC,CAAC;QACxE,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,SAAS;IACT,GAAG,CAAC,KAAK,CACP,qBAAqB,EACrB,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,oBAAoB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YACtD,OAAO,MAAM,WAAW,CAAC,cAAc,CACrC,OAAO,CAAC,MAAM,CAAC,EAAE,EACjB,IAAI,CAAC,QAAQ,EACb,IAAI,CAAC,MAAM,CACZ,CAAC;QACJ,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,OAAO;IACP,GAAG,CAAC,MAAM,CACR,YAAY,EACZ,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;YAC5C,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAChB,OAAO;QACT,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,kCAAkC;IAClC,GAAG,CAAC,IAAI,CACN,kBAAkB,EAClB,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACpD,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;AACJ,CAAC"}
+{"version":3,"file":"tasks.js","sourceRoot":"","sources":["../../src/routes/tasks.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,CAAC,EAAE,QAAQ,EAAE,MAAM,KAAK,CAAC;AAClC,OAAO,EAAE,WAAW,EAAE,MAAM,6BAA6B,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAE,MAAM,mBAAmB,CAAC;AAC/C,OAAO,EAAE,YAAY,EAAE,uBAAuB,EAAE,MAAM,qBAAqB,CAAC;AAC5E,OAAO,EAAE,kBAAkB,EAA0B,MAAM,qCAAqC,CAAC;AACjG,OAAO,EAAE,uBAAuB,EAAE,MAAM,mBAAmB,CAAC;AAC5D,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EACL,WAAW,EACX,iBAAiB,EACjB,qBAAqB,EACrB,6BAA6B,GAC9B,MAAM,sBAAsB,CAAC;AAE9B,MAAM,gBAAgB,GAAG,CAAC,CAAC,MAAM,CAAC;IAChC,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC,QAAQ,EAAE;IAC1C,KAAK,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,mBAAmB,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,mBAAmB,CAAC;IAC7G,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IAClC,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC,QAAQ,EAAE;IAC1D,QAAQ,EAAE,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC;CAClE,CAAC,CAAC;AAEH,MAAM,gBAAgB,GAAG,CAAC,CAAC,MAAM,CAAC;IAChC,KAAK,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,uBAAuB,CAAC,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,EAAE,uBAAuB,CAAC,CAAC,QAAQ,EAAE;IAChI,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,QAAQ,EAAE;IAClC,QAAQ,EAAE,CAAC,CAAC,UAAU,CAAC,YAAY,CAAC,CAAC,QAAQ,EAAE;CAChD,CAAC,CAAC;AAEH,MAAM,mBAAmB,GAAG,CAAC,CAAC,MAAM,CAAC;IACnC,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,uBAAuB,CAAC;IAClD,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,CAAC,uBAAuB,CAAC;CACnD,CAAC,CAAC,MAAM,EAAE,CAAC;AAEZ,KAAK,UAAU,aAAa,CAAC,OAAuB;IAClD,IAAI,OAAO,CAAC,kBAAkB,KAAK,OAAO,IAAI,OAAO,CAAC,uBAAuB,EAAE,CAAC;QAC9E,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,OAAO,CAAC,uBAAuB,EAAE,CAAC;IAC/D,CAAC;IACD,2EAA2E;IAC3E,MAAM,uBAAuB,CAAC,OAAO,CAAC,CAAC;IACvC,OAAO,EAAE,IAAI,EAAE,OAAO,CAAC,kBAAkB,KAAK,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,SAAS,EAAE,CAAC;AACtF,CAAC;AAED,MAAM,kBAAkB,GAAG,CAAC,CAAC,MAAM,CAAC;IAClC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,UAAU,EAAE;QAC/B,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC;YACf,OAAO,EAAE,0BAA0B,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;SAC1E,CAAC;KACH,CAAC;CACH,CAAC,CAAC;AAEH,MAAM,oBAAoB,GAAG,CAAC,CAAC,MAAM,CAAC;IACpC,QAAQ,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,EAAE,+BAA+B,CAAC;IAClE,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,QAAQ,EAAE;CAC5C,CAAC,CAAC;AAEH,MAAM,mBAAmB,GAAG,CAAC,CAAC,MAAM,CAAC;IACnC,MAAM,EAAE,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,QAAQ,EAAE;IAC3C,IAAI,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC;IAC/C,KAAK,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC;CAC7D,CAAC,CAAC;AAEH,MAAM,oBAAoB,GAAG,mBAAmB,CAAC,MAAM,CAAC;IACtD,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC,QAAQ,EAAE;CACxC,CAAC,CAAC,MAAM,CAAC;IACR,KAAK,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC;CAC9D,CAAC,CAAC;AAEH;;GAEG;AACH,SAAS,WAAW,CAAC,KAAc,EAAE,KAAU;IAC7C,IAAI,KAAK,YAAY,QAAQ,EAAE,CAAC;QAC9B,MAAM,WAAW,GAAG,KAAK,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;YAC3C,KAAK,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;YACvB,OAAO,EAAE,CAAC,CAAC,OAAO;SACnB,CAAC,CAAC,CAAC;QACJ,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAChB,OAAO,EAAE,KAAK,EAAE,mBAAmB,EAAE,IAAI,EAAE,kBAAkB,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC;IACxF,CAAC;IAED,IAAI,KAAK,YAAY,YAAY,EAAE,CAAC;QAClC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC;QAC7B,OAAO,EAAE,KAAK,EAAE,KAAK,CAAC,OAAO,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE,CAAC;IACpD,CAAC;IAED,OAAO,CAAC,KAAK,CAAC,0BAA0B,EAAE,KAAK,CAAC,CAAC;IACjD,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAChB,OAAO,EAAE,KAAK,EAAE,uBAAuB,EAAE,IAAI,EAAE,gBAAgB,EAAE,CAAC;AACpE,CAAC;AAED,MAAM,CAAC,KAAK,UAAU,UAAU,CAAC,GAAoB;IACnD,MAAM,cAAc,GAAG,IAAI,kBAAkB,CAAC,WAAW,EAAE,CAAC,CAAC;IAC7D,MAAM,WAAW,GAAG,IAAI,WAAW,CACjC,WAAW,EAAE,EACb,iBAAiB,EAAE,EACnB,qBAAqB,EAAE,EACvB,6BAA6B,EAAE,CAChC,CAAC;IAEF,GAAG,CAAC,GAAG,CAAC,aAAa,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QAC9C,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,oBAAoB,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;YACxD,OAAO,MAAM,WAAW,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;QAC5C,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,uBAAuB;IACvB,GAAG,CAAC,GAAG,CACL,4BAA4B,EAC5B,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,mBAAmB,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;YACvD,OAAO,MAAM,WAAW,CAAC,eAAe,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;QAC5E,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,OAAO;IACP,GAAG,CAAC,IAAI,CACN,4BAA4B,EAC5B,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YAClD,MAAM,IAAI,GAAG,MAAM,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;YACtE,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAChB,OAAO,IAAI,CAAC;QACd,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,YAAY;IACZ,GAAG,CAAC,GAAG,CACL,kCAAkC,EAClC,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,mBAAmB,CAAC,OAAO,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;QACzE,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,SAAS;IACT,GAAG,CAAC,GAAG,CAA6B,YAAY,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACzE,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACvD,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,GAAG,CAA6B,iBAAiB,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QAC9E,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAC3D,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,GAAG,CAA6B,oBAAoB,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACjF,IAAI,CAAC;YAAC,OAAO,MAAM,cAAc,CAAC,GAAG,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,MAAM,aAAa,CAAC,OAAO,CAAC,CAAC,CAAC;QAAC,CAAC;QACzF,OAAO,KAAK,EAAE,CAAC;YAAC,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,KAAK,CAA6B,oBAAoB,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACnF,IAAI,CAAC;YAAC,OAAO,MAAM,cAAc,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,mBAAmB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,MAAM,aAAa,CAAC,OAAO,CAAC,CAAC,CAAC;QAAC,CAAC;QACrI,OAAO,KAAK,EAAE,CAAC;YAAC,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,GAAG,CAA6B,qBAAqB,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QAClF,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,mBAAmB,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC;QACrG,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YAAC,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAAC,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,GAAG,CAA6B,oBAAoB,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACjF,IAAI,CAAC;YAAC,OAAO,MAAM,WAAW,CAAC,gBAAgB,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAAC,CAAC;QACrE,OAAO,KAAK,EAAE,CAAC;YAAC,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,GAAG,CAAC,IAAI,CAA6B,0BAA0B,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACxF,IAAI,CAAC;YAAC,OAAO,MAAM,WAAW,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QAAC,CAAC;QACjE,OAAO,KAAK,EAAE,CAAC;YAAC,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,OAAO;IACP,GAAG,CAAC,GAAG,CAA6B,YAAY,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACzE,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YAClD,OAAO,MAAM,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,IAAI,CAAC,CAAC;QAC3D,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CAAC,CAAC;IAEH,kBAAkB;IAClB,GAAG,CAAC,KAAK,CACP,mBAAmB,EACnB,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,kBAAkB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YACpD,OAAO,MAAM,WAAW,CAAC,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,IAAI,CAAC,MAAM,CAAC,CAAC;QACxE,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,SAAS;IACT,GAAG,CAAC,KAAK,CACP,qBAAqB,EACrB,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,oBAAoB,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC;YACtD,OAAO,MAAM,WAAW,CAAC,cAAc,CACrC,OAAO,CAAC,MAAM,CAAC,EAAE,EACjB,IAAI,CAAC,QAAQ,EACb,IAAI,CAAC,MAAM,CACZ,CAAC;QACJ,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,OAAO;IACP,GAAG,CAAC,MAAM,CACR,YAAY,EACZ,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,MAAM,KAAK,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,oBAAoB,EAAE,CAAC,CAAC,MAAM,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC;YACjH,MAAM,WAAW,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,EAAE,KAAK,CAAC,oBAAoB,CAAC,CAAC;YACxE,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;YAChB,OAAO;QACT,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;IAEF,kCAAkC;IAClC,GAAG,CAAC,IAAI,CACN,kBAAkB,EAClB,KAAK,EAAE,OAAO,EAAE,KAAK,EAAE,EAAE;QACvB,IAAI,CAAC;YACH,OAAO,MAAM,WAAW,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC,CAAC;QACpD,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACf,OAAO,WAAW,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QACnC,CAAC;IACH,CAAC,CACF,CAAC;AACJ,CAAC"}

package/dist/services/__tests__/session-manager.lifecycle.test.js

@@ -4,7 +4,7 @@ import os from 'node:os';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest';
-import { AgentType, SessionStatus, TaskStatus } from '../../types/index.js';
+import { AgentType, SessionPurpose, SessionStatus, TaskStatus } from '../../types/index.js';
 import { EventBus } from '../../core/event-bus.js';
 import { RuntimeType } from '@agent-tower/shared';
 import { StaticRuntimeRegistry } from '../../runtime/runtime-registry.js';
@@ -156,6 +156,54 @@ function waitForEvent(eventBus, event, timeoutMs = 5000) {
         });
     });
 }
+async function createCommitMessageAcpFixture() {
+    const provider = {
+        id: 'commit-message-acp-provider', name: 'Commit Message ACP',
+        agentType: AgentType.CODEX, runtimeType: RuntimeType.ACP,
+        executionPermission: 'FULL_ACCESS', env: {}, config: {}, isDefault: false,
+    };
+    getProviderByIdMock.mockReturnValue(provider);
+    const { workspace, session } = await createSessionFixture({ providerId: provider.id });
+    await prisma.session.update({
+        where: { id: session.id },
+        data: { purpose: SessionPurpose.COMMIT_MSG, runtimeType: RuntimeType.ACP },
+    });
+    const turns = [];
+    let credential = '';
+    const driverSession = {
+        runtimeInstanceId: 'commit-message-runtime',
+        externalSessionId: 'commit-message-external',
+        capabilities: { loadSession: true, terminalInput: false, terminalResize: false, permissions: true },
+        runTurn: vi.fn(async (turn, sink) => {
+            sink.stream({ type: 'external_session_id', externalSessionId: 'commit-message-external' });
+            turn.msgStore.pushPatch([{
+                    op: 'add', path: '/entries/-',
+                    value: { id: `reply-${turn.turnId}`, entryType: 'assistant_message', content: 'fix: release commit message runtime' },
+                }]);
+            const completion = deferred();
+            turns.push(completion);
+            return { completion: completion.promise };
+        }),
+        cancelTurn: vi.fn(async () => { turns.at(-1)?.resolve({ stopReason: 'cancelled' }); }),
+        close: vi.fn(async () => { turns.at(-1)?.resolve({ stopReason: 'cancelled' }); }),
+    };
+    const driver = {
+        type: RuntimeType.ACP,
+        open: vi.fn(async (input, sink) => {
+            credential = input.env.get(AGENT_API_CREDENTIAL_ENV) ?? '';
+            await sink.process({
+                type: 'started', runtimeInstanceId: driverSession.runtimeInstanceId,
+                launchClaimNumber: input.launchClaimNumber, pid: 4501, processGroupId: '4501',
+                birthMarker: 'test-birth:4501', ownershipToken: 'test-owner:4501',
+            });
+            return driverSession;
+        }),
+    };
+    const eventBus = new EventBus();
+    const manager = new SessionManager(eventBus, undefined, new StaticRuntimeRegistry([driver]));
+    await manager.start(session.id);
+    return { manager, eventBus, driverSession, turns, credential, session, workspace };
+}
 async function createRetryableAcpStopFixture(closeFailureMessages) {
     const provider = {
         id: 'cleanup-retry-acp-provider',
@@ -342,6 +390,128 @@ describe('SessionManager session status vs real process state', () => {
         await prisma.task.deleteMany();
         await prisma.project.deleteMany();
     });
+    describe('COMMIT_MSG runtime cleanup', () => {
+        it.each(['completed', 'failed', 'extraction-error'])('closes the ACP runtime after a %s job while retaining its result and status', async (outcome) => {
+            const { getCommitMessageService } = await import('../../core/container.js');
+            const service = getCommitMessageService();
+            const extract = vi.spyOn(service, 'extractAndCache');
+            if (outcome === 'extraction-error')
+                extract.mockRejectedValueOnce(new Error('cache unavailable'));
+            const { manager, driverSession, turns, credential, session, workspace } = await createCommitMessageAcpFixture();
+            try {
+                if (outcome === 'failed')
+                    turns[0].reject(new Error('model request failed'));
+                else
+                    turns[0].resolve({ stopReason: 'end_turn' });
+                await vi.waitFor(async () => {
+                    expect(await prisma.executionProcess.findFirst({ where: { sessionId: session.id } }))
+                        .toMatchObject({ cleanupState: 'CONFIRMED' });
+                    expect(manager.hasRuntimeProcessOwner(driverSession.runtimeInstanceId, session.id, 1)).toBe(false);
+                });
+                expect(driverSession.close).toHaveBeenCalledOnce();
+                expect(validateAgentApiCredential(credential)).toBeNull();
+                const persisted = await prisma.session.findUniqueOrThrow({ where: { id: session.id } });
+                expect(persisted.status).toBe(outcome === 'failed' ? SessionStatus.FAILED : SessionStatus.COMPLETED);
+                expect(persisted.logSnapshot).toContain('fix: release commit message runtime');
+                expect(sessionMsgStoreManager.has(session.id)).toBe(false);
+                expect(extract).toHaveBeenCalledTimes(outcome === 'failed' ? 0 : 1);
+                const savedWorkspace = await prisma.workspace.findUniqueOrThrow({ where: { id: workspace.id } });
+                expect(savedWorkspace.commitMessage).toBe(outcome === 'completed' ? 'fix: release commit message runtime' : null);
+            }
+            finally {
+                extract.mockRestore();
+                await manager.destroyAll();
+            }
+        });
+        it('waits for result extraction before closing, and retries a failed process cleanup', async () => {
+            const { getCommitMessageService } = await import('../../core/container.js');
+            const service = getCommitMessageService();
+            const originalExtract = service.extractAndCache.bind(service);
+            const extracting = deferred();
+            const releaseExtraction = deferred();
+            const extract = vi.spyOn(service, 'extractAndCache').mockImplementation(async (id) => {
+                extracting.resolve();
+                await releaseExtraction.promise;
+                await originalExtract(id);
+            });
+            const { manager, driverSession, turns, session, workspace } = await createCommitMessageAcpFixture();
+            vi.mocked(driverSession.close).mockRejectedValueOnce(new Error('owned process tree still alive'));
+            try {
+                turns[0].resolve({ stopReason: 'end_turn' });
+                await extracting.promise;
+                expect(driverSession.close).not.toHaveBeenCalled();
+                releaseExtraction.resolve();
+                await vi.waitFor(async () => {
+                    expect(await prisma.executionProcess.findFirst({ where: { sessionId: session.id } }))
+                        .toMatchObject({ cleanupState: 'FAILED', cleanupAttemptCount: 1 });
+                });
+                expect(manager.hasRuntimeProcessOwner(driverSession.runtimeInstanceId, session.id, 1)).toBe(true);
+                await manager.retryFailedRuntimeDisposals();
+                expect(driverSession.close).toHaveBeenCalledTimes(2);
+                expect(await prisma.executionProcess.findFirst({ where: { sessionId: session.id } }))
+                    .toMatchObject({ cleanupState: 'CONFIRMED', cleanupError: null });
+                expect(await prisma.session.findUnique({ where: { id: session.id } }))
+                    .toMatchObject({ status: SessionStatus.COMPLETED });
+                expect(await prisma.workspace.findUnique({ where: { id: workspace.id } }))
+                    .toMatchObject({ commitMessage: 'fix: release commit message runtime' });
+            }
+            finally {
+                releaseExtraction.resolve();
+                extract.mockRestore();
+                await manager.destroyAll();
+            }
+        });
+        it('closes the runtime even when final snapshot persistence fails', async () => {
+            const { manager, driverSession, turns, session } = await createCommitMessageAcpFixture();
+            const flush = vi.spyOn(manager, 'flushSnapshotPersist')
+                .mockRejectedValueOnce(new Error('snapshot write failed'));
+            try {
+                turns[0].resolve({ stopReason: 'end_turn' });
+                await vi.waitFor(async () => {
+                    expect(await prisma.executionProcess.findFirst({ where: { sessionId: session.id } }))
+                        .toMatchObject({ cleanupState: 'CONFIRMED' });
+                });
+                expect(driverSession.close).toHaveBeenCalledOnce();
+            }
+            finally {
+                flush.mockRestore();
+                await manager.flushSnapshotPersist(session.id, SessionStatus.COMPLETED);
+                sessionMsgStoreManager.delete(session.id);
+                await manager.destroyAll();
+            }
+        });
+        it('does not close a newer turn when an older commit-message finalizer finishes late', async () => {
+            const { getCommitMessageService } = await import('../../core/container.js');
+            const extracting = deferred();
+            const releaseExtraction = deferred();
+            const extract = vi.spyOn(getCommitMessageService(), 'extractAndCache').mockImplementationOnce(async () => {
+                extracting.resolve();
+                await releaseExtraction.promise;
+            });
+            const { manager, driverSession, turns, session } = await createCommitMessageAcpFixture();
+            try {
+                turns[0].resolve({ stopReason: 'end_turn' });
+                await extracting.promise;
+                const oldFinalization = manager.sessionFinalizations.get(session.id);
+                await manager.sendMessage(session.id, 'generate an updated commit message');
+                releaseExtraction.resolve();
+                await oldFinalization;
+                expect(driverSession.close).not.toHaveBeenCalled();
+                expect(manager.hasActiveTurn(session.id)).toBe(true);
+                turns[1].resolve({ stopReason: 'end_turn' });
+                await vi.waitFor(async () => {
+                    expect(await prisma.executionProcess.findFirst({ where: { sessionId: session.id } }))
+                        .toMatchObject({ cleanupState: 'CONFIRMED' });
+                });
+                expect(driverSession.close).toHaveBeenCalledOnce();
+            }
+            finally {
+                releaseExtraction.resolve();
+                extract.mockRestore();
+                await manager.destroyAll();
+            }
+        });
+    });
     it('requires a Provider runtime supported by the selected Agent before persisting a session', async () => {
         const { workspace } = await createSessionFixture();
         const manager = new SessionManager(new EventBus());