agent-tempo 1.0.1 → 1.2.0

package/dist/utils/bg-preflight.js

@@ -0,0 +1,154 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.__resetBgPreflightCacheForTests = __resetBgPreflightCacheForTests;
+exports.bgPreflight = bgPreflight;
+/**
+ * #596 / ADR 0016 — permission preflight for `claude --bg`.
+ *
+ * Anthropic's per-user supervisor refuses bypass modes
+ * (`--dangerously-skip-permissions`) that were never accepted interactively
+ * in the target cwd. The bypass-consent record is NOT transparently readable
+ * on disk (not in `~/.claude/settings*.json`, not in
+ * `~/.claude/projects/<encoded-cwd>/`), so a behavioral probe is the most
+ * robust signal.
+ *
+ * **Surprise observed during live E2E** (documented for ADR follow-up):
+ * `claude --bg --dangerously-skip-permissions --help` does NOT short-circuit
+ * on `--help` — the supervisor adopts the session FIRST then processes the
+ * help flag. So a "dry-run" probe actually creates a real supervisor job
+ * (prints `backgrounded · <shortId> (idle …)` and exits 0). The probe is
+ * still our most reliable acceptance signal — we just have to immediately
+ * `claude stop <shortId>` the session we created so the probe is truly
+ * side-effect-free from the operator's perspective. Cache hits skip
+ * probe+stop entirely.
+ *
+ * Result is cached per `(host, cwd)` in an in-process `Map` for the
+ * daemon's lifetime — once a daemon has confirmed a cwd is ok, subsequent
+ * recruits in that cwd skip the probe. On failure we surface an actionable
+ * error string the recruit activity logs and rethrows.
+ *
+ * Cache invalidates on daemon restart (the user might have accepted in the
+ * intervening time) — `__resetBgPreflightCacheForTests` exists for unit
+ * coverage. Production code never invalidates the cache directly.
+ */
+const child_process_1 = require("child_process");
+const os = __importStar(require("os"));
+const spawn_1 = require("../spawn");
+const log = (...args) => console.error('[agent-tempo:bg-preflight]', ...args);
+const cache = new Map();
+function cacheKey(k) {
+    return `${k.host}:::${k.cwd}`;
+}
+/**
+ * Test hook — never call from production code. Convention per
+ * `docs/adr/0006-test-hooks-naming.md`.
+ */
+function __resetBgPreflightCacheForTests() {
+    cache.clear();
+}
+/**
+ * Probe whether `claude --bg` can spawn in the given cwd without prompting
+ * the operator for permission acceptance. First call probes; subsequent
+ * calls for the same `(host, cwd)` hit the in-process cache.
+ *
+ * Returns `{ ok: true }` when the dry-run succeeded (exit 0). On any other
+ * exit code (or spawn-side ENOENT), returns `{ ok: false, error: ... }`
+ * with an actionable message. Never throws — callers handle the result.
+ */
+function bgPreflight(cwd, options) {
+    const host = options?.host ?? os.hostname();
+    const key = cacheKey({ host, cwd });
+    if (cache.has(key)) {
+        return { ok: true, cached: true };
+    }
+    const claudeBin = (0, spawn_1.resolveClaudePath)(options?.claudeBin);
+    // Dry-run: `--help` exits immediately without spawning a real session.
+    // Bypass-permissions flag triggers the supervisor's accept-consent check,
+    // which is the behavior we actually want to verify.
+    let result;
+    try {
+        result = (0, child_process_1.spawnSync)(claudeBin, ['--bg', '--dangerously-skip-permissions', '--help'], {
+            cwd,
+            encoding: 'utf8',
+            timeout: 15_000,
+            shell: process.platform === 'win32',
+        });
+    }
+    catch (err) {
+        const msg = err instanceof Error ? err.message : String(err);
+        const error = `claude --bg preflight failed to launch (${msg}). Run 'claude' once in ${cwd} and accept the permission dialog, then retry recruit.`;
+        log(error);
+        return { ok: false, error, cached: false };
+    }
+    if (result.error) {
+        const error = `claude --bg preflight failed to launch (${result.error.message}). Run 'claude' once in ${cwd} and accept the permission dialog, then retry recruit.`;
+        log(error);
+        return { ok: false, error, cached: false };
+    }
+    if (result.status === 0) {
+        // The probe spawned a real supervisor job — clean it up immediately so
+        // the operator never sees a leaked `idle` session in `claude agents`.
+        // Stdout format observed: `backgrounded · <shortId> (idle — send a prompt to start)`
+        const stdoutCombined = (result.stdout || '').toString();
+        const shortIdMatch = stdoutCombined.match(/backgrounded\s*[·•]\s*([0-9a-f]{8})/i);
+        if (shortIdMatch) {
+            const probeShortId = shortIdMatch[1];
+            try {
+                (0, child_process_1.spawnSync)(claudeBin, ['stop', probeShortId], {
+                    cwd,
+                    encoding: 'utf8',
+                    timeout: 10_000,
+                    shell: process.platform === 'win32',
+                });
+                log(`probe stopped its own session ${probeShortId} in ${cwd}`);
+            }
+            catch (err) {
+                log(`probe-cleanup warning: failed to stop ${probeShortId} (${err instanceof Error ? err.message : String(err)}); operator may see an idle 'agents' row`);
+            }
+        }
+        else {
+            log(`probe in ${cwd} exit 0 but no shortId in stdout — supervisor surface may have changed; not stopping anything`);
+        }
+        cache.set(key, true);
+        return { ok: true, cached: false };
+    }
+    const stderr = (result.stderr || '').trim();
+    const stdout = (result.stdout || '').trim();
+    const detail = stderr || stdout || `exit ${result.status}`;
+    const error = `claude --bg preflight rejected in ${cwd} (${detail}). Run 'claude' once in ${cwd} and accept the permission dialog, then retry recruit.`;
+    log(error);
+    return { ok: false, error, cached: false };
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-tempo",
-  "version": "1.0.1",
+  "version": "1.2.0",
   "description": "Many agents, one tempo. Durable coordination for multi-agent work via Temporal.",
   "keywords": [
     "mcp",
@@ -92,6 +92,8 @@
     "@modelcontextprotocol/sdk": "~1.28.0",
     "@temporalio/activity": "~1.15.0",
     "@temporalio/client": "~1.15.0",
+    "@temporalio/common": "~1.15.0",
+    "@temporalio/proto": "~1.15.0",
     "@temporalio/worker": "~1.15.0",
     "@temporalio/workflow": "~1.15.0",
     "croner": "^10.0.1",
@@ -107,7 +109,6 @@
   },
   "devDependencies": {
     "@size-limit/preset-app": "^12.1.0",
-    "@temporalio/common": "^1.15.0",
     "@temporalio/testing": "~1.15.0",
     "@types/chai": "^4.3.20",
     "@types/mocha": "^10.0.10",
@@ -160,7 +161,6 @@
   "engines": {
     "node": ">=20"
   },
-  "packageManager": "npm@10.9.2",
   "license": "MIT",
   "trustedDependencies": [
     "@swc/core",
@@ -168,5 +168,6 @@
   ],
   "overrides": {
     "rxjs": "^7.8.1"
-  }
+  },
+  "packageManager": "npm@10.9.2"
 }