agent-slack 0.6.0 → 0.6.1

package/README.md

@@ -293,7 +293,7 @@ When to use which:
 
 ### Files (snippets/images/attachments)
 
-`message get/list` auto-download attached files to an agent-friendly temp directory and return absolute paths in `message.files[].path`:
+`message get/list` auto-download attached files to an agent-friendly temp directory and return file metadata in `message.files[]`, including `name` when Slack provides the original filename and `path` for the local download. Failed downloads keep the attachment entry, preserve `message.files[].path` with a local `.download-error.txt` file, and include `message.files[].error`. `search messages` and `search all` use the same attachment shape for message results, while `search files` skips entries whose download fails.
 
 - macOS default: `~/.agent-slack/tmp/downloads/`
 

package/dist/index.js

@@ -2417,6 +2417,14 @@ function registerAuthCommand(input) {
 import { mkdir as mkdir3, writeFile as writeFile2 } from "node:fs/promises";
 import { basename, join as join9, resolve } from "node:path";
 import { existsSync as existsSync7 } from "node:fs";
+class SlackDownloadError extends Error {
+  httpStatus;
+  constructor(message, httpStatus) {
+    super(message);
+    this.httpStatus = httpStatus;
+    this.name = "SlackDownloadError";
+  }
+}
 async function downloadSlackFile(input) {
   const { auth, url, destDir, preferredName, options } = input;
   const absDir = resolve(destDir);
@@ -2435,19 +2443,54 @@ async function downloadSlackFile(input) {
     headers.Referer = "https://app.slack.com/";
     headers["User-Agent"] = getUserAgent();
   }
-  const resp = await fetch(url, { headers });
+  let resp;
+  try {
+    resp = await fetch(url, { headers });
+  } catch (err) {
+    throw new SlackDownloadError(`Network error: ${err instanceof Error ? err.message : String(err)}`);
+  }
   if (!resp.ok) {
-    throw new Error(`Failed to download file (${resp.status})`);
+    throw new SlackDownloadError(`Failed to download file (${resp.status})`, resp.status);
   }
   const contentType = resp.headers.get("content-type") || "";
   if (!options?.allowHtml && contentType.includes("text/html")) {
-    const text = await resp.text();
-    throw new Error(`Downloaded HTML instead of file (auth likely failed). First bytes: ${JSON.stringify(text.slice(0, 120))}`);
+    let text;
+    try {
+      text = await resp.text();
+    } catch (err) {
+      throw new SlackDownloadError(`Failed to read download response body: ${err instanceof Error ? err.message : String(err)}`, resp.status);
+    }
+    throw new SlackDownloadError(`Downloaded HTML instead of file (auth likely failed). First bytes: ${JSON.stringify(text.slice(0, 120))}`, resp.status);
+  }
+  let arrayBuffer;
+  try {
+    arrayBuffer = await resp.arrayBuffer();
+  } catch (err) {
+    throw new SlackDownloadError(`Failed to read download response body: ${err instanceof Error ? err.message : String(err)}`, resp.status);
   }
-  const buf = Buffer.from(await resp.arrayBuffer());
+  const buf = Buffer.from(arrayBuffer);
   await writeFile2(path, buf);
   return path;
 }
+async function tryDownloadSlackFile(input) {
+  try {
+    const path = await downloadSlackFile(input);
+    return { ok: true, path };
+  } catch (err) {
+    if (err instanceof SlackDownloadError) {
+      return { ok: false, error: err.message, httpStatus: err.httpStatus };
+    }
+    throw err;
+  }
+}
+async function writeDownloadErrorFile(input) {
+  const absDir = resolve(input.destDir);
+  await mkdir3(absDir, { recursive: true });
+  const path = join9(absDir, sanitizeFilename(`${input.fileId}.download-error.txt`));
+  await writeFile2(path, `${input.error}
+`, "utf8");
+  return path;
+}
 function sanitizeFilename(name) {
   return name.replace(/[\\/<>:"|?*]/g, "_");
 }
@@ -3129,14 +3172,16 @@ function toCompactMessage(msg, input) {
   const content = maxBodyChars >= 0 && rendered.length > maxBodyChars ? `${rendered.slice(0, maxBodyChars)}
 …` : rendered;
   const files = msg.files?.map((f) => {
-    const path = input?.downloadedPaths?.[f.id];
-    if (!path) {
+    const entry = input?.downloadedPaths?.[f.id];
+    if (!entry) {
       return null;
     }
-    return {
+    return entry.ok ? { name: f.name, mimetype: f.mimetype, mode: f.mode, path: entry.path } : {
+      name: f.name,
       mimetype: f.mimetype,
       mode: f.mode,
-      path
+      path: entry.path,
+      error: entry.error
     };
   }).filter((f) => Boolean(f));
   return {
@@ -3743,7 +3788,7 @@ async function downloadCanvasAsMarkdown(input) {
   });
   const html = await readFile6(htmlPath, "utf8");
   if (looksLikeAuthPage(html)) {
-    throw new Error("Downloaded auth/login page instead of canvas content (token may be expired)");
+    throw new SlackDownloadError("Downloaded auth/login page instead of canvas content (token may be expired)");
   }
   const markdown = htmlToMarkdown(html).trim();
   const safeName = `${input.fileId.replace(/[\\/<>"|?*]/g, "_")}.md`;
@@ -3764,25 +3809,53 @@ async function downloadMessageFiles(input) {
       if (!url) {
         continue;
       }
-      try {
-        if (isCanvas) {
-          downloadedPaths[file.id] = await downloadCanvasAsMarkdown({
+      if (isCanvas) {
+        try {
+          const path = await downloadCanvasAsMarkdown({
             auth: input.auth,
             fileId: file.id,
             url,
             destDir: downloadsDir
           });
-        } else {
-          const ext = inferFileExtension(file);
-          downloadedPaths[file.id] = await downloadSlackFile({
-            auth: input.auth,
-            url,
+          downloadedPaths[file.id] = { ok: true, path };
+        } catch (err) {
+          if (!(err instanceof SlackDownloadError)) {
+            throw err;
+          }
+          const path = await writeDownloadErrorFile({
             destDir: downloadsDir,
-            preferredName: `${file.id}${ext ? `.${ext}` : ""}`
+            fileId: file.id,
+            error: err.message
           });
+          downloadedPaths[file.id] = {
+            ok: false,
+            error: err.message,
+            httpStatus: err.httpStatus,
+            path
+          };
+          console.error(`Warning: skipping file ${file.id}: ${err.message}`);
+        }
+      } else {
+        const ext = inferFileExtension(file);
+        const result = await tryDownloadSlackFile({
+          auth: input.auth,
+          url,
+          destDir: downloadsDir,
+          preferredName: `${file.id}${ext ? `.${ext}` : ""}`
+        });
+        if (!result.ok) {
+          downloadedPaths[file.id] = {
+            ...result,
+            path: await writeDownloadErrorFile({
+              destDir: downloadsDir,
+              fileId: file.id,
+              error: result.error
+            })
+          };
+          console.error(`Warning: skipping file ${file.id}: ${result.error}`);
+        } else {
+          downloadedPaths[file.id] = result;
         }
-      } catch (err) {
-        console.error(`Warning: skipping file ${file.id}: ${err instanceof Error ? err.message : String(err)}`);
       }
     }
   }
@@ -6614,18 +6687,22 @@ async function searchFilesViaSearchApi(client, input) {
     if (!id) {
       continue;
     }
-    const path = await downloadSlackFile({
+    const result = await tryDownloadSlackFile({
       auth: input.auth,
       url,
       destDir: downloadsDir,
       preferredName: `${id}${ext ? `.${ext}` : ""}`
     });
+    if (!result.ok) {
+      console.warn(`Warning: skipping file ${id}: ${result.error}`);
+      continue;
+    }
     const title = (getString(f.title) || getString(f.name) || "").trim();
     out.push({
       title: title || undefined,
       mimetype,
       mode,
-      path
+      path: result.path
     });
     if (out.length >= input.limit) {
       break;
@@ -6680,17 +6757,21 @@ async function searchFilesInChannelsFallback(client, input) {
         if (!id) {
           continue;
         }
-        const path = await downloadSlackFile({
+        const result = await tryDownloadSlackFile({
           auth: input.auth,
           url,
           destDir: downloadsDir,
           preferredName: `${id}${ext ? `.${ext}` : ""}`
         });
+        if (!result.ok) {
+          console.warn(`Warning: skipping file ${id}: ${result.error}`);
+          continue;
+        }
         out.push({
           title: title || undefined,
           mimetype,
           mode,
-          path
+          path: result.path
         });
         if (out.length >= input.limit) {
           return out;
@@ -6906,13 +6987,25 @@ async function downloadFilesForMessage(input) {
       continue;
     }
     const ext = inferExt(f);
-    const path = await downloadSlackFile({
+    const result = await tryDownloadSlackFile({
       auth: input.auth,
       url,
       destDir: input.downloadsDir,
       preferredName: `${f.id}${ext ? `.${ext}` : ""}`
     });
-    input.downloadedPaths[f.id] = path;
+    if (!result.ok) {
+      input.downloadedPaths[f.id] = {
+        ...result,
+        path: await writeDownloadErrorFile({
+          destDir: input.downloadsDir,
+          fileId: f.id,
+          error: result.error
+        })
+      };
+      console.warn(`Warning: file ${f.id}: ${result.error}`);
+    } else {
+      input.downloadedPaths[f.id] = result;
+    }
   }
 }
 function messageSummaryFromApiMessage(channelId, msg) {
@@ -7848,5 +7941,5 @@ if (subcommand && subcommand !== "update") {
   backgroundUpdateCheck();
 }
 
-//# debugId=5ADF75C59137BC5064756E2164756E21
+//# debugId=3EBC31FAC3ADA2FD64756E2164756E21
 //# sourceMappingURL=index.js.map