agent-roast 0.12.1 → 0.12.2

package/README.md

@@ -110,7 +110,7 @@ old debt with a baseline: [docs/reference.md](docs/reference.md#configuration).
 Measured, with the denominators and the caveats in [docs/benchmarks.md](docs/benchmarks.md). **Weakened checks are rare, mostly
 deliberate, and not specific to AI. agent-roast is a tripwire that stays silent until a check gets weaker.**
 
-- **64 of 64** hand-labeled cheating edits are caught and **44 of 44** harmless look-alikes (reformats, moves, raised
+- **71 of 71** hand-labeled cheating edits are caught and **51 of 51** harmless look-alikes (reformats, moves, raised
   thresholds, environment-gated skips) stay silent. The cases were written with the detector, so they guard against regressions;
   they do not prove accuracy. Three gaps are documented and still open.
 - **12,645 commits** that touch tests or CI/config in 166 public repositories: blocking rules fired on 0.3% of AI-signed commits
@@ -120,6 +120,10 @@ deliberate, and not specific to AI. agent-roast is a tripwire that stays silent
 - **About one finding in five was a false alarm**, and most of the rest were deliberate, explained changes a reviewer should
   see rather than mistakes. The labels come from one reader (an AI assistant), so treat them as a first estimate.
 - `replay` ran on 179 public repositories that use coding agents: no commit would have been blocked in 149 of them.
+- The rules for **eight more languages** (Go, Rust, Java, Kotlin, C#, Ruby, PHP, Swift) ran on the newest 300 commits of 39
+  repositories and every finding was read: 26 of 99 were skips that depend on the environment, now fixed; of the 73 left, 56 are
+  tests that really are switched off and 17 are deliberate test data. One reader, and the fixes were made on the same
+  repositories, so expect a few new false alarms elsewhere.
 
 ## How it compares
 

package/dist/{chunk-AP5Y4CH6.js → chunk-FA47T742.js}

@@ -1191,7 +1191,8 @@ var GO_GUARD = {
 var RUBY_GUARD = {
   modifier: /^\s*(?:skip|pending)\b.*\b(?:if|unless)\b/,
   conditional: /^\s*(?:if|unless|else|elsif|case|when|begin|rescue|ensure|while|until)\b/,
-  test: /^\s*(?:it|specify|example|scenario|test|before|after|around)\b|^\s*def\s+test_/,
+  // Hooks (before, after, around) are not listed: a hook declared under `elsif RUBY_VERSION ...` gates its skip like an example does.
+  test: /^\s*(?:it|specify|example|scenario|test)\b|^\s*def\s+test_/,
   helper: /^\s*def\s+\w+/
 };
 var PHP_GUARD = {
@@ -1201,9 +1202,10 @@ var PHP_GUARD = {
   helper: /^\s*(?:(?:public|protected|private|static)\s+)*function\s+\w+\s*\(/
 };
 var SWIFT_GUARD = {
+  preprocessor: { open: /^\s*#if\b/, close: /^\s*#endif\b/, other: /^\s*#else(?:if)?\b/ },
   conditional: /^\s*(?:\}\s*)?(?:if|else|guard|switch|case|for|while|do|catch)\b/,
-  test: /^\s*(?:@\w+\s+)*(?:(?:private|fileprivate|static)\s+)*func\s+test\w*\s*\(/,
-  helper: /^\s*(?:@\w+\s+)*(?:(?:private|fileprivate|static)\s+)*func\s+\w+\s*\(/
+  test: /^\s*(?:@\w+\s+)*(?:(?:public|open|internal|private|fileprivate|static|final|override|class|nonisolated)\s+)*func\s+test\w*\s*\(/,
+  helper: /^\s*(?:@\w+\s+)*(?:(?:public|open|internal|private|fileprivate|static|final|override|class|nonisolated)\s+)*func\s+\w+\s*\(/
 };
 var LANGUAGE_LINE_RULES = [
   { files: /_test\.go$/i, rules: [
@@ -1226,7 +1228,9 @@ var LANGUAGE_LINE_RULES = [
     { type: "trivial-assert", regex: /\bassertThat\s*\(\s*true\s*\)\s*\.\s*isTrue\s*\(/, name: "trivial assert (assertThat(true).isTrue())" }
   ] },
   { files: /\.cs$/i, rules: [
-    { type: "test-skip", regex: /\[\s*Ignore\b|\b(?:Fact|Theory)\s*\(\s*(?:[^)]*,\s*)?Skip\s*=/, name: "ignored .NET test ([Ignore] / Skip =)" },
+    // `[Ignore]` is checked separately: it also names a mapping attribute (AutoMapper) and must sit next to a test attribute.
+    // Skip = with SkipUnless, SkipWhen or SkipType depends on the environment.
+    { type: "test-skip", regex: /\b(?:Fact|Theory)\s*\(\s*(?:[^)]*,\s*)?Skip\s*=(?![^\]]*\bSkip(?:Unless|When|Type)\b)/, name: "ignored .NET test (Skip =)" },
     { type: "trivial-assert", regex: /\bAssert\s*\.\s*(?:True|IsTrue)\s*\(\s*true\s*\)/, name: "trivial assert (Assert.True(true))" },
     { type: "trivial-assert", regex: /\bAssert\s*\.\s*(?:False|IsFalse)\s*\(\s*false\s*\)/, name: "trivial assert (Assert.False(false))" },
     { type: "trivial-assert", regex: /\bAssert\s*\.\s*(?:AreEqual|Equal)\s*\(\s*(\d+|true|false|null)\s*,\s*\1\s*\)/, name: "trivial assert (Assert.Equal(1, 1))" }
@@ -1236,7 +1240,9 @@ var LANGUAGE_LINE_RULES = [
     { type: "test-focus", regex: /^\s*(?:fit|fdescribe|fcontext|fspecify|fexample|fscenario)\b/, name: "focused RSpec example (fit / fdescribe)" },
     { type: "test-focus", regex: /\b(?:it|describe|context|specify|scenario)\b[^\n]*[,(]\s*(?::focus\b|focus:\s*true\b)/, name: "focused RSpec example (focus: true)" },
     { type: "test-skip", regex: /^\s*(?:xit|xdescribe|xcontext|xspecify|xexample|xscenario|xfeature)\b/, name: "disabled RSpec example (xit / xdescribe)" },
-    { type: "test-skip", regex: /\b(?:it|describe|context|specify|scenario)\b[^\n]*[,(]\s*(?::skip\b|skip:\s*(?:true\b|["']))/, name: "disabled RSpec example (skip: true)" },
+    // `:skip => !feature?` or `skip: RUBY_VERSION < "3"` gates the example on its environment; only a bare flag, true or a reason
+    // disables it. The line is matched with its strings blanked, so a reason shows as nothing between `skip:` and `do`, `{`, `,` or `)`.
+    { type: "test-skip", regex: /\b(?:it|describe|context|specify|scenario)\b[^\n]*[,(]\s*(?::skip\b(?!\s*=>)|(?::skip\s*=>|skip:)\s*(?:true\b|(?=do\b|\{|,|\)|$)))/, name: "disabled RSpec example (skip: true)" },
     { type: "test-skip", regex: /^\s*skip(?:\s|\(|$)/, name: "skipped Ruby test (skip)", guard: RUBY_GUARD },
     { type: "test-skip", regex: /^\s*pending(?:\s+["'(]|\s*$)/, name: "pending Ruby example (pending)", guard: RUBY_GUARD },
     { type: "trivial-assert", regex: /\bexpect\s*\(\s*(true|false|1|0|nil)\s*\)\s*\.\s*to\s+(?:eq|eql|be|equal)\b\s*\(?\s*\1\b/, name: "trivial expectation (expect(true).to eq(true))" },
@@ -1251,29 +1257,53 @@ var LANGUAGE_LINE_RULES = [
   ] },
   { files: /\.swift$/i, rules: [
     { type: "test-skip", regex: /\bthrow\s+XCTSkip\s*\(/, name: "skipped XCTest (XCTSkip)", guard: SWIFT_GUARD },
-    { type: "test-skip", regex: /@(?:Test|Suite)\s*\([^)]*\.disabled\b/, name: "disabled Swift Testing test (.disabled)" },
+    // `.disabled(if: condition)` depends on the environment; `.disabled()` and `.disabled("reason")` switch the test off.
+    { type: "test-skip", regex: /@(?:Test|Suite)\s*\([^)]*\.disabled\s*\((?!\s*if\b)/, name: "disabled Swift Testing test (.disabled)" },
     { type: "trivial-assert", regex: /\bXCTAssertTrue\s*\(\s*true\s*\)/, name: "trivial assert (XCTAssertTrue(true))" },
     { type: "trivial-assert", regex: /\bXCTAssertFalse\s*\(\s*false\s*\)/, name: "trivial assert (XCTAssertFalse(false))" },
     { type: "trivial-assert", regex: /\bXCTAssertEqual\s*\(\s*(\d+|true|false|nil)\s*,\s*\1\s*\)/, name: "trivial assert (XCTAssertEqual(1, 1))" },
     { type: "trivial-assert", regex: /#expect\s*\(\s*true\s*\)/, name: "trivial expectation (#expect(true))" }
   ] }
 ];
+function inTestAttributeList(lines, index) {
+  const marker = /\[\s*(?:Test|TestCase|TestCaseSource|TestMethod|DataTestMethod|TestFixture|TestClass|Fact|Theory)\b/;
+  if (marker.test(lines[index].code)) return true;
+  for (const step of [-1, 1]) {
+    for (let i = index + step, seen = 0; i >= 0 && i < lines.length && seen < 6; i += step, seen++) {
+      if (lines[i].number !== lines[i - step].number + step || !/^\s*\[/.test(lines[i].code)) break;
+      if (marker.test(lines[i].code)) return true;
+    }
+  }
+  return false;
+}
 function isGuardedBlockSkip(lines, profile) {
   const indentOf = (text) => text.length - text.trimStart().length;
   const mentionsCi = (raw) => /\bCI\b|\bGITHUB_ACTIONS\b/.test(raw);
   const own = lines[lines.length - 1];
   if (profile.modifier?.test(own.code) || profile.conditional.test(own.code)) return !mentionsCi(own.raw);
+  const compiledConditionally = (from) => {
+    const directives = profile.preprocessor;
+    if (!directives) return false;
+    let depth = 0;
+    for (let i2 = from; i2 < lines.length - 1; i2++) {
+      if (directives.open.test(lines[i2].code)) depth++;
+      else if (directives.close.test(lines[i2].code)) depth = Math.max(0, depth - 1);
+    }
+    return depth > 0;
+  };
   let limit = indentOf(own.code);
-  for (let i = lines.length - 2; i >= 0 && lines.length - 1 - i <= 200; i--) {
-    if (lines[i].number !== lines[i + 1].number - 1) return false;
+  let i = lines.length - 2;
+  for (; i >= 0 && lines.length - 1 - i <= 200; i--) {
+    if (lines[i].number !== lines[i + 1].number - 1) return compiledConditionally(i + 1);
     const { code, raw } = lines[i];
     if (!code.trim() || indentOf(code) >= limit) continue;
+    if (profile.preprocessor && (profile.preprocessor.open.test(code) || profile.preprocessor.close.test(code) || profile.preprocessor.other.test(code))) continue;
     if (profile.conditional.test(code)) return !mentionsCi(raw);
-    if (profile.test.test(code)) return false;
+    if (profile.test.test(code)) return compiledConditionally(i + 1);
     if (profile.helper.test(code)) return true;
     limit = indentOf(code);
   }
-  return false;
+  return compiledConditionally(i + 1);
 }
 var JS_TEST_API = /(?<![\w$.])(?:(?:it|test|describe|suite)(?:\s*\.\s*(?:concurrent|serial|parallel|describe|failing|sequential))*\s*\.\s*(skip|todo|only)|((?:xit|xtest|xdescribe|fit|fdescribe)))\b((?:\s*\.\s*(?:each|failing|concurrent|serial|parallel|sequential))*)\s*(?=\(|\u0001)/g;
 function isConditionalSkip(source, raw, open2) {
@@ -1470,6 +1500,13 @@ function auditFileDiffs(files, commitHash = "HEAD", commitDate = (/* @__PURE__ *
         }
       }
     }
+    if (/\.cs$/i.test(file.path)) {
+      maskedLines.forEach((line, index) => {
+        if (/\[\s*Ignore\b/.test(line.code) && inTestAttributeList(maskedLines, index)) {
+          infractions.push({ type: "test-skip", file: file.path, lineNumber: line.number, lineSnippet: line.raw.trim(), commitHash, commitDate, reason: "ignored .NET test ([Ignore])" });
+        }
+      });
+    }
     let source = "";
     let code = "";
     let raw = "";

package/dist/cli.js

@@ -37,7 +37,7 @@ import {
   terminalText,
   uninstallHooks,
   writeBaseline
-} from "./chunk-AP5Y4CH6.js";
+} from "./chunk-FA47T742.js";
 
 // src/cli.ts
 import { Command } from "commander";

package/dist/index.js

@@ -88,7 +88,7 @@ import {
   unquoteGitPath,
   validateExceptions,
   writeBaseline
-} from "./chunk-AP5Y4CH6.js";
+} from "./chunk-FA47T742.js";
 export {
   AGENT_LABELS,
   CONFIG_FILENAMES,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-roast",
-  "version": "0.12.1",
+  "version": "0.12.2",
   "description": "Stops AI coding agents (and rushed humans) from turning a build green by weakening tests, coverage gates or CI. Hook for Claude Code, Codex and Cursor, pre-commit, GitHub Action. Offline.",
   "type": "module",
   "main": "./dist/index.js",