agent-relay 4.0.31 → 4.0.32

package/node_modules/agent-trajectories/dist/cli/index.js

@@ -404,8 +404,16 @@ function abandonTrajectory(trajectory, reason) {
 }
 
 // src/storage/file.ts
+import { randomUUID } from "crypto";
 import { existsSync } from "fs";
-import { mkdir, readFile, readdir, unlink, writeFile } from "fs/promises";
+import {
+  mkdir,
+  readFile,
+  readdir,
+  rename,
+  unlink,
+  writeFile
+} from "fs/promises";
 import { join } from "path";
 
 // src/export/markdown.ts
@@ -586,6 +594,16 @@ function getSearchPaths() {
   }
   return [join(process.cwd(), ".trajectories")];
 }
+var indexLocks = /* @__PURE__ */ new Map();
+function withIndexLock(path2, task) {
+  const prev = indexLocks.get(path2) ?? Promise.resolve();
+  const next = prev.then(task, task);
+  indexLocks.set(
+    path2,
+    next.catch(() => void 0)
+  );
+  return next;
+}
 var FileStorage = class {
   baseDir;
   trajectoriesDir;
@@ -612,10 +630,10 @@ var FileStorage = class {
     await mkdir(this.activeDir, { recursive: true });
     await mkdir(this.completedDir, { recursive: true });
     if (!existsSync(this.indexPath)) {
-      await this.saveIndex({
-        version: 1,
-        lastUpdated: (/* @__PURE__ */ new Date()).toISOString(),
-        trajectories: {}
+      await withIndexLock(this.indexPath, async () => {
+        if (!existsSync(this.indexPath)) {
+          await this.saveIndex(this.emptyIndex());
+        }
       });
     }
     await this.reconcileIndex();
@@ -643,49 +661,51 @@ var FileStorage = class {
       skippedSchemaViolation: 0,
       skippedIoError: 0
     };
-    const index = await this.loadIndex();
-    const before = Object.keys(index.trajectories).length;
-    const discovered = [];
-    try {
-      const activeFiles = await readdir(this.activeDir);
-      for (const file of activeFiles) {
-        if (!file.endsWith(".json")) continue;
-        discovered.push(join(this.activeDir, file));
+    await withIndexLock(this.indexPath, async () => {
+      const index = await this.loadIndex();
+      const before = Object.keys(index.trajectories).length;
+      const discovered = [];
+      try {
+        const activeFiles = await readdir(this.activeDir);
+        for (const file of activeFiles) {
+          if (!file.endsWith(".json")) continue;
+          discovered.push(join(this.activeDir, file));
+        }
+      } catch (error) {
+        if (error.code !== "ENOENT") throw error;
       }
-    } catch (error) {
-      if (error.code !== "ENOENT") throw error;
-    }
-    await this.walkJsonFilesInto(this.completedDir, discovered);
-    for (const filePath of discovered) {
-      summary.scanned += 1;
-      const result = await this.readTrajectoryFile(filePath);
-      if (!result.ok) {
-        if (result.reason === "malformed_json") {
-          summary.skippedMalformedJson += 1;
-        } else if (result.reason === "schema_violation") {
-          summary.skippedSchemaViolation += 1;
-        } else {
-          summary.skippedIoError += 1;
+      await this.walkJsonFilesInto(this.completedDir, discovered);
+      for (const filePath of discovered) {
+        summary.scanned += 1;
+        const result = await this.readTrajectoryFile(filePath);
+        if (!result.ok) {
+          if (result.reason === "malformed_json") {
+            summary.skippedMalformedJson += 1;
+          } else if (result.reason === "schema_violation") {
+            summary.skippedSchemaViolation += 1;
+          } else {
+            summary.skippedIoError += 1;
+          }
+          continue;
         }
-        continue;
+        const trajectory = result.trajectory;
+        if (index.trajectories[trajectory.id]) {
+          summary.alreadyIndexed += 1;
+          continue;
+        }
+        index.trajectories[trajectory.id] = {
+          title: trajectory.task.title,
+          status: trajectory.status,
+          startedAt: trajectory.startedAt,
+          completedAt: trajectory.completedAt,
+          path: filePath
+        };
+        summary.added += 1;
       }
-      const trajectory = result.trajectory;
-      if (index.trajectories[trajectory.id]) {
-        summary.alreadyIndexed += 1;
-        continue;
+      if (Object.keys(index.trajectories).length !== before) {
+        await this.saveIndex(index);
       }
-      index.trajectories[trajectory.id] = {
-        title: trajectory.task.title,
-        status: trajectory.status,
-        startedAt: trajectory.startedAt,
-        completedAt: trajectory.completedAt,
-        path: filePath
-      };
-      summary.added += 1;
-    }
-    if (Object.keys(index.trajectories).length !== before) {
-      await this.saveIndex(index);
-    }
+    });
     const hadSkips = summary.skippedMalformedJson + summary.skippedSchemaViolation + summary.skippedIoError > 0;
     if (summary.added > 0 || hadSkips) {
       const parts = [`reconciled ${summary.added}/${summary.scanned}`];
@@ -888,17 +908,19 @@ var FileStorage = class {
     if (existsSync(activePath)) {
       await unlink(activePath);
     }
-    const index = await this.loadIndex();
-    const entry = index.trajectories[id];
-    if (entry?.path && existsSync(entry.path)) {
-      await unlink(entry.path);
-      const mdPath = entry.path.replace(".json", ".md");
-      if (existsSync(mdPath)) {
-        await unlink(mdPath);
+    await withIndexLock(this.indexPath, async () => {
+      const index = await this.loadIndex();
+      const entry = index.trajectories[id];
+      if (entry?.path && existsSync(entry.path)) {
+        await unlink(entry.path);
+        const mdPath = entry.path.replace(".json", ".md");
+        if (existsSync(mdPath)) {
+          await unlink(mdPath);
+        }
       }
-    }
-    delete index.trajectories[id];
-    await this.saveIndex(index);
+      delete index.trajectories[id];
+      await this.saveIndex(index);
+    });
   }
   /**
    * Search trajectories by text
@@ -976,10 +998,23 @@ var FileStorage = class {
     const result = await this.readTrajectoryFile(path2);
     return result.ok ? result.trajectory : null;
   }
+  /**
+   * Read and parse the on-disk index.
+   *
+   * Tolerances (belt-and-braces against the read/write race):
+   *   - ENOENT: first-run, return an empty index silently.
+   *   - Empty file: a concurrent writer truncated index.json in "w" mode
+   *     right before we read. Return an empty index silently — this is
+   *     not a real corruption, just an interleaving the mutex + atomic
+   *     rename should already prevent. Logging here would be noise.
+   *   - Non-empty but malformed JSON: genuinely corrupted on disk (hand
+   *     edit, disk error, etc). Log it and return an empty index so the
+   *     caller can recover, but keep the log so the problem is visible.
+   */
   async loadIndex() {
+    let content;
     try {
-      const content = await readFile(this.indexPath, "utf-8");
-      return JSON.parse(content);
+      content = await readFile(this.indexPath, "utf-8");
     } catch (error) {
       if (error.code !== "ENOENT") {
         console.error(
@@ -987,27 +1022,56 @@ var FileStorage = class {
           error
         );
       }
-      return {
-        version: 1,
-        lastUpdated: (/* @__PURE__ */ new Date()).toISOString(),
-        trajectories: {}
-      };
+      return this.emptyIndex();
+    }
+    if (content.length === 0) {
+      return this.emptyIndex();
+    }
+    try {
+      return JSON.parse(content);
+    } catch (error) {
+      console.error(
+        "Error loading trajectory index, using empty index:",
+        error
+      );
+      return this.emptyIndex();
     }
   }
+  emptyIndex() {
+    return {
+      version: 1,
+      lastUpdated: (/* @__PURE__ */ new Date()).toISOString(),
+      trajectories: {}
+    };
+  }
+  /**
+   * Atomic write: stage into a process-unique temp path in the same directory
+   * and then rename over the live file. `rename` is atomic on POSIX, so
+   * concurrent readers in any process either see the old complete file or
+   * the new complete file — never a half-written / zero-byte state.
+   *
+   * Callers MUST hold `withIndexLock(this.indexPath, ...)` so the in-process
+   * read-modify-write cycle stays serialized; the unique temp name also keeps
+   * parallel writers in other processes from colliding on a shared tmp path.
+   */
   async saveIndex(index) {
     index.lastUpdated = (/* @__PURE__ */ new Date()).toISOString();
-    await writeFile(this.indexPath, JSON.stringify(index, null, 2), "utf-8");
+    const tmpPath = `${this.indexPath}.${process.pid}.${randomUUID()}.tmp`;
+    await writeFile(tmpPath, JSON.stringify(index, null, 2), "utf-8");
+    await rename(tmpPath, this.indexPath);
   }
   async updateIndex(trajectory, filePath) {
-    const index = await this.loadIndex();
-    index.trajectories[trajectory.id] = {
-      title: trajectory.task.title,
-      status: trajectory.status,
-      startedAt: trajectory.startedAt,
-      completedAt: trajectory.completedAt,
-      path: filePath
-    };
-    await this.saveIndex(index);
+    await withIndexLock(this.indexPath, async () => {
+      const index = await this.loadIndex();
+      index.trajectories[trajectory.id] = {
+        title: trajectory.task.title,
+        status: trajectory.status,
+        startedAt: trajectory.startedAt,
+        completedAt: trajectory.completedAt,
+        path: filePath
+      };
+      await this.saveIndex(index);
+    });
   }
 };