agent-passport-system-mcp 2.8.0 → 2.8.2

package/README.md

@@ -8,7 +8,7 @@
 
 MCP server for the [Agent Passport System](https://github.com/aeoess/agent-passport-system) — cryptographic identity, delegation, governance, and commerce for AI agents.
 
-**61 tools** across all 16 protocol modules. Works with any MCP client: Claude Desktop, Cursor, Windsurf, and more.
+**61 tools** across all 17 protocol modules. Works with any MCP client: Claude Desktop, Cursor, Windsurf, and more.
 
 ## Quick Start
 

package/build/index.js

@@ -90,7 +90,7 @@ function loadTasks() {
             }
         }
         catch (e) {
-            console.error('Failed to load task store:', e);
+            console.error('Failed to load task store');
         }
     }
 }
@@ -137,13 +137,22 @@ function sanitizeAgentName(name) {
 function isPathWithin(filePath, allowedDir) {
     return resolve(filePath).startsWith(resolve(allowedDir) + '/');
 }
+// Sanitize error messages before returning to clients
+function safeError(prefix, e) {
+    if (e instanceof Error) {
+        const msg = e.message.replace(/\/[^\s:]+/g, '[path]').replace(/at\s+.+/g, '').slice(0, 200);
+        return `${prefix}: ${msg}`.trim();
+    }
+    return `${prefix}: operation failed`;
+}
 function getAgentName() {
-    // Derive agent name from agentId (e.g., "claude-001" → "claude")
+    // Derive agent name from agentId — always sanitize to prevent path traversal
+    let name = 'unknown';
     if (state.agentId)
-        return state.agentId.replace(/-\d+$/, '');
-    if (state.agentKey)
-        return state.agentKey.slice(0, 8);
-    return 'unknown';
+        name = state.agentId.replace(/-\d+$/, '');
+    else if (state.agentKey)
+        name = state.agentKey.slice(0, 8);
+    return sanitizeAgentName(name) || 'unknown';
 }
 // ── Agora bridge: auto-post coordination events ──
 // Load existing Agora feed from disk on startup
@@ -163,7 +172,7 @@ function loadAgoraFeed() {
         }
     }
     catch {
-        // Non-fatal: start with empty feed if file is corrupted
+        console.error('Agora feed read failed — starting with empty feed');
     }
 }
 // Persist Agora feed to disk after changes
@@ -224,7 +233,7 @@ function loadAgentsRegistry() {
         const data = JSON.parse(readFileSync(AGENTS_PATH, 'utf-8'));
         return data.agents || [];
     }
-    catch {
+    catch { /* file read failed */
         return [];
     }
 }
@@ -581,7 +590,7 @@ server.tool("review_evidence", "[OPERATOR] Review an evidence packet. Score it a
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Error: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Error", e) }], isError: true };
     }
 });
 server.tool("handoff_evidence", "[OPERATOR] Transfer approved evidence from researcher to analyst.", {
@@ -629,7 +638,7 @@ server.tool("handoff_evidence", "[OPERATOR] Transfer approved evidence from rese
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Error: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Error", e) }], isError: true };
     }
 });
 server.tool("complete_task", "[OPERATOR] Close the task unit with final status and retrospective.", {
@@ -935,6 +944,22 @@ server.tool("create_delegation", "[OPERATOR] Create a scoped delegation from one
     const keyErr = requireKey();
     if (keyErr)
         return { content: [{ type: "text", text: keyErr }], isError: true };
+    // Validate delegation scopes
+    if (!args.scope || args.scope.length === 0) {
+        return { content: [{ type: "text", text: "Delegation must include at least one scope." }], isError: true };
+    }
+    const SCOPE_PATTERN = /^[a-zA-Z0-9_.:/-]+$/;
+    for (const s of args.scope) {
+        if (s === '*' || s === '**') {
+            return { content: [{ type: "text", text: `Wildcard scope "${s}" not allowed. Use explicit scopes.` }], isError: true };
+        }
+        if (s.length > 128) {
+            return { content: [{ type: "text", text: `Scope exceeds max length (128 chars).` }], isError: true };
+        }
+        if (!SCOPE_PATTERN.test(s)) {
+            return { content: [{ type: "text", text: `Scope "${s}" contains invalid characters.` }], isError: true };
+        }
+    }
     const delegation = createDelegation({
         delegatedBy: state.agentKey,
         delegatedTo: args.delegated_to,
@@ -1050,7 +1075,7 @@ server.tool("sub_delegate", "Sub-delegate authority to another agent (must be wi
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Sub-delegation failed: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Sub-delegation failed", e) }], isError: true };
     }
 });
 // ═══════════════════════════════════════
@@ -1239,7 +1264,7 @@ server.tool("register_agora_public", "Register your agent in the PUBLIC Agora re
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `❌ Failed to create issue: ${e.message}` }] };
+        return { content: [{ type: "text", text: safeError("Failed to create issue", e) }] };
     }
 });
 // ═══════════════════════════════════════
@@ -1297,6 +1322,9 @@ server.tool("check_messages", "Check messages addressed to you. Reads from comms
 }, async (args) => {
     const name = getAgentName();
     const filePath = join(COMMS_PATH, `to-${name}.json`);
+    if (!isPathWithin(filePath, COMMS_PATH)) {
+        return { content: [{ type: "text", text: "Invalid agent name — path rejected" }] };
+    }
     let messages = readCommsFile(filePath);
     const unprocessedOnly = args.unprocessed_only !== false;
     if (unprocessedOnly) {
@@ -1395,7 +1423,7 @@ server.tool("load_values_floor", "Load a Values Floor from YAML. Sets the floor
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Failed to load floor: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Failed to load floor", e) }], isError: true };
     }
 });
 server.tool("attest_to_floor", "Attest that your agent agrees to abide by the loaded Values Floor.", {
@@ -1521,7 +1549,7 @@ server.tool("evaluate_intent", "[OPERATOR] Evaluate an intent against the Values
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Policy evaluation failed: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Policy evaluation failed", e) }], isError: true };
     }
 });
 // ═══════════════════════════════════════
@@ -1688,7 +1716,7 @@ server.tool("create_agent_context", "Create an enforcement context that automati
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Failed to create context: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Failed to create context", e) }], isError: true };
     }
 });
 server.tool("execute_with_context", "Execute an action through the enforcement context. Automatically runs the 3-signature chain: creates intent (sig 1), evaluates against floor + delegation (sig 2), returns verdict. Action is DENIED if outside delegated scope.", {
@@ -1729,7 +1757,7 @@ server.tool("execute_with_context", "Execute an action through the enforcement c
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Execute failed: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Execute failed", e) }], isError: true };
     }
 });
 server.tool("complete_action", "Complete a permitted action and get the full 3-signature proof chain (intent + decision + receipt + policy receipt). Call this after successfully executing the action.", {
@@ -1771,7 +1799,7 @@ server.tool("complete_action", "Complete a permitted action and get the full 3-s
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Complete failed: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Complete failed", e) }], isError: true };
     }
 });
 // ═══════════════════════════════════════
@@ -2070,7 +2098,7 @@ server.tool("review_promotion", "Create a signed promotion review for another ag
         };
     }
     catch (err) {
-        return { content: [{ type: "text", text: `Promotion review failed: ${err.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Promotion review failed", err) }], isError: true };
     }
 });
 server.tool("update_reputation", "Update an agent's reputation after a task result. Success increases mu and decreases sigma; failure does the opposite. Higher evidence class = larger effect.", {
@@ -2410,7 +2438,7 @@ server.tool("publish_intent_card", "Publish an IntentCard to the Intent Network
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `API error: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("API error", e) }], isError: true };
     }
 });
 server.tool("search_matches", "Search the Intent Network for people relevant to you. Returns ranked matches from all agents worldwide based on need/offer overlap, tag similarity, and budget compatibility.", {
@@ -2455,7 +2483,7 @@ server.tool("search_matches", "Search the Intent Network for people relevant to
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `API error: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("API error", e) }], isError: true };
     }
 });
 server.tool("get_digest", "Get a personalized digest from the Intent Network: relevant matches, pending intro requests, and incoming intros. The killer feature — 'what matters to me right now?'", {}, async () => {
@@ -2494,7 +2522,7 @@ server.tool("get_digest", "Get a personalized digest from the Intent Network: re
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `API error: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("API error", e) }], isError: true };
     }
 });
 server.tool("request_intro", "Request an introduction to another agent's human based on a match. Both sides must approve before real information crosses.", {
@@ -2535,7 +2563,7 @@ server.tool("request_intro", "Request an introduction to another agent's human b
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Intro request failed: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Intro request failed", e) }], isError: true };
     }
 });
 server.tool("respond_to_intro", "Respond to an introduction request. Approve to share your disclosed information, or decline.", {
@@ -2577,7 +2605,7 @@ server.tool("respond_to_intro", "Respond to an introduction request. Approve to
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `Intro response failed: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("Intro response failed", e) }], isError: true };
     }
 });
 server.tool("remove_intent_card", "Remove your IntentCard from the Intent Network. Use when your needs or offers have changed.", {
@@ -2607,7 +2635,7 @@ server.tool("remove_intent_card", "Remove your IntentCard from the Intent Networ
         };
     }
     catch (e) {
-        return { content: [{ type: "text", text: `API error: ${e.message}` }], isError: true };
+        return { content: [{ type: "text", text: safeError("API error", e) }], isError: true };
     }
 });
 // ═══════════════════════════════════════

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-passport-system-mcp",
-  "version": "2.8.0",
+  "version": "2.8.2",
   "mcpName": "io.github.aeoess/agent-passport-mcp",
   "description": "MCP server for Agent Passport System — cryptographic identity, delegation, governance, and deliberation for AI agents",
   "type": "module",
@@ -46,8 +46,8 @@
   },
   "homepage": "https://github.com/aeoess/agent-passport-mcp",
   "dependencies": {
-    "@modelcontextprotocol/sdk": "^1.12.0",
-    "agent-passport-system": "file:../agent-passport-system/agent-passport-system-1.13.0.tgz",
+    "@modelcontextprotocol/sdk": "1.27.1",
+    "agent-passport-system": "^1.13.0",
     "zod": "^3.25.0"
   },
   "devDependencies": {