agent-notify 0.2.6 → 0.3.0

package/lib/download.js

@@ -9,7 +9,9 @@ function downloadToFile(url, destinationPath, client = https) {
   return new Promise((resolve, reject) => {
     const file = fs.createWriteStream(destinationPath);
 
-    const request = client.get(url, (response) => {
+    const request = client.get(url, {
+      timeout: 300000, // 300 seconds
+    }, (response) => {
       if (response.statusCode >= 300 && response.statusCode < 400 && response.headers.location) {
         const redirectUrl = new URL(response.headers.location, url).toString();
         file.close(() => {
@@ -38,6 +40,15 @@ function downloadToFile(url, destinationPath, client = https) {
         removeFileIfExists(destinationPath, () => reject(err));
       });
     });
+
+    request.on('timeout', () => {
+      request.destroy();
+      file.close(() => {
+        removeFileIfExists(destinationPath, () => {
+          reject(new Error(`download timeout after 300s: ${url}`));
+        });
+      });
+    });
   });
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-notify",
-  "version": "0.2.6",
+  "version": "0.3.0",
   "description": "NPX launcher for the agent-notify binary",
   "bin": {
     "agent-notify": "./bin/agent-notify.js"

package/test/install.test.js

@@ -76,7 +76,7 @@ test('follows relative redirects when downloading', async (t) => {
   const destinationPath = path.join(root, 'archive.tar.gz');
 
   const client = {
-    get(url, handler) {
+    get(url, options, handler) {
       const request = new PassThrough();
       process.nextTick(() => {
         if (url === 'https://example.com/releases/archive.tar.gz') {
@@ -109,7 +109,7 @@ test('removes destination file when download fails with non-200 response', async
   const destinationPath = path.join(root, 'archive.tar.gz');
 
   const client = {
-    get(_url, handler) {
+    get(_url, _options, handler) {
       const request = new PassThrough();
       process.nextTick(() => {
         const response = new PassThrough();
@@ -128,3 +128,25 @@ test('removes destination file when download fails with non-200 response', async
   );
   assert.equal(fs.existsSync(destinationPath), false);
 });
+
+test('rejects with timeout error when download takes too long', async (t) => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), 'agent-notify-download-'));
+  t.after(() => fs.rmSync(root, { recursive: true, force: true }));
+  const destinationPath = path.join(root, 'archive.tar.gz');
+
+  const client = {
+    get(_url, _options, handler) {
+      const request = new PassThrough();
+      process.nextTick(() => {
+        request.emit('timeout');
+      });
+      return request;
+    },
+  };
+
+  await assert.rejects(
+    downloadToFile('https://example.com/releases/archive.tar.gz', destinationPath, client),
+    /download timeout after 300s/,
+  );
+  assert.equal(fs.existsSync(destinationPath), false);
+});