agent-messenger 2.34.0 → 2.35.0

package/src/platforms/kakaotalk/protocol/login-response.test.ts

@@ -0,0 +1,64 @@
+import { describe, expect, it } from 'bun:test'
+
+import { validateLoginListResponse } from './login-response'
+import type { LocoPacket } from './types'
+
+function packet(statusCode: number, body: Record<string, unknown>): LocoPacket {
+  return { packetId: 1, statusCode, method: 'LOGINLIST', bodyType: 0, body }
+}
+
+function captureError(fn: () => unknown): unknown {
+  try {
+    fn()
+    return undefined
+  } catch (error) {
+    return error
+  }
+}
+
+describe('LOGINLIST response classification', () => {
+  it('accepts status=0 and returns the login snapshot', () => {
+    const body = { status: 0, chatDatas: [], eof: true }
+
+    expect(validateLoginListResponse(packet(0, body))).toBe(body)
+  })
+
+  it('accepts a successful response when body.status is omitted', () => {
+    const body = { chatDatas: [], eof: true }
+
+    expect(validateLoginListResponse(packet(0, body))).toBe(body)
+  })
+
+  it('classifies body.status=-950 as invalid_access_token', () => {
+    expect(() => validateLoginListResponse(packet(0, { status: -950 }))).toThrow(
+      expect.objectContaining({ code: 'invalid_access_token', serverStatus: -950 }),
+    )
+  })
+
+  it('classifies packet statusCode=-950 as invalid_access_token', () => {
+    expect(() => validateLoginListResponse(packet(-950, {}))).toThrow(
+      expect.objectContaining({ code: 'invalid_access_token', serverStatus: -950 }),
+    )
+  })
+
+  it('classifies an unknown non-zero body status as login_rejected', () => {
+    expect(() => validateLoginListResponse(packet(0, { status: -777 }))).toThrow(
+      expect.objectContaining({ code: 'login_rejected', serverStatus: -777 }),
+    )
+  })
+
+  it('classifies an unknown non-zero packet status as login_rejected', () => {
+    expect(() => validateLoginListResponse(packet(-777, {}))).toThrow(
+      expect.objectContaining({ code: 'login_rejected', serverStatus: -777 }),
+    )
+  })
+
+  it('keeps a synthetic socket close on the transport-error path', () => {
+    const error = captureError(() => validateLoginListResponse(packet(-1, { error: 'connection closed' })))
+
+    expect(error).toBeInstanceOf(Error)
+    expect(error).toMatchObject({ message: 'KakaoTalk LOGINLIST transport failed: connection closed' })
+    expect(error).not.toHaveProperty('code')
+    expect(error).not.toHaveProperty('serverStatus')
+  })
+})

package/src/platforms/kakaotalk/protocol/login-response.ts

@@ -0,0 +1,40 @@
+import type { KakaoAuthErrorCode } from '../types'
+import type { LoginListResponse, LocoPacket } from './types'
+
+const CONNECTION_CLOSED_STATUS = -1
+const INVALID_ACCESS_TOKEN_STATUS = -950
+
+export class KakaoLoginResponseError extends Error {
+  readonly code: KakaoAuthErrorCode
+  readonly serverStatus: number
+
+  constructor(code: KakaoAuthErrorCode, serverStatus: number) {
+    const reason = code === 'invalid_access_token' ? 'invalid access token' : 'rejected'
+    super(`KakaoTalk LOGINLIST ${reason} (status ${serverStatus})`)
+    this.name = 'KakaoLoginResponseError'
+    this.code = code
+    this.serverStatus = serverStatus
+  }
+}
+
+function isSyntheticConnectionClose(response: LocoPacket): boolean {
+  return response.statusCode === CONNECTION_CLOSED_STATUS && response.body.error === 'connection closed'
+}
+
+function throwAuthenticationError(serverStatus: number): never {
+  const code: KakaoAuthErrorCode =
+    serverStatus === INVALID_ACCESS_TOKEN_STATUS ? 'invalid_access_token' : 'login_rejected'
+  throw new KakaoLoginResponseError(code, serverStatus)
+}
+
+export function validateLoginListResponse(response: LocoPacket): LoginListResponse {
+  if (isSyntheticConnectionClose(response)) {
+    throw new Error('KakaoTalk LOGINLIST transport failed: connection closed')
+  }
+
+  const bodyStatus = typeof response.body.status === 'number' ? response.body.status : 0
+  if (bodyStatus !== 0) throwAuthenticationError(bodyStatus)
+  if (response.statusCode !== 0) throwAuthenticationError(response.statusCode)
+
+  return response.body as unknown as LoginListResponse
+}

package/src/platforms/kakaotalk/protocol/session.ts

@@ -15,6 +15,7 @@ import {
   getLocoDeviceConfig,
 } from './config'
 import { LocoConnection } from './connection'
+import { validateLoginListResponse } from './login-response'
 import type { BookingResponse, CheckinResponse, LoginListResponse, LocoPacket, SyncState } from './types'
 
 // LOCO opcode string emitted on the wire for typing indicator pulses.
@@ -81,27 +82,34 @@ export class LocoSession {
     const lastTokenId = syncState ? new Long(syncState.lastTokenId.low, syncState.lastTokenId.high) : Long.fromNumber(0)
     const lbk = syncState?.lbk ?? 0
 
-    const response = await this.connection.sendPacket('LOGINLIST', {
-      appVer: deviceConfig.appVersion,
-      prtVer: PROTOCOL_VERSION,
-      os: deviceConfig.os,
-      lang: LANG,
-      dtype: DTYPE,
-      duuid: deviceUuid,
-      oauthToken,
-      ntype: 0,
-      MCCMNC: MCCMNC,
-      revision: syncState?.revision ?? 0,
-      chatIds,
-      maxIds,
-      lastTokenId,
-      lbk,
-      rp: new Binary(Buffer.from([0x00, 0x00, 0xff, 0xff, 0x00, 0x00])),
-      bg: false,
-    })
-
-    this.startPing()
-    return response.body as unknown as LoginListResponse
+    try {
+      const response = await this.connection.sendPacket('LOGINLIST', {
+        appVer: deviceConfig.appVersion,
+        prtVer: PROTOCOL_VERSION,
+        os: deviceConfig.os,
+        lang: LANG,
+        dtype: DTYPE,
+        duuid: deviceUuid,
+        oauthToken,
+        ntype: 0,
+        MCCMNC: MCCMNC,
+        revision: syncState?.revision ?? 0,
+        chatIds,
+        maxIds,
+        lastTokenId,
+        lbk,
+        rp: new Binary(Buffer.from([0x00, 0x00, 0xff, 0xff, 0x00, 0x00])),
+        bg: false,
+      })
+
+      const loginResult = validateLoginListResponse(response)
+      this.startPing()
+      return loginResult
+    } catch (error) {
+      this.connection.close()
+      this.connection = null
+      throw error
+    }
   }
 
   private async bookAndCheckin(

package/src/platforms/kakaotalk/protocol/types.ts

@@ -36,6 +36,7 @@ export interface SyncState {
 
 // LOGINLIST uses short BSON field names: c=chatId, t=type, a=activeMembers, etc.
 export interface LoginListResponse extends ChatListResponse {
+  status?: number
   userId: number
   revision: number
 }

package/src/platforms/kakaotalk/types.ts

@@ -12,6 +12,7 @@ export interface ExtractedKakaoToken {
 }
 
 export type KakaoAuthMethod = 'login' | 'extract'
+export type KakaoAuthErrorCode = 'invalid_access_token' | 'login_rejected'
 
 export interface KakaoAccountCredentials {
   account_id: string