agent-messenger 2.20.4 → 2.21.0

package/src/platforms/webexbot/wdm-discovery.test.ts

@@ -0,0 +1,97 @@
+import { afterEach, describe, expect, it, mock } from 'bun:test'
+
+import { createWdmRewriteFetch, discoverWdmDevicesUrl } from './wdm-discovery'
+
+const realFetch = globalThis.fetch
+
+afterEach(() => {
+  globalThis.fetch = realFetch
+})
+
+function jsonResponse(body: unknown, ok = true, status = 200): Response {
+  return { ok, status, json: () => Promise.resolve(body) } as unknown as Response
+}
+
+describe('discoverWdmDevicesUrl', () => {
+  it('returns the U2C wdm serviceLink with /devices appended', async () => {
+    globalThis.fetch = mock(() =>
+      Promise.resolve(jsonResponse({ serviceLinks: { wdm: 'https://wdm-r.wbx2.com/wdm/api/v1' } })),
+    )
+
+    const url = await discoverWdmDevicesUrl('token123')
+
+    expect(url).toBe('https://wdm-r.wbx2.com/wdm/api/v1/devices')
+  })
+
+  it('strips a trailing slash before appending /devices', async () => {
+    globalThis.fetch = mock(() =>
+      Promise.resolve(jsonResponse({ serviceLinks: { wdm: 'https://wdm-r.wbx2.com/wdm/api/v1/' } })),
+    )
+
+    const url = await discoverWdmDevicesUrl('token123')
+
+    expect(url).toBe('https://wdm-r.wbx2.com/wdm/api/v1/devices')
+  })
+
+  it('throws when the catalog request fails', async () => {
+    globalThis.fetch = mock(() => Promise.resolve(jsonResponse({}, false, 401)))
+
+    await expect(discoverWdmDevicesUrl('bad')).rejects.toThrow('Failed to discover Webex WDM cluster')
+  })
+
+  it('throws when the catalog lacks serviceLinks.wdm', async () => {
+    globalThis.fetch = mock(() => Promise.resolve(jsonResponse({ serviceLinks: {} })))
+
+    await expect(discoverWdmDevicesUrl('token123')).rejects.toThrow('did not include serviceLinks.wdm')
+  })
+})
+
+describe('createWdmRewriteFetch', () => {
+  it('rewrites the hardcoded WDM device-registration URL to the discovered cluster', async () => {
+    const seen: string[] = []
+    globalThis.fetch = mock((url: string) => {
+      seen.push(url)
+      return Promise.resolve(jsonResponse({ ok: true }))
+    })
+
+    const fetchFn = createWdmRewriteFetch('https://wdm-r.wbx2.com/wdm/api/v1/devices')
+    await fetchFn({
+      url: 'https://wdm-a.wbx2.com/wdm/api/v1/devices',
+      method: 'POST',
+      headers: { Authorization: 'Bearer x' },
+      body: '{}',
+    })
+
+    expect(seen[0]).toBe('https://wdm-r.wbx2.com/wdm/api/v1/devices')
+  })
+
+  it('rewrites WDM device sub-paths too', async () => {
+    const seen: string[] = []
+    globalThis.fetch = mock((url: string) => {
+      seen.push(url)
+      return Promise.resolve(jsonResponse({}))
+    })
+
+    const fetchFn = createWdmRewriteFetch('https://wdm-r.wbx2.com/wdm/api/v1/devices')
+    await fetchFn({
+      url: 'https://wdm-a.wbx2.com/wdm/api/v1/devices/abc-123',
+      method: 'DELETE',
+      headers: {},
+    })
+
+    expect(seen[0]).toBe('https://wdm-r.wbx2.com/wdm/api/v1/devices/abc-123')
+  })
+
+  it('leaves non-WDM URLs untouched', async () => {
+    const seen: string[] = []
+    globalThis.fetch = mock((url: string) => {
+      seen.push(url)
+      return Promise.resolve(jsonResponse({}))
+    })
+
+    const fetchFn = createWdmRewriteFetch('https://wdm-r.wbx2.com/wdm/api/v1/devices')
+    await fetchFn({ url: 'https://webexapis.com/v1/people/me', method: 'GET', headers: {} })
+
+    expect(seen[0]).toBe('https://webexapis.com/v1/people/me')
+  })
+})

package/src/platforms/webexbot/wdm-discovery.ts

@@ -0,0 +1,43 @@
+import type { FetchFunction, FetchRequest, FetchResponse } from 'webex-message-handler'
+
+import { WebexBotError } from './types'
+
+const U2C_CATALOG_URL = 'https://u2c.wbx2.com/u2c/api/v1/catalog?format=hostmap'
+const HARDCODED_WDM_DEVICES_URL = 'https://wdm-a.wbx2.com/wdm/api/v1/devices'
+
+// webex-message-handler hardcodes the WDM cluster to wdm-a. A bot whose org lives
+// on another cluster (e.g. wdm-r) registers its device on the wrong cluster, so
+// Webex never routes conversation activities to its Mercury socket — the socket
+// connects but no messages arrive. The U2C catalog returns the correct WDM cluster
+// for the token; rewriting the device-registration request to it makes the bot
+// receive real-time events.
+export async function discoverWdmDevicesUrl(token: string): Promise<string> {
+  const response = await fetch(U2C_CATALOG_URL, { headers: { Authorization: `Bearer ${token}` } })
+  if (!response.ok) {
+    throw new WebexBotError(`Failed to discover Webex WDM cluster: HTTP ${response.status}`, 'wdm_discovery_failed')
+  }
+
+  const catalog = (await response.json()) as { serviceLinks?: { wdm?: string } }
+  const wdm = catalog.serviceLinks?.wdm
+  if (!wdm) {
+    throw new WebexBotError('Webex U2C catalog did not include serviceLinks.wdm', 'wdm_discovery_failed')
+  }
+
+  return `${wdm.replace(/\/$/, '')}/devices`
+}
+
+export function createWdmRewriteFetch(wdmDevicesUrl: string): FetchFunction {
+  return async (req: FetchRequest): Promise<FetchResponse> => {
+    const url = req.url.startsWith(HARDCODED_WDM_DEVICES_URL)
+      ? wdmDevicesUrl + req.url.slice(HARDCODED_WDM_DEVICES_URL.length)
+      : req.url
+
+    const res = await fetch(url, { method: req.method, headers: req.headers, body: req.body })
+    return {
+      status: res.status,
+      ok: res.ok,
+      json: () => res.json(),
+      text: () => res.text(),
+    }
+  }
+}