agent-messenger 2.17.0 → 2.19.0

package/src/platforms/whatsapp/commands/auth.ts

@@ -3,6 +3,7 @@ import { rm } from 'node:fs/promises'
 import { Command } from 'commander'
 
 import { handleError } from '@/shared/utils/error-handler'
+import { isInteractive } from '@/shared/utils/interactive'
 import { formatOutput } from '@/shared/utils/output'
 import { displayQR } from '@/shared/utils/qr'
 import { info } from '@/shared/utils/stderr'
@@ -22,10 +23,6 @@ interface StatusOptions {
   pretty?: boolean
 }
 
-function isInteractiveSession(): boolean {
-  return Boolean(process.stdin.isTTY && process.stdout.isTTY)
-}
-
 async function loginWithPairingCode(options: LoginOptions & { phone: string }): Promise<void> {
   const manager = new WhatsAppCredentialManager()
   const accountId = createAccountId(options.phone)
@@ -95,7 +92,7 @@ async function loginWithQR(options: LoginOptions): Promise<void> {
   await rm(existingPaths.auth_dir, { recursive: true, force: true })
   const paths = await manager.ensureAccountPaths(accountId)
   const client = await new WhatsAppClient().login({ authDir: paths.auth_dir })
-  const interactive = isInteractiveSession()
+  const interactive = isInteractive()
 
   let waitForAuth: () => Promise<void>
   let browserOpened = false

package/src/shared/chromium/browsers.ts

@@ -75,7 +75,7 @@ export function discoverBrowserProfileDirs(browserBase: string): string[] {
   dirs.push(join(browserBase, 'Default'))
   if (!existsSync(browserBase)) return dirs
   try {
-    const entries = readdirSync(browserBase, { withFileTypes: true })
+    const entries = readdirSync(browserBase, { withFileTypes: true }).sort((a, b) => a.name.localeCompare(b.name))
     for (const entry of entries) {
       if (!entry.isDirectory()) continue
       if (!/^Profile \d+$/i.test(entry.name)) continue

package/src/shared/utils/interactive.test.ts

@@ -0,0 +1,55 @@
+import { afterEach, beforeEach, describe, expect, it } from 'bun:test'
+
+import { hasTTY, isInteractive } from './interactive'
+
+describe('isInteractive', () => {
+  let originalStdinTTY: boolean | undefined
+  let originalStdoutTTY: boolean | undefined
+
+  beforeEach(() => {
+    originalStdinTTY = process.stdin.isTTY
+    originalStdoutTTY = process.stdout.isTTY
+  })
+
+  afterEach(() => {
+    Object.defineProperty(process.stdin, 'isTTY', { value: originalStdinTTY, writable: true, configurable: true })
+    Object.defineProperty(process.stdout, 'isTTY', { value: originalStdoutTTY, writable: true, configurable: true })
+  })
+
+  function setTTY(stdin: boolean | undefined, stdout: boolean | undefined): void {
+    Object.defineProperty(process.stdin, 'isTTY', { value: stdin, writable: true, configurable: true })
+    Object.defineProperty(process.stdout, 'isTTY', { value: stdout, writable: true, configurable: true })
+  }
+
+  it('returns true when both stdin and stdout are TTY', () => {
+    setTTY(true, true)
+    expect(isInteractive()).toBe(true)
+  })
+
+  it('returns false when stdin is not a TTY (piped input)', () => {
+    setTTY(undefined, true)
+    expect(isInteractive()).toBe(false)
+  })
+
+  it('returns false when stdout is not a TTY (piped output)', () => {
+    setTTY(true, undefined)
+    expect(isInteractive()).toBe(false)
+  })
+
+  it('returns false when neither is a TTY', () => {
+    setTTY(undefined, undefined)
+    expect(isInteractive()).toBe(false)
+  })
+
+  it('returns false when stdin/stdout isTTY is explicitly false', () => {
+    setTTY(false, false)
+    expect(isInteractive()).toBe(false)
+  })
+})
+
+describe('hasTTY', () => {
+  it('returns a boolean reflecting whether a controlling TTY can be opened', () => {
+    const result = hasTTY()
+    expect(typeof result).toBe('boolean')
+  })
+})

package/src/shared/utils/interactive.ts

@@ -0,0 +1,15 @@
+export function isInteractive(): boolean {
+  return Boolean(process.stdin.isTTY && process.stdout.isTTY)
+}
+
+export function hasTTY(): boolean {
+  try {
+    const { openSync, closeSync } = require('node:fs') as typeof import('node:fs')
+    const ttyDevice = process.platform === 'win32' ? 'CONIN$' : '/dev/tty'
+    const fd = openSync(ttyDevice, 'r')
+    closeSync(fd)
+    return true
+  } catch {
+    return false
+  }
+}

package/src/test-setup.ts

@@ -0,0 +1,5 @@
+import { afterEach, mock } from 'bun:test'
+
+afterEach(() => {
+  mock.restore()
+})

package/tsconfig.json

@@ -38,5 +38,5 @@
     "noFallthroughCasesInSwitch": true
   },
   "include": ["src/**/*", "tests/**/*"],
-  "exclude": ["node_modules", "dist", "**/*.test.ts", "**/*-test.ts"]
+  "exclude": ["node_modules", "dist", "**/*.test.ts", "**/*-test.ts", "src/test-setup.ts"]
 }