agent-messenger 2.10.1 → 2.11.0

package/src/platforms/discordbot/commands/auth.ts

@@ -1,5 +1,6 @@
 import { Command } from 'commander'
 
+import { cliOutput } from '@/shared/utils/cli-output'
 import { formatOutput } from '@/shared/utils/output'
 
 import { DiscordBotClient } from '../client'
@@ -163,11 +164,6 @@ export async function removeAction(botId: string, options: ActionOptions): Promi
   }
 }
 
-function cliOutput(result: ActionResult, pretty?: boolean, exitOnError = true): void {
-  console.log(formatOutput(result, pretty))
-  if (result.error && exitOnError) process.exit(1)
-}
-
 export const authCommand = new Command('auth')
   .description('Bot authentication commands')
   .addCommand(

package/src/platforms/discordbot/commands/channel.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test'
+import { afterEach, beforeEach, describe, expect, mock, it } from 'bun:test'
 import { existsSync, rmSync } from 'node:fs'
 import { mkdir } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
@@ -66,7 +66,7 @@ describe('channel commands', () => {
   })
 
   describe('listAction', () => {
-    test('lists text channels from current server', async () => {
+    it('lists text channels from current server', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -90,7 +90,7 @@ describe('channel commands', () => {
       })
     })
 
-    test('filters out non-text channels', async () => {
+    it('filters out non-text channels', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -105,7 +105,7 @@ describe('channel commands', () => {
       expect(hasVoiceChannel).toBe(false)
     })
 
-    test('returns error when no server set', async () => {
+    it('returns error when no server set', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -119,7 +119,7 @@ describe('channel commands', () => {
       expect(result.error).toContain('No server set')
     })
 
-    test('handles client errors', async () => {
+    it('handles client errors', async () => {
       mockListChannels.mockImplementationOnce(() => Promise.reject(new Error('API Error')))
 
       const manager = new DiscordBotCredentialManager(tempDir)
@@ -138,7 +138,7 @@ describe('channel commands', () => {
   })
 
   describe('infoAction', () => {
-    test('returns channel info by ID', async () => {
+    it('returns channel info by ID', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -156,7 +156,7 @@ describe('channel commands', () => {
       expect(result.guild_id).toBe('guild1')
     })
 
-    test('resolves channel by name', async () => {
+    it('resolves channel by name', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -171,7 +171,7 @@ describe('channel commands', () => {
       expect(result.name).toBe('general')
     })
 
-    test('resolves channel by name with hash prefix', async () => {
+    it('resolves channel by name with hash prefix', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -186,7 +186,7 @@ describe('channel commands', () => {
       expect(result.name).toBe('announcements')
     })
 
-    test('returns error for nonexistent channel', async () => {
+    it('returns error for nonexistent channel', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -201,7 +201,7 @@ describe('channel commands', () => {
       expect(result.error).toContain('Channel not found')
     })
 
-    test('returns error when no server set', async () => {
+    it('returns error when no server set', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -215,7 +215,7 @@ describe('channel commands', () => {
       expect(result.error).toContain('No server set')
     })
 
-    test('handles client errors', async () => {
+    it('handles client errors', async () => {
       mockGetChannel.mockImplementationOnce(() => Promise.reject(new Error('Channel not found')))
 
       const manager = new DiscordBotCredentialManager(tempDir)

package/src/platforms/discordbot/commands/file.test.ts

@@ -71,7 +71,7 @@ describe('file commands', () => {
   })
 
   describe('uploadAction', () => {
-    it('should upload file successfully', async () => {
+    it('uploads file successfully', async () => {
       const result = await uploadAction('general', './test.txt', {
         ...options,
         _credManager: mockCredManager,
@@ -80,12 +80,12 @@ describe('file commands', () => {
       expect(result).toBeDefined()
     })
 
-    it('should return error when channel resolution fails', async () => {
+    it('returns error when channel resolution fails', async () => {
       const result = await uploadAction('nonexistent', './test.txt', options)
       expect(result.error).toBeDefined()
     })
 
-    it('should return error when file does not exist', async () => {
+    it('returns error when file does not exist', async () => {
       const result = await uploadAction('general', '/nonexistent/file.txt', {
         ...options,
         _credManager: mockCredManager,
@@ -95,7 +95,7 @@ describe('file commands', () => {
   })
 
   describe('listAction', () => {
-    it('should list files successfully', async () => {
+    it('lists files successfully', async () => {
       const result = await listAction('general', {
         ...options,
         _credManager: mockCredManager,
@@ -104,14 +104,14 @@ describe('file commands', () => {
       expect(result).toBeDefined()
     })
 
-    it('should return error when channel resolution fails', async () => {
+    it('returns error when channel resolution fails', async () => {
       const result = await listAction('nonexistent', options)
       expect(result.error).toBeDefined()
     })
   })
 
   describe('action result structure', () => {
-    it('uploadAction should return success result with file info', async () => {
+    it('returns success result with file info for uploadAction', async () => {
       const result = await uploadAction('general', './test.txt', {
         ...options,
         _credManager: mockCredManager,
@@ -129,7 +129,7 @@ describe('file commands', () => {
       }
     })
 
-    it('listAction should return success result with files array', async () => {
+    it('returns success result with files array for listAction', async () => {
       const result = await listAction('general', {
         ...options,
         _credManager: mockCredManager,

package/src/platforms/discordbot/commands/message.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test'
+import { afterEach, beforeEach, describe, expect, mock, it } from 'bun:test'
 import { existsSync, rmSync } from 'node:fs'
 import { mkdir } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
@@ -120,7 +120,7 @@ describe('message commands', () => {
   })
 
   describe('sendAction', () => {
-    test('sends message to channel by name', async () => {
+    it('sends message to channel by name', async () => {
       const result = await sendAction('general', 'hello world', { _credManager: manager })
 
       expect(result.id).toBe('msg1')
@@ -130,7 +130,7 @@ describe('message commands', () => {
       expect(mockSendMessage).toHaveBeenCalledWith('ch1', 'hello world', { thread_id: undefined })
     })
 
-    test('sends message to channel by ID', async () => {
+    it('sends message to channel by ID', async () => {
       const result = await sendAction('123456', 'hi', { _credManager: manager })
 
       expect(result.id).toBe('msg1')
@@ -138,7 +138,7 @@ describe('message commands', () => {
       expect(mockSendMessage).toHaveBeenCalledWith('123456', 'hi', { thread_id: undefined })
     })
 
-    test('sends message to thread', async () => {
+    it('sends message to thread', async () => {
       const result = await sendAction('general', 'thread reply', {
         _credManager: manager,
         thread: 'thread123',
@@ -148,13 +148,13 @@ describe('message commands', () => {
       expect(mockSendMessage).toHaveBeenCalledWith('ch1', 'thread reply', { thread_id: 'thread123' })
     })
 
-    test('returns error on channel not found', async () => {
+    it('returns error on channel not found', async () => {
       const result = await sendAction('unknown', 'hi', { _credManager: manager })
 
       expect(result.error).toContain('Channel not found')
     })
 
-    test('returns error on client failure', async () => {
+    it('returns error on client failure', async () => {
       mockSendMessage.mockImplementationOnce(() => Promise.reject(new Error('API Error')))
 
       const result = await sendAction('general', 'hi', { _credManager: manager })
@@ -164,7 +164,7 @@ describe('message commands', () => {
   })
 
   describe('listAction', () => {
-    test('lists messages in channel', async () => {
+    it('lists messages in channel', async () => {
       const result = await listAction('general', { _credManager: manager })
 
       expect(result.messages).toHaveLength(2)
@@ -174,25 +174,25 @@ describe('message commands', () => {
       expect(mockGetMessages).toHaveBeenCalledWith('ch1', 50)
     })
 
-    test('uses custom limit', async () => {
+    it('uses custom limit', async () => {
       await listAction('general', { _credManager: manager, limit: '10' })
 
       expect(mockGetMessages).toHaveBeenCalledWith('ch1', 10)
     })
 
-    test('defaults to 50 messages', async () => {
+    it('defaults to 50 messages', async () => {
       await listAction('general', { _credManager: manager })
 
       expect(mockGetMessages).toHaveBeenCalledWith('ch1', 50)
     })
 
-    test('resolves channel name', async () => {
+    it('resolves channel name', async () => {
       await listAction('general', { _credManager: manager })
 
       expect(mockResolveChannel).toHaveBeenCalledWith('guild1', 'general')
     })
 
-    test('returns error on failure', async () => {
+    it('returns error on failure', async () => {
       mockGetMessages.mockImplementationOnce(() => Promise.reject(new Error('Forbidden')))
 
       const result = await listAction('general', { _credManager: manager })
@@ -202,7 +202,7 @@ describe('message commands', () => {
   })
 
   describe('getAction', () => {
-    test('gets a single message', async () => {
+    it('gets a single message', async () => {
       const result = await getAction('general', 'msg1', { _credManager: manager })
 
       expect(result.id).toBe('msg1')
@@ -211,13 +211,13 @@ describe('message commands', () => {
       expect(mockGetMessage).toHaveBeenCalledWith('ch1', 'msg1')
     })
 
-    test('resolves channel name', async () => {
+    it('resolves channel name', async () => {
       await getAction('general', 'msg1', { _credManager: manager })
 
       expect(mockResolveChannel).toHaveBeenCalledWith('guild1', 'general')
     })
 
-    test('returns error on failure', async () => {
+    it('returns error on failure', async () => {
       mockGetMessage.mockImplementationOnce(() => Promise.reject(new Error('Not Found')))
 
       const result = await getAction('general', 'msg999', { _credManager: manager })
@@ -227,7 +227,7 @@ describe('message commands', () => {
   })
 
   describe('updateAction', () => {
-    test('updates a message', async () => {
+    it('updates a message', async () => {
       const result = await updateAction('general', 'msg1', 'updated text', { _credManager: manager })
 
       expect(result.id).toBe('msg1')
@@ -236,13 +236,13 @@ describe('message commands', () => {
       expect(mockEditMessage).toHaveBeenCalledWith('ch1', 'msg1', 'updated text')
     })
 
-    test('resolves channel name', async () => {
+    it('resolves channel name', async () => {
       await updateAction('general', 'msg1', 'new', { _credManager: manager })
 
       expect(mockResolveChannel).toHaveBeenCalledWith('guild1', 'general')
     })
 
-    test('returns error on failure', async () => {
+    it('returns error on failure', async () => {
       mockEditMessage.mockImplementationOnce(() => Promise.reject(new Error('Cannot edit')))
 
       const result = await updateAction('general', 'msg1', 'new', { _credManager: manager })
@@ -252,34 +252,34 @@ describe('message commands', () => {
   })
 
   describe('deleteAction', () => {
-    test('deletes message with --force', async () => {
+    it('deletes message with --force', async () => {
       const result = await deleteAction('general', 'msg1', { _credManager: manager, force: true })
 
       expect(result.deleted).toBe('msg1')
       expect(mockDeleteMessage).toHaveBeenCalledWith('ch1', 'msg1')
     })
 
-    test('returns error without --force', async () => {
+    it('returns error without --force', async () => {
       const result = await deleteAction('general', 'msg1', { _credManager: manager })
 
       expect(result.error).toBe('Use --force to confirm deletion')
       expect(mockDeleteMessage).not.toHaveBeenCalled()
     })
 
-    test('returns error with force=false', async () => {
+    it('returns error with force=false', async () => {
       const result = await deleteAction('general', 'msg1', { _credManager: manager, force: false })
 
       expect(result.error).toBe('Use --force to confirm deletion')
       expect(mockDeleteMessage).not.toHaveBeenCalled()
     })
 
-    test('resolves channel name', async () => {
+    it('resolves channel name', async () => {
       await deleteAction('general', 'msg1', { _credManager: manager, force: true })
 
       expect(mockResolveChannel).toHaveBeenCalledWith('guild1', 'general')
     })
 
-    test('returns error on failure', async () => {
+    it('returns error on failure', async () => {
       mockDeleteMessage.mockImplementationOnce(() => Promise.reject(new Error('Forbidden')))
 
       const result = await deleteAction('general', 'msg1', { _credManager: manager, force: true })
@@ -289,20 +289,20 @@ describe('message commands', () => {
   })
 
   describe('repliesAction', () => {
-    test('fetches thread messages', async () => {
+    it('fetches thread messages', async () => {
       const result = await repliesAction('general', 'thread1', { _credManager: manager })
 
       expect(result.messages).toHaveLength(2)
       expect(mockGetMessages).toHaveBeenCalledWith('thread1', 50)
     })
 
-    test('uses custom limit', async () => {
+    it('uses custom limit', async () => {
       await repliesAction('general', 'thread1', { _credManager: manager, limit: '25' })
 
       expect(mockGetMessages).toHaveBeenCalledWith('thread1', 25)
     })
 
-    test('returns error on failure', async () => {
+    it('returns error on failure', async () => {
       mockGetMessages.mockImplementationOnce(() => Promise.reject(new Error('Thread not found')))
 
       const result = await repliesAction('general', 'thread999', { _credManager: manager })

package/src/platforms/discordbot/commands/message.ts

@@ -1,6 +1,6 @@
 import { Command } from 'commander'
 
-import { formatOutput } from '@/shared/utils/output'
+import { cliOutput } from '@/shared/utils/cli-output'
 
 import type { BotOption } from './shared'
 import { getClient, getCurrentServer } from './shared'
@@ -165,11 +165,6 @@ export async function repliesAction(
   }
 }
 
-function cliOutput(result: MessageResult, pretty?: boolean): void {
-  console.log(formatOutput(result, pretty))
-  if (result.error) process.exit(1)
-}
-
 export const messageCommand = new Command('message')
   .description('Message commands')
   .addCommand(

package/src/platforms/discordbot/commands/reaction.test.ts

@@ -19,7 +19,7 @@ describe('reaction commands', () => {
   })
 
   describe('addAction', () => {
-    it('should add reaction successfully', async () => {
+    it('adds reaction successfully', async () => {
       const result = await addAction('general', 'msg-456', '👍', {
         ...options,
         _credManager: mockCredManager,
@@ -28,14 +28,14 @@ describe('reaction commands', () => {
       expect(result).toBeDefined()
     })
 
-    it('should return error when channel resolution fails', async () => {
+    it('returns error when channel resolution fails', async () => {
       const result = await addAction('nonexistent', 'msg-456', '👍', options)
       expect(result.error).toBeDefined()
     })
   })
 
   describe('removeAction', () => {
-    it('should remove reaction successfully', async () => {
+    it('removes reaction successfully', async () => {
       const result = await removeAction('general', 'msg-456', '👍', {
         ...options,
         _credManager: mockCredManager,
@@ -44,14 +44,14 @@ describe('reaction commands', () => {
       expect(result).toBeDefined()
     })
 
-    it('should return error when channel resolution fails', async () => {
+    it('returns error when channel resolution fails', async () => {
       const result = await removeAction('nonexistent', 'msg-456', '👍', options)
       expect(result.error).toBeDefined()
     })
   })
 
   describe('action result structure', () => {
-    it('addAction should return success result with channel, messageId, emoji', async () => {
+    it('returns success result with channel, messageId, and emoji for addAction', async () => {
       const result = await addAction('general', 'msg-456', '👍', {
         ...options,
         _credManager: mockCredManager,
@@ -64,7 +64,7 @@ describe('reaction commands', () => {
       }
     })
 
-    it('removeAction should return success result with channel, messageId, emoji', async () => {
+    it('returns success result with channel, messageId, and emoji for removeAction', async () => {
       const result = await removeAction('general', 'msg-456', '👍', {
         ...options,
         _credManager: mockCredManager,

package/src/platforms/discordbot/commands/server.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test'
+import { afterEach, beforeEach, describe, expect, mock, it } from 'bun:test'
 import { existsSync, rmSync } from 'node:fs'
 import { mkdir } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
@@ -56,7 +56,7 @@ describe('server commands', () => {
   })
 
   describe('listAction', () => {
-    test('lists all servers from client', async () => {
+    it('lists all servers from client', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -79,7 +79,7 @@ describe('server commands', () => {
       })
     })
 
-    test('marks current server in list', async () => {
+    it('marks current server in list', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -94,7 +94,7 @@ describe('server commands', () => {
       expect(result.servers?.[1].current).toBe(false)
     })
 
-    test('handles client errors', async () => {
+    it('handles client errors', async () => {
       mockListGuilds.mockImplementationOnce(() => Promise.reject(new Error('API Error')))
 
       const manager = new DiscordBotCredentialManager(tempDir)
@@ -112,7 +112,7 @@ describe('server commands', () => {
   })
 
   describe('currentAction', () => {
-    test('returns current server info', async () => {
+    it('returns current server info', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -127,7 +127,7 @@ describe('server commands', () => {
       expect(result.name).toBe('Test Guild')
     })
 
-    test('returns error when no server set', async () => {
+    it('returns error when no server set', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -141,7 +141,7 @@ describe('server commands', () => {
       expect(result.error).toContain('No server set')
     })
 
-    test('handles client errors', async () => {
+    it('handles client errors', async () => {
       mockGetGuild.mockImplementationOnce(() => Promise.reject(new Error('Guild not found')))
 
       const manager = new DiscordBotCredentialManager(tempDir)
@@ -160,7 +160,7 @@ describe('server commands', () => {
   })
 
   describe('switchAction', () => {
-    test('switches to a new server', async () => {
+    it('switches to a new server', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -177,7 +177,7 @@ describe('server commands', () => {
       expect(currentServer).toBe('guild2')
     })
 
-    test('updates server name in credential manager', async () => {
+    it('updates server name in credential manager', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -194,7 +194,7 @@ describe('server commands', () => {
       })
     })
 
-    test('handles client errors', async () => {
+    it('handles client errors', async () => {
       mockGetGuild.mockImplementationOnce(() => Promise.reject(new Error('Unauthorized')))
 
       const manager = new DiscordBotCredentialManager(tempDir)
@@ -212,7 +212,7 @@ describe('server commands', () => {
   })
 
   describe('infoAction', () => {
-    test('returns server info', async () => {
+    it('returns server info', async () => {
       const manager = new DiscordBotCredentialManager(tempDir)
       await manager.setCredentials({
         token: 'token123',
@@ -228,7 +228,7 @@ describe('server commands', () => {
       expect(result.owner).toBe(true)
     })
 
-    test('handles client errors', async () => {
+    it('handles client errors', async () => {
       mockGetGuild.mockImplementationOnce(() => Promise.reject(new Error('Guild not found')))
 
       const manager = new DiscordBotCredentialManager(tempDir)

package/src/platforms/discordbot/commands/server.ts

@@ -1,6 +1,6 @@
 import { Command } from 'commander'
 
-import { formatOutput } from '@/shared/utils/output'
+import { cliOutput } from '@/shared/utils/cli-output'
 
 import { DiscordBotCredentialManager } from '../credential-manager'
 import type { BotOption } from './shared'
@@ -82,10 +82,6 @@ export async function infoAction(serverId: string, options: BotOption): Promise<
   }
 }
 
-const cliOutput = (result: ActionResult, pretty?: boolean) => {
-  console.log(formatOutput(result, pretty))
-}
-
 export const serverCommand = new Command('server')
   .description('Server commands')
   .addCommand(