agent-gear 1.0.3 → 1.1.0

package/tests/acp-spawner.test.ts

@@ -2,14 +2,25 @@ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { EventEmitter } from 'events';
 import { Writable, Readable } from 'node:stream';
 import type { ChildProcess } from 'child_process';
+import * as os from 'os';
+
+vi.mock('os', () => ({
+  platform: vi.fn(() => 'linux'),
+}));
 
 vi.mock('child_process', () => ({
   spawn: vi.fn(),
   execFileSync: vi.fn(() => '/usr/bin/opencode'),
 }));
 
+vi.mock('fs', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('fs')>();
+  return { ...actual, existsSync: vi.fn(() => false), mkdirSync: vi.fn() };
+});
+
 import { AcpSpawner } from '../../src/acp/spawner.js';
-import { spawn } from 'child_process';
+import { spawn, execFileSync } from 'child_process';
+import { existsSync } from 'fs';
 
 function createMockChildProcess(): ChildProcess & EventEmitter {
   const proc = new EventEmitter() as ChildProcess & EventEmitter;
@@ -146,4 +157,88 @@ describe('AcpSpawner', () => {
       await vi.waitFor(() => expect(resolved).toBe(true));
     });
   });
+
+  describe('Windows platform', () => {
+    beforeEach(() => {
+      vi.mocked(os.platform).mockReturnValue('win32');
+      vi.mocked(execFileSync).mockReset();
+      vi.mocked(existsSync).mockReset();
+      vi.mocked(spawn).mockClear();
+    });
+
+    afterEach(() => {
+      vi.mocked(os.platform).mockReturnValue('linux');
+    });
+
+    describe('resolveCommand', () => {
+      it('should use `where` instead of `which`', () => {
+        vi.mocked(execFileSync).mockReturnValue('C:\\npm\\copilot.cmd\r\n');
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot', args: ['--acp', '--stdio'] });
+        sp.start();
+        expect(execFileSync).toHaveBeenCalledWith('where', ['copilot'], { encoding: 'utf8', timeout: 1000 });
+      });
+
+      it('should return full path from `where`', () => {
+        vi.mocked(execFileSync).mockReturnValue('C:\\Users\\ash\\AppData\\Roaming\\npm\\copilot.cmd\r\n');
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot', args: ['--acp', '--stdio'] });
+        sp.start();
+        expect(spawn).toHaveBeenCalledWith(
+          'C:\\Users\\ash\\AppData\\Roaming\\npm\\copilot.cmd',
+          ['--acp', '--stdio'],
+          expect.objectContaining({ shell: true }),
+        );
+      });
+
+      it('should fall back to PATHEXT check when `where` fails', () => {
+        vi.mocked(execFileSync).mockImplementation(() => { throw new Error('not found'); });
+        vi.mocked(existsSync).mockImplementation((p: string) => p === 'copilot.cmd');
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot' });
+        sp.start();
+        expect(spawn).toHaveBeenCalledWith('copilot.cmd', expect.any(Array), expect.objectContaining({ shell: true }));
+      });
+
+      it('should return bare command as last resort', () => {
+        vi.mocked(execFileSync).mockImplementation(() => { throw new Error('not found'); });
+        vi.mocked(existsSync).mockReturnValue(false);
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot' });
+        sp.start();
+        expect(spawn).toHaveBeenCalledWith('copilot', expect.any(Array), expect.objectContaining({ shell: true }));
+      });
+    });
+
+    describe('start', () => {
+      it('should spawn with shell: true', () => {
+        vi.mocked(execFileSync).mockReturnValue('C:\\npm\\copilot.cmd\r\n');
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot' });
+        sp.start();
+        expect(spawn).toHaveBeenCalledWith(
+          expect.any(String),
+          expect.any(Array),
+          expect.objectContaining({ shell: true }),
+        );
+      });
+    });
+
+    describe('stop', () => {
+      it('should call kill() without signal on Windows', () => {
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot' });
+        vi.mocked(execFileSync).mockReturnValue('C:\\npm\\copilot.cmd\r\n');
+        sp.start();
+        sp.stop();
+        expect(mockProcess.kill).toHaveBeenCalledWith();
+        expect(mockProcess.kill).not.toHaveBeenCalledWith('SIGTERM');
+      });
+
+      it('should call kill() again after 5s on Windows', () => {
+        const sp = new AcpSpawner({ sessionId: 's', cwd: 'C:\\project', command: 'copilot' });
+        vi.mocked(execFileSync).mockReturnValue('C:\\npm\\copilot.cmd\r\n');
+        sp.start();
+        sp.stop();
+        expect(mockProcess.kill).toHaveBeenCalledTimes(1);
+        vi.advanceTimersByTime(5000);
+        expect(mockProcess.kill).toHaveBeenCalledTimes(2);
+        expect(mockProcess.kill).not.toHaveBeenCalledWith('SIGKILL');
+      });
+    });
+  });
 });

package/tests/socketio-client.test.ts

@@ -25,11 +25,25 @@ vi.mock('../src/config.js', () => ({
 
 vi.mock('os', () => ({
   hostname: vi.fn().mockReturnValue('test-machine'),
+  platform: vi.fn(() => 'linux'),
+  homedir: vi.fn(() => '/home/user'),
 }));
 
+vi.mock('fs/promises', () => ({
+  readdir: vi.fn(),
+  access: vi.fn(),
+}));
+
+vi.mock('path', async (importOriginal) => {
+  const actual = await importOriginal<typeof import('path')>();
+  return actual;
+});
+
 import { connectToServer, unregister } from '../src/socketio-client.js';
 import { io } from 'socket.io-client';
 import { clearConfigKey } from '../src/config.js';
+import * as os from 'os';
+import { readdir, access } from 'fs/promises';
 
 function createMockSocket() {
   const handlers: Record<string, (...args: unknown[]) => void> = {};
@@ -87,7 +101,7 @@ describe('SocketIO Client', () => {
       expect(mockSocket.emit).toHaveBeenCalledWith('register', {
         key: 'zag_k_1_abc123',
         hostname: 'my-machine',
-        version: '1.0.0',
+        version: '1.0.4',
       });
     });
 
@@ -102,7 +116,7 @@ describe('SocketIO Client', () => {
       expect(mockSocket.emit).toHaveBeenCalledWith('register', {
         key: 'zag_k_1_abc123',
         hostname: 'test-machine',
-        version: '1.0.0',
+        version: '1.0.4',
       });
     });
 
@@ -193,4 +207,108 @@ describe('SocketIO Client', () => {
       expect(mockSocket.emit).toHaveBeenCalledWith('unregister', { reason: 'user_detach' });
     });
   });
+
+  describe('fs:browse', () => {
+    it('should list drives on Windows when path is /', async () => {
+      vi.mocked(os.platform).mockReturnValue('win32');
+      vi.mocked(access).mockImplementation(async (p: string) => {
+        if (p === 'C:\\' || p === 'D:\\') return;
+        throw new Error('not found');
+      });
+
+      const mockSocket = createMockSocket();
+      vi.mocked(io).mockReturnValue(mockSocket as never);
+
+      connectToServer('http://localhost:4001', 'zag_k_1_abc123');
+      mockSocket._trigger('connect');
+      mockSocket._trigger('registered', { controllerId: 'ctrl-1' });
+
+      mockSocket._trigger('fs:browse', { requestId: 'req-1', path: '/' });
+      await vi.waitFor(() => {
+        expect(mockSocket.emit).toHaveBeenCalledWith('fs:browse:result', {
+          requestId: 'req-1',
+          entries: [
+            { name: 'C:', path: 'C:\\', isDirectory: true },
+            { name: 'D:', path: 'D:\\', isDirectory: true },
+          ],
+        });
+      });
+    });
+
+    it('should list drives on Windows when path is empty string', async () => {
+      vi.mocked(os.platform).mockReturnValue('win32');
+      vi.mocked(access).mockImplementation(async (p: string) => {
+        if (p === 'C:\\') return;
+        throw new Error('not found');
+      });
+
+      const mockSocket = createMockSocket();
+      vi.mocked(io).mockReturnValue(mockSocket as never);
+
+      connectToServer('http://localhost:4001', 'zag_k_1_abc123');
+      mockSocket._trigger('connect');
+      mockSocket._trigger('registered', { controllerId: 'ctrl-1' });
+
+      mockSocket._trigger('fs:browse', { requestId: 'req-2', path: '' });
+      await vi.waitFor(() => {
+        expect(mockSocket.emit).toHaveBeenCalledWith('fs:browse:result', {
+          requestId: 'req-2',
+          entries: [
+            { name: 'C:', path: 'C:\\', isDirectory: true },
+          ],
+        });
+      });
+    });
+
+    it('should NOT list drives on Linux when path is /', async () => {
+      vi.mocked(os.platform).mockReturnValue('linux');
+      vi.mocked(readdir).mockResolvedValue([
+        { name: 'home', isDirectory: () => true },
+        { name: 'usr', isDirectory: () => true },
+      ] as never);
+
+      const mockSocket = createMockSocket();
+      vi.mocked(io).mockReturnValue(mockSocket as never);
+
+      connectToServer('http://localhost:4001', 'zag_k_1_abc123');
+      mockSocket._trigger('connect');
+      mockSocket._trigger('registered', { controllerId: 'ctrl-1' });
+
+      mockSocket._trigger('fs:browse', { requestId: 'req-3', path: '/' });
+      await vi.waitFor(() => {
+        expect(mockSocket.emit).toHaveBeenCalledWith('fs:browse:result', {
+          requestId: 'req-3',
+          entries: [
+            { name: 'home', path: '/home', isDirectory: true },
+            { name: 'usr', path: '/usr', isDirectory: true },
+          ],
+        });
+      });
+    });
+
+    it('should skip unavailable drives on Windows', async () => {
+      vi.mocked(os.platform).mockReturnValue('win32');
+      vi.mocked(access).mockImplementation(async (p: string) => {
+        if (p === 'C:\\') return;
+        throw new Error('not found');
+      });
+
+      const mockSocket = createMockSocket();
+      vi.mocked(io).mockReturnValue(mockSocket as never);
+
+      connectToServer('http://localhost:4001', 'zag_k_1_abc123');
+      mockSocket._trigger('connect');
+      mockSocket._trigger('registered', { controllerId: 'ctrl-1' });
+
+      mockSocket._trigger('fs:browse', { requestId: 'req-4', path: '/' });
+      await vi.waitFor(() => {
+        expect(mockSocket.emit).toHaveBeenCalledWith('fs:browse:result', {
+          requestId: 'req-4',
+          entries: [
+            { name: 'C:', path: 'C:\\', isDirectory: true },
+          ],
+        });
+      });
+    });
+  });
 });