agent-gauntlet 0.1.10 → 0.1.12

package/src/commands/list.test.ts

@@ -1,31 +1,41 @@
-import { describe, it, expect, beforeEach, afterEach, beforeAll, afterAll } from 'bun:test';
-import { Command } from 'commander';
-import { registerListCommand } from './list.js';
-import fs from 'node:fs/promises';
-import path from 'node:path';
+import {
+	afterAll,
+	afterEach,
+	beforeAll,
+	beforeEach,
+	describe,
+	expect,
+	it,
+} from "bun:test";
+import fs from "node:fs/promises";
+import path from "node:path";
+import { Command } from "commander";
+import { registerListCommand } from "./list.js";
 
-const TEST_DIR = path.join(process.cwd(), 'test-list-' + Date.now());
-const GAUNTLET_DIR = path.join(TEST_DIR, '.gauntlet');
-const CHECKS_DIR = path.join(GAUNTLET_DIR, 'checks');
-const REVIEWS_DIR = path.join(GAUNTLET_DIR, 'reviews');
+const TEST_DIR = path.join(process.cwd(), `test-list-${Date.now()}`);
+const GAUNTLET_DIR = path.join(TEST_DIR, ".gauntlet");
+const CHECKS_DIR = path.join(GAUNTLET_DIR, "checks");
+const REVIEWS_DIR = path.join(GAUNTLET_DIR, "reviews");
 
-describe('List Command', () => {
-  let program: Command;
-  const originalConsoleLog = console.log;
-  const originalConsoleError = console.error;
-  const originalCwd = process.cwd();
-  let logs: string[];
-  let errors: string[];
+describe("List Command", () => {
+	let program: Command;
+	const originalConsoleLog = console.log;
+	const originalConsoleError = console.error;
+	const originalCwd = process.cwd();
+	let logs: string[];
+	let errors: string[];
 
-  beforeAll(async () => {
-    // Setup test directory structure
-    await fs.mkdir(TEST_DIR, { recursive: true });
-    await fs.mkdir(GAUNTLET_DIR, { recursive: true });
-    await fs.mkdir(CHECKS_DIR, { recursive: true });
-    await fs.mkdir(REVIEWS_DIR, { recursive: true });
+	beforeAll(async () => {
+		// Setup test directory structure
+		await fs.mkdir(TEST_DIR, { recursive: true });
+		await fs.mkdir(GAUNTLET_DIR, { recursive: true });
+		await fs.mkdir(CHECKS_DIR, { recursive: true });
+		await fs.mkdir(REVIEWS_DIR, { recursive: true });
 
-    // Write config.yml
-    await fs.writeFile(path.join(GAUNTLET_DIR, 'config.yml'), `
+		// Write config.yml
+		await fs.writeFile(
+			path.join(GAUNTLET_DIR, "config.yml"),
+			`
 base_branch: origin/main
 log_dir: .gauntlet_logs
 cli:
@@ -38,67 +48,74 @@ entry_points:
       - lint
     reviews:
       - security
-`);
+`,
+		);
 
-    // Write check definition
-    await fs.writeFile(path.join(CHECKS_DIR, 'lint.yml'), `
+		// Write check definition
+		await fs.writeFile(
+			path.join(CHECKS_DIR, "lint.yml"),
+			`
 name: lint
 command: npm run lint
 working_directory: .
-`);
+`,
+		);
 
-    // Write review definition
-    await fs.writeFile(path.join(REVIEWS_DIR, 'security.md'), `---
+		// Write review definition
+		await fs.writeFile(
+			path.join(REVIEWS_DIR, "security.md"),
+			`---
 cli_preference:
   - gemini
 ---
 
 # Security Review
 Review for security.
-`);
-  });
+`,
+		);
+	});
 
-  afterAll(async () => {
-    await fs.rm(TEST_DIR, { recursive: true, force: true });
-  });
+	afterAll(async () => {
+		await fs.rm(TEST_DIR, { recursive: true, force: true });
+	});
 
-  beforeEach(() => {
-    program = new Command();
-    registerListCommand(program);
-    logs = [];
-    errors = [];
-    console.log = (...args: any[]) => {
-      logs.push(args.join(' '));
-    };
-    console.error = (...args: any[]) => {
-      errors.push(args.join(' '));
-    };
-    process.chdir(TEST_DIR);
-  });
+	beforeEach(() => {
+		program = new Command();
+		registerListCommand(program);
+		logs = [];
+		errors = [];
+		console.log = (...args: unknown[]) => {
+			logs.push(args.join(" "));
+		};
+		console.error = (...args: unknown[]) => {
+			errors.push(args.join(" "));
+		};
+		process.chdir(TEST_DIR);
+	});
 
-  afterEach(() => {
-    console.log = originalConsoleLog;
-    console.error = originalConsoleError;
-    process.chdir(originalCwd);
-  });
+	afterEach(() => {
+		console.log = originalConsoleLog;
+		console.error = originalConsoleError;
+		process.chdir(originalCwd);
+	});
 
-  it('should register the list command', () => {
-    const listCmd = program.commands.find(cmd => cmd.name() === 'list');
-    expect(listCmd).toBeDefined();
-    expect(listCmd?.description()).toBe('List configured gates');
-  });
+	it("should register the list command", () => {
+		const listCmd = program.commands.find((cmd) => cmd.name() === "list");
+		expect(listCmd).toBeDefined();
+		expect(listCmd?.description()).toBe("List configured gates");
+	});
 
-  it('should list check gates, review gates, and entry points', async () => {
-    const listCmd = program.commands.find(cmd => cmd.name() === 'list');
-    await listCmd?.parseAsync(['list']);
+	it("should list check gates, review gates, and entry points", async () => {
+		const listCmd = program.commands.find((cmd) => cmd.name() === "list");
+		await listCmd?.parseAsync(["list"]);
 
-    const output = logs.join('\n');
-    expect(output).toContain('Check Gates:');
-    expect(output).toContain('lint');
-    expect(output).toContain('Review Gates:');
-    expect(output).toContain('security');
-    expect(output).toContain('gemini');
-    expect(output).toContain('Entry Points:');
-    expect(output).toContain('src/');
-  });
+		const output = logs.join("\n");
+		expect(output).toContain("Check Gates:");
+		expect(output).toContain("lint");
+		expect(output).toContain("Review Gates:");
+		expect(output).toContain("security");
+		expect(output).toContain("gemini");
+		expect(output).toContain("Entry Points:");
+		expect(output).toContain("src/");
+	});
 });

package/src/commands/list.ts

@@ -1,29 +1,33 @@
-import type { Command } from 'commander';
-import chalk from 'chalk';
-import { loadConfig } from '../config/loader.js';
+import chalk from "chalk";
+import type { Command } from "commander";
+import { loadConfig } from "../config/loader.js";
 
 export function registerListCommand(program: Command): void {
-  program
-    .command('list')
-    .description('List configured gates')
-    .action(async () => {
-      try {
-        const config = await loadConfig();
-        console.log(chalk.bold('Check Gates:'));
-        Object.values(config.checks).forEach(c => console.log(` - ${c.name}`));
-        
-        console.log(chalk.bold('\nReview Gates:'));
-        Object.values(config.reviews).forEach(r => console.log(` - ${r.name} (Tools: ${r.cli_preference?.join(', ')})`));
+	program
+		.command("list")
+		.description("List configured gates")
+		.action(async () => {
+			try {
+				const config = await loadConfig();
+				console.log(chalk.bold("Check Gates:"));
+				Object.values(config.checks).forEach((c) => {
+					console.log(` - ${c.name}`);
+				});
 
-        console.log(chalk.bold('\nEntry Points:'));
-        config.project.entry_points.forEach(ep => {
-          console.log(` - ${ep.path}`);
-          if (ep.checks) console.log(`   Checks: ${ep.checks.join(', ')}`);
-          if (ep.reviews) console.log(`   Reviews: ${ep.reviews.join(', ')}`);
-        });
+				console.log(chalk.bold("\nReview Gates:"));
+				Object.values(config.reviews).forEach((r) => {
+					console.log(` - ${r.name} (Tools: ${r.cli_preference?.join(", ")})`);
+				});
 
-      } catch (error: any) {
-        console.error(chalk.red('Error:'), error.message);
-      }
-    });
+				console.log(chalk.bold("\nEntry Points:"));
+				config.project.entry_points.forEach((ep) => {
+					console.log(` - ${ep.path}`);
+					if (ep.checks) console.log(`   Checks: ${ep.checks.join(", ")}`);
+					if (ep.reviews) console.log(`   Reviews: ${ep.reviews.join(", ")}`);
+				});
+			} catch (error: unknown) {
+				const err = error as { message?: string };
+				console.error(chalk.red("Error:"), err.message);
+			}
+		});
 }

package/src/commands/rerun.ts

@@ -1,122 +1,160 @@
-import type { Command } from 'commander';
-import chalk from 'chalk';
-import { loadConfig } from '../config/loader.js';
-import { ChangeDetector } from '../core/change-detector.js';
-import { EntryPointExpander } from '../core/entry-point.js';
-import { JobGenerator } from '../core/job.js';
-import { Runner } from '../core/runner.js';
-import { Logger } from '../output/logger.js';
-import { ConsoleReporter } from '../output/console.js';
-import { findPreviousFailures, type GateFailures, type PreviousViolation } from '../utils/log-parser.js';
-import { rotateLogs } from './shared.js';
+import chalk from "chalk";
+import type { Command } from "commander";
+import { loadConfig } from "../config/loader.js";
+import { ChangeDetector } from "../core/change-detector.js";
+import { EntryPointExpander } from "../core/entry-point.js";
+import { JobGenerator } from "../core/job.js";
+import { Runner } from "../core/runner.js";
+import { ConsoleReporter } from "../output/console.js";
+import { Logger } from "../output/logger.js";
+import {
+	findPreviousFailures,
+	type PreviousViolation,
+} from "../utils/log-parser.js";
+import { rotateLogs } from "./shared.js";
 
 export function registerRerunCommand(program: Command): void {
-  program
-    .command('rerun')
-    .description('Rerun gates (checks & reviews) with previous failures as context (defaults to uncommitted changes)')
-    .option('-g, --gate <name>', 'Run specific gate only')
-    .option('-c, --commit <sha>', 'Use diff for a specific commit (overrides default uncommitted mode)')
-    .action(async (options) => {
-      try {
-        const config = await loadConfig();
-
-        // Parse previous failures from log files (only for review gates)
-        console.log(chalk.dim('Analyzing previous runs...'));
-        
-        // findPreviousFailures handles errors internally and returns empty array on failure
-        const previousFailures = await findPreviousFailures(
-          config.project.log_dir,
-          options.gate
-        );
-
-        // Create a map: jobId -> (adapterName -> violations)
-        const failuresMap = new Map<string, Map<string, PreviousViolation[]>>();
-        for (const gateFailure of previousFailures) {
-          const adapterMap = new Map<string, PreviousViolation[]>();
-          for (const adapterFailure of gateFailure.adapterFailures) {
-            adapterMap.set(adapterFailure.adapterName, adapterFailure.violations);
-          }
-          failuresMap.set(gateFailure.jobId, adapterMap);
-        }
-
-        if (previousFailures.length > 0) {
-          const totalViolations = previousFailures.reduce(
-            (sum, gf) => sum + gf.adapterFailures.reduce(
-              (s, af) => s + af.violations.length, 0
-            ), 0
-          );
-          console.log(chalk.yellow(
-            `Found ${previousFailures.length} gate(s) with ${totalViolations} previous violation(s)`
-          ));
-        } else {
-          console.log(chalk.dim('No previous failures found. Running as normal...'));
-        }
-
-        // Rotate logs before starting the new run
-        await rotateLogs(config.project.log_dir);
-
-        // Detect changes (default to uncommitted unless --commit is specified)
-        // Note: Rerun defaults to uncommitted changes for faster iteration loops,
-        // unlike 'run' which defaults to base_branch comparison.
-        const changeOptions = {
-          commit: options.commit,
-          uncommitted: !options.commit  // Default to uncommitted unless commit is specified
-        };
-
-        const changeDetector = new ChangeDetector(
-          config.project.base_branch,
-          changeOptions
-        );
-        const expander = new EntryPointExpander();
-        const jobGen = new JobGenerator(config);
-
-        const modeDesc = options.commit
-          ? `commit ${options.commit}`
-          : 'uncommitted changes';
-        console.log(chalk.dim(`Detecting changes (${modeDesc})...`));
-
-        const changes = await changeDetector.getChangedFiles();
-
-        if (changes.length === 0) {
-          console.log(chalk.green('No changes detected.'));
-          process.exit(0);
-        }
-
-        console.log(chalk.dim(`Found ${changes.length} changed files.`));
-
-        const entryPoints = await expander.expand(config.project.entry_points, changes);
-        let jobs = jobGen.generateJobs(entryPoints);
-
-        if (options.gate) {
-          jobs = jobs.filter(j => j.name === options.gate);
-        }
-
-        if (jobs.length === 0) {
-          console.log(chalk.yellow('No applicable gates for these changes.'));
-          process.exit(0);
-        }
-
-        console.log(chalk.dim(`Running ${jobs.length} gates...`));
-        if (previousFailures.length > 0) {
-          console.log(chalk.dim('Previous failures will be injected as context for matching reviewers.'));
-        }
-
-        const logger = new Logger(config.project.log_dir);
-        const reporter = new ConsoleReporter();
-        const runner = new Runner(
-          config,
-          logger,
-          reporter,
-          failuresMap,      // Pass previous failures map
-          changeOptions     // Pass change detection options
-        );
-
-        const success = await runner.run(jobs);
-        process.exit(success ? 0 : 1);
-
-      } catch (error: any) {
-        console.error(chalk.red('Error:'), error.message);
-        process.exit(1);
-      }
-    });
+	program
+		.command("rerun")
+		.description(
+			"Rerun gates (checks & reviews) with previous failures as context (defaults to uncommitted changes)",
+		)
+		.option(
+			"-b, --base-branch <branch>",
+			"Override base branch for change detection",
+		)
+		.option("-g, --gate <name>", "Run specific gate only")
+		.option(
+			"-c, --commit <sha>",
+			"Use diff for a specific commit (overrides default uncommitted mode)",
+		)
+		.action(async (options) => {
+			try {
+				const config = await loadConfig();
+
+				// Parse previous failures from log files (only for review gates)
+				console.log(chalk.dim("Analyzing previous runs..."));
+
+				// findPreviousFailures handles errors internally and returns empty array on failure
+				const previousFailures = await findPreviousFailures(
+					config.project.log_dir,
+					options.gate,
+				);
+
+				// Create a map: jobId -> (adapterName -> violations)
+				const failuresMap = new Map<string, Map<string, PreviousViolation[]>>();
+				for (const gateFailure of previousFailures) {
+					const adapterMap = new Map<string, PreviousViolation[]>();
+					for (const adapterFailure of gateFailure.adapterFailures) {
+						adapterMap.set(
+							adapterFailure.adapterName,
+							adapterFailure.violations,
+						);
+					}
+					failuresMap.set(gateFailure.jobId, adapterMap);
+				}
+
+				if (previousFailures.length > 0) {
+					const totalViolations = previousFailures.reduce(
+						(sum, gf) =>
+							sum +
+							gf.adapterFailures.reduce((s, af) => s + af.violations.length, 0),
+						0,
+					);
+					console.log(
+						chalk.yellow(
+							`Found ${previousFailures.length} gate(s) with ${totalViolations} previous violation(s)`,
+						),
+					);
+				} else {
+					console.log(
+						chalk.dim("No previous failures found. Running as normal..."),
+					);
+				}
+
+				// Rotate logs before starting the new run
+				await rotateLogs(config.project.log_dir);
+
+				// Determine effective base branch
+				// Priority: CLI override > CI env var > config
+				const effectiveBaseBranch =
+					options.baseBranch ||
+					(process.env.GITHUB_BASE_REF &&
+					(process.env.CI === "true" || process.env.GITHUB_ACTIONS === "true")
+						? process.env.GITHUB_BASE_REF
+						: null) ||
+					config.project.base_branch;
+
+				// Detect changes (default to uncommitted unless --commit is specified)
+				// Note: Rerun defaults to uncommitted changes for faster iteration loops,
+				// unlike 'run' which defaults to base_branch comparison.
+				const changeOptions = {
+					commit: options.commit,
+					uncommitted: !options.commit, // Default to uncommitted unless commit is specified
+				};
+
+				const changeDetector = new ChangeDetector(
+					effectiveBaseBranch,
+					changeOptions,
+				);
+				const expander = new EntryPointExpander();
+				const jobGen = new JobGenerator(config);
+
+				const modeDesc = options.commit
+					? `commit ${options.commit}`
+					: "uncommitted changes";
+				console.log(chalk.dim(`Detecting changes (${modeDesc})...`));
+
+				const changes = await changeDetector.getChangedFiles();
+
+				if (changes.length === 0) {
+					console.log(chalk.green("No changes detected."));
+					process.exit(0);
+				}
+
+				console.log(chalk.dim(`Found ${changes.length} changed files.`));
+
+				const entryPoints = await expander.expand(
+					config.project.entry_points,
+					changes,
+				);
+				let jobs = jobGen.generateJobs(entryPoints);
+
+				if (options.gate) {
+					jobs = jobs.filter((j) => j.name === options.gate);
+				}
+
+				if (jobs.length === 0) {
+					console.log(chalk.yellow("No applicable gates for these changes."));
+					process.exit(0);
+				}
+
+				console.log(chalk.dim(`Running ${jobs.length} gates...`));
+				if (previousFailures.length > 0) {
+					console.log(
+						chalk.dim(
+							"Previous failures will be injected as context for matching reviewers.",
+						),
+					);
+				}
+
+				const logger = new Logger(config.project.log_dir);
+				const reporter = new ConsoleReporter();
+				const runner = new Runner(
+					config,
+					logger,
+					reporter,
+					failuresMap, // Pass previous failures map
+					changeOptions, // Pass change detection options
+					effectiveBaseBranch, // Pass effective base branch
+				);
+
+				const success = await runner.run(jobs);
+				process.exit(success ? 0 : 1);
+			} catch (error: unknown) {
+				const err = error as { message?: string };
+				console.error(chalk.red("Error:"), err.message);
+				process.exit(1);
+			}
+		});
 }

package/src/commands/review.test.ts

@@ -1,25 +1,31 @@
-import { describe, it, expect, beforeEach } from 'bun:test';
-import { Command } from 'commander';
-import { registerReviewCommand } from './review.js';
+import { beforeEach, describe, expect, it } from "bun:test";
+import { Command } from "commander";
+import { registerReviewCommand } from "./review.js";
 
-describe('Review Command', () => {
-  let program: Command;
+describe("Review Command", () => {
+	let program: Command;
 
-  beforeEach(() => {
-    program = new Command();
-    registerReviewCommand(program);
-  });
+	beforeEach(() => {
+		program = new Command();
+		registerReviewCommand(program);
+	});
 
-  it('should register the review command', () => {
-    const reviewCmd = program.commands.find(cmd => cmd.name() === 'review');
-    expect(reviewCmd).toBeDefined();
-    expect(reviewCmd?.description()).toBe('Run only applicable reviews for detected changes');
-  });
+	it("should register the review command", () => {
+		const reviewCmd = program.commands.find((cmd) => cmd.name() === "review");
+		expect(reviewCmd).toBeDefined();
+		expect(reviewCmd?.description()).toBe(
+			"Run only applicable reviews for detected changes",
+		);
+	});
 
-  it('should have correct options', () => {
-    const reviewCmd = program.commands.find(cmd => cmd.name() === 'review');
-    expect(reviewCmd?.options.some(opt => opt.long === '--gate')).toBe(true);
-    expect(reviewCmd?.options.some(opt => opt.long === '--commit')).toBe(true);
-    expect(reviewCmd?.options.some(opt => opt.long === '--uncommitted')).toBe(true);
-  });
+	it("should have correct options", () => {
+		const reviewCmd = program.commands.find((cmd) => cmd.name() === "review");
+		expect(reviewCmd?.options.some((opt) => opt.long === "--gate")).toBe(true);
+		expect(reviewCmd?.options.some((opt) => opt.long === "--commit")).toBe(
+			true,
+		);
+		expect(reviewCmd?.options.some((opt) => opt.long === "--uncommitted")).toBe(
+			true,
+		);
+	});
 });