agent-gate-installer 1.4.0 → 1.5.0

package/bin/install.mjs

@@ -9,6 +9,7 @@ import { homedir, platform } from "node:os";
 const CLAUDE_HOME = join(homedir(), ".claude");
 const INSTALL_DIR = join(CLAUDE_HOME, "agent-gate");
 const SETTINGS_PATH = join(CLAUDE_HOME, "settings.json");
+const CLAUDE_JSON_PATH = join(homedir(), ".claude.json");
 const REPO_URL = "https://github.com/jl-cmd/agent-gate.git";
 const MINIMUM_PYTHON_VERSION = [3, 11];
 const IS_WINDOWS = platform() === "win32";
@@ -129,7 +130,35 @@ function registerMcpServer(settings, venvPython) {
     command: venvPython,
     args: [join(INSTALL_DIR, "src", "agent_gate", "server.py")],
   };
-  log("  + Registered agent-gate MCP server");
+  log("  + Registered agent-gate MCP server in settings.json");
+}
+
+function readClaudeJson() {
+  if (!existsSync(CLAUDE_JSON_PATH)) return {};
+  const raw = readFileSync(CLAUDE_JSON_PATH, "utf8");
+  try {
+    return JSON.parse(raw);
+  } catch {
+    log(`  ! ${CLAUDE_JSON_PATH} contains malformed JSON, skipping MCP registration there.`);
+    return null;
+  }
+}
+
+function writeClaudeJson(data) {
+  writeFileSync(CLAUDE_JSON_PATH, JSON.stringify(data, null, 4) + "\n", "utf8");
+}
+
+function registerMcpInClaudeJson(venvPython) {
+  const data = readClaudeJson();
+  if (data === null) return;
+  data.mcpServers = data.mcpServers || {};
+  data.mcpServers["agent-gate"] = {
+    type: "stdio",
+    command: venvPython,
+    args: [join(INSTALL_DIR, "src", "agent_gate", "server.py")],
+  };
+  writeClaudeJson(data);
+  log("  + Registered agent-gate MCP server in ~/.claude.json");
 }
 
 function writeMcpConfigFile(venvPython) {
@@ -179,6 +208,12 @@ async function install() {
 
   mkdirSync(CLAUDE_HOME, { recursive: true });
 
+  const venvDirectory = join(INSTALL_DIR, ".venv");
+  const venvPython = getVenvPython(venvDirectory);
+
+  writeMcpConfigFile(venvPython);
+  registerMcpInClaudeJson(venvPython);
+
   if (existsSync(join(INSTALL_DIR, ".git"))) {
     log("  ~ agent-gate already cloned, pulling latest...");
     try {
@@ -199,9 +234,6 @@ async function install() {
     }
   }
 
-  const venvDirectory = join(INSTALL_DIR, ".venv");
-  const venvPython = getVenvPython(venvDirectory);
-
   if (existsSync(venvDirectory)) {
     log("  ~ venv already exists");
   } else {
@@ -236,8 +268,6 @@ async function install() {
   registerMcpServer(settings, venvPython);
   writeSettings(settings);
 
-  writeMcpConfigFile(venvPython);
-
   log("  + Verifying installation...");
   try {
     run(`"${venvPython}" -c "from agent_gate.server import create_mcp; print('OK')"`);

package/bin/install.test.mjs

@@ -0,0 +1,164 @@
+#!/usr/bin/env node
+
+/**
+ * Tests for install.mjs MCP registration behavior.
+ *
+ * Verifies that:
+ * - /tmp/agent-gate-mcp-config.json is written even when install fails early
+ * - ~/.claude.json gets mcpServers entry for agent-gate
+ */
+
+import { existsSync, readFileSync, rmSync, writeFileSync, mkdirSync } from "node:fs";
+import { join } from "node:path";
+import { execSync } from "node:child_process";
+import { homedir } from "node:os";
+
+const MCP_CONFIG_PATH = "/tmp/agent-gate-mcp-config.json";
+const CLAUDE_JSON_PATH = join(homedir(), ".claude.json");
+let passed = 0;
+let failed = 0;
+
+let claudeJsonBackup = null;
+
+function backupClaudeJson() {
+  if (existsSync(CLAUDE_JSON_PATH)) {
+    claudeJsonBackup = readFileSync(CLAUDE_JSON_PATH, "utf8");
+  }
+}
+
+function restoreClaudeJson() {
+  if (claudeJsonBackup !== null) {
+    writeFileSync(CLAUDE_JSON_PATH, claudeJsonBackup, "utf8");
+  }
+}
+
+function cleanupMcpConfig() {
+  try { rmSync(MCP_CONFIG_PATH); } catch { /* ok */ }
+}
+
+function assert(condition, message) {
+  if (condition) {
+    console.log(`  PASS: ${message}`);
+    passed++;
+  } else {
+    console.log(`  FAIL: ${message}`);
+    failed++;
+  }
+}
+
+// --- Test 1: writeMcpConfigFile writes correct content ---
+console.log("\nTest 1: writeMcpConfigFile writes correct JSON to /tmp");
+cleanupMcpConfig();
+{
+  const venvPython = "/root/.claude/agent-gate/.venv/bin/python";
+  const INSTALL_DIR = "/root/.claude/agent-gate";
+  const config = {
+    mcpServers: {
+      "agent-gate": {
+        type: "stdio",
+        command: venvPython,
+        args: [join(INSTALL_DIR, "src", "agent_gate", "server.py")],
+      },
+    },
+  };
+  writeFileSync(MCP_CONFIG_PATH, JSON.stringify(config, null, 4) + "\n", "utf8");
+
+  assert(existsSync(MCP_CONFIG_PATH), "File exists at /tmp/agent-gate-mcp-config.json");
+
+  const content = JSON.parse(readFileSync(MCP_CONFIG_PATH, "utf8"));
+  assert(content.mcpServers?.["agent-gate"] !== undefined, "Has agent-gate MCP server entry");
+  assert(content.mcpServers["agent-gate"].type === "stdio", "Type is stdio");
+  assert(content.mcpServers["agent-gate"].command === venvPython, "Command points to venv python");
+  assert(
+    content.mcpServers["agent-gate"].args[0].endsWith("server.py"),
+    "Args point to server.py"
+  );
+}
+cleanupMcpConfig();
+
+// --- Test 2: MCP config written even when install exits early ---
+console.log("\nTest 2: /tmp MCP config written even when install exits early");
+cleanupMcpConfig();
+{
+  try {
+    execSync(
+      `GH_TOKEN=bad_token node "${join(import.meta.dirname, "install.mjs")}" --non-interactive`,
+      { encoding: "utf8", stdio: "pipe", timeout: 30000 }
+    );
+  } catch {
+    // Expected — install fails at clone step
+  }
+
+  assert(
+    existsSync(MCP_CONFIG_PATH),
+    "/tmp MCP config exists after failed install (written before clone)"
+  );
+}
+cleanupMcpConfig();
+
+// --- Test 3: ~/.claude.json gets mcpServers on failed install ---
+console.log("\nTest 3: ~/.claude.json gets mcpServers even when install fails");
+backupClaudeJson();
+cleanupMcpConfig();
+{
+  try {
+    execSync(
+      `GH_TOKEN=bad_token node "${join(import.meta.dirname, "install.mjs")}" --non-interactive`,
+      { encoding: "utf8", stdio: "pipe", timeout: 30000 }
+    );
+  } catch {
+    // Expected — install fails at clone step
+  }
+
+  let claudeJsonHasMcp = false;
+  try {
+    const data = JSON.parse(readFileSync(CLAUDE_JSON_PATH, "utf8"));
+    claudeJsonHasMcp = data.mcpServers?.["agent-gate"]?.type === "stdio";
+  } catch { /* ok */ }
+
+  assert(
+    claudeJsonHasMcp,
+    "~/.claude.json has agent-gate mcpServers entry after failed install"
+  );
+}
+restoreClaudeJson();
+cleanupMcpConfig();
+
+// --- Test 4: ~/.claude.json preserves existing data ---
+console.log("\nTest 4: ~/.claude.json preserves existing data when adding mcpServers");
+backupClaudeJson();
+cleanupMcpConfig();
+{
+  // Write a known state to ~/.claude.json
+  const existing = { someExistingKey: "preserved", mcpServers: { "other-server": { type: "http" } } };
+  writeFileSync(CLAUDE_JSON_PATH, JSON.stringify(existing, null, 4) + "\n", "utf8");
+
+  try {
+    execSync(
+      `GH_TOKEN=bad_token node "${join(import.meta.dirname, "install.mjs")}" --non-interactive`,
+      { encoding: "utf8", stdio: "pipe", timeout: 30000 }
+    );
+  } catch {
+    // Expected
+  }
+
+  let preserved = false;
+  let hasAgentGate = false;
+  let hasOtherServer = false;
+  try {
+    const data = JSON.parse(readFileSync(CLAUDE_JSON_PATH, "utf8"));
+    preserved = data.someExistingKey === "preserved";
+    hasAgentGate = data.mcpServers?.["agent-gate"]?.type === "stdio";
+    hasOtherServer = data.mcpServers?.["other-server"]?.type === "http";
+  } catch { /* ok */ }
+
+  assert(preserved, "Existing keys preserved in ~/.claude.json");
+  assert(hasAgentGate, "agent-gate MCP server added");
+  assert(hasOtherServer, "Pre-existing MCP server not removed");
+}
+restoreClaudeJson();
+cleanupMcpConfig();
+
+// --- Summary ---
+console.log(`\n${passed} passed, ${failed} failed\n`);
+process.exit(failed > 0 ? 1 : 0);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-gate-installer",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "One-command installer for agent-gate prompt evaluation gate",
   "type": "module",
   "bin": {