agent-gate-installer 1.4.0 → 1.4.1

package/bin/install.mjs

@@ -179,6 +179,11 @@ async function install() {
 
   mkdirSync(CLAUDE_HOME, { recursive: true });
 
+  const venvDirectory = join(INSTALL_DIR, ".venv");
+  const venvPython = getVenvPython(venvDirectory);
+
+  writeMcpConfigFile(venvPython);
+
   if (existsSync(join(INSTALL_DIR, ".git"))) {
     log("  ~ agent-gate already cloned, pulling latest...");
     try {
@@ -199,9 +204,6 @@ async function install() {
     }
   }
 
-  const venvDirectory = join(INSTALL_DIR, ".venv");
-  const venvPython = getVenvPython(venvDirectory);
-
   if (existsSync(venvDirectory)) {
     log("  ~ venv already exists");
   } else {
@@ -236,8 +238,6 @@ async function install() {
   registerMcpServer(settings, venvPython);
   writeSettings(settings);
 
-  writeMcpConfigFile(venvPython);
-
   log("  + Verifying installation...");
   try {
     run(`"${venvPython}" -c "from agent_gate.server import create_mcp; print('OK')"`);

package/bin/install.test.mjs

@@ -0,0 +1,115 @@
+#!/usr/bin/env node
+
+/**
+ * Tests for writeMcpConfigFile behavior in install.mjs.
+ *
+ * Verifies that /tmp/agent-gate-mcp-config.json is written even when
+ * earlier install steps (clone, venv, pip) fail.
+ */
+
+import { existsSync, readFileSync, rmSync, writeFileSync, mkdirSync } from "node:fs";
+import { join } from "node:path";
+import { execSync } from "node:child_process";
+
+const MCP_CONFIG_PATH = "/tmp/agent-gate-mcp-config.json";
+let passed = 0;
+let failed = 0;
+
+function cleanup() {
+  try { rmSync(MCP_CONFIG_PATH); } catch { /* ok */ }
+}
+
+function assert(condition, message) {
+  if (condition) {
+    console.log(`  PASS: ${message}`);
+    passed++;
+  } else {
+    console.log(`  FAIL: ${message}`);
+    failed++;
+  }
+}
+
+// --- Test 1: writeMcpConfigFile writes correct content ---
+console.log("\nTest 1: writeMcpConfigFile writes correct JSON");
+cleanup();
+{
+  // Inline the function logic to test it in isolation
+  const venvPython = "/root/.claude/agent-gate/.venv/bin/python";
+  const INSTALL_DIR = "/root/.claude/agent-gate";
+  const config = {
+    mcpServers: {
+      "agent-gate": {
+        type: "stdio",
+        command: venvPython,
+        args: [join(INSTALL_DIR, "src", "agent_gate", "server.py")],
+      },
+    },
+  };
+  writeFileSync(MCP_CONFIG_PATH, JSON.stringify(config, null, 4) + "\n", "utf8");
+
+  assert(existsSync(MCP_CONFIG_PATH), "File exists at /tmp/agent-gate-mcp-config.json");
+
+  const content = JSON.parse(readFileSync(MCP_CONFIG_PATH, "utf8"));
+  assert(content.mcpServers?.["agent-gate"] !== undefined, "Has agent-gate MCP server entry");
+  assert(content.mcpServers["agent-gate"].type === "stdio", "Type is stdio");
+  assert(content.mcpServers["agent-gate"].command === venvPython, "Command points to venv python");
+  assert(
+    content.mcpServers["agent-gate"].args[0].endsWith("server.py"),
+    "Args point to server.py"
+  );
+}
+cleanup();
+
+// --- Test 2: Simulate install failure — MCP config should still be written ---
+console.log("\nTest 2: MCP config written even when install exits early");
+cleanup();
+{
+  // Run the installer with a bad GH_TOKEN in non-interactive mode.
+  // The clone step will fail, but we want the MCP config to exist.
+  try {
+    execSync(
+      `GH_TOKEN=bad_token node "${join(import.meta.dirname, "install.mjs")}" --non-interactive`,
+      { encoding: "utf8", stdio: "pipe", timeout: 30000 }
+    );
+  } catch {
+    // Expected — install fails at clone step
+  }
+
+  assert(
+    existsSync(MCP_CONFIG_PATH),
+    "MCP config file exists after failed install (written before clone)"
+  );
+}
+cleanup();
+
+// --- Test 3: Simulate install with existing clone but broken pip ---
+console.log("\nTest 3: MCP config written even when pip install fails");
+cleanup();
+{
+  // Create a fake INSTALL_DIR so clone is skipped, but venv/pip will fail
+  const fakeInstallDir = "/tmp/agent-gate-test-install";
+  try { rmSync(fakeInstallDir, { recursive: true }); } catch { /* ok */ }
+  mkdirSync(join(fakeInstallDir, ".git"), { recursive: true });
+
+  try {
+    execSync(
+      `HOME=/tmp/agent-gate-test-home GH_TOKEN=x node "${join(import.meta.dirname, "install.mjs")}" --non-interactive`,
+      { encoding: "utf8", stdio: "pipe", timeout: 30000, env: { ...process.env, HOME: "/tmp/agent-gate-test-home" } }
+    );
+  } catch {
+    // Expected — install fails at venv/pip step
+  }
+
+  assert(
+    existsSync(MCP_CONFIG_PATH),
+    "MCP config file exists after pip failure (written before pip)"
+  );
+
+  try { rmSync(fakeInstallDir, { recursive: true }); } catch { /* ok */ }
+  try { rmSync("/tmp/agent-gate-test-home", { recursive: true }); } catch { /* ok */ }
+}
+cleanup();
+
+// --- Summary ---
+console.log(`\n${passed} passed, ${failed} failed\n`);
+process.exit(failed > 0 ? 1 : 0);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-gate-installer",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "One-command installer for agent-gate prompt evaluation gate",
   "type": "module",
   "bin": {