agent-feedbacker 0.1.0 → 0.3.0

package/src/mcp.mjs

@@ -1,10 +1,11 @@
 // Minimal MCP server over stdio (newline-delimited JSON-RPC 2.0) with one tool,
 // request_review, which blocks until the user submits the review page.
 
+import fs from 'node:fs';
 import readline from 'node:readline';
 import { buildReview, hasChanges, startReview, toMarkdown } from './core.mjs';
 
-const VERSION = '0.1.0';
+const { version: VERSION } = JSON.parse(fs.readFileSync(new URL('../package.json', import.meta.url), 'utf8'));
 const PROTOCOL = '2025-06-18';
 
 const TOOL = {
@@ -14,7 +15,8 @@ const TOOL = {
     'Open a merge-request-style review page in the user\'s browser with the diffs of the given git repos ' +
     '(working tree, including untracked files, against a base). The user comments on lines, answers your ' +
     'questions and submits. Blocks until they do, then returns their feedback as markdown: a verdict ' +
-    '(approved / changes requested), a general comment, answers, and line comments with the code they refer to. ' +
+    '(approved / changes requested), a general comment, line comments with the code they refer to, and questions the ' +
+    'user asks about the code, which you must answer in your reply. ' +
     'Pass every repo and worktree you changed in this session, as absolute paths.',
   inputSchema: {
     type: 'object',
@@ -28,13 +30,30 @@ const TOOL = {
           properties: {
             path: { type: 'string', description: 'Absolute path to the repo (or any folder inside it).' },
             base: { type: 'string', description: 'Commit, branch or tag to diff against. Default HEAD (uncommitted changes only). With a branch, the diff starts where HEAD forked from it, like a merge request.' },
+            exact: { type: 'boolean', description: 'Diff against base itself, not the point where HEAD forked from it. Set by the session-baseline hook; rarely needed by hand.' },
+            session: { type: 'boolean', description: 'Set by the session-baseline hook: base is where the repo stood when this session started.' },
             worktrees: { type: 'boolean', description: 'Also review every other git worktree of this repo (e.g. parallel agents\' work), each against the same base.' },
           },
           required: ['path'],
         },
       },
-      summary: { type: 'string', description: 'Short summary of what you changed and why, shown at the top of the page.' },
-      questions: { type: 'array', items: { type: 'string' }, description: 'Questions for the user to answer next to the diff.' },
+      summary: { type: 'string', description: 'What you changed and why, shown at the top of the page. Markdown: paragraphs, "- " lists, `code`, **bold**, "### " subheadings. Lead with one or two sentences; put details in a list.' },
+      focus: {
+        type: 'array',
+        description: 'Where the user should look first: the main logic, risky or non-obvious changes. Two to six entries; leave out tests, docs and config unless they are the point.',
+        items: {
+          type: 'object',
+          properties: {
+            path: { type: 'string', description: 'File path, relative to its repo (or absolute).' },
+            repo: { type: 'string', description: 'Repo path or folder name, when the same path exists in several repos.' },
+            startLine: { type: 'integer', description: 'First line (new side) of the part to look at.' },
+            endLine: { type: 'integer', description: 'Last line (new side).' },
+            note: { type: 'string', description: 'Why it matters, in one sentence.' },
+          },
+          required: ['path', 'note'],
+        },
+      },
+      questions: { type: 'array', items: { type: 'string' }, description: 'Only for a decision you cannot make without the user. Usually leave this out: the user asks you questions on the page instead.' },
     },
     required: ['repos'],
   },
@@ -59,9 +78,10 @@ async function callTool(id, params) {
     return toolError('`repos` must be a non-empty array of { path, base? }.');
   }
   const review = buildReview({
-    repos: args.repos.map((r) => (typeof r === 'string' ? r : { path: r.path, base: r.base, worktrees: r.worktrees })),
+    repos: args.repos.map((r) => (typeof r === 'string' ? r : { path: r.path, base: r.base, worktrees: r.worktrees, exact: r.exact, session: r.session })),
     summary: args.summary || '',
     questions: Array.isArray(args.questions) ? args.questions.map(String) : [],
+    focus: Array.isArray(args.focus) ? args.focus : [],
   });
   const errors = review.repos.filter((r) => r.error).map((r) => `${r.path}: ${r.error}`);
   if (!hasChanges(review) && !review.questions.length) {