agent-facets 0.1.2 → 0.2.1

package/.package.json.bak

@@ -0,0 +1,44 @@
+{
+  "name": "agent-facets",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/agent-facets/facets",
+    "directory": "packages/cli"
+  },
+  "version": "0.2.1",
+  "type": "module",
+  "bin": {
+    "facet": "./dist/facet"
+  },
+  "scripts": {
+    "build": "bun build src/index.ts --compile --outfile dist/facet",
+    "prepack": "bun ../../scripts/prepack.ts",
+    "postpack": "bun ../../scripts/postpack.ts",
+    "types": "tsc --noEmit",
+    "test": "bun test --timeout 15000"
+  },
+  "dependencies": {
+    "@bomb.sh/args": "0.3.1",
+    "@types/react": "19.2.14",
+    "arktype": "2.1.29",
+    "ink": "6.8.0",
+    "ink-gradient": "4.0.0",
+    "ink-spinner": "5.0.0",
+    "ink-text-input": "6.0.0",
+    "react": "19.2.4",
+    "react-devtools-core": "7.0.1"
+  },
+  "devDependencies": {
+    "@agent-facets/brand": "workspace:*",
+    "@agent-facets/core": "workspace:*",
+    "@types/bun": "1.3.10",
+    "ink-testing-library": "4.0.0"
+  },
+  "peerDependencies": {
+    "typescript": "^5 || ^6"
+  },
+  "publishConfig": {
+    "access": "public",
+    "provenance": false
+  }
+}

package/.turbo/turbo-build.log

@@ -1,3 +1,3 @@
 $ bun build src/index.ts --compile --outfile dist/facet
- [169ms]  bundle  298 modules
-   [2ms] compile  dist/facet
+ [202ms]  bundle  388 modules
+   [3ms] compile  dist/facet

package/CHANGELOG.md

@@ -1,5 +1,38 @@
 # agent-facets
 
+## 0.2.1
+
+### Patch Changes
+
+- [#39](https://github.com/agent-facets/facets/pull/39) [`f380b7b`](https://github.com/agent-facets/facets/commit/f380b7bc5115acec1f974ef1401eba199a2f90fb) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Ensure release CI works in isolation
+
+## 0.2.0
+
+### Minor Changes
+
+- [#35](https://github.com/agent-facets/facets/pull/35) [`6350718`](https://github.com/agent-facets/facets/commit/63507188f1bb3a7276cd4812f69f7d16d1778fd6) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Ensure proper release isolation
+
+### Patch Changes
+
+- [#37](https://github.com/agent-facets/facets/pull/37) [`1c48260`](https://github.com/agent-facets/facets/commit/1c48260ab77fd27e64be6c5884aa6c447e3639e0) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Better dev & ci dependency management via mise
+- [#33](https://github.com/agent-facets/facets/pull/33) [`540e126`](https://github.com/agent-facets/facets/commit/540e126e677de98a9b3d4e39542df37de8756b73) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Ensure CI runs tests before release and notify Slack when failures occur.
+
+## 0.1.4
+
+### Patch Changes
+
+- [`098fd08`](https://github.com/agent-facets/facets/commit/098fd08bf5d9970babc5c57bee6a155bffcecd97) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Better CLI parameter validation
+
+- [`5262cbe`](https://github.com/agent-facets/facets/commit/5262cbe66df02c625430309878e6061ccde183de) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Fix publishing by properly categorizing dev dependencies
+
+- [`d3b9439`](https://github.com/agent-facets/facets/commit/d3b9439466e0eb65687901426e2ebd6c5a333c60) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Use better github attribution for changesets
+
+## 0.1.3
+
+### Patch Changes
+
+- 66b179f: Wire up the facet edit command
+
 ## 0.1.2
 
 ### Patch Changes

package/package.json

@@ -5,21 +5,22 @@
     "url": "https://github.com/agent-facets/facets",
     "directory": "packages/cli"
   },
-  "version": "0.1.2",
+  "version": "0.2.1",
   "type": "module",
   "bin": {
     "facet": "./dist/facet"
   },
   "scripts": {
     "build": "bun build src/index.ts --compile --outfile dist/facet",
+    "prepack": "bun ../../scripts/prepack.ts",
+    "postpack": "bun ../../scripts/postpack.ts",
     "types": "tsc --noEmit",
     "test": "bun test --timeout 15000"
   },
   "dependencies": {
-    "@agent-facets/brand": "workspace:*",
     "@bomb.sh/args": "0.3.1",
-    "@agent-facets/core": "workspace:*",
     "@types/react": "19.2.14",
+    "arktype": "2.1.29",
     "ink": "6.8.0",
     "ink-gradient": "4.0.0",
     "ink-spinner": "5.0.0",
@@ -28,11 +29,13 @@
     "react-devtools-core": "7.0.1"
   },
   "devDependencies": {
+    "@agent-facets/brand": "0.2.0",
+    "@agent-facets/core": "0.2.0",
     "@types/bun": "1.3.10",
     "ink-testing-library": "4.0.0"
   },
   "peerDependencies": {
-    "typescript": "^5"
+    "typescript": "^5 || ^6"
   },
   "publishConfig": {
     "access": "public",

package/src/__tests__/cli.test.ts

@@ -2,7 +2,7 @@ import { describe, expect, test } from 'bun:test'
 import { resolve } from 'node:path'
 
 const CLI_PATH = resolve(import.meta.dir, '../../dist/facet')
-const COMMAND_NAMES = ['add', 'build', 'create', 'info', 'install', 'list', 'publish', 'remove', 'upgrade']
+const COMMAND_NAMES = ['add', 'build', 'create', 'edit', 'info', 'install', 'list', 'publish', 'remove', 'upgrade']
 const STUB_COMMAND_NAMES = ['add', 'info', 'install', 'list', 'publish', 'remove', 'upgrade']
 
 type ExecResult = {
@@ -79,6 +79,16 @@ describe('CLI — stub commands', () => {
   })
 })
 
+// --- Edit command dispatch ---
+
+describe('CLI — edit command', () => {
+  test('edit with no manifest prints error and exits 1', async () => {
+    const result = await runCli('edit', import.meta.dir)
+    expect(result.exitCode).toBe(1)
+    expect(result.stderr).toContain('facet.json')
+  })
+})
+
 // --- Unknown commands ---
 
 describe('CLI — unknown commands', () => {
@@ -121,32 +131,65 @@ describe('CLI — per-command help', () => {
 // --- Unexpected error ---
 
 describe('CLI — unexpected error', () => {
-  test('unexpected error exits with code 2', async () => {
-    // This test runs against source (not compiled binary) because it needs to
-    // monkey-patch the command registry to inject a crashing command.
-    const script = `
-      import { commands } from '${resolve(import.meta.dir, '../commands.ts')}'
-      import { run } from '${resolve(import.meta.dir, '../run.ts')}'
-      commands['crash'] = {
+  test('unexpected error is thrown by run', async () => {
+    const { run } = await import('../run.ts')
+
+    const crashRegistry = {
+      crash: {
         name: 'crash',
         description: 'Throws an error',
-        run: async () => { throw new Error('boom') },
-      }
-      try {
-        const code = await run(['crash'])
-        process.exit(code)
-      } catch (error) {
-        console.error(error instanceof Error ? error.message : 'An unexpected error occurred.')
-        process.exit(2)
-      }
-    `
-    const proc = Bun.spawn(['bun', '--eval', script], {
-      stdout: 'pipe',
-      stderr: 'pipe',
-    })
-    const stderr = await new Response(proc.stderr).text()
-    const exitCode = await proc.exited
-    expect(exitCode).toBe(2)
-    expect(stderr.trim()).toContain('boom')
+        run: async (_args: string[], _flags: Record<string, unknown>) => {
+          throw new Error('boom')
+        },
+      },
+    }
+
+    await expect(run(['crash'], crashRegistry)).rejects.toThrow('boom')
+  })
+})
+
+// --- Per-command flags ---
+
+describe('CLI — per-command flags', () => {
+  test('create --help shows --force flag and usage', async () => {
+    const result = await runCli('create', '--help')
+    expect(result.exitCode).toBe(0)
+    expect(result.stdout).toContain('[directory]')
+    expect(result.stdout).toContain('--force')
+    expect(result.stdout).toContain('Overwrite existing facet.json')
+  })
+
+  test('build --help shows directory usage', async () => {
+    const result = await runCli('build', '--help')
+    expect(result.exitCode).toBe(0)
+    expect(result.stdout).toContain('[directory]')
+  })
+
+  test('edit --help shows directory usage', async () => {
+    const result = await runCli('edit', '--help')
+    expect(result.exitCode).toBe(0)
+    expect(result.stdout).toContain('[directory]')
+  })
+})
+
+// --- Directory validation ---
+
+describe('CLI — directory validation', () => {
+  test('build with non-existent directory errors', async () => {
+    const result = await runCli('build', `/tmp/does-not-exist-${Date.now()}`)
+    expect(result.exitCode).toBe(1)
+    expect(result.stderr).toContain('does not exist')
+  })
+
+  test('edit with non-existent directory errors', async () => {
+    const result = await runCli('edit', `/tmp/does-not-exist-${Date.now()}`)
+    expect(result.exitCode).toBe(1)
+    expect(result.stderr).toContain('does not exist')
+  })
+
+  test('build with file instead of directory errors', async () => {
+    const result = await runCli('build', import.meta.path)
+    expect(result.exitCode).toBe(1)
+    expect(result.stderr).toContain('Expected a directory')
   })
 })

package/src/__tests__/create-build.test.ts

@@ -3,6 +3,7 @@ import { mkdtemp, rm } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import { join, resolve } from 'node:path'
 import { writeScaffold } from '../commands/create/index.ts'
+import { DEFAULT_VERSION } from '../commands/create-scaffold.ts'
 
 let testDir: string
 
@@ -51,7 +52,7 @@ describe('writeScaffold', () => {
     const files = await writeScaffold(
       {
         name: 'my-facet',
-        version: '0.1.0',
+        version: DEFAULT_VERSION,
         description: 'A test facet',
         skills: ['code-review', 'testing-guide'],
         agents: ['reviewer'],
@@ -61,8 +62,8 @@ describe('writeScaffold', () => {
     )
 
     expect(files).toContain('facet.json')
-    expect(files).toContain('skills/code-review.md')
-    expect(files).toContain('skills/testing-guide.md')
+    expect(files).toContain('skills/code-review/SKILL.md')
+    expect(files).toContain('skills/testing-guide/SKILL.md')
     expect(files).toContain('agents/reviewer.md')
     expect(files).toContain('commands/deploy.md')
 
@@ -70,7 +71,7 @@ describe('writeScaffold', () => {
     const manifestText = await Bun.file(join(dir, 'facet.json')).text()
     const manifest = JSON.parse(manifestText)
     expect(manifest.name).toBe('my-facet')
-    expect(manifest.version).toBe('0.1.0')
+    expect(manifest.version).toBe(DEFAULT_VERSION)
     expect(manifest.description).toBe('A test facet')
     expect(manifest.skills).toBeDefined()
     expect(manifest.skills['code-review']).toBeDefined()
@@ -81,10 +82,10 @@ describe('writeScaffold', () => {
     expect(manifest.commands.deploy).toBeDefined()
 
     // Verify starter files exist and have named template content
-    const skill = await Bun.file(join(dir, 'skills/code-review.md')).text()
+    const skill = await Bun.file(join(dir, 'skills/code-review/SKILL.md')).text()
     expect(skill).toContain('# Code Review')
 
-    const skill2 = await Bun.file(join(dir, 'skills/testing-guide.md')).text()
+    const skill2 = await Bun.file(join(dir, 'skills/testing-guide/SKILL.md')).text()
     expect(skill2).toContain('# Testing Guide')
 
     const agent = await Bun.file(join(dir, 'agents/reviewer.md')).text()
@@ -99,7 +100,7 @@ describe('writeScaffold', () => {
     const files = await writeScaffold(
       {
         name: 'minimal',
-        version: '0.1.0',
+        version: DEFAULT_VERSION,
         description: '',
         skills: ['minimal'],
         agents: [],
@@ -109,7 +110,7 @@ describe('writeScaffold', () => {
     )
 
     expect(files).toContain('facet.json')
-    expect(files).toContain('skills/minimal.md')
+    expect(files).toContain('skills/minimal/SKILL.md')
     expect(files).not.toContain('agents/')
     expect(files).not.toContain('commands/')
 
@@ -120,12 +121,31 @@ describe('writeScaffold', () => {
     expect(manifest.commands).toBeUndefined()
   })
 
+  test('version defaults to DEFAULT_VERSION (0.0.0)', async () => {
+    const dir = await createFixtureDir('scaffold-default-version')
+    await writeScaffold(
+      {
+        name: 'default-ver',
+        version: DEFAULT_VERSION,
+        description: 'Testing default version',
+        skills: ['example'],
+        agents: [],
+        commands: [],
+      },
+      dir,
+    )
+
+    const manifestText = await Bun.file(join(dir, 'facet.json')).text()
+    const manifest = JSON.parse(manifestText)
+    expect(manifest.version).toBe('0.0.0')
+  })
+
   test('scaffolded project passes build', async () => {
     const dir = await createFixtureDir('scaffold-buildable')
     await writeScaffold(
       {
         name: 'buildable',
-        version: '0.1.0',
+        version: DEFAULT_VERSION,
         description: 'A buildable facet',
         skills: ['helper'],
         agents: ['assistant'],
@@ -140,7 +160,7 @@ describe('writeScaffold', () => {
     expect(result.stdout).toContain('Built buildable')
 
     // Verify dist/ output exists — archive + build manifest
-    const distArchive = await Bun.file(join(dir, 'dist/buildable-0.1.0.facet')).exists()
+    const distArchive = await Bun.file(join(dir, `dist/buildable-${DEFAULT_VERSION}.facet`)).exists()
     expect(distArchive).toBe(true)
 
     const distManifest = await Bun.file(join(dir, 'dist/build-manifest.json')).exists()
@@ -157,7 +177,7 @@ describe('writeScaffold', () => {
 describe('facet build', () => {
   test('build succeeds on valid project', async () => {
     const dir = await createFixtureDir('build-valid')
-    await Bun.write(join(dir, 'skills/review.md'), '# Review skill content')
+    await Bun.write(join(dir, 'skills/review/SKILL.md'), '# Review skill content')
     await Bun.write(
       join(dir, 'facet.json'),
       JSON.stringify({
@@ -182,7 +202,7 @@ describe('facet build', () => {
 
     const result = await runCli('build', dir)
     expect(result.exitCode).toBe(1)
-    expect(result.stdout).toContain('Build failed')
+    expect(result.stderr).toContain('facet.json')
   })
 
   test('build fails on missing asset file', async () => {

package/src/__tests__/edit-integration.test.ts

@@ -0,0 +1,171 @@
+import { describe, expect, test } from 'bun:test'
+import { mkdir } from 'node:fs/promises'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import { runBuildPipeline } from '@agent-facets/core'
+import dedent from 'dedent'
+import { applyOperations, buildEditContext } from '../commands/edit/index.ts'
+import type { EditOperation } from '../tui/views/edit/edit-types.ts'
+
+async function createFixtureDir(name: string): Promise<string> {
+  const dir = join(tmpdir(), `facets-edit-integ-${name}-${Date.now()}`)
+  await mkdir(dir, { recursive: true })
+  return dir
+}
+
+async function writeManifest(dir: string, manifest: Record<string, unknown>): Promise<void> {
+  await Bun.write(join(dir, 'facet.json'), JSON.stringify(manifest, null, 2))
+}
+
+describe('edit integration', () => {
+  test('buildEditContext detects new files on disk not in manifest', async () => {
+    const dir = await createFixtureDir('detect-additions')
+    await writeManifest(dir, {
+      name: 'test',
+      version: '1.0.0',
+      skills: { existing: { description: 'Existing skill' } },
+    })
+    await mkdir(join(dir, 'skills/existing'), { recursive: true })
+    await Bun.write(join(dir, 'skills/existing/SKILL.md'), '# Existing')
+    // Add a file not in manifest
+    await mkdir(join(dir, 'skills/new-one'), { recursive: true })
+    await Bun.write(join(dir, 'skills/new-one/SKILL.md'), '# New')
+
+    const result = await buildEditContext(dir)
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    const additions = result.context.reconciliationItems.filter((i) => i.kind === 'addition')
+    expect(additions).toHaveLength(1)
+    expect(additions[0]?.name).toBe('new-one')
+  })
+
+  test('buildEditContext detects missing files in manifest', async () => {
+    const dir = await createFixtureDir('detect-missing')
+    await writeManifest(dir, {
+      name: 'test',
+      version: '1.0.0',
+      skills: {
+        present: { description: 'Present' },
+        gone: { description: 'Gone' },
+      },
+    })
+    await mkdir(join(dir, 'skills/present'), { recursive: true })
+    await Bun.write(join(dir, 'skills/present/SKILL.md'), '# Present')
+    // 'gone' has no file on disk
+
+    const result = await buildEditContext(dir)
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    const missing = result.context.reconciliationItems.filter((i) => i.kind === 'missing')
+    expect(missing).toHaveLength(1)
+    expect(missing[0]?.name).toBe('gone')
+  })
+
+  test('buildEditContext detects front matter in matched files', async () => {
+    const dir = await createFixtureDir('detect-frontmatter')
+    await writeManifest(dir, {
+      name: 'test',
+      version: '1.0.0',
+      skills: { review: { description: 'Review' } },
+    })
+    await mkdir(join(dir, 'skills/review'), { recursive: true })
+    await Bun.write(
+      join(dir, 'skills/review/SKILL.md'),
+      dedent`
+        ---
+        name: Review
+        ---
+        # Review skill
+      `,
+    )
+
+    const result = await buildEditContext(dir)
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    const fm = result.context.reconciliationItems.filter((i) => i.kind === 'front-matter')
+    expect(fm).toHaveLength(1)
+    expect(fm[0]?.name).toBe('review')
+  })
+
+  test('applyOperations scaffolds new skill files', async () => {
+    const dir = await createFixtureDir('scaffold-skill')
+    const manifest = {
+      name: 'test',
+      version: '1.0.0',
+      skills: { helper: { description: 'A helper skill' } },
+    }
+    const operations: EditOperation[] = [{ op: 'write-manifest' }, { op: 'scaffold', type: 'skills', name: 'helper' }]
+
+    await applyOperations(manifest, operations, dir)
+
+    const manifestExists = await Bun.file(join(dir, 'facet.json')).exists()
+    expect(manifestExists).toBe(true)
+
+    const skillExists = await Bun.file(join(dir, 'skills/helper/SKILL.md')).exists()
+    expect(skillExists).toBe(true)
+  })
+
+  test('applyOperations strips front matter from files', async () => {
+    const dir = await createFixtureDir('strip-fm')
+    await mkdir(join(dir, 'skills/review'), { recursive: true })
+    await Bun.write(
+      join(dir, 'skills/review/SKILL.md'),
+      dedent`
+        ---
+        name: Review
+        description: A review skill
+        ---
+        # Review
+        Review all code.
+      `,
+    )
+
+    const manifest = {
+      name: 'test',
+      version: '1.0.0',
+      skills: { review: { description: 'A review skill' } },
+    }
+    const operations: EditOperation[] = [
+      { op: 'write-manifest' },
+      { op: 'strip-front-matter', type: 'skills', name: 'review', path: 'skills/review/SKILL.md' },
+    ]
+
+    await applyOperations(manifest, operations, dir)
+
+    const content = await Bun.file(join(dir, 'skills/review/SKILL.md')).text()
+    expect(content).not.toContain('---')
+    expect(content).toContain('# Review')
+  })
+
+  test('applyOperations deletes removed asset files', async () => {
+    const dir = await createFixtureDir('delete-asset')
+    await mkdir(join(dir, 'skills/old'), { recursive: true })
+    await Bun.write(join(dir, 'skills/old/SKILL.md'), '# Old skill')
+
+    const manifest = { name: 'test', version: '1.0.0', skills: { remaining: { description: 'Remaining' } } }
+    const operations: EditOperation[] = [{ op: 'write-manifest' }, { op: 'delete-file', type: 'skills', name: 'old' }]
+
+    await applyOperations(manifest, operations, dir)
+
+    const deleted = await Bun.file(join(dir, 'skills/old/SKILL.md')).exists()
+    expect(deleted).toBe(false)
+  })
+
+  test('scaffold then build succeeds end-to-end', async () => {
+    const dir = await createFixtureDir('scaffold-then-build')
+    const manifest = {
+      name: 'test-facet',
+      version: '1.0.0',
+      skills: { example: { description: 'An example skill' } },
+    }
+    const operations: EditOperation[] = [{ op: 'write-manifest' }, { op: 'scaffold', type: 'skills', name: 'example' }]
+
+    await applyOperations(manifest, operations, dir)
+
+    const buildResult = await runBuildPipeline(dir)
+    expect(buildResult.ok).toBe(true)
+  })
+})

package/src/__tests__/resolve-dir.test.ts

@@ -0,0 +1,95 @@
+import { describe, expect, test } from 'bun:test'
+import { mkdir } from 'node:fs/promises'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import { resolveTargetDir } from '../commands/resolve-dir.ts'
+
+async function createFixtureDir(name: string): Promise<string> {
+  const dir = join(tmpdir(), `facets-resolve-test-${name}-${Date.now()}`)
+  await mkdir(dir, { recursive: true })
+
+  return dir
+}
+
+describe('resolveTargetDir', () => {
+  test('no arg defaults to cwd', async () => {
+    const result = await resolveTargetDir(undefined, { mustExist: true })
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    expect(result.dir).toBe(process.cwd())
+    expect(result.display).toBe('.')
+  })
+
+  test('facet.json path uses parent directory', async () => {
+    const dir = await createFixtureDir('facet-json')
+    await Bun.write(join(dir, 'facet.json'), '{}')
+
+    const result = await resolveTargetDir(join(dir, 'facet.json'), { mustExist: true })
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    expect(result.dir).toBe(dir)
+  })
+
+  test('non-directory file returns error', async () => {
+    const dir = await createFixtureDir('non-dir')
+    const filePath = join(dir, 'not-a-dir.txt')
+    await Bun.write(filePath, 'hello')
+
+    const result = await resolveTargetDir(filePath, { mustExist: true })
+    expect(result.ok).toBe(false)
+    if (result.ok) return
+
+    expect(result.message).toContain('Expected a directory')
+  })
+
+  test('non-existent dir with mustExist true returns error', async () => {
+    const result = await resolveTargetDir(`/tmp/does-not-exist-${Date.now()}`, { mustExist: true })
+    expect(result.ok).toBe(false)
+    if (result.ok) return
+
+    expect(result.message).toContain('does not exist')
+  })
+
+  test('non-existent dir with mustExist false auto-creates it', async () => {
+    const dir = join(tmpdir(), `facets-resolve-autocreate-${Date.now()}`)
+
+    const result = await resolveTargetDir(dir, { mustExist: false })
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    const { stat } = await import('node:fs/promises')
+    const dirStat = await stat(result.dir)
+    expect(dirStat.isDirectory()).toBe(true)
+  })
+
+  test('valid existing directory passes', async () => {
+    const dir = await createFixtureDir('valid-dir')
+
+    const result = await resolveTargetDir(dir, { mustExist: true })
+    expect(result.ok).toBe(true)
+    if (!result.ok) return
+
+    expect(result.dir).toBe(dir)
+    expect(result.display).toBe(dir)
+  })
+
+  test('facetMustExist true without facet.json returns error', async () => {
+    const dir = await createFixtureDir('no-manifest')
+
+    const result = await resolveTargetDir(dir, { mustExist: true, facetMustExist: true })
+    expect(result.ok).toBe(false)
+    if (result.ok) return
+
+    expect(result.message).toContain('facet.json')
+  })
+
+  test('facetMustExist true with facet.json passes', async () => {
+    const dir = await createFixtureDir('has-manifest')
+    await Bun.write(join(dir, 'facet.json'), '{}')
+
+    const result = await resolveTargetDir(dir, { mustExist: true, facetMustExist: true })
+    expect(result.ok).toBe(true)
+  })
+})