agent-enderun 1.1.2 → 1.1.4

package/src/cli/commands/check.ts

@@ -2,35 +2,25 @@ import fs from "fs";
 import path from "path";
 import { execSync } from "child_process";
 
-import { getFrameworkDir, getConfiguredPaths, getMemoryPath } from "../utils/memory.js";
-import { getPackageVersion, getValidatorPath } from "../utils/pkg.js"; // To get FRAMEWORK_VERSION + robust npm-installed bin/validator resolution
+import { getFrameworkDir, getMemoryPath } from "../utils/memory.js";
+import { getPackageVersion, getValidatorPath } from "../utils/pkg.js";
+import { UI } from "../utils/ui.js";
 
 const FRAMEWORK_VERSION = getPackageVersion();
 
-/**
- * Check framework health and MCP status.
- * Now also runs full AL (Agent Lifecycle) army validation so that
- * `agent-enderun check` guarantees that init setups are AL-compliant.
- */
 export function checkCommand() {
-    console.warn(`🔍 Checking Agent Enderun Health (v${FRAMEWORK_VERSION})...`);
+    UI.intent("Enderun Core Health Check", `Sistem sağlığı ve disiplin kuralları denetleniyor (v${FRAMEWORK_VERSION})...`);
     let issues = 0;
 
     const frameworkDir = getFrameworkDir();
-    const pathsMap = getConfiguredPaths();
     const memoryPath = getMemoryPath();
 
-    console.warn(`   Using framework dir: ${frameworkDir} (AL cross-adapter aware)`);
+    UI.success(`Using framework dir: ${frameworkDir}`);
 
-    // Determine folder names based on adapter detection (AL + cross-adapter support)
     let knowledgeDir = "knowledge";
-    if (frameworkDir === ".agents" || frameworkDir === ".agent") {
-        knowledgeDir = "rules";
-    }
+    if (frameworkDir === ".github") knowledgeDir = "instructions";
 
-    const constitutionPath = fs.existsSync(path.join(process.cwd(), "ENDERUN.md"))
-        ? "ENDERUN.md"
-        : path.join(frameworkDir, "ENDERUN.md");
+    const constitutionPath = fs.existsSync(path.join(process.cwd(), "ENDERUN.md")) ? "ENDERUN.md" : path.join(frameworkDir, "ENDERUN.md");
 
     const checks = [
         { name: "Constitution (ENDERUN.md)", path: constitutionPath },
@@ -42,87 +32,81 @@ export function checkCommand() {
         { name: "ESLint Config (eslint.config.js)", path: "eslint.config.js" },
         { name: "ESLint Standards", path: path.join(frameworkDir, `${knowledgeDir}/eslint-standards.md`) },
         { name: "MCP Server", path: "framework-mcp/package.json" },
-        { name: "Panda CSS Config", path: "panda.config.ts" },
+        { name: "Panda CSS Config", path: "panda.config.ts", optional: true },
         { name: "Brain Dashboard", path: path.join(frameworkDir, "BRAIN_DASHBOARD.md") },
-        { name: "Project Architectural Portal (docs/README.md)", path: path.join(pathsMap.docs, "README.md") },
-        { name: "System Getting Started Guide (docs/getting-started.md)", path: path.join(pathsMap.docs, "getting-started.md") },
-        { name: "Enterprise Approval Flows Protocol", path: path.join(pathsMap.docs, "architecture/approval-flows.md") },
-        { name: "Professional Error Handling Pattern", path: path.join(pathsMap.docs, "backend/error-handling.md") },
-        { name: "Atomic Component Standards", path: path.join(pathsMap.docs, "frontend/component-patterns.md") },
-    ];
-
-    // Optional app-level checks (only when apps/ has content)
-    const optionalChecks = [
-        { name: "Backend Contract", path: path.join(pathsMap.backend, "contract.version.json") },
     ];
 
     for (const check of checks) {
-        if (fs.existsSync(path.join(process.cwd(), check.path))) {
-            console.warn(`✅ ${check.name} found.`);
-        } else {
-            console.warn(`❌ ${check.name} MISSING! (${check.path})`);
-            issues++;
-        }
-    }
-
-    for (const check of optionalChecks) {
-        if (fs.existsSync(path.join(process.cwd(), check.path))) {
-            console.warn(`✅ ${check.name} found.`);
+        const fullPath = path.isAbsolute(check.path) ? check.path : path.join(process.cwd(), check.path);
+        if (fs.existsSync(fullPath)) {
+            UI.success(`${check.name} found.`);
         } else {
-            console.warn(`ℹ️  ${check.name} not found (${check.path}) — created with 'create-app'.`);
+            if (check.optional) {
+                UI.warning(`${check.name} MISSING! (${check.path}) [Optional]`);
+            } else {
+                UI.error(`${check.name} MISSING! (${check.path})`);
+                issues++;
+            }
         }
     }
 
-    // Dependency Check
-    const mcpNodeModules = path.join(process.cwd(), "framework-mcp/node_modules");
-    const rootNodeModules = path.join(process.cwd(), "node_modules");
-    if (!fs.existsSync(mcpNodeModules) && !fs.existsSync(rootNodeModules)) {
-        console.warn("❌ Dependencies MISSING! (Run 'npm install')");
+    // Agent Army Check
+    console.warn("\n🛡️  Running Agent Army Compliance...");
+    try {
+        const validatorScript = getValidatorPath();
+        execSync(`node "${validatorScript}"`, { stdio: "pipe" });
+        UI.success("Agent Army AL validation PASSED.");
+    } catch (error: unknown) {
+        const err = error as Error & { stderr?: Buffer };
+        UI.error(`Agent Army AL validation FAILED: ${err.message}`);
+        if (err.stderr) console.error(err.stderr.toString());
         issues++;
-    } else {
-        console.warn("✅ Dependencies found.");
     }
 
-    // MCP Build Check
-    const mcpPath = path.join(process.cwd(), "framework-mcp/dist/index.js");
-    if (!fs.existsSync(mcpPath)) {
-        console.warn("❌ MCP Build MISSING! (Run 'npm run enderun:build')");
+    // Code Quality
+    console.warn("\n⚖️  Checking Discipline (Code Quality)...");
+    const consoleLogIssues = checkConsoleLogs();
+    if (consoleLogIssues.length > 0) {
+        UI.error(`Forbidden 'console.log' found in ${consoleLogIssues.length} locations.`);
         issues++;
     } else {
-        console.warn("✅ MCP Build found.");
-        console.warn("⏳ Testing MCP Server syntax...");
-        try {
-            execSync(`node --check ${mcpPath}`, { stdio: "pipe" });
-            console.warn("✅ MCP Server syntax valid.");
-        } catch {
-            // If --check fails on ESM, we might skip it or use a better check
-            console.warn("⚠️  MCP Syntax check skipped (ESM/Environment).");
-        }
+        UI.success("No forbidden 'console.log' detected.");
     }
 
-    // === AL (Agent Lifecycle) Army Validation ===
-    // This makes `agent-enderun check` also enforce that init'ed agents are AL-compliant
-    // (stateMachine + tags present and parseable). Works across adapters (skills/plugins/agents).
-    // Uses getValidatorPath() so it resolves inside node_modules/... when installed via npm (not just source cwd).
-    console.warn("\n🛡️  Running Agent Army AL Compliance (validate-agent-army)...");
     try {
-        const validatorPath = getValidatorPath();
-        execSync(`node "${validatorPath}"`, { stdio: "pipe" });
-        console.warn("✅ Agent Army AL validation PASSED (all agents have stateMachine + tags).");
+        execSync("npx tsc --noEmit", { stdio: "pipe" });
+        UI.success("TypeScript type check PASSED.");
     } catch {
-        console.warn("❌ Agent Army AL validation FAILED.");
-        console.warn("   Run manually: agent-enderun validate   (or: npx agent-enderun validate-army)");
-        console.warn("   This usually means your init used an adapter that remapped agents (e.g. antigravity → skills).");
-        console.warn("   The core .md definitions should still be correct; the standalone validator just couldn't locate them.");
-        console.warn("   (Note: from npm package, bare 'node bin/...' will not work — use the CLI command above.)");
+        UI.error("TypeScript type check FAILED.");
         issues++;
     }
 
     if (issues === 0) {
-        console.warn("\n🚀 All systems green! Agent Enderun is ready for orchestration.");
+        UI.success("\n🚀 All systems green! Enderun Core is ready.");
     } else {
-        console.warn(`
-⚠️  Found ${issues} issues. Please fix them before starting.`);
+        UI.error(`\n⚠️  Found ${issues} issues. Please fix them.`);
         process.exit(1);
     }
-}
+}
+
+function checkConsoleLogs(): string[] {
+    const issues: string[] = [];
+    const srcDir = path.join(process.cwd(), "src");
+    if (!fs.existsSync(srcDir)) return [];
+    const walk = (dir: string) => {
+        const files = fs.readdirSync(dir);
+        for (const file of files) {
+            const fullPath = path.join(dir, file);
+            if (fs.statSync(fullPath).isDirectory()) walk(fullPath);
+            else if (file.endsWith(".ts") && !file.includes(".test.")) {
+                const content = fs.readFileSync(fullPath, "utf8");
+                const target = "console." + "log(";
+                if (content.includes(target) && !fullPath.includes("check.ts")) {
+                    issues.push(fullPath);
+                }
+            }
+        }
+    };
+    walk(srcDir);
+    return issues;
+}