agent-device 0.4.2 → 0.5.0

package/src/platforms/ios/__tests__/index.test.ts

@@ -1,312 +0,0 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import { promises as fs } from 'node:fs';
-import os from 'node:os';
-import path from 'node:path';
-import { listIosApps, openIosApp, parseIosDeviceAppsPayload, resolveIosApp } from '../index.ts';
-import type { DeviceInfo } from '../../../utils/device.ts';
-import { AppError } from '../../../utils/errors.ts';
-
-test('openIosApp custom scheme deep links on iOS devices require app bundle context', async () => {
-  const device: DeviceInfo = {
-    platform: 'ios',
-    id: 'ios-device-1',
-    name: 'iPhone Device',
-    kind: 'device',
-    booted: true,
-  };
-
-  await assert.rejects(
-    () => openIosApp(device, 'myapp://home'),
-    (error: unknown) => {
-      assert.equal(error instanceof AppError, true);
-      assert.equal((error as AppError).code, 'INVALID_ARGS');
-      return true;
-    },
-  );
-});
-
-test('openIosApp web URL on iOS device without app falls back to Safari', async () => {
-  const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'agent-device-ios-safari-test-'));
-  const xcrunPath = path.join(tmpDir, 'xcrun');
-  const argsLogPath = path.join(tmpDir, 'args.log');
-  await fs.writeFile(
-    xcrunPath,
-    '#!/bin/sh\nprintf "%s\\n" "$@" > "$AGENT_DEVICE_TEST_ARGS_FILE"\nexit 0\n',
-    'utf8',
-  );
-  await fs.chmod(xcrunPath, 0o755);
-
-  const previousPath = process.env.PATH;
-  const previousArgsFile = process.env.AGENT_DEVICE_TEST_ARGS_FILE;
-  process.env.PATH = `${tmpDir}${path.delimiter}${previousPath ?? ''}`;
-  process.env.AGENT_DEVICE_TEST_ARGS_FILE = argsLogPath;
-
-  const device: DeviceInfo = {
-    platform: 'ios',
-    id: 'ios-device-1',
-    name: 'iPhone Device',
-    kind: 'device',
-    booted: true,
-  };
-
-  try {
-    await openIosApp(device, 'https://example.com/path');
-    const args = (await fs.readFile(argsLogPath, 'utf8'))
-      .trim()
-      .split('\n')
-      .filter(Boolean);
-    assert.deepEqual(args, [
-      'devicectl',
-      'device',
-      'process',
-      'launch',
-      '--device',
-      'ios-device-1',
-      'com.apple.mobilesafari',
-      '--payload-url',
-      'https://example.com/path',
-    ]);
-  } finally {
-    process.env.PATH = previousPath;
-    if (previousArgsFile === undefined) {
-      delete process.env.AGENT_DEVICE_TEST_ARGS_FILE;
-    } else {
-      process.env.AGENT_DEVICE_TEST_ARGS_FILE = previousArgsFile;
-    }
-    await fs.rm(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('openIosApp custom scheme on iOS device uses active app context', async () => {
-  const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'agent-device-ios-openurl-test-'));
-  const xcrunPath = path.join(tmpDir, 'xcrun');
-  const argsLogPath = path.join(tmpDir, 'args.log');
-  await fs.writeFile(
-    xcrunPath,
-    '#!/bin/sh\nprintf "%s\\n" "$@" > "$AGENT_DEVICE_TEST_ARGS_FILE"\nexit 0\n',
-    'utf8',
-  );
-  await fs.chmod(xcrunPath, 0o755);
-
-  const previousPath = process.env.PATH;
-  const previousArgsFile = process.env.AGENT_DEVICE_TEST_ARGS_FILE;
-  process.env.PATH = `${tmpDir}${path.delimiter}${previousPath ?? ''}`;
-  process.env.AGENT_DEVICE_TEST_ARGS_FILE = argsLogPath;
-
-  const device: DeviceInfo = {
-    platform: 'ios',
-    id: 'ios-device-1',
-    name: 'iPhone Device',
-    kind: 'device',
-    booted: true,
-  };
-
-  try {
-    await openIosApp(device, 'myapp://item/42', { appBundleId: 'com.example.app' });
-    const args = (await fs.readFile(argsLogPath, 'utf8'))
-      .trim()
-      .split('\n')
-      .filter(Boolean);
-    assert.deepEqual(args, [
-      'devicectl',
-      'device',
-      'process',
-      'launch',
-      '--device',
-      'ios-device-1',
-      'com.example.app',
-      '--payload-url',
-      'myapp://item/42',
-    ]);
-  } finally {
-    process.env.PATH = previousPath;
-    if (previousArgsFile === undefined) {
-      delete process.env.AGENT_DEVICE_TEST_ARGS_FILE;
-    } else {
-      process.env.AGENT_DEVICE_TEST_ARGS_FILE = previousArgsFile;
-    }
-    await fs.rm(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('openIosApp with app and URL on iOS device launches app bundle with payload URL', async () => {
-  const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'agent-device-ios-open-app-url-test-'));
-  const xcrunPath = path.join(tmpDir, 'xcrun');
-  const argsLogPath = path.join(tmpDir, 'args.log');
-  await fs.writeFile(
-    xcrunPath,
-    '#!/bin/sh\nprintf "%s\\n" "$@" > "$AGENT_DEVICE_TEST_ARGS_FILE"\nexit 0\n',
-    'utf8',
-  );
-  await fs.chmod(xcrunPath, 0o755);
-
-  const previousPath = process.env.PATH;
-  const previousArgsFile = process.env.AGENT_DEVICE_TEST_ARGS_FILE;
-  process.env.PATH = `${tmpDir}${path.delimiter}${previousPath ?? ''}`;
-  process.env.AGENT_DEVICE_TEST_ARGS_FILE = argsLogPath;
-
-  const device: DeviceInfo = {
-    platform: 'ios',
-    id: 'ios-device-1',
-    name: 'iPhone Device',
-    kind: 'device',
-    booted: true,
-  };
-
-  try {
-    await openIosApp(device, 'MyApp', { appBundleId: 'com.example.app', url: 'myapp://screen/to' });
-    const args = (await fs.readFile(argsLogPath, 'utf8'))
-      .trim()
-      .split('\n')
-      .filter(Boolean);
-    assert.deepEqual(args, [
-      'devicectl',
-      'device',
-      'process',
-      'launch',
-      '--device',
-      'ios-device-1',
-      'com.example.app',
-      '--payload-url',
-      'myapp://screen/to',
-    ]);
-  } finally {
-    process.env.PATH = previousPath;
-    if (previousArgsFile === undefined) {
-      delete process.env.AGENT_DEVICE_TEST_ARGS_FILE;
-    } else {
-      process.env.AGENT_DEVICE_TEST_ARGS_FILE = previousArgsFile;
-    }
-    await fs.rm(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('parseIosDeviceAppsPayload maps devicectl app entries', () => {
-  const apps = parseIosDeviceAppsPayload({
-    result: {
-      apps: [
-        {
-          bundleIdentifier: 'com.apple.Maps',
-          name: 'Maps',
-        },
-        {
-          bundleIdentifier: 'com.example.NoName',
-        },
-      ],
-    },
-  });
-
-  assert.equal(apps.length, 2);
-  assert.deepEqual(apps[0], {
-    bundleId: 'com.apple.Maps',
-    name: 'Maps',
-  });
-  assert.equal(apps[1].bundleId, 'com.example.NoName');
-  assert.equal(apps[1].name, 'com.example.NoName');
-});
-
-test('parseIosDeviceAppsPayload ignores malformed entries', () => {
-  const apps = parseIosDeviceAppsPayload({
-    result: {
-      apps: [
-        null,
-        {},
-        { name: 'Missing bundle id' },
-        { bundleIdentifier: '' },
-      ],
-    },
-  });
-  assert.deepEqual(apps, []);
-});
-
-test('resolveIosApp resolves app display name on iOS physical devices', async () => {
-  const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'agent-device-ios-app-resolve-'));
-  const xcrunPath = path.join(tmpDir, 'xcrun');
-  await fs.writeFile(
-    xcrunPath,
-    [
-      '#!/bin/sh',
-      'if [ "$1" = "devicectl" ] && [ "$2" = "device" ] && [ "$3" = "info" ] && [ "$4" = "apps" ]; then',
-      '  out=""',
-      '  while [ "$#" -gt 0 ]; do',
-      '    if [ "$1" = "--json-output" ]; then',
-      '      out="$2"',
-      '      shift 2',
-      '      continue',
-      '    fi',
-      '    shift',
-      '  done',
-      "  cat > \"$out\" <<'JSON'",
-      '{"result":{"apps":[{"bundleIdentifier":"com.apple.Maps","name":"Maps"},{"bundleIdentifier":"com.example.demo","name":"Demo"}]}}',
-      'JSON',
-      '  exit 0',
-      'fi',
-      'echo "unexpected xcrun args: $@" >&2',
-      'exit 1',
-      '',
-    ].join('\n'),
-    'utf8',
-  );
-  await fs.chmod(xcrunPath, 0o755);
-
-  const previousPath = process.env.PATH;
-  process.env.PATH = `${tmpDir}${path.delimiter}${previousPath ?? ''}`;
-
-  const device: DeviceInfo = {
-    platform: 'ios',
-    id: 'ios-device-1',
-    name: 'iPhone Device',
-    kind: 'device',
-    booted: true,
-  };
-
-  try {
-    const bundleId = await resolveIosApp(device, 'Maps');
-    assert.equal(bundleId, 'com.apple.Maps');
-  } finally {
-    process.env.PATH = previousPath;
-    await fs.rm(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('listIosApps applies user-installed filter on simulator', async () => {
-  const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'agent-device-ios-list-sim-'));
-  const xcrunPath = path.join(tmpDir, 'xcrun');
-  await fs.writeFile(
-    xcrunPath,
-    [
-      '#!/bin/sh',
-      'if [ "$1" = "simctl" ] && [ "$2" = "listapps" ]; then',
-      "  cat <<'JSON'",
-      '{"com.apple.Maps":{"CFBundleDisplayName":"Maps"},"com.example.demo":{"CFBundleDisplayName":"Demo"}}',
-      'JSON',
-      '  exit 0',
-      'fi',
-      'echo "unexpected xcrun args: $@" >&2',
-      'exit 1',
-      '',
-    ].join('\n'),
-    'utf8',
-  );
-  await fs.chmod(xcrunPath, 0o755);
-
-  const previousPath = process.env.PATH;
-  process.env.PATH = `${tmpDir}${path.delimiter}${previousPath ?? ''}`;
-
-  const device: DeviceInfo = {
-    platform: 'ios',
-    id: 'sim-1',
-    name: 'iPhone Sim',
-    kind: 'simulator',
-    booted: true,
-  };
-
-  try {
-    const apps = await listIosApps(device, 'user-installed');
-    assert.deepEqual(apps, [{ bundleId: 'com.example.demo', name: 'Demo' }]);
-  } finally {
-    process.env.PATH = previousPath;
-    await fs.rm(tmpDir, { recursive: true, force: true });
-  }
-});

package/src/platforms/ios/__tests__/runner-client.test.ts

@@ -1,155 +0,0 @@
-import test from 'node:test';
-import assert from 'node:assert/strict';
-import type { DeviceInfo } from '../../../utils/device.ts';
-import { AppError } from '../../../utils/errors.ts';
-import {
-  assertSafeDerivedCleanup,
-  isRetryableRunnerError,
-  resolveRunnerEarlyExitHint,
-  resolveRunnerBuildDestination,
-  resolveRunnerDestination,
-  resolveRunnerMaxConcurrentDestinationsFlag,
-  resolveRunnerSigningBuildSettings,
-  shouldRetryRunnerConnectError,
-} from '../runner-client.ts';
-
-const iosSimulator: DeviceInfo = {
-  platform: 'ios',
-  id: 'sim-1',
-  name: 'iPhone Simulator',
-  kind: 'simulator',
-  booted: true,
-};
-
-const iosDevice: DeviceInfo = {
-  platform: 'ios',
-  id: '00008110-000E12341234002E',
-  name: 'iPhone',
-  kind: 'device',
-  booted: true,
-};
-
-test('resolveRunnerDestination uses simulator destination for simulators', () => {
-  assert.equal(resolveRunnerDestination(iosSimulator), 'platform=iOS Simulator,id=sim-1');
-});
-
-test('resolveRunnerDestination uses device destination for physical devices', () => {
-  assert.equal(
-    resolveRunnerDestination(iosDevice),
-    'platform=iOS,id=00008110-000E12341234002E',
-  );
-});
-
-test('resolveRunnerBuildDestination uses generic iOS destination for physical devices', () => {
-  assert.equal(resolveRunnerBuildDestination(iosDevice), 'generic/platform=iOS');
-});
-
-test('resolveRunnerMaxConcurrentDestinationsFlag uses simulator flag for simulators', () => {
-  assert.equal(
-    resolveRunnerMaxConcurrentDestinationsFlag(iosSimulator),
-    '-maximum-concurrent-test-simulator-destinations',
-  );
-});
-
-test('resolveRunnerMaxConcurrentDestinationsFlag uses device flag for physical devices', () => {
-  assert.equal(
-    resolveRunnerMaxConcurrentDestinationsFlag(iosDevice),
-    '-maximum-concurrent-test-device-destinations',
-  );
-});
-
-test('resolveRunnerSigningBuildSettings returns empty args without env overrides', () => {
-  assert.deepEqual(resolveRunnerSigningBuildSettings({}), []);
-});
-
-test('resolveRunnerSigningBuildSettings enables automatic signing for device builds without forcing identity', () => {
-  assert.deepEqual(resolveRunnerSigningBuildSettings({}, true), [
-    'CODE_SIGN_STYLE=Automatic',
-  ]);
-});
-
-test('resolveRunnerSigningBuildSettings ignores device signing overrides for simulator builds', () => {
-  assert.deepEqual(resolveRunnerSigningBuildSettings({
-    AGENT_DEVICE_IOS_TEAM_ID: 'ABCDE12345',
-    AGENT_DEVICE_IOS_SIGNING_IDENTITY: 'Apple Development',
-    AGENT_DEVICE_IOS_PROVISIONING_PROFILE: 'My Profile',
-  }, false), []);
-});
-
-test('resolveRunnerSigningBuildSettings applies optional overrides when provided', () => {
-  const settings = resolveRunnerSigningBuildSettings({
-    AGENT_DEVICE_IOS_TEAM_ID: 'ABCDE12345',
-    AGENT_DEVICE_IOS_SIGNING_IDENTITY: 'Apple Development',
-    AGENT_DEVICE_IOS_PROVISIONING_PROFILE: 'My Profile',
-  }, true);
-  assert.deepEqual(settings, [
-    'CODE_SIGN_STYLE=Automatic',
-    'DEVELOPMENT_TEAM=ABCDE12345',
-    'CODE_SIGN_IDENTITY=Apple Development',
-    'PROVISIONING_PROFILE_SPECIFIER=My Profile',
-  ]);
-});
-
-test('assertSafeDerivedCleanup allows cleaning when no override is set', () => {
-  assert.doesNotThrow(() => {
-    assertSafeDerivedCleanup('/tmp/derived', {});
-  });
-});
-
-test('assertSafeDerivedCleanup rejects cleaning override path by default', () => {
-  assert.throws(
-    () => {
-      assertSafeDerivedCleanup('/tmp/custom', {
-        AGENT_DEVICE_IOS_RUNNER_DERIVED_PATH: '/tmp/custom',
-      });
-    },
-    /Refusing to clean AGENT_DEVICE_IOS_RUNNER_DERIVED_PATH automatically/,
-  );
-});
-
-test('assertSafeDerivedCleanup allows cleaning override path with explicit opt-in', () => {
-  assert.doesNotThrow(() => {
-    assertSafeDerivedCleanup('/tmp/custom', {
-      AGENT_DEVICE_IOS_RUNNER_DERIVED_PATH: '/tmp/custom',
-      AGENT_DEVICE_IOS_ALLOW_OVERRIDE_DERIVED_CLEAN: '1',
-    });
-  });
-});
-
-test('resolveRunnerEarlyExitHint surfaces busy-connecting guidance', () => {
-  const hint = resolveRunnerEarlyExitHint(
-    'Runner did not accept connection (xcodebuild exited early)',
-    'Ineligible destinations for the "AgentDeviceRunner" scheme:\n{ error:Device is busy (Connecting to iPhone) }',
-    '',
-  );
-  assert.match(hint, /still connecting/i);
-});
-
-test('resolveRunnerEarlyExitHint falls back to runner connect timeout hint', () => {
-  const hint = resolveRunnerEarlyExitHint(
-    'Runner did not accept connection (xcodebuild exited early)',
-    '',
-    'xcodebuild failed unexpectedly',
-  );
-  assert.match(hint, /retry runner startup/i);
-});
-
-test('shouldRetryRunnerConnectError does not retry xcodebuild early-exit errors', () => {
-  const err = new AppError('COMMAND_FAILED', 'Runner did not accept connection (xcodebuild exited early)');
-  assert.equal(shouldRetryRunnerConnectError(err), false);
-});
-
-test('shouldRetryRunnerConnectError retries transient connect errors', () => {
-  const err = new AppError('COMMAND_FAILED', 'Runner endpoint probe failed');
-  assert.equal(shouldRetryRunnerConnectError(err), true);
-});
-
-test('isRetryableRunnerError does not retry xcodebuild early-exit errors', () => {
-  const err = new AppError('COMMAND_FAILED', 'Runner did not accept connection (xcodebuild exited early)');
-  assert.equal(isRetryableRunnerError(err), false);
-});
-
-test('isRetryableRunnerError does not retry busy-connecting errors', () => {
-  const err = new AppError('COMMAND_FAILED', 'Device is busy (Connecting to iPhone)');
-  assert.equal(isRetryableRunnerError(err), false);
-});