npm - agent-device - Versions diffs - 0.21.12 → 0.21.13 - Mend

agent-device 0.21.12 → 0.21.13

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (190) hide show

package/dist/apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+SnapshotCapturePlan.swift CHANGED Viewed

@@ -37,6 +37,16 @@ enum SnapshotXCTestChannelPlanState: Equatable {
   case boundedXCTestProbe
 }
+enum SnapshotTierOutcome: Equatable {
+  case completed
+  case deadlineExhausted
+}
 struct EffectiveSnapshotCapturePlan {
   let plan: [SnapshotBackendKind]
   let xCTestChannelState: SnapshotXCTestChannelPlanState
@@ -142,12 +152,6 @@ extension RunnerTests {
     return penalized == bundleId
   }
-  func consumeSnapshotXCTestPenaltyWarmupExemption() -> Bool {
-    let pending = snapshotXCTestPenaltyWarmupExemptionPending
-    snapshotXCTestPenaltyWarmupExemptionPending = false
-    return pending
-  }
@@ -260,7 +264,7 @@ extension RunnerTests {
   func runSnapshotCapturePlan(
     _ plan: [SnapshotBackendKind],
-    app: XCUIApplication,
+    target: SnapshotCaptureTarget,
     options: PresentationOptions,
     terminal: SnapshotCaptureTerminalPolicy,
     deadline: Date? = nil
@@ -270,7 +274,7 @@ extension RunnerTests {
     var axFailure: SnapshotCaptureFailure?
     let deadline = deadline ?? Date().addingTimeInterval(Self.snapshotPlanBudget)
-    let suppressXCTestPenalty = consumeSnapshotXCTestPenaltyWarmupExemption()
+    let suppressXCTestPenalty = snapshotXCTestPenaltyWarmupExemption.consume()
@@ -281,7 +285,7 @@ extension RunnerTests {
     var xCTestChannelPenalized = false
     var xCTestChannelPenalizedByBreaker = false
 #if os(iOS)
-    xCTestChannelPenalizedByBreaker = isSnapshotXCTestChannelPenalized(bundleId: currentBundleId)
+    xCTestChannelPenalizedByBreaker = isSnapshotXCTestChannelPenalized(bundleId: target.bundleId)
     xCTestChannelPenalized = Self.snapshotXCTestChannelTreatedAsPenalized(
       penalized: xCTestChannelPenalizedByBreaker,
       preferredBackend: options.preferredBackend
@@ -305,9 +309,9 @@ extension RunnerTests {
     case .normal:
       break
     case .deferredToIndependentBackend:
-      NSLog("AGENT_DEVICE_RUNNER_SNAPSHOT_XCTEST_CHANNEL_DEFERRED bundle=%@", currentBundleId ?? "")
+      NSLog("AGENT_DEVICE_RUNNER_SNAPSHOT_XCTEST_CHANNEL_DEFERRED bundle=%@", target.bundleId ?? "")
     case .boundedXCTestProbe:
-      NSLog("AGENT_DEVICE_RUNNER_SNAPSHOT_XCTEST_CHANNEL_PROBE_BOUNDED bundle=%@", currentBundleId ?? "")
+      NSLog("AGENT_DEVICE_RUNNER_SNAPSHOT_XCTEST_CHANNEL_PROBE_BOUNDED bundle=%@", target.bundleId ?? "")
     }
     for kind in effectivePlan {
@@ -332,7 +336,7 @@ extension RunnerTests {
       }
       let attempt = try captureWithBackend(
         kind,
-        app: app,
+        target: target,
         options: options,
         deadline: deadline,
         treeCaptureSliceBudgetOverride: effective.treeCaptureSliceBudgetOverride
@@ -340,6 +344,7 @@ extension RunnerTests {
       recordXCTestSnapshotBackendAttemptIfNeeded(
         kind,
         attempt: attempt,
+        bundleId: target.bundleId,
         penaltySuppressed: suppressXCTestPenalty
       )
       if case let .failed(failure, phase: _) = attempt.outcome {
@@ -356,8 +361,19 @@ extension RunnerTests {
       }
       guard case let .captured(capture) = attempt.outcome else { continue }
-      if let sparseReason = Self.sparsePayloadReason(capture.qualityPayload ?? capture.payload) {
-        if firstFailure == nil { firstFailure = sparseReason }
+      if attempt.tierOutcome == .deadlineExhausted {
+        NSLog(
+          "AGENT_DEVICE_RUNNER_SNAPSHOT_TIER_DEADLINE_EXHAUSTED backend=%@ nodes=%d",
+          kind.rawValue,
+          Self.payloadNodeCount(capture.payload)
+        )
+      }
+      if let rejection = Self.snapshotTierRejectionReason(
+        outcome: attempt.tierOutcome,
+        kind: kind,
+        payload: capture.qualityPayload ?? capture.payload
+      ) {
+        if firstFailure == nil { firstFailure = rejection }
         if Self.payloadNodeCount(capture.payload) > Self.payloadNodeCount(best?.capture.payload) {
           best = (kind, capture)
         }
@@ -412,19 +428,21 @@ extension RunnerTests {
   private func captureWithBackend(
     _ kind: SnapshotBackendKind,
-    app: XCUIApplication,
+    target: SnapshotCaptureTarget,
     options: PresentationOptions,
     deadline: Date,
     treeCaptureSliceBudgetOverride: TimeInterval?
   ) throws -> SnapshotBackendAttempt {
+    let app = target.app
     let hint = SnapshotPresentation.captureHint(for: options)
     var timer = SnapshotPhaseTimer()
     let acquisition: SnapshotAcquisition?
+    let tierOutcome: SnapshotTierOutcome
     var keyboardBand: RunnerKeyboardBandFact?
     do {
-      acquisition = try timer.measure(.acquisition) {
+      let measured = try timer.measure(.acquisition) { () -> (SnapshotAcquisition?, SnapshotTierOutcome) in
         switch kind {
         case .recursiveTree:
           guard
@@ -435,10 +453,10 @@ extension RunnerTests {
               treeCaptureSliceBudgetOverride: treeCaptureSliceBudgetOverride
             )
           else {
-            return nil
+            return (nil, .completed)
           }
           keyboardBand = context.keyboardBand
-          return try self.runMainThreadWork(
+          let tree = try self.runMainThreadWork(
             "tree_processing",
             timeout: min(self.treeCaptureSliceBudget, max(0.5, deadline.timeIntervalSinceNow)),
             timeoutError: self.snapshotMainThreadTimeoutError("processing tree snapshot")
@@ -447,26 +465,34 @@ extension RunnerTests {
               ? try self.rawTreeSnapshotAcquisition(context: context, hint: hint)
               : try self.recursiveTreeSnapshotAcquisition(context: context, hint: hint)
           }
+          return (tree, .completed)
         case .querySweep:
-          return try self.runMainThreadWork(
+          let sliceDeadline = Self.querySweepSliceDeadline(startedAt: Date(), planDeadline: deadline)
+          let sweep = try self.runMainThreadWork(
             "query_sweep",
-            timeout: min(Self.flatInteractiveFallbackBudget, max(0.1, deadline.timeIntervalSinceNow)),
+            timeout: max(0.1, sliceDeadline.timeIntervalSinceNow),
             timeoutError: self.snapshotMainThreadTimeoutError("running query-sweep snapshot")
           ) {
             self.querySweepSnapshotAcquisition(
               app: app,
               hint: hint,
-              planDeadline: deadline
+              sliceDeadline: sliceDeadline
             )
           }
+          return (sweep.acquisition, sweep.outcome)
         case .privateAX:
-          return self.privateAXSnapshotAcquisition(
-            app: app,
-            hint: hint,
-            deadline: deadline
+          return (
+            self.privateAXSnapshotAcquisition(
+              target: target,
+              hint: hint,
+              deadline: deadline
+            ),
+            .completed
           )
         }
       }
+      acquisition = measured.0
+      tierOutcome = measured.1
     } catch let failure as SnapshotCaptureFailure {
       return SnapshotBackendAttempt(
         outcome: .failed(failure, phase: .acquisition),
@@ -476,7 +502,8 @@ extension RunnerTests {
     guard let acquisition else {
       return SnapshotBackendAttempt(
         outcome: .noCapture,
-        timing: timer.timing
+        timing: timer.timing,
+        tierOutcome: tierOutcome
       )
     }
@@ -511,12 +538,14 @@ extension RunnerTests {
     } catch let failure as SnapshotPresentationFailure {
       return SnapshotBackendAttempt(
         outcome: .failed(Self.snapshotCaptureFailure(for: failure), phase: .presentation),
-        timing: timer.timing
+        timing: timer.timing,
+        tierOutcome: tierOutcome
       )
     } catch let failure as SnapshotCaptureFailure {
       return SnapshotBackendAttempt(
         outcome: .failed(failure, phase: .presentation),
-        timing: timer.timing
+        timing: timer.timing,
+        tierOutcome: tierOutcome
       )
     }
@@ -525,7 +554,8 @@ extension RunnerTests {
     capture.keyboardBand = keyboardBand?.payload
     return SnapshotBackendAttempt(
       outcome: .captured(capture),
-      timing: timer.timing
+      timing: timer.timing,
+      tierOutcome: tierOutcome
     )
   }
@@ -547,6 +577,24 @@ extension RunnerTests {
+  static func snapshotTierRejectionReason(
+    outcome: SnapshotTierOutcome,
+    kind: SnapshotBackendKind,
+    payload: DataPayload
+  ) -> (reason: String, code: String)? {
+    if outcome == .deadlineExhausted {
+      return (
+        "the \(kind.rawValue) backend spent its capture slice with the collection unfinished",
+        "budget"
+      )
+    }
+    return sparsePayloadReason(payload)
+  }
   static func sparsePayloadReason(_ payload: DataPayload) -> (reason: String, code: String)? {
     guard let nodes = payload.nodes, !nodes.isEmpty else {
       return ("snapshot returned no nodes", "no-nodes")
@@ -629,13 +677,16 @@ extension RunnerTests {
-  private func stampedSnapshotPayload(
+  func stampedSnapshotPayload(
     _ capture: SnapshotBackendCapture,
     backend: SnapshotBackendKind,
     state: String,
     reason: (reason: String, code: String)?
   ) -> DataPayload {
-    runnerAccessibilityHealth = reason?.code == "ax-rejected" ? .unavailable : .healthy
+    let health: RunnerAccessibilityHealth = reason?.code == "ax-rejected" ? .unavailable : .healthy
+    applyMainOwnedSnapshotState("accessibility_health") {
+      self.runnerAccessibilityHealth = health
+    }
     let payload = capture.payload
     let quality = SnapshotQuality(
       state: state,
@@ -648,8 +699,7 @@ extension RunnerTests {
       timing: capture.timing
     )
     return DataPayload(
-      message: Self.legacyQualityMessage(quality) ?? payload.message,
+      message: payload.message,
       nodes: payload.nodes,
@@ -666,549 +716,4 @@ extension RunnerTests {
       runnerFatalReason: payload.runnerFatalReason
     )
   }
-  static func customActionCoverageWarnings(_ coverage: SnapshotCustomActionCoverage) -> [String] {
-    var lines: [String] = []
-    if coverage.blocked {
-      lines.append(
-        "Custom actions were not read: an earlier accessibility read is still hung, so this "
-          + "capture skipped the read pass instead of queueing behind it. No element's actions "
-          + "list is authoritative here. Reads resume once that call returns.")
-    } else if coverage.read < coverage.candidates {
-      lines.append(
-        "Custom actions were read for \(coverage.read) of \(coverage.candidates) merged elements, "
-          + "on-screen ones first; the remaining \(coverage.candidates - coverage.read) were not read, "
-          + "so an absent actions list on those is not evidence that they have none. "
-          + "Scroll them into view and re-run to read them.")
-    }
-    if coverage.truncated > 0 {
-      lines.append(
-        "\(coverage.truncated) element(s) published more custom actions than are shown; those "
-          + "lists are clipped to the first 8 names, and long names are shortened.")
-    }
-    return lines
-  }
-  static func legacyQualityMessage(_ quality: SnapshotQuality) -> String? {
-    let customActionWarnings =
-      quality.customActions.map { Self.customActionCoverageWarnings($0) } ?? []
-    guard quality.state != "healthy" || quality.collapsedLeafIndexes != nil
-      || !customActionWarnings.isEmpty
-    else { return nil }
-    var parts: [String] = []
-    if quality.state == "recovered" {
-      let meaning: String
-      switch quality.reasonCode {
-      case "budget", "deferred":
-        meaning = " The primary capture ran out of its time budget (busy app or simulator); the recovered tree is authoritative for this screen."
-      case "presentation-failed":
-        meaning = " The runner rejected a regular presentation because its cumulative clip invariant failed; report this as a runner bug and treat screenshot as visual truth."
-      default:
-        meaning = " This usually means the app publishes an unhealthy accessibility tree — fixing the app's accessibility is the real cure. Treat screenshot as visual truth when this warning appears."
-      }
-      parts.append(
-        "Detected an overly complex or slow accessibility tree. Fell back to the \(quality.backend) snapshot backend"
-          + (quality.reason.map { " after: \($0)." } ?? ".")
-          + meaning
-      )
-    }
-    if quality.state == "sparse" {
-      parts.append(
-        "No snapshot backend could read this screen"
-          + (quality.reason.map { " (\($0))" } ?? "")
-          + ". Use screenshot as visual truth and coordinate taps."
-      )
-    }
-    parts.append(contentsOf: customActionWarnings)
-    if let depth = quality.effectiveDepth {
-      parts.append(
-        "The accessibility server rejected deeper requests; content below depth \(depth) may be missing — re-run snapshot to retry deeper content."
-      )
-    }
-    return parts.isEmpty ? nil : parts.joined(separator: " ")
-  }
 }