agent-device 0.20.10 → 0.21.1

package/dist/apple/runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+AXSnapshotFallback.swift

@@ -1,25 +1,26 @@
 import XCTest
+import AgentDeviceSnapshotPresentation
 
 extension RunnerTests {
   private static let privateAXSnapshotMaxNodes = 5_000
 
-  /// Upper bound on element-rooted follow-up snapshot requests per capture. A
-  /// depth-capped Bluesky-class tree resolves in 1-3 chained requests (~100-300ms
-  /// each); the bound exists so a pathological tree cannot stack requests past
-  /// the capture-plan deadline, which is also enforced per call.
-  private static let privateAXDeepExtensionCallLimit = 8
 
-  /// Upper bound on per-element custom-action reads per capture. Each is its own
-  /// AX round trip (~100ms on an idle simulator), so this caps the opt-in cost
-  /// at roughly a second on top of the capture; the capture-plan deadline stops
-  /// it earlier under load. A screenful of merged cards is well under this.
+
+
+
+  static let privateAXDeepExtensionCallLimit = 8
+
+
+
+
+
   private static let privateAXCustomActionLimit = 12
 
-  /// A capture is depth-limited unless its frontier extension resolved every
-  /// capped node: frontiers left pending (budget/deadline) or missed (element
-  /// vanished, re-rooted request failed) mean subtrees are still absent, and
-  /// presenting such a capture as complete would hide exactly the content the
-  /// extension exists to recover. nil extension counts = extension never ran.
+
+
+
+
+
   static func privateAXDepthLimited(
     effectiveDepth: Int,
     requestedDepth: Int,
@@ -30,17 +31,17 @@ extension RunnerTests {
     guard let pendingFrontiers, let missedFrontiers else { return true }
     return pendingFrontiers > 0 || missedFrontiers > 0
   }
-  /// Deep React Native trees make the AX server reject bulk snapshot requests outright with
-  /// kAXErrorIllegalArgument once the requested depth crosses a tree-size-dependent limit
-  /// (observed between depth 56 and 64 on the Bluesky Home feed; the limit moves with live
-  /// content). Retrying the same request at a shallower depth succeeds, so on failure we walk
-  /// this ladder instead of giving up. Capped at 4 attempts to bound worst-case latency on
-  /// apps where the AX surface is genuinely unavailable.
+
+
+
+
+
+
   static let privateAXSnapshotDepthLadder = [56, 40, 24, 12]
 
-  /// Ladder rungs for one capture. A remembered accepted depth (recorded when a prior capture's
-  /// deep request was rejected) drops the rungs above it, so the known-rejected deep request is
-  /// not re-paid on every capture of the same screen class.
+
+
+
   static func privateAXAttemptDepths(requestedDepth: Int, rememberedDepth: Int?) -> [Int] {
     var depths = [requestedDepth]
     depths.append(contentsOf: privateAXSnapshotDepthLadder.filter { $0 < requestedDepth })
@@ -48,17 +49,17 @@ extension RunnerTests {
     return depths.filter { $0 <= remembered }
   }
 
-  /// The bridge omits the key entirely when the capture did not ask for custom
-  /// actions, which is the difference between "nothing to disclose" and "read
-  /// none of them" — so a missing key must stay nil, never (0, 0).
+
+
+
   static func privateAXCustomActionCoverage(_ raw: Any?) -> SnapshotCustomActionCoverage? {
     guard let coverage = raw as? [String: Any],
       let read = (coverage[RunnerAXSnapshotCustomActionsReadKey] as? NSNumber)?.intValue,
       let candidates = (coverage[RunnerAXSnapshotCustomActionsCandidatesKey] as? NSNumber)?.intValue
     else { return nil }
-    // read/candidates are the ratio and must both be present; the truncation
-    // count is additive, so an older bridge that omits it reads as zero rather
-    // than voiding the whole coverage.
+
+
+
     let truncated =
       (coverage[RunnerAXSnapshotCustomActionsTruncatedKey] as? NSNumber)?.intValue ?? 0
     let blocked = (coverage[RunnerAXSnapshotCustomActionsBlockedKey] as? NSNumber)?.boolValue ?? false
@@ -66,9 +67,68 @@ extension RunnerTests {
       read: read, candidates: candidates, truncated: truncated, blocked: blocked)
   }
 
+  struct PrivateAXLadderOutcome {
+    let response: [String: Any]
+    let effectiveDepth: Int
+    let deadlineSpent: Bool
+    let lastError: String
+
+    var succeeded: Bool { response["ok"] as? Bool == true }
+  }
+
+
+
+
+  static func privateAXLadderCapture(
+    attemptDepths: [Int],
+    deadline: Date,
+    capture: (Int) -> [String: Any]
+  ) -> PrivateAXLadderOutcome {
+    var response: [String: Any] = [:]
+    var effectiveDepth = attemptDepths.first ?? 0
+    var lastError = "unknown private AX snapshot failure"
+    for depth in attemptDepths {
+      if depth != attemptDepths.first, Date() >= deadline {
+        NSLog("AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_BUDGET_EXHAUSTED depth=%ld", depth)
+        return PrivateAXLadderOutcome(
+          response: response, effectiveDepth: effectiveDepth, deadlineSpent: true,
+          lastError: lastError)
+      }
+      response = capture(depth)
+      if response["ok"] as? Bool == true {
+        effectiveDepth = depth
+        break
+      }
+      lastError = response["error"] as? String ?? lastError
+      NSLog(
+        "AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_DEPTH_RETRY depth=%ld error=%@",
+        depth,
+        lastError
+      )
+    }
+    return PrivateAXLadderOutcome(
+      response: response, effectiveDepth: effectiveDepth, deadlineSpent: false, lastError: lastError)
+  }
+
+
+
+
+  func recordPrivateAXAcceptedDepth(
+    exactDepthRequested: Bool,
+    effectiveDepth: Int,
+    attemptDepths: [Int]
+  ) {
+    guard !exactDepthRequested, effectiveDepth != attemptDepths.first else { return }
+    rememberPrivateAXAcceptedDepth(
+      bundleId: currentBundleId,
+      processIdentifier: currentAppProcessIdentifier,
+      depth: effectiveDepth
+    )
+  }
+
   func rememberPrivateAXAcceptedDepth(bundleId: String?, processIdentifier: Int?, depth: Int) {
-    // No PID means no way to notice a relaunch later; record nothing rather than risk serving
-    // a stale shallow rung to a fresh process.
+
+
     guard let processIdentifier else { return }
     privateAXAcceptedDepthLock.lock()
     privateAXAcceptedDepthBundleId = bundleId
@@ -105,14 +165,14 @@ extension RunnerTests {
 
   func privateAXSnapshotAcquisition(
     app: XCUIApplication,
-    options: PresentationOptions,
+    hint: CaptureHint,
     deadline: Date = .distantFuture
   ) -> SnapshotAcquisition? {
     #if os(iOS) && targetEnvironment(simulator)
-      let requestedDepth = options.depth ?? 64
-      // An explicit --depth request is honored as asked: no accepted-depth
-      // memory, no frontier extension past it.
-      let exactDepthRequested = options.depth != nil
+      let requestedDepth = hint.rawTraversalDepth ?? 64
+
+
+      let exactDepthRequested = hint.rawTraversalDepth != nil
       let rememberedDepth =
         exactDepthRequested
         ? nil
@@ -124,50 +184,32 @@ extension RunnerTests {
         requestedDepth: requestedDepth,
         rememberedDepth: rememberedDepth
       )
-      var response: [String: Any] = [:]
-      var effectiveDepth = requestedDepth
-      var lastError = "unknown private AX snapshot failure"
-      for depth in attemptDepths {
-        // The first rung always runs (the plan gated entry on its own budget); later rungs
-        // stop when the capture-plan deadline is spent so ladder retries can never stack
-        // past the runner's main-thread watchdog (#1105).
-        if depth != attemptDepths.first, Date() >= deadline {
-          NSLog("AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_BUDGET_EXHAUSTED depth=%ld", depth)
-          break
-        }
-        response = RunnerAXSnapshotBridge.snapshotTree(
+
+
+
+
+      let ladder = Self.privateAXLadderCapture(attemptDepths: attemptDepths, deadline: deadline) {
+        depth in
+        RunnerAXSnapshotBridge.snapshotTree(
           for: app,
           maxDepth: depth,
           maxNodes: Self.privateAXSnapshotMaxNodes,
           deepExtensionCallLimit: exactDepthRequested ? 0 : Self.privateAXDeepExtensionCallLimit,
-          customActionLimit: options.customActions ? Self.privateAXCustomActionLimit : 0,
+          customActionLimit: hint.customActions ? Self.privateAXCustomActionLimit : 0,
           deadline: deadline
         )
-        if response["ok"] as? Bool == true {
-          effectiveDepth = depth
-          break
-        }
-        lastError = response["error"] as? String ?? lastError
-        NSLog(
-          "AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_DEPTH_RETRY depth=%ld error=%@",
-          depth,
-          lastError
-        )
       }
-      guard response["ok"] as? Bool == true else {
-        NSLog("AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_FAILED=%@", lastError)
+      let response = ladder.response
+      let effectiveDepth = ladder.effectiveDepth
+      guard ladder.succeeded else {
+        NSLog("AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_FAILED=%@", ladder.lastError)
         return nil
       }
-      // Only a capture that actually descended records memory: a first-rung success on a
-      // remembered depth deliberately does NOT refresh the TTL, so expiry re-probes the full
-      // requested depth once per window instead of capping this screen class forever.
-      if !exactDepthRequested, effectiveDepth != attemptDepths.first {
-        rememberPrivateAXAcceptedDepth(
-          bundleId: currentBundleId,
-          processIdentifier: currentAppProcessIdentifier,
-          depth: effectiveDepth
-        )
-      }
+      recordPrivateAXAcceptedDepth(
+        exactDepthRequested: exactDepthRequested,
+        effectiveDepth: effectiveDepth,
+        attemptDepths: attemptDepths
+      )
       guard let root = response["root"] as? [String: Any] else {
         NSLog("AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_FAILED=missing root")
         return nil
@@ -175,20 +217,22 @@ extension RunnerTests {
 
       let rootFrame = privateAXRect(root["frame"])
       let viewport = privateAXSnapshotViewport(app: app, rootFrame: rootFrame)
-      let nodes = privateAXPresentation(
+      let nodes = privateAXAcquisition(
         rawRoot: root,
-        options: options,
+        hint: hint,
         viewport: viewport
       )
+
+
       if nodes.count <= 1 {
         NSLog("AGENT_DEVICE_RUNNER_PRIVATE_AX_SNAPSHOT_SPARSE=%ld", nodes.count)
         return nil
       }
 
-      // A capture whose frontier extension resolved every capped node is
-      // complete despite the per-request depth cap — reporting it as
-      // depth-limited would send agents chasing deeper content that is not
-      // there. Pending or missed frontiers keep the depth-limited verdict.
+
+
+
+
       let deepExtension = response[RunnerAXSnapshotDeepExtensionKey] as? [String: Any]
       let depthLimited = Self.privateAXDepthLimited(
         effectiveDepth: effectiveDepth,
@@ -203,22 +247,24 @@ extension RunnerTests {
         deepExtension?[RunnerAXSnapshotDeepExtensionNodesAddedKey] as? Int ?? 0
       )
       return SnapshotAcquisition(
+        hint: hint,
         nodes: nodes,
         truncated: (response["truncated"] as? Bool) == true,
         effectiveDepth: depthLimited ? effectiveDepth : nil,
         customActions: Self.privateAXCustomActionCoverage(
           response[RunnerAXSnapshotCustomActionsKey]
-        )
+        ),
+        viewport: viewport
       )
     #else
       return nil
     #endif
   }
 
-  /// The viewport read is XCTest main-thread work — the exact channel the penalty marks as
-  /// grinding on this screen class. Under penalty it reliably burns its full timeout and
-  /// falls back anyway (~1s added to every private AX capture on the Bluesky bench feed),
-  /// so honor the penalty here the same way capture plans do.
+
+
+
+
   func shouldReadPrivateAXViewportViaXCTest() -> Bool {
     !hasAbandonedTreeCapture() && !isSnapshotXCTestChannelPenalized(bundleId: currentBundleId)
   }
@@ -230,7 +276,6 @@ extension RunnerTests {
     }
     do {
       let viewport = try runMainThreadWork(
-        command: nil,
         timeout: 1,
         timeoutError: snapshotMainThreadTimeoutError("reading private AX viewport")
       ) {
@@ -265,3 +310,552 @@ extension RunnerTests {
   }
 }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+