agent-device 0.16.9 → 0.16.10

package/ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+Transport.swift

@@ -19,7 +19,11 @@ extension RunnerTests {
       if buffer.count + data.count > self.maxRequestBytes {
         let response = self.jsonResponse(
           status: 413,
-          response: Response(ok: false, error: ErrorPayload(message: "request too large"))
+          response: self.errorResponse(
+            code: "INVALID_ARGS",
+            message: "runner request body exceeds \(self.maxRequestBytes) bytes",
+            hint: "Send one runner command per request and keep the payload below the runner request limit."
+          )
         )
         self.sendResponse(response, over: connection) { [weak self] in
           self?.finish()
@@ -28,10 +32,11 @@ extension RunnerTests {
       }
       let combined = buffer + data
       if let body = self.parseRequest(data: combined) {
-        let result = self.handleRequestBody(body)
-        self.sendResponse(result.data, over: connection) { [weak self] in
-          if result.shouldFinish {
-            self?.finish()
+        self.handleRequestBody(body) { [weak self] result in
+          self?.sendResponse(result.data, over: connection) { [weak self] in
+            if result.shouldFinish {
+              self?.finish()
+            }
           }
         }
       } else {
@@ -82,29 +87,62 @@ extension RunnerTests {
     return nil
   }
 
-  private func handleRequestBody(_ body: Data) -> (data: Data, shouldFinish: Bool) {
-    guard let json = String(data: body, encoding: .utf8) else {
-      return (
-        jsonResponse(status: 400, response: Response(ok: false, error: ErrorPayload(message: "invalid json"))),
-        false
-      )
-    }
-    guard let data = json.data(using: .utf8) else {
-      return (
-        jsonResponse(status: 400, response: Response(ok: false, error: ErrorPayload(message: "invalid json"))),
+  private func handleRequestBody(
+    _ body: Data,
+    completion: @escaping ((data: Data, shouldFinish: Bool)) -> Void
+  ) {
+    guard String(data: body, encoding: .utf8) != nil else {
+      completion((
+        jsonResponse(
+          status: 400,
+          response: errorResponse(
+            code: "INVALID_ARGS",
+            message: "runner request body must be UTF-8 JSON",
+            hint: "Send a JSON object matching the runner command protocol."
+          )
+        ),
         false
-      )
+      ))
+      return
     }
 
     do {
-      let command = try JSONDecoder().decode(Command.self, from: data)
-      let response = try execute(command: command)
-      return (jsonResponse(status: 200, response: response), command.command == .shutdown)
+      let command = try JSONDecoder().decode(Command.self, from: body)
+      if command.command == .status {
+        completion((jsonResponse(status: 200, response: executeStatus(command: command)), false))
+        return
+      }
+      commandJournal.accept(command: command)
+      commandExecutionQueue.async {
+        do {
+          let response = try self.executeAccepted(command: command)
+          completion((self.jsonResponse(status: 200, response: response), command.command == .shutdown))
+        } catch {
+          completion((
+            self.jsonResponse(
+              status: 500,
+              response: self.errorResponse(
+                code: "COMMAND_FAILED",
+                message: error.localizedDescription,
+                hint: "Check the runner log for XCTest details, then retry after the app is foregrounded if this was a timeout or activation failure."
+              )
+            ),
+            false
+          ))
+        }
+      }
     } catch {
-      return (
-        jsonResponse(status: 500, response: Response(ok: false, error: ErrorPayload(message: "\(error)"))),
+      completion((
+        jsonResponse(
+          status: 400,
+          response: errorResponse(
+            code: "INVALID_ARGS",
+            message: "runner command payload is invalid: \(String(describing: error))",
+            hint: "Check the command name and fields against the runner protocol."
+          )
+        ),
         false
-      )
+      ))
     }
   }
 
@@ -116,6 +154,10 @@ extension RunnerTests {
     return httpResponse(status: status, body: body)
   }
 
+  private func errorResponse(code: String, message: String, hint: String? = nil) -> Response {
+    Response(ok: false, error: ErrorPayload(code: code, message: message, hint: hint))
+  }
+
   private func httpResponse(status: Int, body: String) -> Data {
     let headers = [
       "HTTP/1.1 \(status) OK",

package/ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests.swift

@@ -32,6 +32,8 @@ final class RunnerTests: XCTestCase {
   static let defaultRecordingFps: Int32 = 15
   var listener: NWListener?
   var doneExpectation: XCTestExpectation?
+  let transportQueue = DispatchQueue(label: "agent-device.runner.transport")
+  let commandExecutionQueue = DispatchQueue(label: "agent-device.runner.commands")
   let app = XCUIApplication()
   lazy var springboard = XCUIApplication(bundleIdentifier: Self.springboardBundleId)
   var currentApp: XCUIApplication?
@@ -53,6 +55,7 @@ final class RunnerTests: XCTestCase {
   var needsPostSnapshotInteractionDelay = false
   var needsFirstInteractionDelay = false
   var activeRecording: ScreenRecorder?
+  let commandJournal = RunnerCommandJournal()
   let interactiveTypes: Set<XCUIElement.ElementType> = [
     .button,
     .cell,
@@ -91,7 +94,6 @@ final class RunnerTests: XCTestCase {
   func testCommand() throws {
     doneExpectation = expectation(description: "agent-device command handled")
     NSLog("AGENT_DEVICE_RUNNER_HEADLESS_STARTUP=1")
-    let queue = DispatchQueue(label: "agent-device.runner")
     let desiredPort = RunnerEnv.resolvePort()
     NSLog("AGENT_DEVICE_RUNNER_DESIRED_PORT=%d", desiredPort)
     listener = try makeRunnerListener(desiredPort: desiredPort)
@@ -112,10 +114,11 @@ final class RunnerTests: XCTestCase {
       }
     }
     listener?.newConnectionHandler = { [weak self] conn in
-      conn.start(queue: queue)
-      self?.handle(connection: conn)
+      guard let self else { return }
+      conn.start(queue: self.transportQueue)
+      self.handle(connection: conn)
     }
-    listener?.start(queue: queue)
+    listener?.start(queue: transportQueue)
 
     guard let expectation = doneExpectation else {
       XCTFail("runner expectation was not initialized")

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-device",
-  "version": "0.16.9",
+  "version": "0.16.10",
   "description": "Agent-native CLI for AI mobile testing and app automation across iOS, Android, tvOS, Android TV, macOS, and Linux.",
   "mcpName": "io.github.callstackincubator/agent-device",
   "license": "MIT",

package/server.json

@@ -7,12 +7,12 @@
     "url": "https://github.com/callstackincubator/agent-device",
     "source": "github"
   },
-  "version": "0.16.9",
+  "version": "0.16.10",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "agent-device",
-      "version": "0.16.9",
+      "version": "0.16.10",
       "transport": {
         "type": "stdio"
       }

package/android-multitouch-helper/dist/agent-device-android-multitouch-helper-0.16.9.apk.sha256

@@ -1 +0,0 @@
-5e33b9281e0c508ae6605bcd6766a859467939aae2e9fde22414a37e0f577602  agent-device-android-multitouch-helper-0.16.9.apk

package/android-snapshot-helper/dist/agent-device-android-snapshot-helper-0.16.9.apk.sha256

@@ -1 +0,0 @@
-5d1106a1696ba569c2497666e80f9e2f0ba8d44072613a4491242e1118885f1a  agent-device-android-snapshot-helper-0.16.9.apk