agent-dealer 1.3.4 → 1.3.5

package/bundle/server/dist/coordinator/operator-verification.integration.test.js

@@ -358,13 +358,15 @@ function recordVisualEvidence(issueId, opts) {
             baseSha: "base1",
             uiAffecting: true,
             state: opts.state,
-            runId: opts.state === "missing" ? null : 42,
+            runId: opts.state === "available" || opts.state === "failed" ? 42 : null,
             artifactNames: opts.state === "available" ? ["ui-screenshots", "ui-baseline", "ui-diff"] : [],
             reason: opts.state === "available"
                 ? null
                 : opts.state === "failed"
                     ? "Visual run 42 for this head concluded failure — its captures are unusable"
-                    : "no Visual workflow run found for head abc123",
+                    : opts.state === "not_applicable"
+                        ? "repository has no Visual workflow (workflow visual.yml not found on the default branch) — nothing to capture"
+                        : "no Visual workflow run found for head abc123",
         },
         author: "system",
     });
@@ -420,6 +422,22 @@ test("NOT-384: available visual evidence on a UI head merges normally", async ()
     assert.deepEqual(calls, [{ cwd: managedCwd, number: 42 }]);
     assert.equal(getIssue(issueId).status, "done");
 });
+test("NOT-538: not_applicable visual evidence (no Visual workflow) on a UI head merges normally", async () => {
+    const calls = [];
+    setMergePrForTests(async (opts) => {
+        calls.push(opts);
+        return { ok: true };
+    });
+    const issueId = newIssue("It works");
+    startWorkflow(issueId);
+    recordVisualEvidence(issueId, { headSha: "abc123", state: "not_applicable" });
+    const result = await approve(issueId);
+    assert.equal(result.applied, true);
+    if (result.applied)
+        assert.equal(result.issueStatus, "done");
+    assert.deepEqual(calls, [{ cwd: managedCwd, number: 42 }]);
+    assert.equal(getIssue(issueId).status, "done");
+});
 test("NOT-384: [operator] criteria plus a visual hold raise one action naming both", async () => {
     let merges = 0;
     setMergePrForTests(async () => {

package/bundle/server/dist/coordinator/reviewer-visual-evidence.js

@@ -22,8 +22,10 @@
 //     Dealer's issue-artifact storage, stage a read-only copy inside the
 //     reviewer's worktree (outside tracked paths, ignored by `isWorktreeClean`),
 //     and record one `visual_evidence` artifact row. It never throws: every
-//     failure mode resolves to `missing` with a reason, and a missing or
-//     failed capture never counts as a visual pass.
+//     failure mode resolves to `missing` with a reason — except a lookup 404
+//     proving the repository has no `visual.yml`, which resolves to
+//     `not_applicable` (nothing to capture) — and a missing or failed capture
+//     never counts as a visual pass.
 //  4. `readVisualEvidenceHold` — the merge-gate reader (auto-merge.ts): a
 //     UI-affecting head whose recorded evidence is `missing` or `failed` holds
 //     for `operator_verification` instead of merging or queuing a repair round.
@@ -334,6 +336,24 @@ function truncateReason(text, maxChars = 300) {
     const oneLine = text.replace(/\s+/g, " ").trim();
     return oneLine.length > maxChars ? `${oneLine.slice(0, maxChars).trimEnd()}…` : oneLine;
 }
+/**
+ * NOT-538: true when a Visual run lookup failure means the repository's
+ * default branch has no `visual.yml` (`gh run list --workflow visual.yml`
+ * answers HTTP 404: "workflow visual.yml not found on the default branch"),
+ * rather than a transient or auth failure. Deliberately narrow — all three
+ * markers must be present — so auth, network, 5xx, and rate-limit failures
+ * keep failing closed to `missing`.
+ */
+export function isVisualWorkflowNotFoundError(message) {
+    const text = message.toLowerCase();
+    return text.includes("404") && text.includes("visual.yml") && text.includes("not found");
+}
+/**
+ * NOT-538: the recorded reason when the lookup proves the repository has no
+ * Visual workflow. The head still matches the UI paths (`uiAffecting: true`),
+ * but there is nothing to capture, so the merge gate must not hold.
+ */
+export const VISUAL_WORKFLOW_ABSENT_REASON = "repository has no Visual workflow (workflow visual.yml not found on the default branch) — nothing to capture";
 function noEvidence(uiAffecting, base, reason) {
     return {
         ...base,
@@ -357,7 +377,9 @@ function noEvidence(uiAffecting, base, reason) {
  *
  * Never throws and never returns usable evidence it does not have: unknown
  * changed files fail closed to UI-affecting + `missing`, and every lookup,
- * download, stage, or record failure degrades to `missing` with a reason.
+ * download, stage, or record failure degrades to `missing` with a reason —
+ * except a lookup 404 proving the repository has no Visual workflow, which
+ * records `not_applicable` instead (NOT-538).
  */
 export async function resolveReviewerVisualEvidence(opts) {
     const base = { headSha: opts.headSha, baseSha: opts.baseSha };
@@ -411,7 +433,25 @@ export async function resolveReviewerVisualEvidence(opts) {
             run = await fetcher.findRunForHead({ cwd: opts.worktreePath, headSha: opts.headSha });
         }
         catch (err) {
-            const resolved = noEvidence(true, base, `Visual run lookup failed: ${truncateReason(err instanceof Error ? err.message : String(err))}`);
+            const message = err instanceof Error ? err.message : String(err);
+            if (isVisualWorkflowNotFoundError(message)) {
+                const resolved = {
+                    ...base,
+                    uiAffecting: true,
+                    state: "not_applicable",
+                    runId: null,
+                    artifactNames: [],
+                    stagedDir: null,
+                    summaryChars: null,
+                    reason: VISUAL_WORKFLOW_ABSENT_REASON,
+                    staged: null,
+                    summary: null,
+                    files: null,
+                };
+                record(resolved, null);
+                return resolved;
+            }
+            const resolved = noEvidence(true, base, `Visual run lookup failed: ${truncateReason(message)}`);
             record(resolved, null);
             return resolved;
         }

package/bundle/server/dist/coordinator/reviewer-visual-evidence.test.js

@@ -17,7 +17,7 @@ const { createIssue } = await import("../repository/issues.js");
 const { createIssueArtifact } = await import("../repository/artifacts.js");
 const { listArtifactsForIssueByKind } = await import("../repository/artifacts-for-issue.js");
 const { isWorktreeClean, REVIEWER_VISUAL_STAGING_DIR_NAME } = await import("../adapters/git-worktree.js");
-const { VISUAL_WORKFLOW_PATHS, VISUAL_ARTIFACT_NAMES, VISUAL_EVIDENCE_ARTIFACT_KIND, isUiAffectingChange, classifyVisualEvidence, githubVisualEvidenceFetcher, resolveReviewerVisualEvidence, stageVisualArtifacts, cleanupStagedVisualArtifacts, readVisualDiffSummary, reviewerVisualStagingDir, toReviewerVisualEvidenceInput, readVisualEvidenceHold, } = await import("./reviewer-visual-evidence.js");
+const { VISUAL_WORKFLOW_PATHS, VISUAL_ARTIFACT_NAMES, VISUAL_EVIDENCE_ARTIFACT_KIND, VISUAL_WORKFLOW_ABSENT_REASON, isUiAffectingChange, classifyVisualEvidence, githubVisualEvidenceFetcher, resolveReviewerVisualEvidence, stageVisualArtifacts, cleanupStagedVisualArtifacts, readVisualDiffSummary, reviewerVisualStagingDir, toReviewerVisualEvidenceInput, readVisualEvidenceHold, } = await import("./reviewer-visual-evidence.js");
 before(() => migrate());
 beforeEach(() => {
     getDb().exec(`
@@ -285,6 +285,8 @@ function fixtureFetcher(opts) {
     return {
         calls,
         async findRunForHead() {
+            if (opts.failLookupError !== undefined)
+                throw new Error(opts.failLookupError);
             if (opts.failLookup)
                 throw new Error("gh exploded");
             return opts.run === undefined
@@ -494,3 +496,129 @@ test("NOT-384: gate reader holds only UI heads with missing/failed evidence at t
     });
     assert.equal(readVisualEvidenceHold(nonUiIssue, HEAD), null);
 });
+// NOT-538: a repository whose default branch has no visual.yml has nothing to
+// capture — the lookup's "workflow not found" 404 resolves to not_applicable
+// (the head still matches the UI paths) instead of holding the PR.
+test("NOT-538: workflow-not-found 404 records not_applicable, never missing", async () => {
+    const issueId = makeIssue();
+    const worktree = initRepo();
+    try {
+        const resolved = await resolveReviewerVisualEvidence({
+            issueId,
+            worktreePath: worktree,
+            baseSha: "c".repeat(40),
+            headSha: HEAD,
+            changedFiles: ["packages/shared/src/types.ts"],
+            github: {},
+            fetcher: fixtureFetcher({
+                failLookupError: "gh run list failed: HTTP 404: workflow visual.yml not found on the default branch",
+            }),
+        });
+        assert.equal(resolved.state, "not_applicable");
+        assert.equal(resolved.uiAffecting, true);
+        assert.equal(resolved.runId, null);
+        assert.equal(resolved.staged, null);
+        assert.equal(resolved.reason, VISUAL_WORKFLOW_ABSENT_REASON);
+        assert.match(resolved.reason, /repository has no Visual workflow/);
+        assert.equal(toReviewerVisualEvidenceInput(resolved), undefined);
+        const rows = listArtifactsForIssueByKind(issueId, VISUAL_EVIDENCE_ARTIFACT_KIND);
+        assert.equal(rows.length, 1);
+        const content = JSON.parse(rows[0].contentJson);
+        assert.equal(content.state, "not_applicable");
+        assert.equal(content.uiAffecting, true);
+        // The recorded workflow-absent record releases the merge gate.
+        assert.equal(readVisualEvidenceHold(issueId, HEAD), null);
+    }
+    finally {
+        fs.rmSync(worktree, { recursive: true, force: true });
+    }
+});
+// NOT-538: every other lookup failure still fails closed to missing with the
+// existing reason — only the workflow-not-found 404 skips the gate.
+test("NOT-538: auth, network, 5xx, and rate-limit lookup failures still record missing", async () => {
+    const worktree = initRepo();
+    try {
+        const failures = {
+            auth: "gh run list failed: HTTP 401: Bad credentials",
+            network: "gh run list failed: Could not resolve host: api.github.com",
+            server: "gh run list failed: HTTP 502: Bad Gateway",
+            rateLimit: "gh run list failed: HTTP 403: API rate limit exceeded for user ID 123",
+        };
+        for (const [kind, message] of Object.entries(failures)) {
+            const resolved = await resolveReviewerVisualEvidence({
+                issueId: makeIssue(),
+                worktreePath: worktree,
+                baseSha: "c".repeat(40),
+                headSha: HEAD,
+                changedFiles: ["packages/shared/src/types.ts"],
+                github: {},
+                fetcher: fixtureFetcher({ failLookupError: message }),
+            });
+            assert.equal(resolved.state, "missing", `${kind} failure must stay missing`);
+            assert.equal(resolved.uiAffecting, true);
+            assert.match(resolved.reason, /^Visual run lookup failed: /, `${kind} failure keeps the lookup-failed reason`);
+        }
+        // Near-miss 404s that do not name the missing workflow also stay missing.
+        for (const message of [
+            "gh run list failed: HTTP 404: Not Found",
+            "gh run list failed: HTTP 404: repository not found",
+        ]) {
+            const resolved = await resolveReviewerVisualEvidence({
+                issueId: makeIssue(),
+                worktreePath: worktree,
+                baseSha: "c".repeat(40),
+                headSha: HEAD,
+                changedFiles: ["packages/shared/src/types.ts"],
+                github: {},
+                fetcher: fixtureFetcher({ failLookupError: message }),
+            });
+            assert.equal(resolved.state, "missing", `${message} must stay missing`);
+        }
+    }
+    finally {
+        fs.rmSync(worktree, { recursive: true, force: true });
+    }
+});
+// NOT-538: the gate reader releases a UI-affecting head whose record is
+// not_applicable because the repository has no Visual workflow, and still
+// holds missing and failed.
+test("NOT-538: gate reader releases workflow-absent not_applicable, holds missing and failed", () => {
+    const absentIssue = makeIssue();
+    createIssueArtifact({
+        issueId: absentIssue,
+        kind: VISUAL_EVIDENCE_ARTIFACT_KIND,
+        content: {
+            headSha: HEAD,
+            uiAffecting: true,
+            state: "not_applicable",
+            reason: VISUAL_WORKFLOW_ABSENT_REASON,
+            runId: null,
+            artifactNames: [],
+        },
+        author: "system",
+    });
+    assert.equal(readVisualEvidenceHold(absentIssue, HEAD), null);
+    const missingIssue = makeIssue();
+    createIssueArtifact({
+        issueId: missingIssue,
+        kind: VISUAL_EVIDENCE_ARTIFACT_KIND,
+        content: {
+            headSha: HEAD,
+            uiAffecting: true,
+            state: "missing",
+            reason: "Visual run lookup failed: HTTP 502: Bad Gateway",
+            runId: null,
+            artifactNames: [],
+        },
+        author: "system",
+    });
+    assert.equal(readVisualEvidenceHold(missingIssue, HEAD).state, "missing");
+    const failedIssue = makeIssue();
+    createIssueArtifact({
+        issueId: failedIssue,
+        kind: VISUAL_EVIDENCE_ARTIFACT_KIND,
+        content: { headSha: HEAD, uiAffecting: true, state: "failed", reason: "boom", runId: 9, artifactNames: [] },
+        author: "system",
+    });
+    assert.equal(readVisualEvidenceHold(failedIssue, HEAD).state, "failed");
+});

package/bundle/server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agent-dealer/server",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "type": "module",
   "main": "dist/index.js",
   "files": [
@@ -23,7 +23,7 @@
     "test": "AGENT_DEALER_SKIP_GITHUB_HEALTH=1 AGENT_DEALER_SKIP_AGENT_HEALTH=1 npm run build -w @agent-dealer/shared && AGENT_DEALER_SKIP_GITHUB_HEALTH=1 AGENT_DEALER_SKIP_AGENT_HEALTH=1 node ../../scripts/run-workspace-tests.mjs"
   },
   "dependencies": {
-    "@agent-dealer/shared": "1.3.4",
+    "@agent-dealer/shared": "1.3.5",
     "@fastify/cors": "^11.0.1",
     "@fastify/static": "^8.2.0",
     "@modelcontextprotocol/sdk": "^1.29.0",

package/bundle/shared/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agent-dealer/shared",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "type": "module",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-dealer",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "description": "Human control plane for agent execution — queue, plan approval, audit",
   "license": "MIT",
   "type": "module",