agent-dealer 1.3.3 → 1.3.5

package/bundle/server/static-ui/index.html

@@ -8,8 +8,8 @@
     <link rel="apple-touch-icon" href="/apple-touch-icon.png" />
     <meta name="theme-color" content="#0a0e14" />
     <link rel="preload" href="/fonts/Monaco.ttf" as="font" type="font/ttf" crossorigin />
-    <script type="module" crossorigin src="/assets/index-B_pNUDRY.js"></script>
-    <link rel="stylesheet" crossorigin href="/assets/index-DL8mEXzN.css">
+    <script type="module" crossorigin src="/assets/index-CrLQFFpw.js"></script>
+    <link rel="stylesheet" crossorigin href="/assets/index-CHCiztRI.css">
   </head>
   <body>
     <div id="root"></div>

package/bundle/shared/dist/issues.d.ts

@@ -96,8 +96,8 @@ export declare const Issue: z.ZodObject<{
     prUrl: z.ZodNullable<z.ZodString>;
     /**
      * When true, reviewer `approved` merges the PR and marks the issue done (skips
-     * `final_review`). Kick UI defaults this on; API/CLI omit → false so existing
-     * callers keep the human final-review path.
+     * `final_review`). NOT-489: every create surface (web, API, CLI, agents) defaults
+     * this on; `false` is the explicit opt-in to final human review.
      */
     autoMerge: z.ZodBoolean;
     createdAt: z.ZodString;
@@ -197,7 +197,10 @@ export declare const CreateIssueInput: z.ZodObject<{
     reviewerAgentId: z.ZodString;
     maxReviewRounds: z.ZodDefault<z.ZodNumber>;
     maxInfraAttempts: z.ZodDefault<z.ZodNumber>;
-    /** Kick UI sends true; omit/false preserves final_review after approve. */
+    /**
+     * NOT-489: omitted means auto-merge (reviewer approval enters the guarded merge path);
+     * only an explicit `false` parks the approved PR at final human review.
+     */
     autoMerge: z.ZodDefault<z.ZodBoolean>;
     source: z.ZodDefault<z.ZodEnum<["manual", "linear", "agent"]>>;
     externalId: z.ZodOptional<z.ZodString>;
@@ -438,8 +441,8 @@ export declare const CreateIssueResult: z.ZodObject<{
     prUrl: z.ZodNullable<z.ZodString>;
     /**
      * When true, reviewer `approved` merges the PR and marks the issue done (skips
-     * `final_review`). Kick UI defaults this on; API/CLI omit → false so existing
-     * callers keep the human final-review path.
+     * `final_review`). NOT-489: every create surface (web, API, CLI, agents) defaults
+     * this on; `false` is the explicit opt-in to final human review.
      */
     autoMerge: z.ZodBoolean;
     createdAt: z.ZodString;

package/bundle/shared/dist/issues.js

@@ -69,8 +69,8 @@ export const Issue = z.object({
     prUrl: z.string().nullable(),
     /**
      * When true, reviewer `approved` merges the PR and marks the issue done (skips
-     * `final_review`). Kick UI defaults this on; API/CLI omit → false so existing
-     * callers keep the human final-review path.
+     * `final_review`). NOT-489: every create surface (web, API, CLI, agents) defaults
+     * this on; `false` is the explicit opt-in to final human review.
      */
     autoMerge: z.boolean(),
     createdAt: z.string(),
@@ -87,8 +87,11 @@ export const CreateIssueInput = z.object({
     reviewerAgentId: z.string().uuid(),
     maxReviewRounds: z.number().int().min(1).default(3),
     maxInfraAttempts: z.number().int().min(0).default(3),
-    /** Kick UI sends true; omit/false preserves final_review after approve. */
-    autoMerge: z.boolean().default(false),
+    /**
+     * NOT-489: omitted means auto-merge (reviewer approval enters the guarded merge path);
+     * only an explicit `false` parks the approved PR at final human review.
+     */
+    autoMerge: z.boolean().default(true),
     source: IssueSource.default("manual"),
     externalId: z.string().optional(),
     externalLabel: z.string().optional(),

package/bundle/shared/dist/issues.test.js

@@ -62,9 +62,19 @@ test("CreateIssueInput defaults baseBranch to main and maxReviewRounds to 3", ()
     assert.equal(parsed.baseBranch, "main");
     assert.equal(parsed.maxReviewRounds, 3);
     assert.equal(parsed.source, "manual");
-    assert.equal(parsed.autoMerge, false);
     assert.equal(parsed.repo, "github.com/acme/app");
 });
+test("NOT-489: CreateIssueInput defaults an omitted autoMerge to true and preserves an explicit false", () => {
+    const base = {
+        title: "Fix login bug",
+        repo: "acme/app",
+        developerAgentId: "22222222-2222-2222-2222-222222222222",
+        reviewerAgentId: "33333333-3333-3333-3333-333333333333"
+    };
+    assert.equal(CreateIssueInput.parse(base).autoMerge, true);
+    assert.equal(CreateIssueInput.parse({ ...base, autoMerge: false }).autoMerge, false);
+    assert.equal(CreateIssueInput.parse({ ...base, autoMerge: true }).autoMerge, true);
+});
 test("CreateIssueInput rejects local filesystem paths (NOT-149)", () => {
     assert.throws(() => CreateIssueInput.parse({
         title: "Local",

package/bundle/shared/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agent-dealer/shared",
-  "version": "1.3.3",
+  "version": "1.3.5",
   "type": "module",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",

package/dist/index.js

@@ -17,7 +17,7 @@ function printUsage() {
   agent-dealer install [--to VERSION] [--migrate-cli] [--purge-global]
   agent-dealer upgrade [--to VERSION] [--yes] [--check]
   agent-dealer agent list
-  agent-dealer issue create --title T --repo owner/repo --developer-agent ID --reviewer-agent ID [--description D] [--acceptance-criteria A] [--base-branch B] [--no-enqueue]
+  agent-dealer issue create --title T --repo owner/repo --developer-agent ID --reviewer-agent ID [--description D] [--acceptance-criteria A] [--base-branch B] [--no-enqueue] [--no-auto-merge]
   agent-dealer issue import --external-id ID --title T --repo owner/repo --developer-agent ID --reviewer-agent ID [--external-label L]
   agent-dealer issue list [--status S1,S2]
   agent-dealer issue show <id> [--include evidence]

package/dist/issue.d.ts

@@ -8,6 +8,7 @@ export type ParsedIssueArgs = {
     acceptanceCriteria?: string;
     baseBranch?: string;
     enqueue: boolean;
+    autoMerge: boolean;
 } | {
     subcommand: "import";
     externalId: string;

package/dist/issue.js

@@ -48,7 +48,8 @@ export function parseIssueArgs(args) {
                 return { subcommand: "import", externalId, externalLabel: flag(rest, "--external-label"), title, repo, developerAgentId, reviewerAgentId };
             }
             // NOT-118: create enqueues for admission by default; --no-enqueue leaves a draft out.
-            return { subcommand: "create", title, repo, developerAgentId, reviewerAgentId, description: flag(rest, "--description"), acceptanceCriteria: flag(rest, "--acceptance-criteria"), baseBranch: flag(rest, "--base-branch"), enqueue: !rest.includes("--no-enqueue") };
+            // NOT-489: auto-merge by default; --no-auto-merge opts into final human review.
+            return { subcommand: "create", title, repo, developerAgentId, reviewerAgentId, description: flag(rest, "--description"), acceptanceCriteria: flag(rest, "--acceptance-criteria"), baseBranch: flag(rest, "--base-branch"), enqueue: !rest.includes("--no-enqueue"), autoMerge: !rest.includes("--no-auto-merge") };
         }
         case "list": {
             return { subcommand: "list", status: flag(rest, "--status") };
@@ -111,7 +112,7 @@ export async function runIssueCommand(args) {
     try {
         switch (parsed.subcommand) {
             case "create": {
-                const result = (await apiFetch("/api/issues", { method: "POST", body: { title: parsed.title, repo: parsed.repo, developerAgentId: parsed.developerAgentId, reviewerAgentId: parsed.reviewerAgentId, description: parsed.description, acceptanceCriteria: parsed.acceptanceCriteria, baseBranch: parsed.baseBranch, source: "agent", enqueue: parsed.enqueue } }));
+                const result = (await apiFetch("/api/issues", { method: "POST", body: { title: parsed.title, repo: parsed.repo, developerAgentId: parsed.developerAgentId, reviewerAgentId: parsed.reviewerAgentId, description: parsed.description, acceptanceCriteria: parsed.acceptanceCriteria, baseBranch: parsed.baseBranch, source: "agent", enqueue: parsed.enqueue, autoMerge: parsed.autoMerge } }));
                 console.log(JSON.stringify(result, null, 2));
                 // stdout stays pure JSON for agents that pipe it — the hint goes to stderr.
                 console.error(createOutcomeHint(result));

package/dist/issue.test.js

@@ -84,6 +84,43 @@ test("issue create sends enqueue:true by default and enqueue:false with --no-enq
         draft.restore();
     }
 });
+test("NOT-489: issue create sends autoMerge:true by default and autoMerge:false only with --no-auto-merge", async () => {
+    const args = ["create", "--title", "T", "--repo", "owner/repo", "--developer-agent", "a1", "--reviewer-agent", "a2"];
+    assert.equal(parseIssueArgs(args).autoMerge, true);
+    assert.equal(parseIssueArgs([...args, "--no-auto-merge"]).autoMerge, false);
+    const byDefault = stubFetch("/api/issues", "POST", { id: "i1", status: "ready", created: true, queue: "enqueued", priorPasses: 0 });
+    try {
+        assert.equal(await runIssueCommand(args), 0);
+        assert.deepEqual(byDefault.assertCalled(), {
+            title: "T",
+            repo: "owner/repo",
+            developerAgentId: "a1",
+            reviewerAgentId: "a2",
+            source: "agent",
+            enqueue: true,
+            autoMerge: true,
+        });
+    }
+    finally {
+        byDefault.restore();
+    }
+    const optedOut = stubFetch("/api/issues", "POST", { id: "i2", status: "ready", created: true, queue: "enqueued", priorPasses: 0 });
+    try {
+        assert.equal(await runIssueCommand([...args, "--no-auto-merge"]), 0);
+        assert.deepEqual(optedOut.assertCalled(), {
+            title: "T",
+            repo: "owner/repo",
+            developerAgentId: "a1",
+            reviewerAgentId: "a2",
+            source: "agent",
+            enqueue: true,
+            autoMerge: false,
+        });
+    }
+    finally {
+        optedOut.restore();
+    }
+});
 /** Runs the command with stderr captured — the hints go to stderr, stdout stays JSON. */
 async function captureStderr(args) {
     const errs = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-dealer",
-  "version": "1.3.3",
+  "version": "1.3.5",
   "description": "Human control plane for agent execution — queue, plan approval, audit",
   "license": "MIT",
   "type": "module",