agent-dealer 1.3.1 → 1.3.2

package/bundle/server/dist/routes/issues.js

@@ -10,7 +10,7 @@ import { listUsageEventsForIssue, summarizeIssueUsage } from "../repository/usag
 import { listWorkflowEventsForIssue, appendWorkflowEvent, listWorkflowInstancesForIssue, getActiveWorkflowInstance, } from "../repository/workflow-events.js";
 import { listHumanActionsForIssue, listOpenHumanActions } from "../repository/human-actions.js";
 import { listFindingsForIssue } from "../repository/findings.js";
-import { abortIssueAsync, applyParkedEdit, canEditParkedIssue, capWaitForIssue, checkIssueReadiness, closeReadyIssue, parkCapWait, PARKED_EDITABLE_FIELDS } from "../coordinator/commands.js";
+import { abortIssueAsync, applyParkedEdit, canEditParkedIssue, capWaitForIssue, checkIssueReadiness, closeReadyIssue, diffTaskSnapshotFromLive, parkCapWait, parkedEditableFields, parkedEditableFieldsLabel } from "../coordinator/commands.js";
 import { deleteDealerIssue } from "../coordinator/delete-issue.js";
 import { getAgent } from "../repository/agents.js";
 import { executeIssueNow, isStartable, queueStatusForIssue, refreshQueueWaitReasonForIssue, startIssueViaQueue, } from "../coordinator/admission.js";
@@ -82,6 +82,10 @@ export async function registerIssueRoutes(app) {
             const statuses = requested.length > 0
                 ? requested
                 : IssueStatus.options.filter((s) => s !== "closed");
+            // NOT-385: the direction is allowlisted — only an explicit `asc` reverses
+            // to oldest-first; an absent or unknown value renders newest-first
+            // instead of failing the list.
+            const direction = query.direction?.trim() === "asc" ? "asc" : "desc";
             const result = queryIssues({
                 search: query.q,
                 status: statuses,
@@ -89,6 +93,7 @@ export async function registerIssueRoutes(app) {
                 needsAttention: query.needsAttention === "1" || query.needsAttention === "true",
                 page: query.page !== undefined ? Number(query.page) : undefined,
                 limit: query.limit !== undefined ? Number(query.limit) : undefined,
+                direction,
             });
             const openActionIssueIds = new Set(listOpenHumanActions().map((a) => a.issueId));
             return {
@@ -154,6 +159,10 @@ export async function registerIssueRoutes(app) {
             // NOT-364: durable Linear source attachments — files with safe name, size
             // and checksum plus Dealer blob path; links as labeled metadata only.
             sourceAttachments: listSourceAttachments(id),
+            // NOT-422: live-vs-frozen task diff — the fields a parked resume would
+            // re-freeze into a new task snapshot (empty = in sync, or pre-freeze).
+            // Issue Detail renders the pending-snapshot notice off this.
+            pendingSnapshotChangedFields: diffTaskSnapshotFromLive(issue),
         };
     });
     /** NOT-173: stable issue-level execution read model. The existing
@@ -348,18 +357,21 @@ export async function registerIssueRoutes(app) {
             if (getActiveWorkerSessionForIssue(id)) {
                 return "Cannot edit an issue with an actively running session";
             }
-            // NOT-185: the one active-workflow exception — parked at an open attempts_exhausted
-            // or policy_escalation action with nothing pending/leased. A resume re-freezes the
-            // snapshot (task fields) and the next round's profile snapshot (agent fields).
+            // NOT-185: the active-workflow exception — parked at an open attempts_exhausted,
+            // policy_escalation, or (NOT-422) product_scope_decision action with nothing
+            // pending/leased. A resume re-freezes the snapshot (task fields) and, at an
+            // attempts/policy park, the next round's profile snapshot (agent fields).
             if (getActiveWorkflowInstance(id)) {
                 if (!canEditParkedIssue(fresh)) {
                     return "Cannot edit an issue with an active workflow";
                 }
                 // Only the re-frozen inputs may change at the park: repo/base branch, the review
-                // budget and autoMerge stay as the running workflow saw them.
-                const blocked = Object.keys(parsed.data).filter((k) => !PARKED_EDITABLE_FIELDS.has(k));
+                // budget and autoMerge stay as the running workflow saw them — and at a pure
+                // product-scope pause the agents stay too (task text only).
+                const allowed = parkedEditableFields(id);
+                const blocked = Object.keys(parsed.data).filter((k) => !allowed.has(k));
                 if (blocked.length > 0) {
-                    return `Only title, description, acceptanceCriteria, developerAgentId and reviewerAgentId can be edited while parked (got: ${blocked.join(", ")})`;
+                    return `Only ${parkedEditableFieldsLabel(id)} can be edited while parked (got: ${blocked.join(", ")})`;
                 }
             }
             return null;
@@ -453,7 +465,10 @@ export async function registerIssueRoutes(app) {
     /**
      * NOT-363: reload a Linear-sourced issue's task text from its linked ticket.
      * Only while `ready` with no active workflow or running worker — a race
-     * with admission fails closed with 409. Replaces title + description
+     * with admission fails closed with 409. NOT-422 adds the parked exception:
+     * a `needs_human` product-scope pause (open `product_scope_decision`, no
+     * running session, nothing pending/leased) reloads the same way and keeps
+     * the action open for an explicit Resume. Replaces title + description
      * atomically, recompiles the execution contract, and swaps the acceptance
      * criteria for the freshly derived ones; repo, agents, policy fields,
      * auto-merge, queue position, and coordinator-owned fields are preserved.

package/bundle/server/dist/routes/issues.test.js

@@ -735,6 +735,86 @@ test("NOT-228: limit clamps to 100 and out-of-range pages keep totals", async ()
     assert.equal(pastEnd.page, 9);
     await app.close();
 });
+// NOT-385: Latest with no direction renders newest-first; the ascending
+// reverse renders the same cohort oldest-first, and an unknown direction
+// falls back to newest-first instead of failing.
+test("NOT-385: direction defaults to newest-first, asc reverses, unknown falls back", async () => {
+    const app = await buildApp();
+    const oldIssue = await r228Seed(app, "R385 order old");
+    const newIssue = await r228Seed(app, "R385 order new");
+    getDb().prepare("UPDATE issues SET updated_at = ? WHERE id = ?").run("2026-08-01T00:00:00.000Z", oldIssue.id);
+    getDb().prepare("UPDATE issues SET updated_at = ? WHERE id = ?").run("2026-09-01T00:00:00.000Z", newIssue.id);
+    const q = encodeURIComponent("R385 order");
+    const newest = await r228Get(app, `?q=${q}&page=1&limit=10`);
+    assert.deepEqual(newest.issues.map((i) => i.id), [newIssue.id, oldIssue.id]);
+    const explicitDesc = await r228Get(app, `?q=${q}&page=1&limit=10&direction=desc`);
+    assert.deepEqual(explicitDesc.issues.map((i) => i.id), [newIssue.id, oldIssue.id]);
+    const oldest = await r228Get(app, `?q=${q}&page=1&limit=10&direction=asc`);
+    assert.deepEqual(oldest.issues.map((i) => i.id), [oldIssue.id, newIssue.id]);
+    assert.equal(oldest.total, newest.total);
+    const fallback = await r228Get(app, `?q=${q}&page=1&limit=10&direction=sideways`);
+    assert.deepEqual(fallback.issues.map((i) => i.id), [newIssue.id, oldIssue.id]);
+    await app.close();
+});
+// NOT-385: equal `updated_at` rows paginate without duplicates or skips in
+// either direction — the rowid tie-breaker follows the timestamp direction
+// before LIMIT/OFFSET applies.
+test("NOT-385: equal timestamps paginate repeatably in both directions", async () => {
+    const app = await buildApp();
+    const ids = [];
+    for (const title of ["R385 tie one", "R385 tie two", "R385 tie three"]) {
+        ids.push((await r228Seed(app, title)).id);
+    }
+    for (const id of ids) {
+        getDb().prepare("UPDATE issues SET updated_at = ? WHERE id = ?").run("2026-09-01T00:00:00.000Z", id);
+    }
+    const q = encodeURIComponent("R385 tie");
+    const descFirst = await r228Get(app, `?q=${q}&limit=2&page=1`);
+    const descSecond = await r228Get(app, `?q=${q}&limit=2&page=2`);
+    assert.deepEqual(descFirst.issues.map((i) => i.id), [ids[2], ids[1]]);
+    assert.deepEqual(descSecond.issues.map((i) => i.id), [ids[0]]);
+    const ascFirst = await r228Get(app, `?q=${q}&limit=2&page=1&direction=asc`);
+    const ascSecond = await r228Get(app, `?q=${q}&limit=2&page=2&direction=asc`);
+    assert.deepEqual(ascFirst.issues.map((i) => i.id), [ids[0], ids[1]]);
+    assert.deepEqual(ascSecond.issues.map((i) => i.id), [ids[2]]);
+    for (const [first, second] of [[descFirst, descSecond], [ascFirst, ascSecond]]) {
+        assert.equal(first.total, 3);
+        assert.equal(first.totalPages, 2);
+        assert.deepEqual(new Set([...first.issues, ...second.issues].map((i) => i.id)).size, 3, "pages neither duplicate nor skip rows");
+    }
+    await app.close();
+});
+// NOT-385: the direction composes with every filter — the reverse renders the
+// same result set, only oldest-first.
+test("NOT-385: direction coexists with the search, status, repo, and attention filters", async () => {
+    const app = await buildApp();
+    const repo = "github.com/r385/filtered";
+    const keep = await r228Seed(app, "R385 filter keep me", { repo });
+    const moved = await r228Seed(app, "R385 filter moved on", { repo });
+    await r228Seed(app, "R385 filter other repo", { repo: "github.com/r385/elsewhere" });
+    transitionIssue(moved.id, "developing");
+    createHumanAction({
+        issueId: moved.id,
+        actionType: "final_review",
+        reason: "Reviewer approved",
+        question: "Accept?",
+        responseOptions: ["complete"],
+    });
+    getDb().prepare("UPDATE issues SET updated_at = ? WHERE id = ?").run("2026-08-01T00:00:00.000Z", keep.id);
+    getDb().prepare("UPDATE issues SET updated_at = ? WHERE id = ?").run("2026-09-01T00:00:00.000Z", moved.id);
+    const q = encodeURIComponent("R385 filter");
+    const repoParam = encodeURIComponent(repo);
+    const newest = await r228Get(app, `?q=${q}&repo=${repoParam}&page=1&limit=10`);
+    assert.deepEqual(newest.issues.map((i) => i.id), [moved.id, keep.id]);
+    const oldest = await r228Get(app, `?q=${q}&repo=${repoParam}&page=1&limit=10&direction=asc`);
+    assert.deepEqual(oldest.issues.map((i) => i.id), [keep.id, moved.id]);
+    assert.equal(oldest.total, newest.total);
+    const byStatus = await r228Get(app, `?q=${q}&status=developing&page=1&limit=10&direction=asc`);
+    assert.deepEqual(byStatus.issues.map((i) => i.id), [moved.id]);
+    const attention = await r228Get(app, `?q=${q}&needsAttention=1&page=1&limit=10&direction=asc`);
+    assert.deepEqual(attention.issues.map((i) => i.id), [moved.id]);
+    await app.close();
+});
 test("NOT-217: PATCH reviewer-only edit records before/after reviewers without touching the developer", async () => {
     const app = await buildApp();
     const created = (await app.inject({

package/bundle/server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@agent-dealer/server",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "type": "module",
   "main": "dist/index.js",
   "files": [
@@ -23,7 +23,7 @@
     "test": "AGENT_DEALER_SKIP_GITHUB_HEALTH=1 AGENT_DEALER_SKIP_AGENT_HEALTH=1 npm run build -w @agent-dealer/shared && AGENT_DEALER_SKIP_GITHUB_HEALTH=1 AGENT_DEALER_SKIP_AGENT_HEALTH=1 node ../../scripts/run-workspace-tests.mjs"
   },
   "dependencies": {
-    "@agent-dealer/shared": "1.3.1",
+    "@agent-dealer/shared": "1.3.2",
     "@fastify/cors": "^11.0.1",
     "@fastify/static": "^8.2.0",
     "@modelcontextprotocol/sdk": "^1.29.0",