agent-dealer 0.3.0 → 1.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/bundle/server/dist/adapters/agent-deck-bind.js +443 -0
- package/bundle/server/dist/adapters/agent-deck-bind.test.js +454 -0
- package/bundle/server/dist/adapters/agent-deck.js +38 -50
- package/bundle/server/dist/adapters/agent-deck.test.js +63 -0
- package/bundle/server/dist/adapters/agent-health.js +215 -45
- package/bundle/server/dist/adapters/agent-health.test.js +237 -0
- package/bundle/server/dist/adapters/authority-lifecycle.js +289 -0
- package/bundle/server/dist/adapters/codex-scoped-config.js +103 -0
- package/bundle/server/dist/adapters/execution-authority.js +103 -0
- package/bundle/server/dist/adapters/execution-authority.test.js +166 -0
- package/bundle/server/dist/adapters/external.js +0 -1
- package/bundle/server/dist/adapters/git-worktree.js +514 -0
- package/bundle/server/dist/adapters/git-worktree.test.js +502 -0
- package/bundle/server/dist/adapters/github.js +170 -0
- package/bundle/server/dist/adapters/github.test.js +205 -0
- package/bundle/server/dist/adapters/linear-inbox.js +199 -30
- package/bundle/server/dist/adapters/linear-inbox.test.js +35 -0
- package/bundle/server/dist/adapters/linear-sync.js +3 -101
- package/bundle/server/dist/adapters/managed-repo.js +179 -0
- package/bundle/server/dist/adapters/managed-repo.test.js +63 -0
- package/bundle/server/dist/adapters/outbound-delivery.js +83 -0
- package/bundle/server/dist/adapters/outbound-delivery.test.js +53 -0
- package/bundle/server/dist/adapters/reflect-authority.js +43 -0
- package/bundle/server/dist/cli-env.js +10 -0
- package/bundle/server/dist/coordinator/abort.integration.test.js +74 -0
- package/bundle/server/dist/coordinator/admission.js +330 -0
- package/bundle/server/dist/coordinator/admission.test.js +338 -0
- package/bundle/server/dist/coordinator/args.js +128 -0
- package/bundle/server/dist/coordinator/args.test.js +132 -0
- package/bundle/server/dist/coordinator/authority-recovery.integration.test.js +661 -0
- package/bundle/server/dist/coordinator/auto-merge.integration.test.js +414 -0
- package/bundle/server/dist/coordinator/auto-merge.js +354 -0
- package/bundle/server/dist/coordinator/auto-merge.timeout.test.js +56 -0
- package/bundle/server/dist/coordinator/branch-progress.js +81 -0
- package/bundle/server/dist/coordinator/clock-jump.js +98 -0
- package/bundle/server/dist/coordinator/commands.js +1094 -0
- package/bundle/server/dist/coordinator/commands.test.js +571 -0
- package/bundle/server/dist/coordinator/deck-outage-config.js +32 -0
- package/bundle/server/dist/coordinator/deck-outage.integration.test.js +200 -0
- package/bundle/server/dist/coordinator/dependencies.js +242 -0
- package/bundle/server/dist/coordinator/dependency-readiness.integration.test.js +535 -0
- package/bundle/server/dist/coordinator/developer-effect.js +959 -0
- package/bundle/server/dist/coordinator/developer-effect.test.js +1143 -0
- package/bundle/server/dist/coordinator/dispatcher.js +58 -0
- package/bundle/server/dist/coordinator/dispatcher.test.js +81 -0
- package/bundle/server/dist/coordinator/effect-registry.js +17 -0
- package/bundle/server/dist/coordinator/execution-env.integration.test.js +122 -0
- package/bundle/server/dist/coordinator/failure-reason.js +273 -0
- package/bundle/server/dist/coordinator/failure-reason.test.js +234 -0
- package/bundle/server/dist/coordinator/guidance.js +33 -0
- package/bundle/server/dist/coordinator/guidance.test.js +110 -0
- package/bundle/server/dist/coordinator/human-resolution.js +91 -0
- package/bundle/server/dist/coordinator/human-resolution.test.js +84 -0
- package/bundle/server/dist/coordinator/intent-forecast.js +13 -0
- package/bundle/server/dist/coordinator/intent-forecast.test.js +34 -0
- package/bundle/server/dist/coordinator/latest-failure.js +100 -0
- package/bundle/server/dist/coordinator/latest-failure.test.js +125 -0
- package/bundle/server/dist/coordinator/metrics.js +35 -0
- package/bundle/server/dist/coordinator/metrics.test.js +52 -0
- package/bundle/server/dist/coordinator/permissions.js +127 -0
- package/bundle/server/dist/coordinator/permissions.test.js +184 -0
- package/bundle/server/dist/coordinator/presumed-dead-budget.integration.test.js +146 -0
- package/bundle/server/dist/coordinator/process-liveness.js +191 -0
- package/bundle/server/dist/coordinator/profile-snapshot.js +20 -0
- package/bundle/server/dist/coordinator/profile-snapshot.test.js +118 -0
- package/bundle/server/dist/coordinator/projection.js +147 -0
- package/bundle/server/dist/coordinator/projection.test.js +121 -0
- package/bundle/server/dist/coordinator/prompts.js +172 -0
- package/bundle/server/dist/coordinator/prompts.test.js +198 -0
- package/bundle/server/dist/coordinator/queue-by-default.integration.test.js +271 -0
- package/bundle/server/dist/coordinator/reclaim-republish.integration.test.js +372 -0
- package/bundle/server/dist/coordinator/recovery.js +466 -0
- package/bundle/server/dist/coordinator/recovery.test.js +164 -0
- package/bundle/server/dist/coordinator/reflect-trigger.js +218 -0
- package/bundle/server/dist/coordinator/reflect-trigger.test.js +324 -0
- package/bundle/server/dist/coordinator/repair-cycle.integration.test.js +234 -0
- package/bundle/server/dist/coordinator/restart-recovery.integration.test.js +363 -0
- package/bundle/server/dist/coordinator/reviewer-effect.js +552 -0
- package/bundle/server/dist/coordinator/reviewer-effect.test.js +670 -0
- package/bundle/server/dist/coordinator/reviewer-result.js +86 -0
- package/bundle/server/dist/coordinator/reviewer-result.test.js +83 -0
- package/bundle/server/dist/coordinator/routing.js +171 -0
- package/bundle/server/dist/coordinator/routing.test.js +351 -0
- package/bundle/server/dist/coordinator/session-lifecycle.integration.test.js +127 -0
- package/bundle/server/dist/coordinator/session-lifecycle.js +280 -0
- package/bundle/server/dist/coordinator/session-lifecycle.test.js +121 -0
- package/bundle/server/dist/coordinator/session-progress.js +351 -0
- package/bundle/server/dist/coordinator/session-progress.test.js +190 -0
- package/bundle/server/dist/coordinator/session-timeouts.js +33 -0
- package/bundle/server/dist/coordinator/sleep-recovery.integration.test.js +233 -0
- package/bundle/server/dist/coordinator/spawn.js +49 -0
- package/bundle/server/dist/coordinator/sync-issue-base-branch.js +18 -0
- package/bundle/server/dist/coordinator/usage-cap-config.js +10 -0
- package/bundle/server/dist/coordinator/usage-cap-defer.js +189 -0
- package/bundle/server/dist/coordinator/usage-cap.integration.test.js +193 -0
- package/bundle/server/dist/coordinator/usage.js +40 -0
- package/bundle/server/dist/coordinator/usage.test.js +69 -0
- package/bundle/server/dist/coordinator/verification-receipt.js +333 -0
- package/bundle/server/dist/coordinator/verification-receipt.test.js +382 -0
- package/bundle/server/dist/coordinator/worker-loop.js +363 -0
- package/bundle/server/dist/coordinator/worker-loop.test.js +329 -0
- package/bundle/server/dist/coordinator/workflow-instances.test.js +45 -0
- package/bundle/server/dist/coordinator/worktree-owner-liveness.js +82 -0
- package/bundle/server/dist/coordinator/worktree-owner-liveness.test.js +199 -0
- package/bundle/server/dist/db/artifacts-issue-columns.test.js +18 -0
- package/bundle/server/dist/db/authority-attempts-stale-at-migration.test.js +65 -0
- package/bundle/server/dist/db/idempotency-index-migration.test.js +57 -0
- package/bundle/server/dist/db/index.js +357 -6
- package/bundle/server/dist/db/linear-inbox-unlock.test.js +67 -0
- package/bundle/server/dist/db/migrate-to-issues.js +824 -0
- package/bundle/server/dist/db/migrate-to-issues.test.js +843 -0
- package/bundle/server/dist/db/schema.sql +311 -1
- package/bundle/server/dist/db/schema.test.js +66 -0
- package/bundle/server/dist/db/worker-session-pid-migration.test.js +112 -0
- package/bundle/server/dist/dev-review-cli-happy-path.integration.test.js +339 -0
- package/bundle/server/dist/direct-start-liveness.integration.test.js +350 -0
- package/bundle/server/dist/index.js +58 -5
- package/bundle/server/dist/paths.js +40 -4
- package/bundle/server/dist/paths.test.js +42 -0
- package/bundle/server/dist/pid-marker-claim-child.js +18 -0
- package/bundle/server/dist/pid-marker-hold-arbiter-child.js +24 -0
- package/bundle/server/dist/pid-marker.js +141 -0
- package/bundle/server/dist/pid-marker.test.js +208 -0
- package/bundle/server/dist/queue/approve-deliver.js +128 -28
- package/bundle/server/dist/queue/reflect-schedule.js +25 -0
- package/bundle/server/dist/queue/send-gate.test.js +172 -36
- package/bundle/server/dist/repository/agents.js +55 -18
- package/bundle/server/dist/repository/artifacts-for-issue.js +42 -0
- package/bundle/server/dist/repository/artifacts-for-issue.test.js +48 -0
- package/bundle/server/dist/repository/artifacts.js +47 -0
- package/bundle/server/dist/repository/artifacts.test.js +48 -0
- package/bundle/server/dist/repository/authority-attempts.js +189 -0
- package/bundle/server/dist/repository/findings.js +70 -0
- package/bundle/server/dist/repository/findings.test.js +68 -0
- package/bundle/server/dist/repository/human-actions.js +142 -0
- package/bundle/server/dist/repository/human-actions.test.js +123 -0
- package/bundle/server/dist/repository/intake-settings.js +5 -59
- package/bundle/server/dist/repository/issues.js +305 -0
- package/bundle/server/dist/repository/issues.test.js +69 -0
- package/bundle/server/dist/repository/outbound-drafts.js +28 -0
- package/bundle/server/dist/repository/queue-entries.js +162 -0
- package/bundle/server/dist/repository/review-publications.js +153 -0
- package/bundle/server/dist/repository/review-publications.test.js +78 -0
- package/bundle/server/dist/repository/runs-external-id.test.js +5 -3
- package/bundle/server/dist/repository/runs.js +4 -211
- package/bundle/server/dist/repository/runtime-availability.js +54 -0
- package/bundle/server/dist/repository/usage-events.js +60 -0
- package/bundle/server/dist/repository/usage-events.test.js +56 -0
- package/bundle/server/dist/repository/work-items.js +305 -0
- package/bundle/server/dist/repository/work-items.test.js +142 -0
- package/bundle/server/dist/repository/worker-sessions.js +219 -0
- package/bundle/server/dist/repository/worker-sessions.test.js +60 -0
- package/bundle/server/dist/repository/workflow-events.js +193 -0
- package/bundle/server/dist/repository/workflow-events.test.js +89 -0
- package/bundle/server/dist/resolve-tsx-bin.js +19 -0
- package/bundle/server/dist/routes/human-actions.js +68 -0
- package/bundle/server/dist/routes/human-actions.test.js +286 -0
- package/bundle/server/dist/routes/index.js +29 -496
- package/bundle/server/dist/routes/issues.js +240 -0
- package/bundle/server/dist/routes/issues.test.js +451 -0
- package/bundle/server/dist/routes/queue.js +41 -0
- package/bundle/server/dist/routes/queue.test.js +78 -0
- package/bundle/server/dist/runners/claude-args.js +18 -30
- package/bundle/server/dist/runners/claude.js +19 -82
- package/bundle/server/dist/runners/claude.test.js +15 -70
- package/bundle/server/dist/runners/process-registry.js +11 -0
- package/bundle/server/dist/runners/prompts.js +13 -280
- package/bundle/server/dist/runners/prompts.test.js +22 -153
- package/bundle/server/dist/runners/reflect.js +4 -16
- package/bundle/server/dist/runners/spawn-cli.js +116 -9
- package/bundle/server/dist/runners/spawn-cli.test.js +130 -0
- package/bundle/server/dist/runners/stream-json.js +0 -141
- package/bundle/server/dist/runners/usage-cap.js +242 -0
- package/bundle/server/dist/runners/usage-cap.test.js +97 -0
- package/bundle/server/dist/server-liveness.js +37 -0
- package/bundle/server/dist/server-liveness.test.js +82 -0
- package/bundle/server/dist/static-ui.test.js +44 -0
- package/bundle/server/package.json +4 -2
- package/bundle/server/static-ui/assets/index-BTtPGYpY.js +60 -0
- package/bundle/server/static-ui/assets/index-BxTx4b1d.css +1 -0
- package/bundle/server/static-ui/index.html +2 -2
- package/bundle/shared/dist/agents.d.ts +254 -126
- package/bundle/shared/dist/agents.js +84 -19
- package/bundle/shared/dist/cursor-auth-health.d.ts +12 -0
- package/bundle/shared/dist/cursor-auth-health.js +36 -0
- package/bundle/shared/dist/cursor-auth-health.test.d.ts +1 -0
- package/bundle/shared/dist/cursor-auth-health.test.js +40 -0
- package/bundle/shared/dist/findings.d.ts +46 -0
- package/bundle/shared/dist/findings.js +17 -0
- package/bundle/shared/dist/findings.test.d.ts +1 -0
- package/bundle/shared/dist/findings.test.js +20 -0
- package/bundle/shared/dist/github-repo.d.ts +28 -0
- package/bundle/shared/dist/github-repo.js +98 -0
- package/bundle/shared/dist/github-repo.test.d.ts +1 -0
- package/bundle/shared/dist/github-repo.test.js +32 -0
- package/bundle/shared/dist/human-actions.d.ts +66 -0
- package/bundle/shared/dist/human-actions.js +51 -0
- package/bundle/shared/dist/human-actions.test.d.ts +1 -0
- package/bundle/shared/dist/human-actions.test.js +57 -0
- package/bundle/shared/dist/index.d.ts +488 -678
- package/bundle/shared/dist/index.js +22 -36
- package/bundle/shared/dist/issues.d.ts +385 -0
- package/bundle/shared/dist/issues.js +169 -0
- package/bundle/shared/dist/issues.test.d.ts +1 -0
- package/bundle/shared/dist/issues.test.js +72 -0
- package/bundle/shared/dist/outbound-draft.d.ts +6 -0
- package/bundle/shared/dist/outbound-draft.js +4 -0
- package/bundle/shared/dist/plan-triage.d.ts +6 -6
- package/bundle/shared/dist/profile-snapshot.d.ts +154 -0
- package/bundle/shared/dist/profile-snapshot.js +145 -0
- package/bundle/shared/dist/profile-snapshot.test.d.ts +1 -0
- package/bundle/shared/dist/profile-snapshot.test.js +67 -0
- package/bundle/shared/dist/queue-entries.d.ts +89 -0
- package/bundle/shared/dist/queue-entries.js +19 -0
- package/bundle/shared/dist/result-qa.d.ts +2 -2
- package/bundle/shared/dist/runtime-auth-health.d.ts +66 -0
- package/bundle/shared/dist/runtime-auth-health.js +186 -0
- package/bundle/shared/dist/runtime-auth-health.test.d.ts +1 -0
- package/bundle/shared/dist/runtime-auth-health.test.js +200 -0
- package/bundle/shared/dist/runtime-availability.d.ts +51 -0
- package/bundle/shared/dist/runtime-availability.js +13 -0
- package/bundle/shared/dist/usage-events.d.ts +36 -0
- package/bundle/shared/dist/usage-events.js +13 -0
- package/bundle/shared/dist/worker-sessions.d.ts +140 -0
- package/bundle/shared/dist/worker-sessions.js +70 -0
- package/bundle/shared/dist/worker-sessions.test.d.ts +1 -0
- package/bundle/shared/dist/worker-sessions.test.js +39 -0
- package/bundle/shared/dist/workflow.d.ts +78 -0
- package/bundle/shared/dist/workflow.js +59 -0
- package/bundle/shared/dist/workflow.test.d.ts +1 -0
- package/bundle/shared/dist/workflow.test.js +61 -0
- package/bundle/shared/package.json +1 -1
- package/dist/action.d.ts +1 -0
- package/dist/action.js +50 -0
- package/dist/action.test.d.ts +1 -0
- package/dist/action.test.js +70 -0
- package/dist/agent.d.ts +1 -0
- package/dist/agent.js +17 -0
- package/dist/agent.test.d.ts +1 -0
- package/dist/agent.test.js +19 -0
- package/dist/cli-check.d.ts +7 -0
- package/dist/cli-check.js +40 -0
- package/dist/doctor.js +59 -1
- package/dist/http.d.ts +5 -0
- package/dist/http.js +19 -0
- package/dist/index.js +28 -0
- package/dist/install.js +1 -1
- package/dist/issue.d.ts +35 -0
- package/dist/issue.js +143 -0
- package/dist/issue.test.d.ts +1 -0
- package/dist/issue.test.js +240 -0
- package/dist/lifecycle.contract.test.d.ts +1 -0
- package/dist/lifecycle.contract.test.js +135 -0
- package/dist/queue.d.ts +11 -0
- package/dist/queue.js +60 -0
- package/dist/queue.test.d.ts +1 -0
- package/dist/queue.test.js +46 -0
- package/dist/setup.js +5 -1
- package/dist/test-fetch-stub.d.ts +6 -0
- package/dist/test-fetch-stub.js +31 -0
- package/package.json +2 -1
- package/templates/prod.env.example +1 -1
- package/bundle/server/static-ui/assets/index-DTcianAH.js +0 -79
- package/bundle/server/static-ui/assets/index-QYv3zmE6.css +0 -1
|
@@ -0,0 +1,351 @@
|
|
|
1
|
+
// packages/server/src/coordinator/routing.test.ts
|
|
2
|
+
import { test } from "node:test";
|
|
3
|
+
import assert from "node:assert/strict";
|
|
4
|
+
import { routeDeveloperOutcome, routeReviewerOutcome, } from "./routing.js";
|
|
5
|
+
const REVIEW_ROUNDS_LEFT = { currentRound: 1, maxReviewRounds: 3, infraAttempts: 0, maxInfraAttempts: 3 };
|
|
6
|
+
const REVIEW_AT_LIMIT = { currentRound: 3, maxReviewRounds: 3, infraAttempts: 0, maxInfraAttempts: 3 };
|
|
7
|
+
const INFRA_ATTEMPTS_LEFT = { currentRound: 1, maxReviewRounds: 3, infraAttempts: 1, maxInfraAttempts: 3 };
|
|
8
|
+
const INFRA_AT_LIMIT = { currentRound: 1, maxReviewRounds: 3, infraAttempts: 3, maxInfraAttempts: 3 };
|
|
9
|
+
const PINNED_HEAD = "pinned-head-sha";
|
|
10
|
+
// --- Developer outcomes ---
|
|
11
|
+
test("clean handoff routes to spawn_reviewer", () => {
|
|
12
|
+
const outcome = { kind: "clean_handoff", branch: "br", headSha: "h", baseSha: "b", prNumber: 1, prUrl: "u" };
|
|
13
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, REVIEW_ROUNDS_LEFT), { next: "spawn_reviewer", headSha: "h" });
|
|
14
|
+
});
|
|
15
|
+
test("no PR with infra attempts remaining retries the developer without spending a review round", () => {
|
|
16
|
+
const outcome = { kind: "no_pr" };
|
|
17
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, REVIEW_AT_LIMIT), {
|
|
18
|
+
next: "retry_developer",
|
|
19
|
+
reason: "Developer session produced no PR.",
|
|
20
|
+
});
|
|
21
|
+
});
|
|
22
|
+
test("no PR at the infra-attempt limit escalates, not attempts_exhausted (that stays pure to review rounds)", () => {
|
|
23
|
+
const outcome = { kind: "no_pr" };
|
|
24
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
25
|
+
assert.equal(result.next, "human_action");
|
|
26
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
27
|
+
});
|
|
28
|
+
test("session_failed with infra attempts remaining also just retries (same bucket as no_pr)", () => {
|
|
29
|
+
const outcome = { kind: "session_failed" };
|
|
30
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
31
|
+
next: "retry_developer",
|
|
32
|
+
reason: "Developer session failed or crashed.",
|
|
33
|
+
});
|
|
34
|
+
});
|
|
35
|
+
test("dirty worktree always escalates immediately — never retried, regardless of any budget", () => {
|
|
36
|
+
const outcome = { kind: "dirty_worktree" };
|
|
37
|
+
const result = routeDeveloperOutcome(outcome, REVIEW_ROUNDS_LEFT);
|
|
38
|
+
assert.equal(result.next, "human_action");
|
|
39
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
40
|
+
});
|
|
41
|
+
test("NOT-145: dirty_worktree with path/recovery folds recovery into the escalation reason like worktree_conflict", () => {
|
|
42
|
+
const outcome = {
|
|
43
|
+
kind: "dirty_worktree",
|
|
44
|
+
reason: "Auto-commit salvage failed: hook rejected.",
|
|
45
|
+
path: "/data/worktrees/s-dev-developer",
|
|
46
|
+
recoveryCommands: ["cd /data/worktrees/s-dev-developer", "git status"],
|
|
47
|
+
};
|
|
48
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
49
|
+
assert.equal(result.next, "human_action");
|
|
50
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
51
|
+
const reason = result.reason;
|
|
52
|
+
assert.match(reason, /Auto-commit salvage failed/);
|
|
53
|
+
assert.match(reason, /git status/);
|
|
54
|
+
assert.match(reason, /s-dev-developer/);
|
|
55
|
+
});
|
|
56
|
+
test("unpushed commit always escalates immediately — never retried, regardless of any budget", () => {
|
|
57
|
+
const outcome = { kind: "unpushed_commit", reason: "non-fast-forward" };
|
|
58
|
+
const result = routeDeveloperOutcome(outcome, REVIEW_ROUNDS_LEFT);
|
|
59
|
+
assert.equal(result.next, "human_action");
|
|
60
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
61
|
+
});
|
|
62
|
+
test("NOT-137: unpushed_commit escalation folds divergence facts and recovery like worktree_conflict", () => {
|
|
63
|
+
const localSha = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
|
|
64
|
+
const remoteSha = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
|
|
65
|
+
const outcome = {
|
|
66
|
+
kind: "unpushed_commit",
|
|
67
|
+
reason: `local and origin/issue-1 have diverged: local ${localSha.slice(0, 12)} is 2 commit(s) ahead, ` +
|
|
68
|
+
`remote ${remoteSha.slice(0, 12)} is 1 commit(s) ahead. ` +
|
|
69
|
+
`Do not git pull — that integrates the wrong history for a rewritten branch.`,
|
|
70
|
+
recoveryCommands: [
|
|
71
|
+
`# Confirm the remote tip is still ${remoteSha.slice(0, 12)}, then publish local with a lease pin:`,
|
|
72
|
+
`git push --force-with-lease=refs/heads/issue-1:${remoteSha} origin ${localSha}:refs/heads/issue-1`,
|
|
73
|
+
],
|
|
74
|
+
};
|
|
75
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
76
|
+
assert.equal(result.next, "human_action");
|
|
77
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
78
|
+
const reason = result.reason;
|
|
79
|
+
assert.match(reason, /diverged/);
|
|
80
|
+
assert.match(reason, new RegExp(localSha.slice(0, 12)));
|
|
81
|
+
assert.match(reason, new RegExp(remoteSha.slice(0, 12)));
|
|
82
|
+
assert.match(reason, /2 commit\(s\) ahead/);
|
|
83
|
+
assert.match(reason, /1 commit\(s\) ahead/);
|
|
84
|
+
assert.match(reason, /force-with-lease/);
|
|
85
|
+
assert.match(reason, new RegExp(remoteSha));
|
|
86
|
+
assert.doesNotMatch(reason, /use 'git pull'/i);
|
|
87
|
+
});
|
|
88
|
+
test("worktree conflict always escalates immediately — never retried, regardless of any budget, and carries path/recovery in the reason", () => {
|
|
89
|
+
const outcome = {
|
|
90
|
+
kind: "worktree_conflict",
|
|
91
|
+
path: "/data/worktrees/old-session-developer",
|
|
92
|
+
reason: "A previous developer worktree for branch issue-1 still holds it at /data/worktrees/old-session-developer with uncommitted or unpushed work.",
|
|
93
|
+
recoveryCommands: ["cd /data/worktrees/old-session-developer", "git status"],
|
|
94
|
+
};
|
|
95
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
96
|
+
assert.equal(result.next, "human_action");
|
|
97
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
98
|
+
const reason = result.reason;
|
|
99
|
+
assert.match(reason, /old-session-developer/);
|
|
100
|
+
assert.match(reason, /git status/);
|
|
101
|
+
});
|
|
102
|
+
test("NOT-127: live_owner retries on the infra budget — never escalates as worktree_conflict", () => {
|
|
103
|
+
const outcome = {
|
|
104
|
+
kind: "live_owner",
|
|
105
|
+
path: "/data/worktrees/old-session-developer",
|
|
106
|
+
ownerSessionId: "old-session",
|
|
107
|
+
reason: "still in use by session old-session (live process)",
|
|
108
|
+
};
|
|
109
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
110
|
+
next: "retry_developer",
|
|
111
|
+
reason: outcome.reason,
|
|
112
|
+
});
|
|
113
|
+
const exhausted = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
114
|
+
assert.equal(exhausted.next, "human_action");
|
|
115
|
+
assert.equal(exhausted.actionType, "policy_escalation");
|
|
116
|
+
assert.match(exhausted.reason, /live process/);
|
|
117
|
+
assert.doesNotMatch(exhausted.reason, /uncommitted/);
|
|
118
|
+
});
|
|
119
|
+
test("adapter failure is bounded-retried on the infra budget (unified failure policy), not escalated on first occurrence", () => {
|
|
120
|
+
const outcome = { kind: "adapter_failure", reason: "gh: command not found" };
|
|
121
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
122
|
+
next: "retry_developer",
|
|
123
|
+
reason: "Git/GitHub verification failed: gh: command not found",
|
|
124
|
+
});
|
|
125
|
+
});
|
|
126
|
+
test("Agent Deck failures have a structural outcome and deck-specific label", () => {
|
|
127
|
+
const outcome = {
|
|
128
|
+
kind: "deck_failure",
|
|
129
|
+
reason: "preflight failed: get_playbook(pb-x) returned an error: missing",
|
|
130
|
+
};
|
|
131
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
132
|
+
next: "retry_developer",
|
|
133
|
+
reason: "Agent Deck preflight failed: get_playbook(pb-x) returned an error: missing",
|
|
134
|
+
});
|
|
135
|
+
});
|
|
136
|
+
test("an unreachable deck defers instead of spending an infra attempt (NOT-136)", () => {
|
|
137
|
+
const outcome = {
|
|
138
|
+
kind: "deck_unavailable",
|
|
139
|
+
reason: "Agent Deck is unreachable — fetch failed",
|
|
140
|
+
};
|
|
141
|
+
// Even with the infra budget already exhausted it waits — nothing was attempted, so
|
|
142
|
+
// there is nothing to escalate.
|
|
143
|
+
for (const limits of [INFRA_ATTEMPTS_LEFT, INFRA_AT_LIMIT]) {
|
|
144
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, limits), {
|
|
145
|
+
next: "defer_work",
|
|
146
|
+
reason: "Agent Deck is unreachable — fetch failed",
|
|
147
|
+
});
|
|
148
|
+
}
|
|
149
|
+
});
|
|
150
|
+
test("adapter failure after push retries publish only (no full developer session)", () => {
|
|
151
|
+
const outcome = {
|
|
152
|
+
kind: "adapter_failure",
|
|
153
|
+
reason: "Branch already pushed (issue-1); only draft PR create failed: boom",
|
|
154
|
+
publishable: { branch: "issue-1" },
|
|
155
|
+
};
|
|
156
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
157
|
+
next: "retry_publish",
|
|
158
|
+
reason: "Git/GitHub verification failed: Branch already pushed (issue-1); only draft PR create failed: boom",
|
|
159
|
+
branch: "issue-1",
|
|
160
|
+
});
|
|
161
|
+
});
|
|
162
|
+
test("adapter failure after push still escalates once infra attempts are exhausted", () => {
|
|
163
|
+
const outcome = {
|
|
164
|
+
kind: "adapter_failure",
|
|
165
|
+
reason: "Branch already pushed (issue-1); only draft PR create failed: boom",
|
|
166
|
+
publishable: { branch: "issue-1" },
|
|
167
|
+
};
|
|
168
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
169
|
+
assert.equal(result.next, "human_action");
|
|
170
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
171
|
+
});
|
|
172
|
+
test("adapter failure escalates once the infra-attempt limit is reached", () => {
|
|
173
|
+
const outcome = { kind: "adapter_failure", reason: "gh: command not found" };
|
|
174
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
175
|
+
assert.equal(result.next, "human_action");
|
|
176
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
177
|
+
});
|
|
178
|
+
test("timed_out with infra attempts remaining retries (same bucket as session_failed/no_pr)", () => {
|
|
179
|
+
const outcome = { kind: "timed_out" };
|
|
180
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
181
|
+
next: "retry_developer",
|
|
182
|
+
reason: "Developer session timed out.",
|
|
183
|
+
});
|
|
184
|
+
});
|
|
185
|
+
test("checks_failed with infra attempts remaining retries (same bucket as session_failed/no_pr)", () => {
|
|
186
|
+
const outcome = { kind: "checks_failed", details: "lint failed" };
|
|
187
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_ATTEMPTS_LEFT), {
|
|
188
|
+
next: "retry_developer",
|
|
189
|
+
reason: "Developer's PR checks failed.",
|
|
190
|
+
});
|
|
191
|
+
});
|
|
192
|
+
test("checks_failed at the infra-attempt limit escalates", () => {
|
|
193
|
+
const outcome = { kind: "checks_failed" };
|
|
194
|
+
const result = routeDeveloperOutcome(outcome, INFRA_AT_LIMIT);
|
|
195
|
+
assert.equal(result.next, "human_action");
|
|
196
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
197
|
+
});
|
|
198
|
+
test("an infra-class developer failure never spends the review-round budget, even at the review-round limit", () => {
|
|
199
|
+
const outcome = { kind: "session_failed" };
|
|
200
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, REVIEW_AT_LIMIT), {
|
|
201
|
+
next: "retry_developer",
|
|
202
|
+
reason: "Developer session failed or crashed.",
|
|
203
|
+
});
|
|
204
|
+
});
|
|
205
|
+
test("usage_capped defers instead of infra retry (NOT-111)", () => {
|
|
206
|
+
const outcome = {
|
|
207
|
+
kind: "usage_capped",
|
|
208
|
+
until: "2099-01-01T00:00:00.000Z",
|
|
209
|
+
reason: "claude_code usage capped",
|
|
210
|
+
};
|
|
211
|
+
assert.deepStrictEqual(routeDeveloperOutcome(outcome, INFRA_AT_LIMIT), {
|
|
212
|
+
next: "defer_work",
|
|
213
|
+
until: outcome.until,
|
|
214
|
+
reason: outcome.reason,
|
|
215
|
+
});
|
|
216
|
+
});
|
|
217
|
+
// --- Reviewer outcomes ---
|
|
218
|
+
test("approved verdict routes to final_review regardless of round", () => {
|
|
219
|
+
const outcome = {
|
|
220
|
+
kind: "verdict",
|
|
221
|
+
result: { verdict: "approved", baseSha: "b", headSha: "h", acceptanceCriteriaAssessment: "met", evidenceAssessment: "ok", findings: [], risks: [] },
|
|
222
|
+
};
|
|
223
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, REVIEW_ROUNDS_LEFT, PINNED_HEAD), { next: "final_review" });
|
|
224
|
+
});
|
|
225
|
+
test("approved verdict with autoMerge routes to auto_merge instead of final_review", () => {
|
|
226
|
+
const outcome = {
|
|
227
|
+
kind: "verdict",
|
|
228
|
+
result: { verdict: "approved", baseSha: "b", headSha: "h", acceptanceCriteriaAssessment: "met", evidenceAssessment: "ok", findings: [], risks: [] },
|
|
229
|
+
};
|
|
230
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, { ...REVIEW_ROUNDS_LEFT, autoMerge: true }, PINNED_HEAD), { next: "auto_merge" });
|
|
231
|
+
});
|
|
232
|
+
test("changes_requested with rounds remaining retries the developer with findings", () => {
|
|
233
|
+
const outcome = {
|
|
234
|
+
kind: "verdict",
|
|
235
|
+
result: { verdict: "changes_requested", baseSha: "b", headSha: "h", acceptanceCriteriaAssessment: "partial", evidenceAssessment: "ok", findings: [{ fingerprint: "f1", severity: "blocking", title: "T", rationale: "R" }], risks: [] },
|
|
236
|
+
};
|
|
237
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, REVIEW_ROUNDS_LEFT, PINNED_HEAD), { next: "retry_developer_with_findings" });
|
|
238
|
+
});
|
|
239
|
+
test("changes_requested at the review-round limit exhausts attempts, even with infra attempts untouched", () => {
|
|
240
|
+
const outcome = {
|
|
241
|
+
kind: "verdict",
|
|
242
|
+
result: { verdict: "changes_requested", baseSha: "b", headSha: "h", acceptanceCriteriaAssessment: "partial", evidenceAssessment: "ok", findings: [], risks: [] },
|
|
243
|
+
};
|
|
244
|
+
const result = routeReviewerOutcome(outcome, REVIEW_AT_LIMIT, PINNED_HEAD);
|
|
245
|
+
assert.equal(result.next, "human_action");
|
|
246
|
+
assert.equal(result.actionType, "attempts_exhausted");
|
|
247
|
+
});
|
|
248
|
+
test("escalated with a product scope question routes to product_scope_decision", () => {
|
|
249
|
+
const outcome = {
|
|
250
|
+
kind: "verdict",
|
|
251
|
+
result: { verdict: "escalated", baseSha: "b", headSha: "h", acceptanceCriteriaAssessment: "unclear", evidenceAssessment: "ok", findings: [], risks: [], productScopeQuestion: "Should deleted users retain their sessions?" },
|
|
252
|
+
};
|
|
253
|
+
const result = routeReviewerOutcome(outcome, REVIEW_ROUNDS_LEFT, PINNED_HEAD);
|
|
254
|
+
assert.equal(result.actionType, "product_scope_decision");
|
|
255
|
+
});
|
|
256
|
+
test("escalated without a product scope question remaps to automatic repair (NOT-150)", () => {
|
|
257
|
+
const outcome = {
|
|
258
|
+
kind: "verdict",
|
|
259
|
+
result: { verdict: "escalated", baseSha: "b", headSha: "h", acceptanceCriteriaAssessment: "unclear", evidenceAssessment: "ok", findings: [], risks: [] },
|
|
260
|
+
};
|
|
261
|
+
const result = routeReviewerOutcome(outcome, REVIEW_ROUNDS_LEFT, PINNED_HEAD);
|
|
262
|
+
assert.deepStrictEqual(result, { next: "retry_developer_with_findings" });
|
|
263
|
+
});
|
|
264
|
+
test("approved with blocking finding remaps to changes_requested repair (NOT-150)", () => {
|
|
265
|
+
const outcome = {
|
|
266
|
+
kind: "verdict",
|
|
267
|
+
result: {
|
|
268
|
+
verdict: "approved",
|
|
269
|
+
baseSha: "b",
|
|
270
|
+
headSha: "h",
|
|
271
|
+
acceptanceCriteriaAssessment: "ok",
|
|
272
|
+
evidenceAssessment: "ok",
|
|
273
|
+
findings: [{ fingerprint: "f1", severity: "blocking", title: "Bug", rationale: "breaks" }],
|
|
274
|
+
risks: [],
|
|
275
|
+
},
|
|
276
|
+
};
|
|
277
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, REVIEW_ROUNDS_LEFT, PINNED_HEAD), { next: "retry_developer_with_findings" });
|
|
278
|
+
});
|
|
279
|
+
test("stale review retries the reviewer at the freshly verified head while infra attempts remain", () => {
|
|
280
|
+
const outcome = { kind: "stale", currentHeadSha: "new-head" };
|
|
281
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, INFRA_ATTEMPTS_LEFT, PINNED_HEAD), { next: "retry_reviewer_at_new_head", headSha: "new-head" });
|
|
282
|
+
});
|
|
283
|
+
test("a stale review never spends a review round, even at the review-round limit", () => {
|
|
284
|
+
const outcome = { kind: "stale", currentHeadSha: "new-head" };
|
|
285
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, REVIEW_AT_LIMIT, PINNED_HEAD), { next: "retry_reviewer_at_new_head", headSha: "new-head" });
|
|
286
|
+
});
|
|
287
|
+
test("a head that keeps moving faster than the reviewer can catch up eventually escalates, bounding the retry loop", () => {
|
|
288
|
+
const outcome = { kind: "stale", currentHeadSha: "new-head" };
|
|
289
|
+
const result = routeReviewerOutcome(outcome, INFRA_AT_LIMIT, PINNED_HEAD);
|
|
290
|
+
assert.equal(result.next, "human_action");
|
|
291
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
292
|
+
});
|
|
293
|
+
test("reviewer session_failed is bounded-retried at the SAME pinned head, not the developer", () => {
|
|
294
|
+
const outcome = { kind: "session_failed" };
|
|
295
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, INFRA_ATTEMPTS_LEFT, PINNED_HEAD), {
|
|
296
|
+
next: "retry_reviewer",
|
|
297
|
+
headSha: PINNED_HEAD,
|
|
298
|
+
reason: "Reviewer session failed, timed out, its worktree checkout failed, or its output was unparseable.",
|
|
299
|
+
});
|
|
300
|
+
});
|
|
301
|
+
test("reviewer deck_failure preserves and labels the preflight reason", () => {
|
|
302
|
+
const outcome = {
|
|
303
|
+
kind: "deck_failure",
|
|
304
|
+
reason: "preflight failed: get_playbook(pb-x) returned an error: missing",
|
|
305
|
+
};
|
|
306
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, INFRA_ATTEMPTS_LEFT, PINNED_HEAD), {
|
|
307
|
+
next: "retry_reviewer",
|
|
308
|
+
headSha: PINNED_HEAD,
|
|
309
|
+
reason: "Agent Deck preflight failed: get_playbook(pb-x) returned an error: missing",
|
|
310
|
+
});
|
|
311
|
+
});
|
|
312
|
+
test("reviewer deck_unavailable defers rather than burning the reviewer's infra budget", () => {
|
|
313
|
+
const outcome = {
|
|
314
|
+
kind: "deck_unavailable",
|
|
315
|
+
reason: "Agent Deck is unreachable — fetch failed",
|
|
316
|
+
};
|
|
317
|
+
for (const limits of [INFRA_ATTEMPTS_LEFT, INFRA_AT_LIMIT]) {
|
|
318
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, limits, PINNED_HEAD), {
|
|
319
|
+
next: "defer_work",
|
|
320
|
+
reason: "Agent Deck is unreachable — fetch failed",
|
|
321
|
+
});
|
|
322
|
+
}
|
|
323
|
+
});
|
|
324
|
+
test("reviewer session_failed escalates once the infra-attempt limit is reached", () => {
|
|
325
|
+
const outcome = { kind: "session_failed" };
|
|
326
|
+
const result = routeReviewerOutcome(outcome, INFRA_AT_LIMIT, PINNED_HEAD);
|
|
327
|
+
assert.equal(result.next, "human_action");
|
|
328
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
329
|
+
});
|
|
330
|
+
test("review publish_failed is bounded-retried rather than immediately confused with a code finding", () => {
|
|
331
|
+
const outcome = { kind: "publish_failed" };
|
|
332
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, INFRA_ATTEMPTS_LEFT, PINNED_HEAD), {
|
|
333
|
+
next: "retry_reviewer",
|
|
334
|
+
headSha: PINNED_HEAD,
|
|
335
|
+
reason: "Review publication to GitHub failed.",
|
|
336
|
+
});
|
|
337
|
+
});
|
|
338
|
+
test("review publish_failed escalates once the infra-attempt limit is reached", () => {
|
|
339
|
+
const outcome = { kind: "publish_failed" };
|
|
340
|
+
const result = routeReviewerOutcome(outcome, INFRA_AT_LIMIT, PINNED_HEAD);
|
|
341
|
+
assert.equal(result.next, "human_action");
|
|
342
|
+
assert.equal(result.actionType, "policy_escalation");
|
|
343
|
+
});
|
|
344
|
+
test("a reviewer infra-class failure never spends the review-round budget, even at the review-round limit", () => {
|
|
345
|
+
const outcome = { kind: "session_failed" };
|
|
346
|
+
assert.deepStrictEqual(routeReviewerOutcome(outcome, REVIEW_AT_LIMIT, PINNED_HEAD), {
|
|
347
|
+
next: "retry_reviewer",
|
|
348
|
+
headSha: PINNED_HEAD,
|
|
349
|
+
reason: "Reviewer session failed, timed out, its worktree checkout failed, or its output was unparseable.",
|
|
350
|
+
});
|
|
351
|
+
});
|
|
@@ -0,0 +1,127 @@
|
|
|
1
|
+
// packages/server/src/coordinator/session-lifecycle.integration.test.ts
|
|
2
|
+
//
|
|
3
|
+
// The rest of this package's coordinator tests use fakeDeps() for the git-worktree
|
|
4
|
+
// boundary (see session-lifecycle.test.ts, dispatcher.test.ts) — good for the DI seam,
|
|
5
|
+
// but never proves the real adapter (packages/server/src/adapters/git-worktree.ts)
|
|
6
|
+
// actually round-trips with the coordinator. This file exercises the REAL worktree
|
|
7
|
+
// adapter (addWorktree/removeWorktree/isWorktreeClean/mergeBase) against a real temp
|
|
8
|
+
// git repo. github + spawn stay faked: they need network / a real CLI the test
|
|
9
|
+
// environment may not have.
|
|
10
|
+
import { test, before } from "node:test";
|
|
11
|
+
import assert from "node:assert/strict";
|
|
12
|
+
import { execFile } from "node:child_process";
|
|
13
|
+
import { promisify } from "node:util";
|
|
14
|
+
import fs from "node:fs";
|
|
15
|
+
import os from "node:os";
|
|
16
|
+
import path from "node:path";
|
|
17
|
+
const run = promisify(execFile);
|
|
18
|
+
process.env.AGENT_DEALER_HOME = fs.mkdtempSync(path.join(os.tmpdir(), "dealer-lifecycle-integration-"));
|
|
19
|
+
const { migrate } = await import("../db/index.js");
|
|
20
|
+
const { BUILTIN_AGENT_CLAUDE_ID, BUILTIN_AGENT_CURSOR_ID } = await import("@agent-dealer/shared");
|
|
21
|
+
const { createIssue, getIssue } = await import("../repository/issues.js");
|
|
22
|
+
const { listWorkerSessionsForIssue } = await import("../repository/worker-sessions.js");
|
|
23
|
+
const { listOpenHumanActions } = await import("../repository/human-actions.js");
|
|
24
|
+
const { startIssueWorkflow, advanceIssue } = await import("./session-lifecycle.js");
|
|
25
|
+
const worktreeAdapter = await import("../adapters/git-worktree.js");
|
|
26
|
+
before(() => {
|
|
27
|
+
migrate();
|
|
28
|
+
});
|
|
29
|
+
async function git(cwd, args) {
|
|
30
|
+
const { stdout } = await run("git", args, { cwd });
|
|
31
|
+
return stdout.trim();
|
|
32
|
+
}
|
|
33
|
+
async function initRepo() {
|
|
34
|
+
const repo = fs.mkdtempSync(path.join(os.tmpdir(), "dealer-integration-repo-"));
|
|
35
|
+
await git(repo, ["init", "-b", "main"]);
|
|
36
|
+
await git(repo, ["config", "user.email", "test@example.com"]);
|
|
37
|
+
await git(repo, ["config", "user.name", "Test"]);
|
|
38
|
+
fs.writeFileSync(path.join(repo, "README.md"), "hello\n");
|
|
39
|
+
await git(repo, ["add", "README.md"]);
|
|
40
|
+
await git(repo, ["commit", "-m", "initial"]);
|
|
41
|
+
return repo;
|
|
42
|
+
}
|
|
43
|
+
function seedIssue(repo) {
|
|
44
|
+
return createIssue({
|
|
45
|
+
title: "Integration issue",
|
|
46
|
+
description: "test issue",
|
|
47
|
+
acceptanceCriteria: "works",
|
|
48
|
+
repo,
|
|
49
|
+
baseBranch: "main",
|
|
50
|
+
developerAgentId: BUILTIN_AGENT_CLAUDE_ID,
|
|
51
|
+
reviewerAgentId: BUILTIN_AGENT_CURSOR_ID,
|
|
52
|
+
maxReviewRounds: 3,
|
|
53
|
+
source: "manual",
|
|
54
|
+
});
|
|
55
|
+
}
|
|
56
|
+
test("a real git worktree carries a developer commit through to review under the real adapter", async () => {
|
|
57
|
+
const repo = await initRepo();
|
|
58
|
+
const issue = seedIssue(repo);
|
|
59
|
+
const branch = `issue-${issue.id}`;
|
|
60
|
+
// Filled in once the fake "developer" has actually committed inside the real worktree.
|
|
61
|
+
let developerHeadSha = "";
|
|
62
|
+
const deps = {
|
|
63
|
+
worktree: {
|
|
64
|
+
addWorktree: worktreeAdapter.addWorktree,
|
|
65
|
+
removeWorktree: worktreeAdapter.removeWorktree,
|
|
66
|
+
isWorktreeClean: worktreeAdapter.isWorktreeClean,
|
|
67
|
+
mergeBase: worktreeAdapter.mergeBase,
|
|
68
|
+
},
|
|
69
|
+
github: {
|
|
70
|
+
viewPr: async () => ({
|
|
71
|
+
number: 1,
|
|
72
|
+
url: "https://github.com/x/y/pull/1",
|
|
73
|
+
headRefOid: developerHeadSha,
|
|
74
|
+
baseRefName: "main",
|
|
75
|
+
headRefName: branch,
|
|
76
|
+
reviews: [],
|
|
77
|
+
}),
|
|
78
|
+
publishReview: async () => ({ ok: true, event: "APPROVE" }),
|
|
79
|
+
},
|
|
80
|
+
spawnDeveloper: async (session) => {
|
|
81
|
+
const worktreePath = session.worktreePath;
|
|
82
|
+
// Prove this is a REAL git worktree: write a file and commit, on disk.
|
|
83
|
+
fs.writeFileSync(path.join(worktreePath, "feature.txt"), "real work\n");
|
|
84
|
+
await git(worktreePath, ["add", "feature.txt"]);
|
|
85
|
+
await git(worktreePath, ["commit", "-m", "add feature"]);
|
|
86
|
+
developerHeadSha = await git(worktreePath, ["rev-parse", "HEAD"]);
|
|
87
|
+
return { exitCode: 0, transcript: "done", logPath: "/tmp/log" };
|
|
88
|
+
},
|
|
89
|
+
spawnReviewer: async () => ({
|
|
90
|
+
exitCode: 0,
|
|
91
|
+
transcript: "```json\n" +
|
|
92
|
+
JSON.stringify({
|
|
93
|
+
verdict: "approved",
|
|
94
|
+
baseSha: (await git(repo, ["rev-parse", "HEAD"])),
|
|
95
|
+
headSha: developerHeadSha,
|
|
96
|
+
acceptanceCriteriaAssessment: "met",
|
|
97
|
+
evidenceAssessment: "ok",
|
|
98
|
+
findings: [],
|
|
99
|
+
risks: [],
|
|
100
|
+
}) +
|
|
101
|
+
"\n```",
|
|
102
|
+
logPath: "/tmp/log",
|
|
103
|
+
}),
|
|
104
|
+
};
|
|
105
|
+
await startIssueWorkflow(issue.id, deps);
|
|
106
|
+
await advanceIssue(issue.id, deps); // developer: real worktree add -> real commit -> real merge-base
|
|
107
|
+
const afterDev = listWorkerSessionsForIssue(issue.id);
|
|
108
|
+
assert.equal(afterDev.length, 2);
|
|
109
|
+
assert.equal(afterDev[0].status, "done");
|
|
110
|
+
assert.equal(afterDev[1].role, "reviewer");
|
|
111
|
+
assert.equal(afterDev[1].inputSha, developerHeadSha);
|
|
112
|
+
assert.ok(developerHeadSha, "developer session must have produced a real commit sha");
|
|
113
|
+
const afterDevIssue = getIssue(issue.id);
|
|
114
|
+
assert.equal(afterDevIssue?.status, "reviewing");
|
|
115
|
+
assert.equal(afterDevIssue?.headSha, developerHeadSha);
|
|
116
|
+
// The developer's worktree must have been cleaned up by the real adapter, but the
|
|
117
|
+
// branch it created must survive in the bare repo for the reviewer worktree to check out.
|
|
118
|
+
const branches = await git(repo, ["branch", "--list", branch]);
|
|
119
|
+
assert.ok(branches.includes(branch));
|
|
120
|
+
await advanceIssue(issue.id, deps); // reviewer: real detached worktree checkout at the developer's real commit
|
|
121
|
+
const afterReview = listWorkerSessionsForIssue(issue.id);
|
|
122
|
+
assert.equal(afterReview.length, 2);
|
|
123
|
+
assert.equal(afterReview[1].status, "done");
|
|
124
|
+
assert.equal(getIssue(issue.id)?.status, "final_review");
|
|
125
|
+
assert.ok(listOpenHumanActions().some((a) => a.issueId === issue.id && a.actionType === "final_review"));
|
|
126
|
+
fs.rmSync(repo, { recursive: true, force: true });
|
|
127
|
+
});
|