agent-dealer 0.1.3 → 0.1.4

package/bundle/server/dist/adapters/agent-deck-deliver.test.js

@@ -0,0 +1,52 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { assertCallServiceToolSuccess, toCallServiceToolPayload } from "./agent-deck.js";
+test("toCallServiceToolPayload maps serviceName to serviceId verbatim args", () => {
+    const toolCall = {
+        serviceName: "34eb6c24-f151-4da2-8db8-d6996aa296be",
+        toolName: "chat_postMessage",
+        arguments: { channel: "C123", text: "Hello world" },
+    };
+    const payload = toCallServiceToolPayload(toolCall);
+    assert.equal(payload.serviceId, toolCall.serviceName);
+    assert.equal(payload.toolName, toolCall.toolName);
+    assert.deepEqual(payload.arguments, toolCall.arguments);
+});
+test("assertCallServiceToolSuccess throws on deck proxy failure JSON", () => {
+    assert.throws(() => assertCallServiceToolSuccess({
+        content: [{ type: "text", text: JSON.stringify({ success: false, error: "Service not found" }) }],
+    }), /Service not found/);
+});
+test("assertCallServiceToolSuccess throws on nested Slack channel_not_found", () => {
+    const receipt = {
+        content: [
+            {
+                type: "text",
+                text: JSON.stringify({
+                    content: [{ type: "text", text: "channel_not_found\n\nThe channel could not be found." }],
+                    isError: true,
+                }),
+            },
+        ],
+    };
+    assert.throws(() => assertCallServiceToolSuccess(receipt), /channel_not_found/);
+});
+test("assertCallServiceToolSuccess throws on deck-wrapped Slack JSON (live MCP shape)", () => {
+    const receipt = {
+        content: [
+            {
+                type: "text",
+                text: JSON.stringify({
+                    content: [
+                        {
+                            type: "text",
+                            text: "channel_not_found\n\nThe channel could not be found. It may not exist, may be in a different workspace than your app is installed on, or your app may lack permission to access it.",
+                        },
+                    ],
+                    isError: true,
+                }),
+            },
+        ],
+    };
+    assert.throws(() => assertCallServiceToolSuccess(receipt), /channel_not_found/);
+});

package/bundle/server/dist/adapters/agent-deck.js

@@ -1,5 +1,7 @@
 import fs from "node:fs";
 import path from "node:path";
+import { Client } from "@modelcontextprotocol/sdk/client/index.js";
+import { StreamableHTTPClientTransport } from "@modelcontextprotocol/sdk/client/streamableHttp.js";
 import { getAgentDeckConfig } from "../repository/intake-settings.js";
 export function getAgentDeckApiUrl() {
     if (process.env.AGENT_DECK_API_URL) {
@@ -134,3 +136,141 @@ export function isAgentDeckMcpRegistered() {
         return false;
     }
 }
+/** Map PRD toolCall to deck MCP call_service_tool args (serviceName → serviceId). */
+export function toCallServiceToolPayload(toolCall) {
+    return {
+        serviceId: toolCall.serviceName,
+        toolName: toolCall.toolName,
+        arguments: toolCall.arguments,
+    };
+}
+function extractPermalink(toolResult) {
+    if (!toolResult || typeof toolResult !== "object")
+        return undefined;
+    const content = toolResult.content;
+    if (!Array.isArray(content))
+        return undefined;
+    for (const block of content) {
+        if (block.type !== "text" || !block.text)
+            continue;
+        try {
+            const parsed = JSON.parse(block.text);
+            if (parsed.permalink)
+                return parsed.permalink;
+        }
+        catch {
+            const m = block.text.match(/https?:\/\/\S+/);
+            if (m)
+                return m[0];
+        }
+    }
+    return undefined;
+}
+/** Parse Agent Deck call_service_tool MCP result — throws on proxy- or Slack-reported failure. */
+export function assertCallServiceToolSuccess(toolResult) {
+    const err = findCallServiceToolError(toolResult);
+    if (err)
+        throw new Error(err);
+}
+function findCallServiceToolError(toolResult, depth = 0) {
+    if (!toolResult || typeof toolResult !== "object" || depth > 4)
+        return undefined;
+    const tr = toolResult;
+    if (tr.isError) {
+        const text = formatToolResultText(tr) ?? "call_service_tool failed";
+        const nested = parseNestedCallServiceToolError(text, depth);
+        if (nested)
+            return nested;
+        return summarizeToolErrorText(text) ?? text.slice(0, 500);
+    }
+    if (tr.success === false) {
+        return tr.error ?? "call_service_tool failed";
+    }
+    const text = formatToolResultText(tr);
+    if (text) {
+        const nested = parseNestedCallServiceToolError(text, depth);
+        if (nested)
+            return nested;
+        const plain = summarizeToolErrorText(text);
+        if (plain)
+            return plain;
+    }
+    return undefined;
+}
+function parseNestedCallServiceToolError(text, depth) {
+    try {
+        const parsed = JSON.parse(text);
+        return findCallServiceToolError(parsed, depth + 1);
+    }
+    catch {
+        return undefined;
+    }
+}
+const SLACK_ERROR_RE = /channel_not_found|not_in_channel|missing_scope|invalid_auth|user_not_found|cannot_dm|is_archived/i;
+function summarizeToolErrorText(text) {
+    const t = text.trim();
+    if (!t)
+        return undefined;
+    try {
+        const parsed = JSON.parse(t);
+        if (typeof parsed.error === "string" && parsed.error.trim())
+            return parsed.error.trim();
+        if (typeof parsed.message === "string" && parsed.message.trim())
+            return parsed.message.trim();
+    }
+    catch {
+        // not top-level JSON — fall through
+    }
+    if (SLACK_ERROR_RE.test(t)) {
+        const line = t.split("\n").find((l) => SLACK_ERROR_RE.test(l));
+        if (line?.trim())
+            return line.trim().slice(0, 500);
+        const match = t.match(SLACK_ERROR_RE);
+        if (match)
+            return match[0];
+    }
+    if (/"success"\s*:\s*false/i.test(t)) {
+        try {
+            const parsed = JSON.parse(t);
+            if (typeof parsed.error === "string" && parsed.error.trim())
+                return parsed.error.trim();
+        }
+        catch {
+            // ignore
+        }
+    }
+    return undefined;
+}
+function formatToolResultText(tr) {
+    if (!Array.isArray(tr.content))
+        return undefined;
+    return tr.content
+        .filter((b) => b.type === "text" && b.text)
+        .map((b) => b.text)
+        .join("\n")
+        .trim() || undefined;
+}
+export async function deliverOutboundDraft(deckId, toolCall, opts) {
+    const payload = toCallServiceToolPayload(toolCall);
+    const workspaceRoot = opts?.workspaceRoot ?? process.cwd();
+    const callTool = opts?.callTool ??
+        (async (p) => {
+            const mcpBase = getAgentDeckMcpUrl().replace(/\/mcp\/?$/, "");
+            const transport = new StreamableHTTPClientTransport(new URL(`${mcpBase}/mcp`));
+            const client = new Client({ name: "agent-dealer-deliver", version: "0.0.1" });
+            await client.connect(transport);
+            try {
+                await client.callTool({
+                    name: "bind_workspace",
+                    arguments: { deckId, workspaceRoot },
+                });
+                return await client.callTool({ name: "call_service_tool", arguments: p });
+            }
+            finally {
+                await client.close();
+            }
+        });
+    const toolResult = await callTool(payload);
+    assertCallServiceToolSuccess(toolResult);
+    return { toolResult, permalink: extractPermalink(toolResult) };
+}

package/bundle/server/dist/queue/approve-deliver.js

@@ -0,0 +1,62 @@
+import { deliverOutboundDraft } from "../adapters/agent-deck.js";
+import { syncLinearForRun } from "../adapters/linear-sync.js";
+import { workspaceForRun } from "../runners/prompts.js";
+import { addArtifact, appendEvent, getRun, transitionRun, } from "../repository/runs.js";
+import { deliverInFlight, getPendingOutboundDraft, markOutboundDraftSent, } from "../repository/outbound-drafts.js";
+import { scheduleReflect } from "./dispatcher.js";
+export async function approveRunWithDeliver(runId, deps) {
+    const run = getRun(runId);
+    if (!run)
+        return { ok: false, code: 404, error: "Not found" };
+    if (run.status !== "review") {
+        return { ok: false, code: 400, error: "Run must be in review" };
+    }
+    if (deliverInFlight.has(runId)) {
+        return { ok: false, code: 409, error: "Deliver already in progress" };
+    }
+    const pending = getPendingOutboundDraft(runId);
+    if (!pending) {
+        const updated = transitionRun(runId, "done");
+        syncLinearForRun(updated, "done").catch((e) => console.error("[linear-sync] done:", e));
+        scheduleReflect(updated, { trigger: "approve" });
+        return { ok: true, run: updated, delivered: false };
+    }
+    if (!run.deckId) {
+        return { ok: false, code: 502, error: "No deck bound — cannot deliver outbound draft" };
+    }
+    const deliver = deps?.deliver ?? deliverOutboundDraft;
+    deliverInFlight.add(runId);
+    try {
+        let toolResult;
+        let permalink;
+        try {
+            const result = await deliver(run.deckId, pending.content.draft.toolCall, {
+                workspaceRoot: workspaceForRun(run),
+            });
+            toolResult = result.toolResult;
+            permalink = result.permalink;
+        }
+        catch (err) {
+            const message = err instanceof Error ? err.message : String(err);
+            appendEvent(runId, "deliver_failed", { error: message });
+            return { ok: false, code: 502, error: message };
+        }
+        const sent = markOutboundDraftSent(pending.artifact.id);
+        if (!sent) {
+            return { ok: false, code: 409, error: "Draft already sent or rejected" };
+        }
+        addArtifact(runId, "send_receipt", {
+            draftArtifactId: pending.artifact.id,
+            sentAt: new Date().toISOString(),
+            toolResult: toolResult,
+            permalink,
+        }, "system");
+        const updated = transitionRun(runId, "done");
+        syncLinearForRun(updated, "done").catch((e) => console.error("[linear-sync] done:", e));
+        scheduleReflect(updated, { trigger: "approve" });
+        return { ok: true, run: updated, delivered: true };
+    }
+    finally {
+        deliverInFlight.delete(runId);
+    }
+}

package/bundle/server/dist/queue/dispatcher.js

@@ -6,6 +6,7 @@ import { persistRunOutput, seedDeliverableFromParent } from "../runners/persist.
 import { checkAgentDeckHealth } from "../adapters/agent-deck.js";
 import { pollLinearIssues } from "../adapters/external.js";
 import { syncLinearForRun } from "../adapters/linear-sync.js";
+import { pendingSendCount } from "../repository/outbound-drafts.js";
 import { listAgentsWithHealth } from "../adapters/agent-health.js";
 import { listAgents } from "../repository/agents.js";
 import { runReflect } from "../runners/reflect.js";
@@ -84,9 +85,18 @@ export function getSnapshot() {
             openQuestionCounts[run.id] = n;
     }
     const awaitingAnswerRuns = awaitingPlanReview.filter((r) => openQuestionCounts[r.id]);
+    const pendingSendCounts = {};
+    for (const run of resultReviewRuns) {
+        const n = pendingSendCount(run.id);
+        if (n > 0)
+            pendingSendCounts[run.id] = n;
+    }
     const autoApprovedRunIds = [...waitingExecution, ...runningRuns]
         .filter((r) => getLatestArtifact(r.id, "approved_plan")?.author === "system")
         .map((r) => r.id);
+    const sentRunIds = recentDone
+        .filter((r) => getLatestArtifact(r.id, "send_receipt"))
+        .map((r) => r.id);
     return {
         planReviewCount: awaitingPlanReview.length,
         resultReviewCount: resultReviewRuns.length,
@@ -100,6 +110,8 @@ export function getSnapshot() {
         awaitingPlanReview,
         awaitingAnswerRuns,
         openQuestionCounts,
+        pendingSendCounts,
+        sentRunIds,
         autoApprovedRunIds,
         runs: all,
         agentDeckOnline: false,

package/bundle/server/dist/queue/send-gate.test.js

@@ -0,0 +1,108 @@
+import { test, before } from "node:test";
+import assert from "node:assert/strict";
+import fs from "node:fs";
+import os from "node:os";
+import path from "node:path";
+process.env.AGENT_DEALER_HOME = fs.mkdtempSync(path.join(os.tmpdir(), "dealer-send-gate-"));
+process.env.MAX_CONCURRENT_RUNS = "0";
+const { migrate } = await import("../db/index.js");
+const { BUILTIN_AGENT_CLAUDE_ID } = await import("@agent-dealer/shared");
+const { updateAgent } = await import("../repository/agents.js");
+const { addArtifact, createRun, getLatestArtifact, getRun, transitionRun, updateRunFields, } = await import("../repository/runs.js");
+const { approveRunWithDeliver } = await import("./approve-deliver.js");
+const { rejectPendingOutboundDrafts, pendingSendCount } = await import("../repository/outbound-drafts.js");
+const { getSnapshot } = await import("./dispatcher.js");
+const TOOL_CALL = {
+    serviceName: "34eb6c24-f151-4da2-8db8-d6996aa296be",
+    toolName: "chat_postMessage",
+    arguments: { channel: "C1", text: "Hello gate test" },
+};
+const DRAFT_CONTENT = {
+    draft: {
+        actionType: "slack_message",
+        summary: { target: "#test", body: "Hello gate test" },
+        toolCall: TOOL_CALL,
+    },
+    status: "pending",
+};
+before(() => {
+    migrate();
+    updateAgent(BUILTIN_AGENT_CLAUDE_ID, { workspaceRoot: process.env.AGENT_DEALER_HOME });
+});
+function seedReviewRun(withDraft = true) {
+    const run = createRun({
+        title: "Send gate test",
+        taskCategory: "communication",
+        status: "plan_pending",
+        agentId: BUILTIN_AGENT_CLAUDE_ID,
+    });
+    updateRunFields(run.id, { deck_id: "6e825b59-13de-4ddd-ab7e-55ab5a1c279a" });
+    transitionRun(run.id, "plan_approved");
+    transitionRun(run.id, "running");
+    transitionRun(run.id, "review");
+    if (withDraft) {
+        addArtifact(run.id, "slack_draft", DRAFT_CONTENT, "agent");
+    }
+    return getRun(run.id);
+}
+test("pendingSendCount is 1 when draft pending", () => {
+    const run = seedReviewRun(true);
+    assert.equal(pendingSendCount(run.id), 1);
+});
+test("approve without draft transitions to done", async () => {
+    const run = seedReviewRun(false);
+    const res = await approveRunWithDeliver(run.id);
+    assert.equal(res.ok, true);
+    assert.equal(res.ok && res.delivered, false);
+    assert.equal(getRun(run.id).status, "done");
+});
+test("approve with mock deliver sends byte-identical payload and creates receipt", async () => {
+    const run = seedReviewRun(true);
+    let captured = null;
+    const res = await approveRunWithDeliver(run.id, {
+        deliver: async (_deckId, toolCall) => {
+            captured = toolCall;
+            return { toolResult: { ok: true }, permalink: "https://slack.example/msg/1" };
+        },
+    });
+    assert.equal(res.ok, true);
+    assert.equal(res.ok && res.delivered, true);
+    assert.deepEqual(captured, TOOL_CALL);
+    assert.equal(getRun(run.id).status, "done");
+    assert.ok(getLatestArtifact(run.id, "send_receipt"));
+    const draftArt = getLatestArtifact(run.id, "slack_draft");
+    assert.match(draftArt.contentJson, /"status":"sent"/);
+});
+test("deliver failure keeps run in review with pending draft", async () => {
+    const run = seedReviewRun(true);
+    const res = await approveRunWithDeliver(run.id, {
+        deliver: async () => {
+            throw new Error("deck down");
+        },
+    });
+    assert.equal(res.ok, false);
+    assert.equal(!res.ok && res.code, 502);
+    assert.equal(getRun(run.id).status, "review");
+    assert.equal(pendingSendCount(run.id), 1);
+});
+test("proxy success:false from deck is treated as deliver failure", async () => {
+    const run = seedReviewRun(true);
+    const res = await approveRunWithDeliver(run.id, {
+        deliver: async () => {
+            throw new Error("Service not found");
+        },
+    });
+    assert.equal(res.ok, false);
+    assert.equal(getRun(run.id).status, "review");
+});
+test("retry rejects pending draft", () => {
+    const run = seedReviewRun(true);
+    rejectPendingOutboundDrafts(run.id);
+    assert.equal(pendingSendCount(run.id), 0);
+    const draftArt = getLatestArtifact(run.id, "slack_draft");
+    assert.match(draftArt.contentJson, /"status":"rejected"/);
+});
+test("snapshot exposes pendingSendCounts", () => {
+    const snap = getSnapshot();
+    assert.equal(typeof snap.pendingSendCounts, "object");
+});

package/bundle/server/dist/repository/outbound-drafts.js

@@ -0,0 +1,62 @@
+import { isOutboundDraftKind } from "@agent-dealer/shared";
+import { getDb } from "../db/index.js";
+import { listArtifacts } from "./runs.js";
+export function getPendingOutboundDraft(runId) {
+    const arts = listArtifacts(runId).filter((a) => isOutboundDraftKind(a.kind) && a.contentJson);
+    for (let i = arts.length - 1; i >= 0; i--) {
+        const art = arts[i];
+        try {
+            const content = JSON.parse(art.contentJson);
+            if (content.status === "pending") {
+                return { artifact: art, content };
+            }
+        }
+        catch {
+            // skip
+        }
+    }
+    return null;
+}
+export function pendingSendCount(runId) {
+    return getPendingOutboundDraft(runId) ? 1 : 0;
+}
+export function rejectPendingOutboundDrafts(runId) {
+    const now = new Date().toISOString();
+    const db = getDb();
+    for (const art of listArtifacts(runId)) {
+        if (!isOutboundDraftKind(art.kind) || !art.contentJson)
+            continue;
+        try {
+            const content = JSON.parse(art.contentJson);
+            if (content.status !== "pending")
+                continue;
+            const next = { ...content, status: "rejected", rejectedAt: now };
+            db.prepare("UPDATE artifacts SET content_json = ? WHERE id = ?").run(JSON.stringify(next), art.id);
+        }
+        catch {
+            // skip
+        }
+    }
+}
+/** Atomic pending → sent transition. Returns false if not pending. */
+export function markOutboundDraftSent(artifactId) {
+    const db = getDb();
+    const row = db.prepare("SELECT content_json FROM artifacts WHERE id = ?").get(artifactId);
+    if (!row?.content_json)
+        return false;
+    let content;
+    try {
+        content = JSON.parse(row.content_json);
+    }
+    catch {
+        return false;
+    }
+    if (content.status !== "pending")
+        return false;
+    const next = { ...content, status: "sent", sentAt: new Date().toISOString() };
+    const result = db
+        .prepare("UPDATE artifacts SET content_json = ? WHERE id = ? AND content_json = ?")
+        .run(JSON.stringify(next), artifactId, row.content_json);
+    return result.changes === 1;
+}
+export const deliverInFlight = new Set();

package/bundle/server/dist/routes/index.js

@@ -5,6 +5,8 @@ import { addArtifact, createRun, findActiveByExternalId, getRun, listArtifacts,
 import { createAgent, deleteAgent, getAgent, listAgents, updateAgent, } from "../repository/agents.js";
 import { listAgentsWithHealth } from "../adapters/agent-health.js";
 import { forceDispatch, getSnapshotAsync, kickRun, schedulePlanDraft, scheduleRedraft, scheduleReflect, submitPlanAnswers, subscribe, } from "../queue/dispatcher.js";
+import { approveRunWithDeliver } from "../queue/approve-deliver.js";
+import { rejectPendingOutboundDrafts } from "../repository/outbound-drafts.js";
 import { fetchAgentDeckDecks, updatePlaybookBody } from "../adapters/agent-deck.js";
 import { testAgentDeckConnection } from "../adapters/agent-deck.js";
 import { getLinearIssue, listLinearCandidates, testLinearConnection, } from "../adapters/linear-inbox.js";
@@ -373,16 +375,11 @@ export async function registerRoutes(app) {
     });
     app.post("/api/runs/:id/approve", async (req, reply) => {
         const { id } = req.params;
-        const run = getRun(id);
-        if (!run)
-            return reply.status(404).send({ error: "Not found" });
-        if (run.status !== "review") {
-            return reply.status(400).send({ error: "Run must be in review" });
+        const result = await approveRunWithDeliver(id);
+        if (!result.ok) {
+            return reply.status(result.code).send({ error: result.error });
         }
-        const updated = transitionRun(id, "done");
-        syncLinearForRun(updated, "done").catch((e) => console.error("[linear-sync] done:", e));
-        scheduleReflect(updated, { trigger: "approve" });
-        return updated;
+        return result.run;
     });
     app.post("/api/runs/:id/retry", async (req, reply) => {
         const { id } = req.params;
@@ -398,6 +395,7 @@ export async function registerRoutes(app) {
         }
         const input = RetryRunInput.parse(req.body);
         addArtifact(id, "feedback", { markdown: input.feedback }, "human");
+        rejectPendingOutboundDrafts(id);
         const retry = createRun({
             title: run.title,
             description: run.description ?? undefined,

package/bundle/server/dist/runners/claude-args.js

@@ -0,0 +1,24 @@
+import { getTemporalOutputDir } from "../paths.js";
+export const DENY_SEND_TOOL = "mcp__agent-deck__call_service_tool";
+const DECK_READ_TOOLS = "mcp__agent-deck__get_playbook,mcp__agent-deck__get_bound_deck,mcp__agent-deck__bind_workspace,mcp__agent-deck__list_service_tools";
+const PLAN_REFLECT_TOOLS = `Read,Glob,Grep,Skill,${DECK_READ_TOOLS}`;
+function executeToolsForCategory(category) {
+    const base = ["Read", "Write", "Edit", "Glob", "Grep", "Skill", DECK_READ_TOOLS];
+    if (category !== "communication" && category !== "email") {
+        base.splice(5, 0, "Bash");
+    }
+    return base.join(",");
+}
+/** Build claude -p CLI args for a phase (excluding prompt, model, resume, mcp-config, budget). */
+export function buildClaudePhaseArgs(run, mode) {
+    const args = ["--output-format", "stream-json", "--verbose"];
+    if (mode === "plan" || mode === "reflect") {
+        args.push("--allowedTools", PLAN_REFLECT_TOOLS);
+    }
+    else {
+        args.push("--add-dir", getTemporalOutputDir());
+        args.push("--allowedTools", executeToolsForCategory(run.taskCategory));
+    }
+    args.push("--disallowedTools", DENY_SEND_TOOL);
+    return args;
+}

package/bundle/server/dist/runners/claude.js

@@ -3,10 +3,11 @@ import fs from "node:fs";
 import path from "node:path";
 import { buildExecutionPrompt, buildExecutionContinuationPrompt, buildPlanPrompt, buildReflectPrompt, workspaceForRun } from "./prompts.js";
 import { humanFeedbackText, lineageParentExecuteSessionId } from "./run-context.js";
-import { getTemporalLogsDir, getTemporalOutputDir } from "../paths.js";
+import { getTemporalLogsDir } from "../paths.js";
 import { resolveClaudeBin, resolveCursorBin } from "../cli-env.js";
 import { resolveBudgetForPhase, resolveModelForPhase, getRun } from "../repository/runs.js";
 import { budgetCliArgs } from "@agent-dealer/shared";
+import { buildClaudePhaseArgs } from "./claude-args.js";
 async function spawnCli(cmd, args, cwd) {
     return new Promise((resolve, reject) => {
         const chunks = [];
@@ -50,19 +51,8 @@ export async function runClaude(run, mode = "execute", model, opts) {
         "--mcp-config",
         mcpConfig,
         ...budgetCliArgs(phaseBudget),
-        "--output-format",
-        "stream-json",
-        "--verbose",
+        ...buildClaudePhaseArgs(run, mode),
     ];
-    if (mode === "plan") {
-        args.push("--allowedTools", "Read,Glob,Grep,Skill,mcp__agent-deck__get_playbook,mcp__agent-deck__get_bound_deck,mcp__agent-deck__bind_workspace");
-    }
-    else if (mode === "reflect") {
-        args.push("--allowedTools", "Read,Glob,Grep,Skill,mcp__agent-deck__get_playbook,mcp__agent-deck__get_bound_deck,mcp__agent-deck__bind_workspace");
-    }
-    else {
-        args.push("--add-dir", getTemporalOutputDir(), "--allowedTools", "Read,Write,Edit,Glob,Grep,Bash,Skill,mcp__agent-deck__get_playbook,mcp__agent-deck__get_bound_deck,mcp__agent-deck__bind_workspace");
-    }
     const { exitCode, transcript } = await spawnCli(resolveClaudeBin(), args, workspaceForRun(run));
     if (transcript)
         fs.writeFileSync(logPath, transcript);

package/bundle/server/dist/runners/claude.test.js

@@ -0,0 +1,58 @@
+import { test } from "node:test";
+import assert from "node:assert/strict";
+import { buildClaudePhaseArgs, DENY_SEND_TOOL } from "./claude-args.js";
+const baseRun = {
+    id: "00000000-0000-4000-a000-000000000099",
+    source: "manual",
+    externalId: null,
+    externalLabel: null,
+    title: "Test",
+    description: null,
+    repo: null,
+    artifactWorkspace: null,
+    agentId: null,
+    agentName: null,
+    deckId: null,
+    deckName: null,
+    playbookId: null,
+    runtime: "claude_code",
+    planModel: null,
+    executeModel: null,
+    status: "running",
+    lineageId: null,
+    acceptanceCriteria: null,
+    approvalGatesJson: null,
+    budgetJson: null,
+    createdAt: new Date().toISOString(),
+    updatedAt: new Date().toISOString(),
+};
+function runWithCategory(taskCategory) {
+    return { ...baseRun, taskCategory };
+}
+function hasDisallowSend(args) {
+    const i = args.indexOf("--disallowedTools");
+    return i >= 0 && args[i + 1] === DENY_SEND_TOOL;
+}
+test("all phases deny call_service_tool", () => {
+    for (const mode of ["plan", "execute", "reflect"]) {
+        const args = buildClaudePhaseArgs(runWithCategory("code"), mode);
+        assert.equal(hasDisallowSend(args), true, mode);
+    }
+});
+test("execute allowlist includes list_service_tools", () => {
+    const args = buildClaudePhaseArgs(runWithCategory("code"), "execute");
+    const i = args.indexOf("--allowedTools");
+    assert.match(args[i + 1], /list_service_tools/);
+});
+test("communication and email execute omit Bash", () => {
+    for (const cat of ["communication", "email"]) {
+        const args = buildClaudePhaseArgs(runWithCategory(cat), "execute");
+        const i = args.indexOf("--allowedTools");
+        assert.doesNotMatch(args[i + 1], /\bBash\b/);
+    }
+});
+test("code execute retains Bash", () => {
+    const args = buildClaudePhaseArgs(runWithCategory("code"), "execute");
+    const i = args.indexOf("--allowedTools");
+    assert.match(args[i + 1], /\bBash\b/);
+});