npm - agent-dag - Versions diffs - 3.8.8 → 3.8.9 - Mend

agent-dag 3.8.8 → 3.8.9

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (12) hide show

package/bin/agent-dag.js +2 -2
package/bin/deck.js +13 -4
package/dist/web/assets/{index-DLRqo4Ty.js → index-Dq0gpZ5v.js} +2 -2
package/dist/web/index.html +1 -1
package/package.json +1 -1
package/release-notes.json +6 -0
package/src/server/browser-presence.mjs +9 -0
package/src/server/browser-react.mjs +8 -2
package/src/server/claude-accounts.mjs +17 -1
package/src/server/self-update.mjs +36 -2
package/src/server/supervisor.mjs +3 -3
package/src/server/term.mjs +9 -2

package/dist/web/index.html CHANGED Viewed

@@ -40,7 +40,7 @@
         document.documentElement.setAttribute("data-theme", stored === "light" ? "light" : "dark");
       })();
     </script>
-    <script type="module" crossorigin src="/assets/index-DLRqo4Ty.js"></script>
+    <script type="module" crossorigin src="/assets/index-Dq0gpZ5v.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-ByAgTqB8.css">
   </head>
   <body>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "agent-dag",
-  "version": "3.8.8",
+  "version": "3.8.9",
   "description": "Live deck of Claude Code and Codex agents — watch tool calls, token spend and every Claude Code subagent on one calm canvas. Run it with npx ccdeck.",
   "type": "module",
   "bin": {

package/release-notes.json CHANGED Viewed

@@ -31,6 +31,12 @@
     "about a defect in the type, and the suite refuses both it and no space at",
     "all."
   ],
+  "3.8.9": [
+    {
+      "title": "\ud83d\udda5\ufe0f Four things that only went wrong on somebody else's operating system",
+      "body": "**Ubuntu:** the deck knew where Chromium and Brave keep their profiles when installed as a snap or a flatpak \u2014 which on a default Ubuntu is the only place Chromium is \u2014 but not what those programs are called. So it reported them as not running while they were, and refused to quit them. Both now work.\n\n**Windows:** the deck asked the system whether it could write to the folder an update installs into, and Windows always answers yes for a folder whatever the permissions say. It offered you an update that then died inside npm with a permission error. It now finds out by trying, and declines up front with the command to run yourself \u2014 which is what every other platform already got.\n\n**Linux:** if `XDG_DATA_HOME` was set to something starting with `~`, as it is from a systemd unit or a Dockerfile, the deck and claude-swap looked in two different places for your accounts. The panel said you had none while `cswap list` showed them all.\n\n**Plain terminals:** six messages used a typographic dash the old Windows console and the Linux text console cannot draw, so a box appeared mid-sentence \u2014 including in the line that explains why no events are arriving. They use the plain form on those terminals now, like everything else already did."
+    }
+  ],
   "3.8.8": [
     {
       "title": "\ud83d\udcc9 A false 99% on the memory chart, and three other quiet failures",

package/src/server/browser-presence.mjs CHANGED Viewed

@@ -76,6 +76,15 @@ const APP_NAME = {
     "chrome-beta": "chrome",
     "chrome-canary": "chrome",
     chromium: "chromium",
+    // The two roots `browserRoots` emits and this table used to miss (#794).
+    // The snap path's own comment there says it "is the only Chromium root a
+    // default Ubuntu install has" — so on stock Ubuntu the panel reported
+    // Chromium as not running while it was running, and the quit reaction,
+    // which `available("linux")` does offer, answered `unknown_browser` on
+    // every finding from either of them. darwin covers all 8 of its roots and
+    // win32 all 7 of its own; only this table was short.
+    "chromium-snap": "chromium",
+    "brave-flatpak": "brave",
     brave: "brave",
     edge: "msedge",
     vivaldi: "vivaldi-bin",

package/src/server/browser-react.mjs CHANGED Viewed

@@ -206,10 +206,16 @@ export async function closeTab(browserKey, url, platform = process.platform, dep
 /** Quit a browser. The only reaction that takes the session back. */
 export async function quitBrowser(browserKey, platform = process.platform, deps = {}) {
-  const app = appName(browserKey);
-  if (!app) return { ok: false, reason: "unknown_browser" };
   const exec = deps.run ?? run;
   if (platform === "darwin") {
+    // The darwin display-name table is consulted HERE rather than at the top of
+    // the function (#794). It used to gate every platform, so a browser missing
+    // from a macOS-only table — `chromium-snap` and `brave-flatpak`, the two
+    // roots a default Ubuntu install actually has — answered `unknown_browser`
+    // on Linux before the branch that would have known what to do with it was
+    // ever reached.
+    const app = appName(browserKey);
+    if (!app) return { ok: false, reason: "unknown_browser" };
     const r = await exec("osascript", [
       // `--`, as everywhere else that hands osascript an operand. `app` comes
       // from a fixed table so it is safe by construction; the separator costs

package/src/server/claude-accounts.mjs CHANGED Viewed

@@ -39,7 +39,23 @@ import { homedir, platform } from "node:os";
 export function backupRoot() {
   if (process.env.CLAUDE_SWAP_BACKUP) return process.env.CLAUDE_SWAP_BACKUP;
   if (platform() === "linux") {
-    const xdg = process.env.XDG_DATA_HOME;
+    // `~` IS EXPANDED BEFORE THE ABSOLUTENESS TEST (#796), which is what
+    // claude-swap's own paths.py does: `Path(os.path.expanduser(xdg))` and then
+    // `is_absolute()`, under a docstring saying it exists so that "values like
+    // `~/data` set via systemd unit files or Dockerfiles (which don't get shell
+    // expansion) still work". This function claims to mirror that and did not.
+    //
+    // Unexpanded, `XDG_DATA_HOME=~/data` failed `startsWith("/")` and the deck
+    // read ~/.local/share/claude-swap while cswap read and wrote
+    // ~/data/claude-swap. The Accounts panel then reported `no_accounts` while
+    // `cswap list` showed the roster — and the damaging part is
+    // `seedFirstAccount`, which reads a missing sequence file as zero accounts,
+    // passes its `before > 0` guard, and runs `cswap add` against a populated
+    // store, re-pointing activeAccountNumber with nothing here to restore it.
+    const raw = process.env.XDG_DATA_HOME;
+    const xdg = raw === "~" ? homedir()
+      : raw?.startsWith("~/") ? join(homedir(), raw.slice(2))
+      : raw;
     if (xdg && xdg.startsWith("/")) return join(xdg, "claude-swap");
     return join(homedir(), ".local/share/claude-swap");
   }

package/src/server/self-update.mjs CHANGED Viewed

@@ -22,7 +22,7 @@
 // it by name and only where it can actually work: a global install, on a
 // directory we can write, outside a git checkout and outside an npx cache.
 // Everywhere else this stays what it has always been — a printed command.
-import { accessSync, constants as FS, existsSync, mkdirSync, readdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { accessSync, constants as FS, existsSync, mkdirSync, readdirSync, readFileSync, rmSync, unlinkSync, writeFileSync } from "node:fs";
 import { spawn } from "node:child_process";
 import { homedir } from "node:os";
 import { dirname, join, resolve } from "node:path";
@@ -894,8 +894,42 @@ export function upgradeMode(blockedReason) {
   return blockedReason === "npx" ? "npx" : null;
 }
+/**
+ * Can this user write into `p`?
+ *
+ * ON WINDOWS THE QUESTION HAS TO BE ASKED BY WRITING (#795). libuv's
+ * `fs__access` short-circuits to success for anything carrying
+ * FILE_ATTRIBUTE_DIRECTORY — "Directories cannot be read-only on Windows" — and
+ * never consults the ACL; Node documents this. Both arguments this is called
+ * with are always directories, so `writable` was unconditionally true there,
+ * `upgradeBlockedReason` could never answer `not_writable`, and the banner
+ * offered "Update & restart" on the common nvm-windows layout where the global
+ * prefix is C:\Program Files\nodejs and a non-elevated shell cannot write it.
+ * npm then died with EPERM and the user got a truncated npm log tail in a
+ * 46-character box — where a POSIX user in the same position gets "the install
+ * directory is not writable by this user" and the command to paste. The comment
+ * on upgradeBlockedReason states the intent the platform defeated: "Failing
+ * inside npm with EACCES tells the user less than declining up front does."
+ *
+ * The probe is `createTemp`'s "wx" pattern, synchronously: a name nothing else
+ * can be using, created exclusively and removed at once. POSIX keeps
+ * `accessSync`, where it is correct and cheaper.
+ */
 function dirWritable(p) {
-  try { accessSync(p, FS.W_OK); return true; } catch { return false; }
+  if (process.platform !== "win32") {
+    try { accessSync(p, FS.W_OK); return true; } catch { return false; }
+  }
+  // `wx` fails if the name exists, so a collision reads as "not writable"
+  // rather than clobbering somebody's file — hence pid and a random suffix.
+  const probe = join(p, `.ccdeck-w-${process.pid}-${Math.random().toString(36).slice(2, 8)}`);
+  try {
+    writeFileSync(probe, "", { flag: "wx" });
+    return true;
+  } catch {
+    return false;
+  } finally {
+    try { unlinkSync(probe); } catch { /* never created, or already gone */ }
+  }
 }
 /** The same question, answered against the real filesystem and environment. */

package/src/server/supervisor.mjs CHANGED Viewed

@@ -225,13 +225,13 @@ export function upgradeAttempt({
  *  banner and the terminal say, so it has to name the version, say what already
  *  happened to it, and leave the user somewhere to go. The copyable command is
  *  already on screen next to it. */
-export function upgradeRefusalText({ reason, waitMs = 0, attempt = 0 } = {}, target = null) {
+export function upgradeRefusalText({ reason, waitMs = 0, attempt = 0, dash = "—" } = {}, target = null) {
   const what = target ? `v${target}` : "this update";
   if (reason === "exhausted") {
-    return `${what} failed to fetch ${attempt} times — not trying again from here; run the command yourself`;
+    return `${what} failed to fetch ${attempt} times ${dash} not trying again from here; run the command yourself`;
   }
   const left = waitMs >= 60_000 ? `${Math.ceil(waitMs / 60_000)}m` : `${Math.max(1, Math.ceil(waitMs / 1000))}s`;
-  return `${what} failed to fetch a moment ago — waiting ${left} before trying again`;
+  return `${what} failed to fetch a moment ago ${dash} waiting ${left} before trying again`;
 }
 /**

package/src/server/term.mjs CHANGED Viewed

@@ -628,12 +628,19 @@ export function pulseDot(beat, { registered = true, claude = true, busy = null }
  *
  * @param file the discovery file that could not be written.
  * @param claude whether this deck is watching Claude Code at all.
+ * @param dash the em dash, or the ASCII stand-in on a console that cannot draw
+ *   one (#797). A parameter for the same reason `renameNotice` takes one: this
+ *   module's own header says "every glyph the deck prints — punctuation
+ *   included, since an em dash is as absent from CP437 as a check mark — comes
+ *   from one of them", and this sentence had it hardcoded. On a legacy cmd.exe
+ *   or the Linux virtual console the reader got a box in the middle of the one
+ *   line explaining why no events are arriving.
  */
-export function unregisteredDetail({ file, claude = true }) {
+export function unregisteredDetail({ file, claude = true, dash = "—" }) {
   if (claude) {
     return `Claude Code hooks find this deck through ${file}, so until that file exists no Claude Code events arrive.`;
   }
-  return `Codex capture does not use ${file} — the deck tails the rollout files itself — so events still arrive. Only decks sharing one events log need it, to agree on which of them records.`;
+  return `Codex capture does not use ${file} ${dash} the deck tails the rollout files itself ${dash} so events still arrive. Only decks sharing one events log need it, to agree on which of them records.`;
 }
 // ── cursor ───────────────────────────────────────────────────────────────────