npm - agent-dag - Versions diffs - 1.35.32 → 1.35.34 - Mend

agent-dag 1.35.32 → 1.35.34

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (12) hide show

package/dist/web/assets/{index-Ca-CsYuj.js → index-BiZ-D_yB.js} +21 -21
package/dist/web/index.html +1 -1
package/package.json +1 -1
package/src/server/claude-dir.mjs +8 -1
package/src/server/codex-auth.mjs +14 -1
package/src/server/cswap-admin.mjs +13 -1
package/src/server/cswap-auto.mjs +19 -1
package/src/server/cswap-install.mjs +25 -2
package/src/server/installer.mjs +7 -1
package/src/server/npx.mjs +6 -1
package/src/server/self-update.mjs +9 -2
package/src/server/term.mjs +42 -8

package/dist/web/index.html CHANGED Viewed

@@ -40,7 +40,7 @@
         document.documentElement.setAttribute("data-theme", stored === "light" ? "light" : "dark");
       })();
     </script>
-    <script type="module" crossorigin src="/assets/index-Ca-CsYuj.js"></script>
+    <script type="module" crossorigin src="/assets/index-BiZ-D_yB.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-jWyLguyW.css">
   </head>
   <body>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "agent-dag",
-  "version": "1.35.32",
+  "version": "1.35.34",
   "description": "Live deck of Claude Code and Codex agents — watch tool calls, token spend and every Claude Code subagent on one calm canvas. Also available as npx ccdeck and npx agent-dag.",
   "type": "module",
   "bin": {

package/src/server/claude-dir.mjs CHANGED Viewed

@@ -113,8 +113,15 @@ const CLAUDE_USE_MARKERS = [
  * PATH walk is done by hand, with PATHEXT applied on Windows exactly as cmd.exe
  * would — a `claude.cmd` shim from npm and a bare `claude.exe` from the native
  * installer both have to count, and neither is spelled `claude`.
+ *
+ * Not exported (#383). It is the first half of `hasClaudeInstalled` below, and
+ * that function takes the same four injected dependencies — platform, env, home
+ * and `exists` — so every branch of this walk is already driven from a test with
+ * no host state reaching it, including the Windows PATHEXT branch exercised from
+ * a Mac. Exporting it would offer a second, narrower answer to "is Claude Code
+ * here", and the point of #402 was that there is one.
  */
-export function claudeCliOnDisk({
+function claudeCliOnDisk({
   platform = process.platform,
   env = process.env,
   home = homedir(),

package/src/server/codex-auth.mjs CHANGED Viewed

@@ -100,7 +100,20 @@ const PERMANENT_CODES = new Set([
   "invalid_grant",
 ]);
-/** Decode a JWT payload. Returns null for anything that isn't a 3-part JWT. */
+/**
+ * Decode a JWT payload. Returns null for anything that isn't a 3-part JWT.
+ *
+ * Exported for its test and not for a caller (#383). Its two readers are
+ * `expiryMs` below — which decides whether the deck spends the single-use
+ * refresh token, the one mistake in this file that costs the user a `codex
+ * login` — and `identityFrom`, which reads the plan, the account id and the
+ * email out of the id_token. Both take the answer from a file the deck did not
+ * write and cannot validate, so every way this can be handed something that is
+ * not a JWT is a real input, and neither reader can be driven far enough to
+ * exercise them: `expiryMs` collapses the whole result to one number and
+ * `identityFrom` needs a full auth file plus a refresh round-trip to reach.
+ * See codex-jwt-decode.test.ts.
+ */
 export function decodeJwt(token) {
   if (typeof token !== "string") return null;
   const parts = token.split(".");

package/src/server/cswap-admin.mjs CHANGED Viewed

@@ -110,7 +110,19 @@ export function newSlot(before, after) {
   return fresh.length === 1 ? fresh[0] : null;
 }
-/** Anthropic's own view of who is signed in. Null when it cannot be read. */
+/**
+ * Anthropic's own view of who is signed in. Null when it cannot be read.
+ *
+ * Exported for its test rather than for a caller (#383). Both callers are inside
+ * the login flow and neither can show what was parsed: `spawnLogin` keeps only
+ * `identity?.email` as the address to restore to, and `submitLoginCode` turns
+ * the whole thing into a pass/fail — a null there is the difference between a
+ * sign-in the deck accepts and one it reports as "signed in, but the claude CLI
+ * still reports nobody logged in". The success path, where the email read here
+ * is what matches the new credential to a cswap slot, is reachable only with a
+ * real signed-in CLI on the machine running the suite. See
+ * cswap-identity.test.ts.
+ */
 export async function currentIdentity() {
   const r = await run(await claudeBin(), ["auth", "status", "--json"], { timeout: 20_000 });
   if (!r.ok) return null;

package/src/server/cswap-auto.mjs CHANGED Viewed

@@ -34,7 +34,18 @@ const SETTINGS = {
 // ── settings ───────────────────────────────────────────────────────────────
-/** Parse `cswap config` — "key   value   (default)" per line. */
+/**
+ * Parse `cswap config` — "key   value   (default)" per line.
+ *
+ * Exported for its test rather than for a caller (#383). The two callers here —
+ * `autoStatus`, which hands the map straight to the settings panel, and
+ * `tickInterval`, which takes the poll interval out of it — both reduce the
+ * parse to something a test cannot see through: the panel takes whatever shape
+ * it is given, and the interval collapses four fields to one number that is
+ * clamped anyway. The parse itself is a regex over human-formatted output from a
+ * separate Python tool, on both line-ending conventions. See
+ * cswap-auto-readers.test.ts.
+ */
 export async function readCswapConfig() {
   const r = await run(await cswapBin(), ["config"]);
   if (!r.ok) return null;
@@ -117,6 +128,13 @@ async function runAutoTick() {
  * budget that is already the scarce resource here, and the user would have two
  * things switching their account with no single place showing why. So the deck
  * reports it and stays out of the way.
+ *
+ * Exported for its test rather than for a caller (#383). Its two callers reduce
+ * it to a boolean on a status object and to a skipped tick, so neither can show
+ * WHICH command line was matched — and the matching is the whole function. The
+ * two halves also run completely different commands, `ps` against
+ * `Get-CimInstance`, so on any one machine only half of it is ever exercised at
+ * all. See cswap-auto-readers.test.ts, which drives both from either host.
  */
 export async function externalAutoRunning() {
   // A line is the user's loop if it runs `cswap auto` without --once. Our own

package/src/server/cswap-install.mjs CHANGED Viewed

@@ -87,7 +87,26 @@ export async function cswapBin() {
   return "cswap";   // not found; leave the bare name so errors read sensibly
 }
-/** Forget the cached resolution — call after installing. */
+/**
+ * Forget the cached resolution — call after installing.
+ *
+ * WHAT IS ACTUALLY STALE HERE (#383). Note that `cswapBin` above memoizes only
+ * SUCCESS: the "not found" answer is the bare name returned without ever being
+ * written to `_bin`, so a lookup that found nothing is already re-run on the
+ * next call and there is no negative result for this to clear. What it clears is
+ * a positive one — a path that resolved, was cached, and has since been
+ * superseded. That is not hypothetical on the install path: `cswapVersion` runs
+ * `--version` a SECOND time under the default timeout after `cswapBin` has
+ * already cached the copy its own 8s probe accepted, so a copy that is present
+ * but too slow, half-written or broken caches a path and still reports no
+ * version — and the install that follows lands a working cswap somewhere the
+ * cached path may not point at. Clearing is cheap; a deck driving the wrong
+ * binary for the life of the process is not.
+ *
+ * Exported for its test rather than for a caller (#383): the one caller is
+ * ensureCswap below, whose return value says nothing about which binary the
+ * following twenty account operations will be sent to. See cswap-bin-memo.test.ts.
+ */
 export function resetCswapBin() { _bin = null; }
 /** Installed version string, or null when cswap cannot be found. */
@@ -327,7 +346,11 @@ export async function ensureCswap() {
   const result = await installCswap();
   if (!result.ok) return { state: "unavailable", ...result };
-  resetCswapBin();   // it exists now; the earlier "not on PATH" answer is stale
+  // Something was just installed, so any path resolved before it is a guess made
+  // against a different filesystem. Nothing is cached when the earlier lookup
+  // found nothing — see resetCswapBin — but a lookup that DID resolve, to a copy
+  // whose `--version` then failed, is exactly the case that got us here.
+  resetCswapBin();
   // Freshly installed tools land in ~/.local/bin, which may not be on the PATH
   // of the shell that launched us — cswapBin looks there directly, so this

package/src/server/installer.mjs CHANGED Viewed

@@ -530,7 +530,13 @@ export function keepDiscovery({ port, workspace, token, persist = null, codex =
   return { file: discoveryPath(), check, stop: () => clearInterval(timer) };
 }
-export { AGENT_DAG_DIR, CLAUDE_DIR, CODEX_DIR, CLAUDE_EVENTS };
+// CLAUDE_EVENTS used to ride along here (#383). It is the events list of the
+// `claude` entry in PROVIDERS and has never had a reader outside this file; it
+// was easy to miss because the three directories beside it ARE imported and
+// because the long justification below belongs to the SECOND export, not this
+// one. Which events the deck asks Claude Code for is answered by installHooks
+// writing settings.json, which is what the tests read.
+export { AGENT_DAG_DIR, CLAUDE_DIR, CODEX_DIR };
 // Exported for the other modules that rewrite settings.json — the sound toggle
 // today. Every one of them needs the same two guarantees: a file we cannot
 // parse is never treated as an empty one, and the replacement is a single

package/src/server/npx.mjs CHANGED Viewed

@@ -103,7 +103,12 @@ export function npxLaunch(args, {
 // Long enough for a cold tarball on a slow line; short enough that a connection
 // hanging on a dead proxy does not hold the deck's Update button for the three
 // minutes the tab waits before giving up on its own.
-export const PREFETCH_TIMEOUT_MS = 120_000;
+//
+// Not exported (#383): it is the default of `prefetch`'s `timeoutMs` parameter
+// and nothing else. A caller that wants a different budget passes one, and a
+// caller that wants this one passes nothing — there is no third caller for the
+// number to be worth naming across the module boundary.
+const PREFETCH_TIMEOUT_MS = 120_000;
 /**
  * What to hand npx to DOWNLOAD a spec without running it.

package/src/server/self-update.mjs CHANGED Viewed

@@ -132,8 +132,15 @@ export function isNpxInstall(pkgRoot) {
 /** A git checkout is the maintainer's own tree. Its version routinely sits
  *  ahead of npm, and telling someone to `npm i -g` over their working copy is
- *  actively wrong, so the registry side of the check is skipped there. */
-export function isGitCheckout(pkgRoot) {
+ *  actively wrong, so the registry side of the check is skipped there.
+ *
+ *  Not exported (#383). It gates three answers and each of the three is already
+ *  asserted against a directory with a real `.git` in it — `upgradeCommand`
+ *  returning "git pull && npm run build", `upgradeName` refusing to move a
+ *  checkout onto a published alias, and `startUpgrade` refusing with
+ *  `git_checkout`. A test importing the predicate would restate what those three
+ *  already prove, one level further from the behaviour a user can see. */
+function isGitCheckout(pkgRoot) {
   try { return existsSync(join(pkgRoot, ".git")); } catch { return false; }
 }

package/src/server/term.mjs CHANGED Viewed

@@ -411,22 +411,54 @@ function renderWord(word) {
   return rows.map((r) => r.replace(/\s+$/, ""));
 }
+/** The drawn mark itself, three text rows of half-blocks.
+ *
+ *  Exported for one reader, and it is a test rather than a caller (#383). This
+ *  is the ONLY place the art's true width can be measured: `renderWord` trims
+ *  each row's trailing blanks, so the rows are not all the same length, and the
+ *  arithmetic in WORDMARK_WIDTH below is a hand-computed prediction of the
+ *  widest of them. Nothing in the banner path compares the two — `wordmark()`
+ *  gates on WORDMARK_WIDTH and then prints THESE lines — so an under-counting
+ *  width lets the art render into a terminal too narrow to hold it and the
+ *  three rows wrap into six. See wordmark-art-width.test.ts, which is the
+ *  comparison this export exists to make possible. */
 export const WORDMARK_LINES = renderWord("ccdeck");
 /** 29 columns of art, plus the two-space indent every other line uses. */
 export const WORDMARK_WIDTH = 2 + LETTERS.c[0].length * 6 + 5;
-/** The tagline, longest version that fits — the name and version are the part
- *  that must survive, the rest is context. */
-function tagline(version, columns, bullet) {
+/**
+ * The tagline, longest version that fits — the name and version are the part
+ * that must survive, the rest is context.
+ *
+ * `prefix` is how many columns are already spent on the line the tagline lands
+ * on, and it is a parameter because the three layouts below do not agree on it
+ * (#383). In the full banner the tagline gets a line of its own behind a
+ * two-space indent; in the compact and plain ones it shares the line with the
+ * product name, which costs eight or nine columns more. This budget was
+ * hard-coded at 2 for all three, so between 21 and 31 columns — the widths where
+ * the compact form is chosen and the medium tagline still looks affordable —
+ * the banner printed a 36-column line into a terminal that could not hold it and
+ * the first thing a user saw wrapped. `columns - 1` keeps the last cell empty,
+ * because a line ending exactly at the right margin makes some terminals wrap
+ * anyway.
+ */
+function tagline(version, columns, bullet, prefix) {
   const v = `v${version}`;
   const options = [
     `${v} ${bullet} live agent DAG ${bullet} Claude Code + Codex`,
     `${v} ${bullet} live agent DAG`,
     v,
   ];
-  return options.find((o) => o.length + 2 <= columns - 1) ?? v;
+  return options.find((o) => o.length + prefix <= columns - 1) ?? v;
 }
+// What each layout spends before the tagline starts, counted off the strings
+// built in `wordmark` below: "  ccdeck " for plain, "  ccdeck  " for compact,
+// and the bare two-space indent for the full banner's own tagline line.
+const PLAIN_PREFIX_W   = "  ccdeck ".length;
+const COMPACT_PREFIX_W = "  ccdeck  ".length;
+const TAG_INDENT_W     = "  ".length;
 /**
  * The wordmark, in the largest form this terminal can hold.
  *
@@ -442,11 +474,13 @@ export function wordmark({
   columns = 80, version = "0.0.0", profile = "none", unicode = true, pal = palette(profile),
 } = {}) {
   const g = glyphs(unicode);
-  const tag = tagline(version, columns, g.bullet);
+  // Each layout asks for its own tagline, because each leaves it a different
+  // amount of room — see the prefix constants above.
+  const tag = (prefix) => tagline(version, columns, g.bullet, prefix);
-  if (profile === "none") return { kind: "plain", lines: ["", `  ccdeck ${tag}`, ""] };
+  if (profile === "none") return { kind: "plain", lines: ["", `  ccdeck ${tag(PLAIN_PREFIX_W)}`, ""] };
   if (!unicode || columns < WORDMARK_WIDTH + 1) {
-    return { kind: "compact", lines: ["", `  ${pal.bold}${pal.accent}ccdeck${pal.reset}  ${pal.muted}${tag}${pal.reset}`, ""] };
+    return { kind: "compact", lines: ["", `  ${pal.bold}${pal.accent}ccdeck${pal.reset}  ${pal.muted}${tag(COMPACT_PREFIX_W)}${pal.reset}`, ""] };
   }
   const ramp = [pal.accentSoft, pal.accent, pal.accentDeep];
@@ -456,7 +490,7 @@ export function wordmark({
       "",
       ...WORDMARK_LINES.map((l, i) => `  ${ramp[i]}${l}${pal.reset}`),
       "",
-      `  ${pal.muted}${tag}${pal.reset}`,
+      `  ${pal.muted}${tag(TAG_INDENT_W)}${pal.reset}`,
       "",
     ],
   };