agent-conveyor 0.1.16 → 0.1.18

package/README.md

@@ -324,7 +324,14 @@ tmux attach -t codex-live-test
   asset receipt counts.
 - `campaign dashboard --name C [--json]` —
   Show a manager-oriented campaign aggregate: worker slot lifecycle states,
-  blockers, approval counts, and the next recommended manager action.
+  blockers, approval counts, and the next recommended manager action. This is
+  also the supported way to inspect asset receipts and per-slot receipt counts;
+  there is no separate `campaign assets` subcommand.
+- `campaign closeout --name C [--failure-mode TEXT] [--json]` —
+  Produce a read-only closeout report from the campaign dashboard, including
+  verdict, worker thread ids, blockers, receipt counts by assignment, proof
+  checks, and the strongest realistic failure mode evidence to carry into a
+  manager/operator handoff.
 
 Creative Ops Campaign manager loop:
 
@@ -608,6 +615,9 @@ stay out of receipts.
   permissions, expected tools, epilogues, evidence gates, cleanup behavior,
   disallowed actions, locked setup summary template, and suggested
   `manager-config` command. Use this before cutting a manager loose.
+  `campaign-duplicate-guard-dogfood` is the recipe for visible creative
+  campaign dogfoods that prove accidental duplicate assignment receipts are
+  rejected unless a worker explicitly uses `--allow-additional-receipt`.
 - `worker-ack <task> --from-stdin|--json [--correlation-id ID]` /
   `manager-ack <task> --from-stdin|--json [--correlation-id ID]` — Persist or
   read the latest structured acknowledgement from the worker or manager. Acks

package/dist/cli/typescript-runtime.js

@@ -384,7 +384,11 @@ function commandHelpText(program, command) {
             `  ${program} finish-task my-task --reason "Accepted criteria satisfied" --require-criteria-audit --path /tmp/work/workerctl.db --json`,
         ],
         campaign: [
-            `usage: ${program} campaign <create|add-slot|attach-slot|rotate-slot|archive-slot|brief|assign|asset|status|dashboard> --name <campaign> [options] ${path} [--json]`,
+            `usage: ${program} campaign <${campaignActionsUsage()}> --name <campaign> [options] ${path} [--json]`,
+            "",
+            `Supported subcommands: ${campaignActionsUsage()}`,
+            "",
+            "Use `dashboard` to list campaign assets and slot receipt counts; there is no separate `assets` subcommand.",
             "",
             "Examples:",
             `  ${program} campaign create --name launch --objective "Create launch assets" --metadata-json '{"owner":"ops"}' --json`,
@@ -398,6 +402,7 @@ function commandHelpText(program, command) {
             `  ${program} campaign asset --name launch --slot campaign-slot-id --assignment campaign-assignment-id --asset-type copy --title "Hooks v2" --allow-additional-receipt --json`,
             `  ${program} campaign status --name launch --json`,
             `  ${program} campaign dashboard --name launch --json`,
+            `  ${program} campaign closeout --name launch --failure-mode "hidden duplicate receipt" --json`,
         ],
         "manager-ack": [
             `usage: ${program} manager-ack <task> --from-stdin ${path}`,
@@ -472,7 +477,8 @@ function commandHelpText(program, command) {
     };
     return linesByCommand[command] ?? [`usage: ${program} ${command} [-h] [options]`];
 }
-const CAMPAIGN_ACTIONS = new Set(["create", "add-slot", "attach-slot", "rotate-slot", "archive-slot", "brief", "assign", "asset", "status", "dashboard"]);
+const CAMPAIGN_ACTION_NAMES = ["create", "add-slot", "attach-slot", "rotate-slot", "archive-slot", "brief", "assign", "asset", "status", "dashboard", "closeout"];
+const CAMPAIGN_ACTIONS = new Set(CAMPAIGN_ACTION_NAMES);
 const CAMPAIGN_STRING_FLAGS = {
     "--artifact-path": "artifactPath",
     "--asset-type": "assetType",
@@ -480,6 +486,7 @@ const CAMPAIGN_STRING_FLAGS = {
     "--brief-json": "briefJson",
     "--channel": "channel",
     "--expected-thread-id": "expectedThreadId",
+    "--failure-mode": "failureMode",
     "--instructions": "instructions",
     "--objective": "objective",
     "--prompt-summary": "promptSummary",
@@ -3022,7 +3029,7 @@ function parseRuntimeArgs(args, env) {
         }
         else if (command === "campaign" && flags.action === null) {
             if (!CAMPAIGN_ACTIONS.has(arg)) {
-                return { command, enabled, error: `Unsupported campaign action: ${arg}`, explicit, flags, task };
+                return { command, enabled, error: unsupportedCampaignActionMessage(arg), explicit, flags, task };
             }
             flags.action = arg;
         }
@@ -6253,12 +6260,25 @@ function runCampaignCommand(parsed, options) {
             const dashboard = campaignDashboardSync(database, campaign);
             return campaignResult(parsed, dashboard, renderCampaignDashboardText(dashboard));
         }
-        return errorResult(`Unsupported campaign action: ${action}`);
+        if (action === "closeout") {
+            const dashboard = campaignDashboardSync(database, campaign);
+            const closeout = campaignCloseoutReport(dashboard, {
+                failureMode: parsed.flags.failureMode,
+            });
+            return campaignResult(parsed, closeout, renderCampaignCloseoutText(closeout));
+        }
+        return errorResult(unsupportedCampaignActionMessage(action));
     }
     finally {
         database.close();
     }
 }
+function campaignActionsUsage() {
+    return CAMPAIGN_ACTION_NAMES.join("|");
+}
+function unsupportedCampaignActionMessage(action) {
+    return `Unsupported campaign action: ${action ?? "<missing>"}; expected one of: ${CAMPAIGN_ACTION_NAMES.join(", ")}. Use \`conveyor campaign dashboard --name <campaign> --json\` to list assets and receipt counts.`;
+}
 function campaignResult(parsed, payload, lines) {
     return parsed.flags.json ? jsonResult(payload) : textResult(lines);
 }
@@ -6331,6 +6351,107 @@ function renderCampaignDashboardText(dashboard) {
     }
     return lines;
 }
+function campaignCloseoutReport(dashboard, options = {}) {
+    const receiptCountsByAssignment = campaignReceiptCountsByAssignment(dashboard);
+    const activeSlots = dashboard.slots.filter((slot) => slot.state !== "archived");
+    const slotsMissingReceipts = activeSlots.filter((slot) => slot.assignments.length > 0 && slot.asset_receipts === 0);
+    const duplicateAssignmentCounts = receiptCountsByAssignment.filter((item) => item.receipt_count > 1);
+    const failureMode = options.failureMode
+        ?? "A hidden duplicate or missing worker receipt could make the campaign look closed while dashboard receipt counts are wrong.";
+    const receiptEvidence = dashboard.slots
+        .map((slot) => `${slot.slot_key}:assignments=${slot.assignments.length},receipts=${slot.asset_receipts}`)
+        .join("; ");
+    return {
+        action: "closeout",
+        approvals: dashboard.approvals,
+        blockers: dashboard.blockers,
+        campaign: dashboard.campaign,
+        failure_mode: {
+            evidence: `dashboard asset_total=${dashboard.summary.asset_total}; assignment_total=${dashboard.summary.assignment_total}; ${receiptEvidence}`,
+            strongest_realistic_failure_mode: failureMode,
+        },
+        next_manager_action: dashboard.next_manager_action,
+        proof_checks: [
+            {
+                check: "dashboard_loaded",
+                evidence: `campaign_id=${dashboard.campaign.id}; updated_at=${dashboard.campaign.updated_at}`,
+                status: "passed",
+            },
+            {
+                check: "blockers_absent",
+                evidence: `blockers=${dashboard.blockers.length}`,
+                status: dashboard.blockers.length === 0 ? "passed" : "failed",
+            },
+            {
+                check: "active_worker_slots_have_receipts",
+                evidence: slotsMissingReceipts.length === 0
+                    ? "all active slots with assignments have at least one receipt"
+                    : `missing_receipt_slots=${slotsMissingReceipts.map((slot) => slot.slot_key).join(",")}`,
+                status: slotsMissingReceipts.length === 0 ? "passed" : "attention",
+            },
+            {
+                check: "assignment_receipt_counts",
+                evidence: duplicateAssignmentCounts.length === 0
+                    ? "no assignment has more than one receipt"
+                    : `additional_receipt_assignments=${duplicateAssignmentCounts.map((item) => `${item.assignment_id}:${item.receipt_count}`).join(",")}`,
+                status: duplicateAssignmentCounts.length === 0 ? "passed" : "attention",
+            },
+            {
+                check: "human_review_gate",
+                evidence: `needs_review=${dashboard.approvals.needs_review}; approved=${dashboard.approvals.approved}; published=${dashboard.approvals.published}`,
+                status: dashboard.approvals.needs_review > 0 && dashboard.approvals.published === 0 ? "passed" : "attention",
+            },
+        ],
+        receipt_counts_by_assignment: receiptCountsByAssignment,
+        summary: dashboard.summary,
+        verdict: campaignCloseoutVerdict(dashboard),
+        workers: dashboard.slots.map((slot) => ({
+            active_assignments: slot.active_assignments,
+            asset_receipts: slot.asset_receipts,
+            blockers: slot.blockers,
+            channel: slot.channel,
+            codex_app_thread_id: slot.codex_app_thread_id,
+            codex_app_thread_title: slot.codex_app_thread_title,
+            lifecycle_state: slot.lifecycle.state,
+            receipt_ids: slot.assets.map((asset) => asset.id),
+            slot_key: slot.slot_key,
+            state: slot.state,
+        })),
+    };
+}
+function campaignReceiptCountsByAssignment(dashboard) {
+    return dashboard.slots.flatMap((slot) => slot.assignments.map((assignment) => ({
+        assignment_id: assignment.id,
+        receipt_count: slot.assets.filter((asset) => asset.assignment_id === assignment.id).length,
+        slot_key: slot.slot_key,
+    })));
+}
+function campaignCloseoutVerdict(dashboard) {
+    if (dashboard.blockers.length > 0 || dashboard.summary.blocked_assignments > 0 || dashboard.summary.blocked_slots > 0 || dashboard.summary.stale_slots > 0) {
+        return "blocked";
+    }
+    if (dashboard.next_manager_action.action === "close_campaign") {
+        return "ready_to_close";
+    }
+    if (dashboard.approvals.needs_review > 0 || dashboard.approvals.rejected > 0) {
+        return "needs_review";
+    }
+    return "needs_work";
+}
+function renderCampaignCloseoutText(report) {
+    return [
+        `campaign ${report.campaign.name} ${report.campaign.status}`,
+        `closeout verdict ${report.verdict}`,
+        `next ${report.next_manager_action.action}: ${report.next_manager_action.reason}`,
+        `summary slots=${report.summary.active_slots}/${report.summary.archived_slots} assignments=${report.summary.assignment_total} assets=${report.summary.asset_total} blockers=${report.blockers.length}`,
+        `approvals needs_review=${report.approvals.needs_review} approved=${report.approvals.approved} rejected=${report.approvals.rejected} published=${report.approvals.published}`,
+        `failure_mode ${report.failure_mode.strongest_realistic_failure_mode}`,
+        `failure_mode_evidence ${report.failure_mode.evidence}`,
+        ...report.proof_checks.map((check) => `proof ${check.status} ${check.check}: ${check.evidence}`),
+        ...report.receipt_counts_by_assignment.map((item) => `assignment_receipts ${item.slot_key} ${item.assignment_id}=${item.receipt_count}`),
+        ...report.workers.slice(0, 8).map((worker) => `worker ${worker.slot_key} ${worker.state}/${worker.lifecycle_state} assignments=${worker.active_assignments} receipts=${worker.asset_receipts} thread=${worker.codex_app_thread_id ?? "none"}`),
+    ];
+}
 function statusCountsText(counts) {
     return Object.entries(counts).map(([status, count]) => `${status}=${count}`).join(" ");
 }
@@ -17212,6 +17333,45 @@ const MANAGER_RECIPES = {
         supportPatterns: ["Inbox / No-Tmux App Loop", "Recovery / Resume / Handoff"],
         tools: ["verification.run_tests", "context.fetch_prs"],
     },
+    "campaign-duplicate-guard-dogfood": {
+        acceptance: [
+            "The campaign dashboard shows exactly one normal asset receipt for each active assignment before the duplicate probe.",
+            "A worker visibly attempts an accidental duplicate `campaign asset` receipt without --allow-additional-receipt and records the expected non-zero failure.",
+            "Manager independently verifies the post-probe dashboard still has the original asset_total, the probed slot still has one receipt, and blockers are empty.",
+        ],
+        cleanup: "off by default; archive or rotate only campaign-owned worker slots with exact expected thread ids",
+        description: "Dogfood creative campaign workers while proving assignment-scoped duplicate receipts are blocked unless explicitly allowed.",
+        disallowedActions: [
+            "Do not use --allow-additional-receipt for the accidental duplicate probe.",
+            "Do not treat the worker's duplicate-failure claim as proof until the manager verifies the dashboard.",
+            "Do not publish, schedule, contact external services, inspect private content, edit product/content files, or commit during the dogfood.",
+            "Do not archive or rotate a worker thread unless the campaign slot owns that exact thread id.",
+        ],
+        displayName: "Campaign Duplicate-Guard Dogfood",
+        epilogues: [],
+        evidenceGates: [
+            "campaign_dashboard_pre_probe",
+            "visible_worker_duplicate_failure",
+            "duplicate_failure_exit_code",
+            "post_probe_dashboard_no_extra_asset",
+            "manager_duplicate_guard_decision",
+        ],
+        finalReportRequirements: [
+            "Report the manager thread id, worker thread ids, assignment ids, original receipt ids, duplicate error text, pre/post dashboard counts, and residual cleanup status.",
+        ],
+        guidelines: [
+            "Keep manager and worker sessions visibly chatty with CONVEYOR RECEIVED, WORK, and CONVEYOR SEND sections.",
+            "Use `campaign dashboard --name <campaign> --json` as the supported receipt-listing surface.",
+            "Ask exactly one worker to perform the missing-override duplicate probe, then require manager-side dashboard verification before closeout.",
+        ],
+        loopTemplate: null,
+        mode: "strict",
+        name: "campaign-duplicate-guard-dogfood",
+        objective: "Supervise a visible campaign dogfood that proves duplicate assignment receipts fail closed without --allow-additional-receipt.",
+        permissions: [],
+        supportPatterns: ["Creative Ops Campaign", "Inbox / No-Tmux App Loop", "Recovery / Resume / Handoff"],
+        tools: ["campaign.dashboard", "codex_app.send_message_to_thread"],
+    },
     "nudge-whats-next": {
         acceptance: [
             "Accepted criteria are satisfied or explicitly deferred.",
@@ -17370,6 +17530,10 @@ const MANAGER_RECIPES = {
     },
 };
 const MANAGER_RECIPE_ALIASES = {
+    "campaign duplicate guard": "campaign-duplicate-guard-dogfood",
+    "campaign duplicate guard dogfood": "campaign-duplicate-guard-dogfood",
+    "creative duplicate guard": "campaign-duplicate-guard-dogfood",
+    "duplicate guard dogfood": "campaign-duplicate-guard-dogfood",
     "goalbuddy conveyor": "goalbuddy-conveyor",
     goalbuddy: "goalbuddy-conveyor",
     "nudge / what's next manager": "nudge-whats-next",