agent-comms 2.27.0 → 2.29.0

package/dist/test/room-protocol-notify.test.js

@@ -0,0 +1,178 @@
+/**
+ * Direct, DI-based unit tests for RoomProtocol's handleRoomNotify (P3.8's directed-delivery replacement for informational events, agent-comms#48) -- moved into its own file to stay under the repo's max-lines cap once room-protocol.test.ts and room-protocol-admission.test.ts were already at capacity. Real identities and real minted tokens throughout, matching those two files' own established convention (handleRoomNotify genuinely verifies tokens cryptographically, so an opaque placeholder string fails the mint/verify outright).
+ */
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import * as fs from "node:fs";
+import * as path from "node:path";
+import { tmpdir } from "node:os";
+import { bytesToHex, deviceIdFromHex } from "wire-mesh-core/domain/device-id";
+import { mintCapabilityToken } from "wire-mesh-core/domain/tokens";
+import { createSystemClock } from "wire-mesh-core/adapters/system-clock";
+import { createRevocationView } from "wire-mesh-core/domain/revocation-view";
+import { generateIdentity } from "../core/identity.js";
+import { loadOrCreateIdentity } from "../core/identity-store.js";
+import { toIdentityPort } from "../core/wire-mesh-identity.js";
+import { ownerNamedRoomPath } from "../core/room-path.js";
+import { RoomProtocol } from "../core/room-protocol.js";
+import { randomId } from "../core/random-id.js";
+const TOKEN_TTL_MS = 60_000;
+function room(overrides = {}) {
+    return {
+        id: "room-1",
+        version: 1,
+        name: "room-name",
+        type: "public",
+        owner: "",
+        createdAt: "2026-01-01T00:00:00.000Z",
+        description: "a room",
+        members: [],
+        invited: [],
+        memberJoins: {},
+        memberLeaves: {},
+        invitedJoins: {},
+        invitedLeaves: {},
+        ...overrides,
+    };
+}
+async function makeIdentities() {
+    const owner = generateIdentity();
+    const member = generateIdentity();
+    return {
+        ownerId: bytesToHex(Uint8Array.from(owner.deviceId)),
+        ownerPort: await toIdentityPort(owner),
+        memberId: bytesToHex(Uint8Array.from(member.deviceId)),
+    };
+}
+async function mintRoomToken(issuerPort, bearerHex, roomPath) {
+    const clock = createSystemClock();
+    const verdict = await mintCapabilityToken({
+        identity: issuerPort,
+        clock,
+        tokenId: randomId(),
+        bearer: deviceIdFromHex(bearerHex),
+        capability: "room:member",
+        scope: { kind: "room", path: roomPath },
+        expires: clock.now() + TOKEN_TTL_MS,
+        delegationsRemaining: 0,
+    });
+    if (!verdict.ok)
+        throw new Error("expected the fixture token to mint successfully");
+    return verdict.token;
+}
+async function makeHarness() {
+    const ids = await makeIdentities();
+    const slotDir = fs.mkdtempSync(path.join(tmpdir(), "room-protocol-notify-test-"));
+    const slot = { harness: "test", cwd: "room-protocol-notify", dir: slotDir };
+    loadOrCreateIdentity(slot);
+    const queueDelivery = vi.fn();
+    const fireLocalDelivery = vi.fn();
+    const deps = {
+        rooms: new Map(),
+        messages: new Map(),
+        dms: new Map(),
+        agents: new Map(),
+        dmRequestsInitiatedByMe: new Set(),
+        getPeerId: () => ids.ownerId,
+        requireIdentity: () => ({
+            identity: ids.ownerPort,
+            clock: createSystemClock(),
+            slot,
+            revocation: createRevocationView(),
+            dataStorage: {},
+        }),
+        requireTransport: () => ({}),
+        deliveryEngine: {
+            queueDelivery,
+            fireLocalDelivery,
+            bump: vi.fn(),
+            recordMemberOp: vi.fn(),
+            refreshMembership: vi.fn(),
+            broadcastPatch: vi.fn().mockResolvedValue(undefined),
+            deliverToRoom: vi.fn().mockResolvedValue(undefined),
+        },
+        revokeMemberGrant: vi.fn().mockResolvedValue(undefined),
+    };
+    return {
+        deps,
+        protocol: new RoomProtocol(deps),
+        ids,
+        queueDelivery,
+        fireLocalDelivery,
+    };
+}
+function handle(deviceHex) {
+    return { id: deviceHex };
+}
+function manageRequest(overrides = {}) {
+    return {
+        requestId: 1,
+        command: { verb: "room:member", params: overrides.params ?? {} },
+        scope: overrides.scope ?? { kind: "room" },
+        token: overrides.token,
+        respond: vi.fn().mockResolvedValue(undefined),
+    };
+}
+describe("RoomProtocol — handleRoomNotify", () => {
+    let h;
+    let ownerNamedRoom;
+    beforeEach(async () => {
+        h = await makeHarness();
+        ownerNamedRoom = ownerNamedRoomPath(h.ids.ownerId, "general");
+        h.deps.rooms.set(ownerNamedRoom, room({
+            id: ownerNamedRoom,
+            owner: h.ids.ownerId,
+            members: [h.ids.ownerId, h.ids.memberId],
+        }));
+    });
+    async function notify(params, token) {
+        const handler = h.protocol.roomVerbHandlers["room.notify"];
+        if (handler === undefined)
+            throw new Error("expected room.notify handler");
+        return handler(manageRequest({
+            scope: { kind: "room", path: ownerNamedRoom },
+            token,
+            params,
+        }), handle(h.ids.memberId));
+    }
+    it("returns missing_scope_path when the request carries no room path", async () => {
+        const handler = h.protocol.roomVerbHandlers["room.notify"];
+        if (handler === undefined)
+            throw new Error("expected room.notify handler");
+        const outcome = await handler(manageRequest({ scope: { kind: "room" } }), handle(h.ids.memberId));
+        expect(outcome).toEqual({ result: "error", code: "missing_scope_path" });
+    });
+    it("returns unauthorized when no token is presented", async () => {
+        const outcome = await notify({ verb: "room.notify", event: { type: "member_joined" } }, undefined);
+        expect(outcome).toEqual({ result: "error", code: "unauthorized" });
+    });
+    it("returns malformed_params for an event that doesn't parse as a real DeliveryEvent", async () => {
+        const token = await mintRoomToken(h.ids.ownerPort, h.ids.memberId, ownerNamedRoom);
+        const outcome = await notify({ verb: "room.notify", event: { type: "not-a-real-type" } }, token);
+        expect(outcome).toEqual({ result: "error", code: "malformed_params" });
+    });
+    it("returns malformed_params when the event's own room field doesn't match the token's verified scope", async () => {
+        const token = await mintRoomToken(h.ids.ownerPort, h.ids.memberId, ownerNamedRoom);
+        const event = {
+            type: "member_status",
+            room: "a-different-room-entirely",
+            agent: h.ids.memberId,
+            status: "idle",
+        };
+        const outcome = await notify({ verb: "room.notify", event }, token);
+        expect(outcome).toEqual({ result: "error", code: "malformed_params" });
+    });
+    it("queues and fires local delivery for a well-formed, correctly-scoped event", async () => {
+        const token = await mintRoomToken(h.ids.ownerPort, h.ids.memberId, ownerNamedRoom);
+        const event = {
+            type: "member_status",
+            room: ownerNamedRoom,
+            agent: h.ids.memberId,
+            status: "busy",
+        };
+        const outcome = await notify({ verb: "room.notify", event }, token);
+        expect(outcome).toEqual({ result: "ok" });
+        expect(h.queueDelivery).toHaveBeenCalledWith(h.ids.ownerId, event);
+        expect(h.fireLocalDelivery).toHaveBeenCalledWith(h.ids.ownerId, event);
+    });
+});
+//# sourceMappingURL=room-protocol-notify.test.js.map

package/dist/test/room-protocol-notify.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"room-protocol-notify.test.js","sourceRoot":"","sources":["../../src/test/room-protocol-notify.test.ts"],"names":[],"mappings":"AAAA;;GAEG;AACH,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,KAAK,EAAE,MAAM,SAAS,CAAC;AAC9B,OAAO,KAAK,IAAI,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AACjC,OAAO,EAAE,UAAU,EAAE,eAAe,EAAE,MAAM,iCAAiC,CAAC;AAC9E,OAAO,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACnE,OAAO,EAAE,iBAAiB,EAAE,MAAM,sCAAsC,CAAC;AACzE,OAAO,EAAE,oBAAoB,EAAE,MAAM,uCAAuC,CAAC;AAM7E,OAAO,EAAE,gBAAgB,EAAE,MAAM,qBAAqB,CAAC;AACvD,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,cAAc,EAAE,MAAM,+BAA+B,CAAC;AAC/D,OAAO,EAAE,kBAAkB,EAAE,MAAM,sBAAsB,CAAC;AAC1D,OAAO,EAAE,YAAY,EAAyB,MAAM,0BAA0B,CAAC;AAC/E,OAAO,EAAE,QAAQ,EAAE,MAAM,sBAAsB,CAAC;AAGhD,MAAM,YAAY,GAAG,MAAM,CAAC;AAE5B,SAAS,IAAI,CAAC,YAA2B,EAAE;IACzC,OAAO;QACL,EAAE,EAAE,QAAQ;QACZ,OAAO,EAAE,CAAC;QACV,IAAI,EAAE,WAAW;QACjB,IAAI,EAAE,QAAQ;QACd,KAAK,EAAE,EAAE;QACT,SAAS,EAAE,0BAA0B;QACrC,WAAW,EAAE,QAAQ;QACrB,OAAO,EAAE,EAAE;QACX,OAAO,EAAE,EAAE;QACX,WAAW,EAAE,EAAE;QACf,YAAY,EAAE,EAAE;QAChB,YAAY,EAAE,EAAE;QAChB,aAAa,EAAE,EAAE;QACjB,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAQD,KAAK,UAAU,cAAc;IAC3B,MAAM,KAAK,GAAG,gBAAgB,EAAE,CAAC;IACjC,MAAM,MAAM,GAAG,gBAAgB,EAAE,CAAC;IAClC,OAAO;QACL,OAAO,EAAE,UAAU,CAAC,UAAU,CAAC,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;QACpD,SAAS,EAAE,MAAM,cAAc,CAAC,KAAK,CAAC;QACtC,QAAQ,EAAE,UAAU,CAAC,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC;KACvD,CAAC;AACJ,CAAC;AAED,KAAK,UAAU,aAAa,CAC1B,UAAsD,EACtD,SAAiB,EACjB,QAAgB;IAEhB,MAAM,KAAK,GAAG,iBAAiB,EAAE,CAAC;IAClC,MAAM,OAAO,GAAG,MAAM,mBAAmB,CAAC;QACxC,QAAQ,EAAE,UAAU;QACpB,KAAK;QACL,OAAO,EAAE,QAAQ,EAAE;QACnB,MAAM,EAAE,eAAe,CAAC,SAAS,CAAC;QAClC,UAAU,EAAE,aAAa;QACzB,KAAK,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,QAAQ,EAAE;QACvC,OAAO,EAAE,KAAK,CAAC,GAAG,EAAE,GAAG,YAAY;QACnC,oBAAoB,EAAE,CAAC;KACxB,CAAC,CAAC;IACH,IAAI,CAAC,OAAO,CAAC,EAAE;QACb,MAAM,IAAI,KAAK,CAAC,iDAAiD,CAAC,CAAC;IACrE,OAAO,OAAO,CAAC,KAAK,CAAC;AACvB,CAAC;AAUD,KAAK,UAAU,WAAW;IACxB,MAAM,GAAG,GAAG,MAAM,cAAc,EAAE,CAAC;IACnC,MAAM,OAAO,GAAG,EAAE,CAAC,WAAW,CAC5B,IAAI,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,4BAA4B,CAAC,CAClD,CAAC;IACF,MAAM,IAAI,GAAG,EAAE,OAAO,EAAE,MAAM,EAAE,GAAG,EAAE,sBAAsB,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC;IAC5E,oBAAoB,CAAC,IAAI,CAAC,CAAC;IAC3B,MAAM,aAAa,GACjB,EAAE,CAAC,EAAE,EAAuD,CAAC;IAC/D,MAAM,iBAAiB,GACrB,EAAE,CAAC,EAAE,EAA2D,CAAC;IAEnE,MAAM,IAAI,GAAqB;QAC7B,KAAK,EAAE,IAAI,GAAG,EAAE;QAChB,QAAQ,EAAE,IAAI,GAAG,EAAE;QACnB,GAAG,EAAE,IAAI,GAAG,EAAE;QACd,MAAM,EAAE,IAAI,GAAG,EAAE;QACjB,uBAAuB,EAAE,IAAI,GAAG,EAAE;QAClC,SAAS,EAAE,GAAG,EAAE,CAAC,GAAG,CAAC,OAAO;QAC5B,eAAe,EAAE,GAAG,EAAE,CAAC,CAAC;YACtB,QAAQ,EAAE,GAAG,CAAC,SAAS;YACvB,KAAK,EAAE,iBAAiB,EAAE;YAC1B,IAAI;YACJ,UAAU,EAAE,oBAAoB,EAAE;YAClC,WAAW,EAAE,EAAW;SACzB,CAAC;QACF,gBAAgB,EAAE,GAAG,EAAE,CACrB,CAAC,EAAE,CAAgE;QACrE,cAAc,EAAE;YACd,aAAa;YACb,iBAAiB;YACjB,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;YACb,cAAc,EACZ,EAAE,CAAC,EAAE,EAAwD;YAC/D,iBAAiB,EACf,EAAE,CAAC,EAAE,EAA2D;YAClE,cAAc,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,SAAS,CAAC;YACpD,aAAa,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,SAAS,CAAC;SACpD;QACD,iBAAiB,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,SAAS,CAAC;KACxD,CAAC;IAEF,OAAO;QACL,IAAI;QACJ,QAAQ,EAAE,IAAI,YAAY,CAAC,IAAI,CAAC;QAChC,GAAG;QACH,aAAa;QACb,iBAAiB;KAClB,CAAC;AACJ,CAAC;AAED,SAAS,MAAM,CAAC,SAAiB;IAC/B,OAAO,EAAE,EAAE,EAAE,SAAS,EAAE,CAAC;AAC3B,CAAC;AAED,SAAS,aAAa,CACpB,YAII,EAAE;IAEN,OAAO;QACL,SAAS,EAAE,CAAC;QACZ,OAAO,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE,MAAM,EAAE,SAAS,CAAC,MAAM,IAAI,EAAE,EAAE;QAChE,KAAK,EAAE,SAAS,CAAC,KAAK,IAAI,EAAE,IAAI,EAAE,MAAM,EAAE;QAC1C,KAAK,EAAE,SAAS,CAAC,KAAK;QACtB,OAAO,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,SAAS,CAAC;KACV,CAAC;AACxC,CAAC;AAED,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;IAC/C,IAAI,CAAU,CAAC;IACf,IAAI,cAAsB,CAAC;IAE3B,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,CAAC,GAAG,MAAM,WAAW,EAAE,CAAC;QACxB,cAAc,GAAG,kBAAkB,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,SAAS,CAAC,CAAC;QAC9D,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CACd,cAAc,EACd,IAAI,CAAC;YACH,EAAE,EAAE,cAAc;YAClB,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,OAAO;YACpB,OAAO,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC;SACzC,CAAC,CACH,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,KAAK,UAAU,MAAM,CACnB,MAA+B,EAC/B,KAAkC;QAElC,MAAM,OAAO,GAAG,CAAC,CAAC,QAAQ,CAAC,gBAAgB,CAAC,aAAa,CAAC,CAAC;QAC3D,IAAI,OAAO,KAAK,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,8BAA8B,CAAC,CAAC;QAC3E,OAAO,OAAO,CACZ,aAAa,CAAC;YACZ,KAAK,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,cAAc,EAAE;YAC7C,KAAK;YACL,MAAM;SACP,CAAC,EACF,MAAM,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,CACvB,CAAC;IACJ,CAAC;IAED,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,OAAO,GAAG,CAAC,CAAC,QAAQ,CAAC,gBAAgB,CAAC,aAAa,CAAC,CAAC;QAC3D,IAAI,OAAO,KAAK,SAAS;YAAE,MAAM,IAAI,KAAK,CAAC,8BAA8B,CAAC,CAAC;QAC3E,MAAM,OAAO,GAAG,MAAM,OAAO,CAC3B,aAAa,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,CAAC,EAC1C,MAAM,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,CACvB,CAAC;QACF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,oBAAoB,EAAE,CAAC,CAAC;IAC3E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,OAAO,GAAG,MAAM,MAAM,CAC1B,EAAE,IAAI,EAAE,aAAa,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,eAAe,EAAE,EAAE,EACzD,SAAS,CACV,CAAC;QACF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,cAAc,EAAE,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kFAAkF,EAAE,KAAK,IAAI,EAAE;QAChG,MAAM,KAAK,GAAG,MAAM,aAAa,CAC/B,CAAC,CAAC,GAAG,CAAC,SAAS,EACf,CAAC,CAAC,GAAG,CAAC,QAAQ,EACd,cAAc,CACf,CAAC;QACF,MAAM,OAAO,GAAG,MAAM,MAAM,CAC1B,EAAE,IAAI,EAAE,aAAa,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,iBAAiB,EAAE,EAAE,EAC3D,KAAK,CACN,CAAC;QACF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,CAAC;IACzE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mGAAmG,EAAE,KAAK,IAAI,EAAE;QACjH,MAAM,KAAK,GAAG,MAAM,aAAa,CAC/B,CAAC,CAAC,GAAG,CAAC,SAAS,EACf,CAAC,CAAC,GAAG,CAAC,QAAQ,EACd,cAAc,CACf,CAAC;QACF,MAAM,KAAK,GAAkB;YAC3B,IAAI,EAAE,eAAe;YACrB,IAAI,EAAE,2BAA2B;YACjC,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,QAAQ;YACrB,MAAM,EAAE,MAAM;SACf,CAAC;QACF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,KAAK,EAAE,EAAE,KAAK,CAAC,CAAC;QACpE,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,CAAC;IACzE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,KAAK,IAAI,EAAE;QACzF,MAAM,KAAK,GAAG,MAAM,aAAa,CAC/B,CAAC,CAAC,GAAG,CAAC,SAAS,EACf,CAAC,CAAC,GAAG,CAAC,QAAQ,EACd,cAAc,CACf,CAAC;QACF,MAAM,KAAK,GAAkB;YAC3B,IAAI,EAAE,eAAe;YACrB,IAAI,EAAE,cAAc;YACpB,KAAK,EAAE,CAAC,CAAC,GAAG,CAAC,QAAQ;YACrB,MAAM,EAAE,MAAM;SACf,CAAC;QACF,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,KAAK,EAAE,EAAE,KAAK,CAAC,CAAC;QACpE,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC;QAC1C,MAAM,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,oBAAoB,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;QACnE,MAAM,CAAC,CAAC,CAAC,iBAAiB,CAAC,CAAC,oBAAoB,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,EAAE,KAAK,CAAC,CAAC;IACzE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "agent-comms",
-  "version": "2.27.0",
+  "version": "2.29.0",
   "description": "Cross-harness communication mesh for LLM agents — rooms, DMs, presence, and real-time push delivery over TCP",
   "type": "module",
   "packageManager": "pnpm@12.4.1+sha512.2e81e399d73fe8390dab25e06aa788ab7a5908248d2f5a370f82b481147a6a7a367bf8048f9a6fdb6460f21a66f0542dedb8b94ca2c8723596741920b1656d4c",